D27304: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R120:6f7a878e6d73: Replace plasma.kde.org with kde.org/plasma-desktop (authored by heikobecker). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27304?vs=75410&i

D27261: [Folder view] Fix binding loop on width

2020-02-10 Thread George Vogiatzis
gvgeo added a comment. Also adds smallSpacing at the top. It would not look right with Plasma Components Label, which already has empty space top and bottom. PC3 on the other hand has none... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27261 To: ngraham,

D27261: [Folder view] Fix binding loop on width

2020-02-10 Thread Nathaniel Graham
ngraham updated this revision to Diff 75427. ngraham added a comment. Re-add margins, and also add missing bottomMargin REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27261?vs=75285&id=75427 BRANCH fix-folderview-binding-loop (branched from master

D27304: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Feels wrong having "desktop" on the URL, but I guess this is not the right place to fix it. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.o

D27303: [applets/taskmanager] Add a bit more padding around album/artist info in tooltip

2020-02-10 Thread Nathaniel Graham
ngraham updated this revision to Diff 75425. ngraham added a comment. Only add vertical padding REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27303?vs=75409&id=75425 BRANCH more-padding-around-album-info-in-tooltips (branched from master) REVISI

D27303: [applets/taskmanager] Add a bit more padding around album/artist info in tooltip

2020-02-10 Thread Noah Davis
ndavis added a comment. I agree with @filipf REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27303 To: ngraham, #vdg, manueljlin Cc: ndavis, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenB

D27308: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R161:1076889d06f5: Replace plasma.kde.org with kde.org/plasma-desktop (authored by heikobecker). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27308?v

D27307: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R845:d6062a6a0273: Replace plasma.kde.org with kde.org/plasma-desktop (authored by heikobecker). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27307?vs=75413&id=75

D27303: [applets/taskmanager] Add a bit more padding around album/artist info in tooltip

2020-02-10 Thread Filip Fila
filipf added a comment. The added vertical padding looks good to me, but I don't like how the horizontal paddding now makes these labels no longer aligned with the tooltip heading. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27303 To: ngraham, #vdg, manu

D27306: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R114:2b9a7a71b8b3: Replace plasma.kde.org with kde.org/plasma-desktop (authored by heikobecker). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27306?vs=75412&id=7

D27305: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R119:537729cbed02: Replace plasma.kde.org with kde.org/plasma-desktop (authored by heikobecker). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27305?vs=75411&id=

D27308: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I think you can just commit these without review FWIW. It's a pretty self-explanatorily-correct change. REPOSITORY R161 KActivity Manager Service BRANCH Plasma/5.18 REVISION DETAIL

D27308: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY plasma.kde.org doesn't exist anymore. REPOSITORY R161 KActivity Manager Service BR

D27307: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY plasma.kde.org doesn't exist anymore and causes the appstream test to to fail. REPO

D27306: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY plasma.kde.org doesn't exist anymore and causes check-appstream-compliance to compla

D27305: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY plasma.kde.org doesn't exist anymore and causes the appstream test to to fail. REPO

D27304: Replace plasma.kde.org with kde.org/plasma-desktop

2020-02-10 Thread Heiko Becker
heikobecker created this revision. heikobecker added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY plasma.kde.org doesn't exist anymore and causes the appstream test to to fail. REPO

D27303: [applets/taskmanager] Add a bit more padding around album/artist info in tooltip

2020-02-10 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, manueljlin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Last visual change required to complete T12640: Refine Task Manager tooltips

D27301: [applets/taskmanager] Make launcher item tooltips look identical to panel widget tooltips

2020-02-10 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:f0f2dcc81448: [applets/taskmanager] Make launcher item tooltips look identical to panel… (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 55 - Still unstable!

2020-02-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/55/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 10 Feb 2020 19:47:32 + Build duration: 2 min 31 sec and counting JUnit Tests Name:

KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 56 - Fixed!

2020-02-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/56/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 10 Feb 2020 19:47:31 + Build duration: 42 sec and counting

D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes

2020-02-10 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:bddb65f1defe: [applets/taskmanager] increase size of tooltip playback ToolButton sizes (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes

2020-02-10 Thread Nathaniel Graham
ngraham updated this revision to Diff 75404. ngraham added a comment. Sst sizes manually since we can't depend on a frameworks change for several months REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27222?vs=75192&id=75404 BRANCH smallMedium-pla

D27271: [kcms/colors] RFC: Accent Colours

2020-02-10 Thread Dominic Hayes
The-Feren-OS-Dev added a comment. Since this is related, I'll just drop my concept design for Colours KCM for reference on a possible colour schemes header design to consider. Ignore the button at the bottom, I've realised now that that idea is pointless since we removed so many colour schem

D27055: [kcms/cursortheme] Don't skip everything because of lack of XFixes

2020-02-10 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:0d17a4b4e07c: [kcms/cursortheme] Don't skip everything because of lack of XFixes (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D27301: [applets/taskmanager] Make launcher item tooltips look identical to panel widget tooltips

2020-02-10 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. TEST PLAN Before: F8095730: Before.mp4 After: F8095728: They look t

Plasma 5.18 tar updates

2020-02-10 Thread Jonathan Riddell
Two nicht afore updates for Plasma 5.18 LTS tars: https://cgit.kde.org/breeze.git/commit/?h=Plasma/5.18&id=80326b63d93ba799c1835e6a854a88d0c4b53487 breeze-5.18.0.tar.xz bb6dc332a0425abbc0935de25a0229531b6285093b3129552fd92ce5407e3831 https://cgit.kde.org/plasma-workspace.git/log/?h=Plasma/5.18 pl

D27251: Relicense to LGPL-2.0-or-later

2020-02-10 Thread Andreas Cord-Landwehr
This revision was automatically updated to reflect the committed changes. Closed by commit R169:3f55e64993f9: Relicense to LGPL-2.0-or-later (authored by cordlandwehr). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27251?vs=75259&id=75390 REVISION DETAIL

Request for re-spin

2020-02-10 Thread Nate Graham
Hello release mangler! I hate to do this, but could I request a re-spin of plasma-workspace and breeze before the final release tomorrow? I'd like to pick up the following commits so they make it into the Plasma 5.18.0 release: https://cgit.kde.org/plasma-workspace.git/commit/?id=b4258707ad6d

D27277: Properly search for PipeWire libs

2020-02-10 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R838:05a9caf5e866: Properly search for PipeWire libs (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27277?vs=

D27277: Properly search for PipeWire libs

2020-02-10 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Just one thing left to fix before pushing INLINE COMMENTS > FindPipeWire.cmake:112 > INTERFACE_COMPILE_OPTIONS "${PipeWire_DEFINITIONS}" > -INTERFACE_INCLUDE_DIRE

D27277: Properly search for PipeWire libs

2020-02-10 Thread Jan Grulich
jgrulich updated this revision to Diff 75379. jgrulich marked 5 inline comments as done. jgrulich added a comment. Improve includes REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27277?vs=75373&id=75379 BRANCH Plasma/5

D27277: Properly search for PipeWire libs

2020-02-10 Thread Jan Grulich
jgrulich added a comment. Fixed all issues. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D27277 To: jgrulich, #plasma Cc: cgiboudeaux, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_

D27277: Properly search for PipeWire libs

2020-02-10 Thread Christophe Giboudeaux
cgiboudeaux added inline comments. INLINE COMMENTS > FindPipeWire.cmake:74 > +pipewire-0.3/pipewire/pipewire.h > +spa-0.2/spa/param/props.h > +# Old PipeWire locations same thing for this one > FindPipeWire.cmake:80 > ${PKG_PipeWire_INCLUDE_DIRS} > +${PK

D27277: Properly search for PipeWire libs

2020-02-10 Thread Christophe Giboudeaux
cgiboudeaux added inline comments. INLINE COMMENTS > FindPipeWire.cmake:73 > NAMES > +pipewire-0.3/pipewire/pipewire.h > +spa-0.2/spa/param/props.h this would break includes > FindPipeWire.cmake:76 > +# Old PipeWire locations > pipewire/pipewire.h > +

D27273: [applets/taskmanager] Don't show tooltip subtitle that's identical to the main text

2020-02-10 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:3c4ba1aee620: [applets/taskmanager] Don't show tooltip subtitle that's identical to the main… (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kd

D27273: [applets/taskmanager] Don't show tooltip subtitle that's identical to the main text

2020-02-10 Thread Nathaniel Graham
ngraham updated this revision to Diff 75375. ngraham marked an inline comment as done. ngraham added a comment. Triple equals FTW REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27273?vs=75323&id=75375 BRANCH dont-be-redundant-in-tooltips (branched

D27225: Add support for static platformtheme plugins

2020-02-10 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R169:f1f3d58419e1: Add support for static platformtheme plugins (authored by masonm, committed by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27225?vs=7519

D27277: Properly search for PipeWire libs

2020-02-10 Thread Jan Grulich
jgrulich updated this revision to Diff 75373. jgrulich added a comment. Drop unrelated change REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27277?vs=75372&id=75373 BRANCH Plasma/5.18 REVISION DETAIL https://phabric

D27277: Properly search for PipeWire libs

2020-02-10 Thread Jan Grulich
jgrulich updated this revision to Diff 75372. jgrulich added a comment. - Fix cmake variable name REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27277?vs=75371&id=75372 BRANCH Plasma/5.18 REVISION DETAIL https://pha

D27277: Properly search for PipeWire libs

2020-02-10 Thread Jan Grulich
jgrulich updated this revision to Diff 75371. jgrulich added a comment. Simplify cmake code REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27277?vs=75343&id=75371 BRANCH Plasma/5.18 REVISION DETAIL https://phabricat

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

2020-02-10 Thread Cyril Rossi
crossi updated this revision to Diff 75360. crossi added a comment. Check before assign and emit changed REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27188?vs=75093&id=75360 REVISION DETAIL https://phabricator.kde.org/D27188 AFFECTED FILES kc

D27166: Refactor converter runner

2020-02-10 Thread Alexander Lohnau
alex marked 11 inline comments as done. alex added a comment. Hello, I have found no way to get the currency symbols, other that hard coded. If you have a look at https://phabricator.kde.org/source/kunitconversion/browse/master/src/currency.cpp$67 you can see that the symbols are concaten

D27166: Refactor converter runner

2020-02-10 Thread Alexander Lohnau
alex updated this revision to Diff 75359. alex added a comment. - Start implementing requested changes - Remove unnecessary class declaration REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27166?vs=75064&id=75359 BRANCH converter_runner_refactori

D27096: Refactoring, improve validation in kcm, optimize

2020-02-10 Thread Alexander Lohnau
alex updated this revision to Diff 75358. alex added a comment. - Implement requested changes REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27096?vs=74849&id=75358 BRANCH charrunner_improvements (branched from master) REVISION DETAIL https://ph

D27096: Refactoring, improve validation in kcm, optimize

2020-02-10 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > charrunner.cpp:40 > +Plasma::RunnerContext::ShellCommand); > +addSyntax(Plasma::RunnerSyntax(m_triggerWord + QStringLiteral(":q:"), > + i18n("Creates Characters from :q: if it > is a hexadecimal code or

D27282: [Applet]Correct raise max volume functions for mic

2020-02-10 Thread George Vogiatzis
gvgeo created this revision. gvgeo added reviewers: Plasma, drosca, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Correct osd source devices display when `Raise maximum volume` is enabled. Lower to no

D27137: Handle spawning kinfocenter with a full path

2020-02-10 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R124:a1d44475d4be: Handle spawning kinfocenter with a full path (authored by davidedmundson). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27137?vs=74943&id=75

D27166: Refactor converter runner

2020-02-10 Thread Harald Sitter
sitter added a comment. Looks so much better already! I'd really love a unit test for this though. plasma-workspace's servicesrunner should have an example one INLINE COMMENTS > converterrunner.cpp:19 > > +#define CONVERSION_CHAR QLatin1Char( '>' ) > #include "converterrunner.h" Ple

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

2020-02-10 Thread Kai Uwe Broulik
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R122:ca614feb833a: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't… (authored by alnikiforov,

D27276: Powerdevil: allow using qt5widget classes with powerdevil

2020-02-10 Thread Aleksei Nikiforov
alnikiforov added a comment. Thanks, I'll try reworking KIdleTime. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D27276 To: alnikiforov, apol, davidedmundson Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, G

D27281: Fix chrome bookmarks test

2020-02-10 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b88cdbcfe156: Fix chrome bookmarks test (authored by heikobecker). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27281?vs=75349&id=75351 REVISION DETAIL

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

2020-02-10 Thread Aleksei Nikiforov
alnikiforov updated this revision to Diff 75350. alnikiforov added a comment. Updated remaining conditions REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27278?vs=75348&id=75350 REVISION DETAIL https://phabricator.kde.org/D27278 AFFECTED FILES daem

D27281: Fix chrome bookmarks test

2020-02-10 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27281 To: heikobecker, #plasma, yurchor, broulik Cc: broulik, plasma-devel,

D27281: Fix chrome bookmarks test

2020-02-10 Thread Heiko Becker
heikobecker created this revision. heikobecker added reviewers: Plasma, yurchor. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY The urls were changed from http to https in the test's source files with 6d6

monday meeting notes for 10/2/2020

2020-02-10 Thread Marco Martin
Kai Uwe: Notifications: * Started a thread on standardizing the inline-reply feature on XDG mailing list * https://lists.freedesktop.org/archives/xdg/2020-February/014227.html * The spec we came up with is incompatible with what I added in 5.18 but seems generally nicer * Will update Te

D27137: Handle spawning kinfocenter with a full path

2020-02-10 Thread David Edmundson
davidedmundson added a comment. I'm going to ship this as it fixes an easy to hit bug that is definitely wrong. I'm not trying to ingore any other proposals, we can always expand and change. REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D27276: Powerdevil: allow using qt5widget classes with powerdevil

2020-02-10 Thread Kai Uwe Broulik
broulik added a comment. Please check out D27279 REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D27276 To: alnikiforov, apol, davidedmundson Cc: broulik, plasma-devel, mlcarr, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jralei

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

2020-02-10 Thread Kai Uwe Broulik
broulik added a comment. > If you think these conditions should be updated too, I'll add it to this change. I think we should be consistent here, so please do add them. I'll land this afterwards. Thanks a lot! REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

2020-02-10 Thread Aleksei Nikiforov
alnikiforov added a comment. In D27278#608788 , @broulik wrote: > Makes sense, this can go into 5.18 branch. > Do I need to land this for you? Yes, please land it when you think it's ready to be merged. AFAIK, I have no push permission

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

2020-02-10 Thread Aleksei Nikiforov
alnikiforov marked an inline comment as done. alnikiforov added a comment. In D27278#608791 , @broulik wrote: > There seem to be a bunch of additional `m_helper.isNull()` that could be ported to be consistent? In D27278#608814

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

2020-02-10 Thread Kai Uwe Broulik
broulik added a comment. What about the `!m_helper.isNull()` checks in `onWakeupFromIdle` and `onIdleTimeout`? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D27278 To: alnikiforov, apol, davidedmundson, broulik Cc: broulik, plasma-devel, mlcarr, Orage, LeGast00n

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

2020-02-10 Thread Aleksei Nikiforov
alnikiforov updated this revision to Diff 75348. alnikiforov added a comment. Fixed superfluous parenthesis in one of conditions. REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27278?vs=75344&id=75348 REVISION DETAIL https://phabricator.kde.org/D27278

D27280: ScrollView: Use scrollbar height as bottom padding, not width

2020-02-10 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. Closed by commit R858:6995b4ae81a2: ScrollView: Use scrollbar height as bottom padding, not width (authored by ahiemstra). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricato

D27280: ScrollView: Use scrollbar height as bottom padding, not width

2020-02-10 Thread Arjen Hiemstra
ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Apparently I accidentally used the bottom scrollbar width instead of height. Oops. TEST P

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

2020-02-10 Thread Aleksei Nikiforov
alnikiforov added inline comments. INLINE COMMENTS > broulik wrote in powerdevildpmsaction.cpp:196 > There's a superfluous parenthesis. Right. Thanks for finding it. I've just recently made additional changes in all functions except for initial change in 'PowerDevilDPMSAction::onProfileUnload(

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

2020-02-10 Thread Kai Uwe Broulik
broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. There seem to be a bunch of additional `m_helper.isNull()` that could be ported to be consistent? INLINE COMMENTS > powerdevildpmsaction.cpp:196 > // Inhibition trigge

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

2020-02-10 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Makes sense, this can go into 5.18 branch. Do I need to land this for you? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D27278 To: alnikiforov, apol, davi

D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

2020-02-10 Thread Aleksei Nikiforov
alnikiforov created this revision. alnikiforov added reviewers: apol, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alnikiforov requested review of this revision. REVISION SUMMARY When DPMS extension isn't available, powerdevil unexpectedly exits due to

D27277: Properly search for PipeWire libs

2020-02-10 Thread Jan Grulich
jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY Recent change in upcoming PipeWire releases made all headers to be installed versioned directories so multiple versions can be i

D27276: Powerdevil: allow using qt5widget classes with powerdevil

2020-02-10 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. Lets fix KIdleTime instead. It doesn't need a widget to make an offscreen window REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D27276 To: alnikiforov, apol, davidedmundson Cc:

D27276: Powerdevil: allow using qt5widget classes with powerdevil

2020-02-10 Thread Aleksei Nikiforov
alnikiforov planned changes to this revision. alnikiforov added a comment. I've hit this crash trying to use KDE via x2go (https://wiki.x2go.org/doku.php) with both x2go client and server running in two separate VMs. Here's backtrace of crash: Application: Система управления питан

D27212: Have pullback toolbars on scrollable pages also for footers

2020-02-10 Thread Marco Martin
mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. almost there, just two minor nitpicks INLINE COMMENTS > AbstractApplicationHeader.qml:24 > import org.kde.kirigami 2.4 > - > +import QtQuick.Controls 2.7 as Controls > the maximum

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 54 - Failure!

2020-02-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/54/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 10 Feb 2020 09:46:28 + Build duration: 1 min 35 sec and counting CONSOLE OUTPUT [...

KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 55 - Failure!

2020-02-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/55/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 10 Feb 2020 09:46:34 + Build duration: 1 min 8 sec and counting CONSOLE OUTPUT

D27276: Powerdevil: allow using qt5widget classes with powerdevil

2020-02-10 Thread Aleksei Nikiforov
alnikiforov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alnikiforov requested review of this revision. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D27276 AFFECTED FILES daemon/powerdevilapp.cpp daemon/powerdev

D27251: Relicense to LGPL-2.0-or-later

2020-02-10 Thread Marco Martin
mart added a comment. I'm fine with it. should it be 2.0 or later or 2.1 or later? (I'm ok for whatever makes everyone's life easier) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27251 To: cordlandwehr, mart Cc: plasma-devel, fbampaloukas, GB_2, domson, dkarda

Accessibility in Wayland, somebody at FOSDEM to discuss about it?

2020-02-10 Thread Samuel Thibault
Hello, For information, we have been discussing a couple of days before FOSDEM about how to properly set up the accessibility AT-SPI bus on Wayland, notes are available on https://wiki.gnome.org/Hackfests/GTK2020/Notes Qt will need some changes in order to properly support compartmentized applic

D27054: Syncronise environment to user systemd session

2020-02-10 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:77f418500e56: Syncronise environment to user systemd session (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27054?vs=74755&id

D27206: [Sessions KCM] Fix firmware setup

2020-02-10 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b08981bfe444: [Sessions KCM] Fix firmware setup (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27206?vs=75153&id=75333 REVISION DETAI

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

2020-02-10 Thread Benjamin Port
bport added inline comments. INLINE COMMENTS > kcm.cpp:257 > +{ > +m_currentBehavior = m_behaviorSettingsList[identifier]; > +emit behaviorSettingsChanged(); Add a if to emit signal only if needed REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27188 To