D26797: KCM/Component Refactor UI to a single list of combobox

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f55252fbf5d6: KCM/Component Refactor UI to a single list of combobox (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26797?vs=74541&id=74

D27053: Solid-device-automounter/kcm: Improve width of columns

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8eb9e9b72a47: Solid-device-automounter/kcm: Improve width of columns (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27053?vs=74776&id=74

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5eb5c9ab7d7e: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27019?vs=74

D27071: Remove KCM Init Phase 2

davidedmundson added inline comments. INLINE COMMENTS > main.cpp:133 >libphase = vphase.toInt(); > >if( phase != -1 && libphase != phase ) can you add if (libphase > 1 ) libphase = 1 just in case of some hypothetical 3rd party out there REPOSITORY R120 Plasma Workspa

D27113: Delete cache when resetting user settings

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Can you explain what happens that would require us to delete the cache and why this isn't the case when you change colour themes on a regular session. REPOSITORY

D27113: Delete cache when resetting user settings

filipf created this revision. filipf added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Apparently SDDM's cache is not always allowing for a clean reset of user theming preferences

D26891: Upgrade theme to Breeze GTK on startup

gikari updated this revision to Diff 74881. gikari added a comment. Rename files to provide ground for more kconf scripts in the future REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26891?vs=74815&id=74881 BRANCH apply-theme-on-startup

D27107: Remove redundant reparse configuration call

davidedmundson added a comment. > Would it make sense to port other methods to be triggered by corresponding KConfigWatchers Absolutely. It means changing some stuff upstream to emit the change notifications, but it's the direction I want to take us. REPOSITORY R99 KDE Gtk Configura

D27107: Remove redundant reparse configuration calls

gikari updated this revision to Diff 74877. gikari added a comment. Rollback the reparsings that are actually needed REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27107?vs=74872&id=74877 BRANCH remove-reparse-config (branched from mast

D27107: Remove redundant reparse configuration calls

gikari added a comment. In D27107#604878 , @davidedmundson wrote: > You need to be careful here. > > Some of this code is re-evaluated on receipt of other direct DBus signals. Not from kconfigwatcher. > > In those cases, you will have to

D27109: Fix duplicate results for sessions, simplify and optimize

alex updated this revision to Diff 74875. alex added a comment. Minor formatting improvements REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27109?vs=74874&id=74875 BRANCH katesession_improvements (branched from master) REVISION DETAIL https://p

D27109: Fix duplicate results for sessions, simplify and optimize

alex created this revision. alex added reviewers: broulik, davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The sessions are now only loaded when the plugin is initialized or the folder cha

D27107: Remove redundant reparse configuration calls

davidedmundson added a comment. You need to be careful here. Some of this code is re-evaluated on receipt of other direct DBus signals. Not from kconfigwatcher. In those cases, you will have to reparse. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricat

D27107: Remove redundant reparse configuration calls

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Since KConfigWatcher automatically reparses configuration on change, these calls are redundant. TEST PLAN Check if config changes

D26271: [Applet]Update layout based on T10470

davidedmundson added inline comments. INLINE COMMENTS > ListItemBase.qml:111 > RowLayout { > -Layout.fillWidth: true > +Layout.minimumHeight: contextMenuButton.height > That's asking for a binding loop. An implicit size should never be

D27100: Parameterise GTK config editing

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY This diff is only touches the editing part of the ConfigEditor. Changes: 1. Pass config values as the respecting types: `int

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

alex updated this revision to Diff 74853. alex added a comment. Allow search for profiles without "konsole" prefix REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=74852&id=74853 BRANCH konsole_bugfix (branched from master) REVISION DETAIL

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

alex created this revision. alex added reviewers: davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY Now Konsole is actually startet when an option is selected. Additionally the match method