D27045: [wallpapers] Use more high-quality JPEGs for Next

raveomelette added a comment. Yup, definitely looks nicer! REPOSITORY R31 Breeze BRANCH more-hq-next (branched from master) REVISION DETAIL https://phabricator.kde.org/D27045 To: filipf, #plasma, #vdg, ngraham Cc: The-Feren-OS-Dev, rikmills, raveomelette, plasma-devel, Orage, LeGast00

D27045: [wallpapers] Use more high-quality JPEGs for Next

filipf added a subscriber: rikmills. filipf added a comment. In D27045#603590 , @ngraham wrote: > Noticeably less JPEG-compression-artifacty. > > If this lands, make sure it's on the `Plasma/5.18` branch. Will do! Any objections from #

D27045: [wallpapers] Use more high-quality JPEGs for Next

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Noticeably less JPEG-compression-artifacty. If this lands, make sure it's on the `Plasma/5.18` branch. REPOSITORY R31 Breeze BRANCH more-hq-next (branched from master) REVISION

D27047: Make the api docs reflect that Kirigami is not only a mobile toolkit

nicolasfella created this revision. nicolasfella added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R169 Kirigami BRANCH docs REVISION DETAIL https://phabricator.kde.org/D27047 A

D27034: Fix message box when passing a remote url that includes a file

This revision was automatically updated to reflect the committed changes. Closed by commit R135:317a899dc774: Fix message box when passing a remote url that includes a file (authored by apol). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabric

D27045: [wallpapers] Use more high-quality JPEGs for Next

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Due to filesize concerns, we optimized the Volna wallpaper to be JPEG compressed at 90% quality. JPEGs seems like the right way

D27041: fix incorrect parsing of "at foo.so" and empty function name

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY for unknown reasons gdb seems to behave inconsistently here. usually 'at' denotes a file, but there are backtraces where it doesn't

D26640: [applets/weather] Port weather station picker to QQC2+ListView

This revision was automatically updated to reflect the committed changes. Closed by commit R114:8861250b2e47: [applets/weather] Port weather station picker to QQC2+ListView (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26640?vs=74

D26845: [context menu] Remove last traces of "Lock Widgets" action from UI

This revision was automatically updated to reflect the committed changes. Closed by commit R120:66940389d66b: [context menu] Remove last traces of "Lock Widgets" action from UI (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2684

D26882: [Applets/Folder] Re-arrange positioning of "Arrange in" and "Align" submenus

This revision was automatically updated to reflect the committed changes. Closed by commit R119:37a8d5945ec7: [Applets/Folder] Re-arrange positioning of "Arrange in" and "Align" submenus (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D26912: Use Qt5 signal syntax, format files, optimizations

alex added a comment. Yes, I have used an automatic formatter. And in general about formatting: When I commit a patch which contains code changes, should I format the files (even the code that I don't directly edit) or would it be easier for the reviewers if I commit this in a separate p

D26884: [Folder View] Fix text label color in pop-up

This revision was automatically updated to reflect the committed changes. Closed by commit R119:78eccc8bda2c: [Folder View] Fix text label color in pop-up (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26884?vs=74274&id=74703 REV

D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

ngraham updated this revision to Diff 74702. ngraham added a comment. "Battery may be damaged" -> "Not charging" (it's more accurate) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=73554&id=74702 BRANCH arcpatch-D24070 REVISION DETAIL

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

ngraham added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27019 To: meven, #plasma, broulik, ngraham, ervin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, him

D27037: [Notifications] Fixup setSourceModel

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Qt says to do a proper model reset in this method. I also noticed something funky going on with

D27027: Clip the flickable parent item

apol added a comment. The fact that isn't preexistent doesn't change that if the flicked item were to be placed properly, clipping wouldn't be necessary REPOSITORY R169 Kirigami BRANCH scrollview_clip REVISION DETAIL https://phabricator.kde.org/D27027 To: ahiemstra, #kirigami, ngraha

D27030: remove all platform conditionals not pertaining to linux or *bsd

This revision was automatically updated to reflect the committed changes. Closed by commit R102:43cd7a26f31a: remove all platform conditionals not pertaining to linux or *bsd (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27030?vs=746

D27026: add trivial systemsettings finder and mark it as RUNTIME dep

This revision was automatically updated to reflect the committed changes. Closed by commit R102:35b19106c5cb: add trivial systemsettings finder and mark it as RUNTIME dep (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27026?vs=74673&i

D27036: KApiDox: add "Plasma Workspaces Libraries" group info

kossebau created this revision. kossebau added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Here the initial patch to get a plasma subcategory on api.kde.org started, as

D27034: Fix message box when passing a remote url that includes a file

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY The if was negated, I assume it was a typo TEST PLAN I don't get the following screenshot anymore R

D27027: Clip the flickable parent item

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah the cut-off is a pre-existing issue. This fixes the visual issue I've been seeing with the System Tray configuration view and the Notifications KCM's applications list. +1. REPO

D27027: Clip the flickable parent item

ahiemstra added a comment. That's because the KCM for some reason does not want to size smaller even when the kcmshell window does get smaller. This is not related to the scrollbar however, I get the same result without the scrollbar: F8025393: Screenshot_20200130_152414.png

D26875: Make it possible to stream only input

apol closed this revision. apol added a comment. https://commits.kde.org/xdg-desktop-portal-kde/46ebf487e8075635179cf18bc5f6ec5ea79388aa REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D26875 To: apol, #plasma, #kde_connect, jgruli

D27027: Clip the flickable parent item

apol added a comment. after looks cropped now, are you sure this is the right fix? (not that it isn't necessary...) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27027 To: ahiemstra, #kirigami Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngrah

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

meven added inline comments. INLINE COMMENTS > broulik wrote in DeviceModel.cpp:119 > Do we want to add items that are *not* a `StorageAccess`? > Shouldn't this be more like > > if (access && !access->isIgnored())` I needed to add the not mounted storage access as storage access ignores not

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 421 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/421/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 30 Jan 2020 12:21:04 + Build duration: 38 min and counting JUnit Tests Name: projectr

D26912: Use Qt5 signal syntax, format files, optimizations

meven added a comment. In D26912#603041 , @alex wrote: > Hello, > > I already wondered how this will be handled. > > Should I abandon this revision now and maybe create a new one with the relevant changes once your request has been merged

D26478: KCM/baloo Display full mount point in list of excluded mount points

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3d5719e76a57: KCM/baloo Display full mount point in list of excluded mount points (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26478?v

D27030: remove all platform conditionals not pertaining to linux or *bsd

sitter created this revision. sitter added reviewers: broulik, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY we do not support plasma on anything else, nor do we CI on other platforms, so all th

D27029: Remove header top margin from private ScrollView

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY With the scrollbars taking up actual width, the top margin of the vertical scrollbar b

D27027: Clip the flickable parent item

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Without clipping the contents, they can draw stuff outside of the scrollview bounds, l

D27026: add trivial systemsettings finder and mark it as RUNTIME dep

sitter created this revision. sitter added reviewers: mart, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY simply finds systemsettings5 in the expected path and report it as part of the feature summar

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 420 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/420/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 30 Jan 2020 10:57:39 + Build duration: 2 min 47 sec and counting CONSOLE OUTPUT [...tr

D27023: Port to UpdateLaunchEnvJob

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9e3fd9215245: Port to UpdateLaunchEnvJob (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27023?vs=74666&id=74670 REVISION DETAIL htt

D26993: [libkworkspace] Introduce UpdateLaunchEnvJob

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6253163af827: [libkworkspace] Introduce UpdateLaunchEnvJob (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26993?vs=74668&id=74669 R

D26993: [libkworkspace] Introduce UpdateLaunchEnvJob

broulik updated this revision to Diff 74668. broulik added a comment. - docs REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26993?vs=74587&id=74668 REVISION DETAIL https://phabricator.kde.org/D26993 AFFECTED FILES libkworkspace/CMakeLists.txt

D27023: Port to UpdateLaunchEnvJob

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in krdb.cpp:39-40 > I don't understand why this changes I don't either but it wouldn't build without. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27023 To: broulik, #plasma, davidedmundso

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

meven created this revision. meven added reviewers: broulik, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY A user might find odd that when a known device in the UI is unmounted, it disappears. Despite

D27023: Port to UpdateLaunchEnvJob

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Beautiful. I suspect this will fix a few bugs whilst we're at it. There were a lot running after startplasma has started, so wouldn't have been synced properly to the

D26993: [libkworkspace] Introduce UpdateLaunchEnvJob

davidedmundson added inline comments. INLINE COMMENTS > updatelaunchenvjob.h:28 > + > +class KWORKSPACE_EXPORT UpdateLaunchEnvJob : public KJob > +{ Docs REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26993 To: broulik, #plasma Cc: davidedmundson, plasma-dev

D27023: Port to UpdateLaunchEnvJob

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN Depends on D26993 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D21764: Port all plasma workspace to new libkworkspace API

This revision was automatically updated to reflect the committed changes. Closed by commit R120:26a217fa3d61: Port all plasma workspace to new libkworkspace API (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21764?vs=7428

KDE CI: Plasma » kinfocenter » kf5-qt5 FreeBSDQt5.13 - Build # 94 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/94/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 30 Jan 2020 10:00:38 + Build duration: 4 min 4 sec and counting

D27020: Port plasma-desktop to autoconfig.kde.org

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fc668c5574dd: Port plasma-desktop to autoconfig.kde.org (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27020?vs=74651&id=74657#toc REPOSITORY R119 Plasma Desktop CHAN

KDE CI: Plasma » kinfocenter » kf5-qt5 SUSEQt5.12 - Build # 156 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20SUSEQt5.12/156/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 30 Jan 2020 10:00:38 + Build duration: 3 min 4 sec and counting JUnit Tests Name: (root) Failed

KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/17/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 30 Jan 2020 09:53:18 + Build duration: 3 min 43 sec and counting

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 16 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/16/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 30 Jan 2020 09:53:18 + Build duration: 3 min 7 sec and counting JUnit Tests Name: (

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

meven updated this revision to Diff 74656. meven added a comment. Checking if this is a not-ignored or not mounted StorageAccess is what we need REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27019?vs=74654&id=74656 BRANCH master REVISION DETAIL

D27021: Port plasma-workspace to autoconfig.kde.org

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7eaf278a7de6: Port plasma-workspace to autoconfig.kde.org (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27021?vs=74653&id=74655#toc REPOSITORY R120 Plasma Workspace

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

meven updated this revision to Diff 74654. meven marked an inline comment as done. meven added a comment. Only display device that are not ignored Solid::StorageVolume and Solid::StorageAccess REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27019?vs=

D27021: Port plasma-workspace to autoconfig.kde.org

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. As D27020 , might want to backport this to any branches still being released. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.k

D27020: Port plasma-desktop to autoconfig.kde.org

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Goodness me, yes please. Land in 5.18 for sure (also perhaps backport to anywhere that's still being released) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.or

KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/16/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 30 Jan 2020 09:30:13 + Build duration: 6 min 6 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/15/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 30 Jan 2020 09:30:13 + Build duration: 2 min 8 sec and counting CONSOLE OUTPUT [...t

D27021: Port plasma-workspace to autoconf.kde.org

broulik created this revision. broulik added reviewers: Plasma, leinir, bcooksley. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY As per Ben's request in https://mail.kde.org/pipermail/kde-frameworks-devel/202

D27020: Port plasma-desktop to autoconf.kde.org

broulik created this revision. broulik added reviewers: Plasma, leinir, bcooksley. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY As per Ben's request in https://mail.kde.org/pipermail/kde-frameworks-devel/202

D27018: [sddm-theme] Fix broken wallpaper loading

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9573fd8c99ca: [sddm-theme] Fix broken wallpaper loading (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27018?vs=74646&id=74650 REVIS

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

broulik added inline comments. INLINE COMMENTS > DeviceModel.cpp:119 > +const Solid::StorageAccess *access = dev.as(); > +if (access == nullptr || !access->isIgnored()) { > +beginInsertRows(index(0, 0), m_attached.size(), > m_attached.size()); Do we want to add items

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

meven updated this revision to Diff 74649. meven added a comment. Separate foreach conversions REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27019?vs=74647&id=74649 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27019 AFFECTED FIL

D26912: Use Qt5 signal syntax, format files, optimizations

alex added a comment. Hello, I already wondered how this will be handled. Should I abandon this revision now and maybe create a new one with the relevant changes once your request has been merged ? And is there any way I could have known that this kcm is going to be refactored ?

D26999: [Notifications] Fix action button size

This revision was automatically updated to reflect the committed changes. Closed by commit R120:aaf9c38749b2: [Notifications] Fix action button size (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26999?vs=74603&id=74648 REVISIO

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

broulik added a comment. Can we do the foreach ports separately, please REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27019 To: meven, #plasma, broulik, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragr

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

meven created this revision. meven added reviewers: Plasma, broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY BUG: 396537 FIXED-IN: 5.18 REPOSITORY R119 Plasma Desktop BRANCH master REVISI

D27018: [sddm-theme] Fix broken wallpaper loading

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY We switched to .jpg for Next but SDDM theme's code still points to .png so we got a white screen instead. Have the code point to

D24070: [Applets/Battery] Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. Are you asking for my approval? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: ngraham, #vdg, #plasma, ndavis, mthw Cc: GB_2, ndavis, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,

D26797: KCM/Component Refactor UI to a single list of combobox

meven added a comment. > I may want to reconsider and simply add whatever service is in Default Application and display it, ignoring entries in "Added Associations", as I do elsewhere. I am thinking about doing this, as it makes the code more similar with other cfgplugin, and the curren

D26912: Use Qt5 signal syntax, format files, optimizations

meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. This kcms is going through some refactoring in D26934 , not the greatest time for a mostly formatting PR. This will introduce a lot of conflic