D26739: [applets/Task Manager] Refine tooltip highlight effect

ndavis accepted this revision. ndavis added a comment. LGTM REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26739 To: ngraham, #plasma, #vdg, filipf, ndavis Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampal

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham updated this revision to Diff 74475. ngraham added a comment. Correct comment; last change now :) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26739?vs=74474&id=74475 BRANCH tooltip-highlights-take-2 (branched from master) REVISION DETA

D26739: [applets/Task Manager] Refine tooltip highlight effect

ndavis added a comment. BTW, I tried fixing the old style just to see if I wanted it more and got most of the way there (I had to edit the size of the 2nd Rectangle in `playerControlsFrostedGlass`), but realized that this new style is still better. REPOSITORY R119 Plasma Desktop REVISION

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham updated this revision to Diff 74474. ngraham added a comment. Fix that and also make the code simpler and more sensible REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26739?vs=74465&id=74474 BRANCH tooltip-highlights-take-2 (branched from

D26956: Remove export header from static install

masonm added a comment. Ah, I'll take a closer look. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D26956 To: masonm, #kirigami, mart, apol Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. In D26739#601666 , @ndavis wrote: > Actually, I just noticed a problem. When you hover over the bar, the thumbnail area gets highlighted, bit if you click on the bar, it doesn't bring the window to the front. Yes,

D26739: [applets/Task Manager] Refine tooltip highlight effect

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Actually, I just noticed a problem. When you hover over the bar, the thumbnail area gets highlighted, bit if you click on the bar, it doesn't bring the window to the front. REPOS

D26739: [applets/Task Manager] Refine tooltip highlight effect

ndavis added a comment. In D26739#601652 , @trmdi wrote: > What happens when you hover the mouse on the control bar? Did you address it? The buttons on the control bar use normal plasmashell toolbutton hover effects. The bar itself does

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. What happens when you hover the mouse on the control bar? Did you address it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26739 To: ngraham, #plasma, #vdg, filipf, ndavis Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The

D26956: Remove export header from static install

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Wait no, are you sure? kirigami headers will still include the file... REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D26956 To: masonm, #kirigami, mart, ap

D26953: Replace Ice Cold with Volna for Plasma 5.18

ngraham planned changes to this revision. ngraham added a comment. That's a good point. I'll try a high-quality-level JPEG and see how that looks. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26953 To: ngraham, #vdg, #plasma, davidedmundson Cc: Luwx, ndavis, brouli

D26739: [applets/Task Manager] Refine tooltip highlight effect

ndavis accepted this revision. ndavis added a comment. I like this. It's pretty elegant. F7981156: Screenshot_20200127_202032.PNG F7981150: Screenshot_20200127_201909.PNG REPOSITORY R119 Plasma Desktop REVIS

D26956: Remove export header from static install

masonm created this revision. masonm added a reviewer: VDG. masonm added a project: Kirigami. Herald added a subscriber: plasma-devel. masonm requested review of this revision. REVISION SUMMARY When building the "install" target with a static Kirigami build an error occurs due to the missing fi

D26953: Replace Ice Cold with Volna for Plasma 5.18

Luwx added a comment. The compression affected the wallpaper quality quite a lot, especially at lower resolutions. There are some artifacts (unnaturally bright pixels) F7980960: 2020-01-27_21-05.png If saving space is very important, JPEG format ma

D26953: Replace Ice Cold with Volna for Plasma 5.18

ndavis added a comment. In D26953#601606 , @broulik wrote: > What's with the odd dithering, though? Is that intentional? > > FTR at 3840x2160 our past images were: > 5.16 (ice cold) 1.6 MiB > 5.14 (the one with the galaxy) 3.9 MiB > 5

D26953: Replace Ice Cold with Volna for Plasma 5.18

broulik added a comment. What's with the odd dithering, though? Is that intentional? FTR at 3840x2160 our past images were: 5.16 (ice cold) 3.2 MiB 5.14 (the one with the galaxy) 3.9 MiB 5.12 (the blue-brown stripe) 3.2 MiB 5.10 2.3 MiB 5.9 (canoppee with the "9") a whopping 5.9

D26953: Replace Ice Cold with Volna for Plasma 5.18

ngraham updated this revision to Diff 74466. ngraham added a comment. Use https://www.imagesmaller.com/ to reduce total size to 22 Mb REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26953?vs=74461&id=74466 BRANCH icecold-to-volna (branched from Plasma/5.18)

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham updated this revision to Diff 74465. ngraham added a comment. Tweak pixels once more and add explanatory comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26739?vs=74464&id=74465 BRANCH tooltip-highlights-take-2 (branched from master

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham updated this revision to Diff 74464. ngraham added a comment. That is nicer; let's do that instead REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26739?vs=74183&id=74464 BRANCH tooltip-highlights-take-2 (branched from master) REVISION DET

D26954: Add Ice Cold wallpaper

ngraham updated this revision to Diff 74463. ngraham added a comment. Actually add it lol REPOSITORY R131 Plasma Wallpapers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26954?vs=74462&id=74463 BRANCH add-icecold (branched from Plasma/5.18) REVISION DETAIL https://phabricat

D26954: Add Ice Cold wallpaper

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Per tradition, we add the previous Plasma version's wallpaper to this repo when it gets rep

D26953: Replace Ice Cold with Volna for Plasma 5.18

ngraham added a comment. Outstanding concern: The full collection is much larger than Ice Cold; 46 Mb compared to 13 Mb for all the Ice Cold versions. The author already did some optimization, but everything is still quite a bit larger in total. Is there anyone in #VDG

D26953: Replace Ice Cold with Volna for Plasma 5.18

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Volna won the wallpaper competition, so time to add it to Breeze as the new default! TEST PL

D26943: [Notifications] Set transient parent for file menu

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3c31b7a6a1b7: [Notifications] Set transient parent for file menu (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26943?vs=74436&id=74

D26895: Introduce an Info Center mode

meven added inline comments. INLINE COMMENTS > BaseMode.cpp:32 > #include "ModuleView.h" > - > +#include > class BaseMode::Private { Not needed > mart wrote in ModuleView.cpp:349 > that's a good point. > Tough, at the moment we don't do anything with the statistics in kinfocenter > mode, so

D26947: Drop kconf_update module, handled by kde-gtk-config now

fvogt added a comment. In D26947#601517 , @ngraham wrote: > 5.18 I suppose? Yes, once D26891 landed. REPOSITORY R98 Breeze for Gtk BRANCH nokconf_update REVISION DETAIL https://phabricator.kde.

D26924: [SystemTray] Remove scrolbar paddings

ngraham added a comment. No worries! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26924 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham, nicolasfella Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fba

D26947: Drop kconf_update module, handled by kde-gtk-config now

ngraham added a comment. 5.18 I suppose? REPOSITORY R98 Breeze for Gtk BRANCH nokconf_update REVISION DETAIL https://phabricator.kde.org/D26947 To: fvogt, #plasma, gikari, davidedmundson Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB

D26945: Added smallSpacing to leftMargin

ngraham added a comment. Hmm, it almost seems like the header in the popup is over too far to the right, and we should fix that (and maybe increase the default margins in the theme: D21813 ) rather than adding extra margins in every plasmoid. REPOSITORY

D26946: Changed leftMargins to smallSpacing to be consistent

ngraham added a comment. Hmm, it almost seems like the header in the popup is over too far to the right, and we should fix that (and maybe increase the default margins in the theme: D21813 ) rather than adding extra margins in every plasmoid. REPOSITORY

D25273: Enable selecting all installed color schemes in Cuttlefish

This revision was automatically updated to reflect the committed changes. Closed by commit R118:2d8d17a7b4e6: Enable selecting all installed color schemes in Cuttlefish (authored by davidre). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25273?vs=74358&id=

D26926: Fix Windows build (Qt5.14 deprecation)

jjazeix closed this revision. jjazeix added a comment. Fix is commited, there are now link issues with KStatusNotifierItem: https://build.kde.org/view/Failing/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/2/console REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 2 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/2/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 27 Jan 2020 16:38:36 + Build duration: 2 min 36 sec and counting CONSOLE OUTPUT [...tru

D26947: Drop kconf_update module, handled by kde-gtk-config now

fvogt created this revision. fvogt added reviewers: Plasma, gikari. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY D26891 introduces a kconf_update script which achieves the same. TEST PLAN Ran make, no kconf_upd

D26941: [Task Manager] Remove strict URL handling

ngraham added a comment. Works for me with all my use cases. I think this makes sense to go into 5.18.0 with enough testing (so thanks for the new unit test!). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26941 To: broulik, #plasma, hein Cc: ngraham, pla

D26806: [Applets/Power Manager] Update layout based on T10470

manueljlin added a comment. Might be better to be aligned to the left since it looks similar now to the battery percentage, but aside from that it's great! Also, sorry for replying late :P REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #p

D26946: Changed leftMargins to smallSpacing to be consistent

niccolove updated this revision to Diff 74443. niccolove added a comment. Revert accidental line changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26946?vs=74441&id=74443 BRANCH smallspacingmargin (branched from master) REVISION DETAIL h

D26686: Remove scrollbar related workarounds from list delegates

This revision was automatically updated to reflect the committed changes. Closed by commit R858:9dfb38179ac5: Remove scrollbar related workarounds from list delegates (authored by ahiemstra). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde

D26946: Changed leftMargins to smallSpacing to be consistent

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY With other two patches, this aims to make leftMargin consistent in widgets REPOSITORY R120 Plasma Workspace BRANCH smallsp

D25634: Add kconf update script for ksmserver

davidedmundson updated this revision to Diff 74440. davidedmundson added a comment. update copying and pasting something fvogt just did REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25634?vs=70627&id=74440 BRANCH master REVISION DETAIL https:/

D26773: Added option to blur background on active window

niccolove added a comment. Sorry, forgot I was on a arc feature already! Forget the last commit REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26773 To: niccolove, #plasma Cc: mart, Zren, ngraham, anthonyfieroni, davidedmundson, plasma-devel, Orage, LeGast

D26945: Added smallSpacing to leftMargin

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY With the other two patches, this aims to make leftMargin consistent in plasmoids. REPOSITORY R104 KScreen BRANCH master

D26891: Upgrade theme to Breeze GTK on startup

gikari added a comment. In D26891#601329 , @fvogt wrote: > Tested, confirmed to work. > > I wonder what's up with the gtkrc files everywhere: > > ~/.config/gtkrc-2.0 > ~/.config/gtkrc > ~/.gtkrc-2.0 > ./.config/gtk-3.0 >

D26773: Added option to blur background on active window

niccolove updated this revision to Diff 74439. niccolove added a comment. Set all proper leftMargins to smallSpacing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26773?vs=73894&id=74439 BRANCH master REVISION DETAIL https://phabricator.kde.

D26943: [Notifications] Set transient parent for file menu

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Required on Wayland so it can be properly positioned. BUG: 387597 FIXED-IN: 5.18.0 TEST PL

D26891: Upgrade theme to Breeze GTK on startup

fvogt added a comment. Tested, confirmed to work. I wonder what's up with the gtkrc files everywhere: ~/.config/gtkrc-2.0 ~/.config/gtkrc ~/.gtkrc-2.0 ./.config/gtk-3.0 It seems like the first two are created by krdb, does it read both still? REPOSITORY R99 KDE G

D26942: Fix kwin.upd not running if python 2 not installed

This revision was automatically updated to reflect the committed changes. Closed by commit R108:53af330d8f3e: Fix kwin.upd not running if python 2 not installed (authored by fvogt). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26942?vs=74432&id=74435 REVISION

D26896: Kill the KinfoCenter binary

mart updated this revision to Diff 74434. mart added a comment. - back to kinfocenter bin name REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26896?vs=74433&id=74434 BRANCH mart/kinfoCenterMode REVISION DETAIL https://phabricator.kde.org/D26896 A

D26896: Kill the KinfoCenter binary

mart updated this revision to Diff 74433. mart added a comment. - link kinfocenter to systemsettings5 REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26896?vs=74308&id=74433 BRANCH mart/kinfoCenterMode REVISION DETAIL https://phabricator.kde.org/D2

D26942: Fix kwin.upd not running if python 2 not installed

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: KWin. Herald added a subscriber: kwin. fvogt requested review of this revision. REVISION SUMMARY If the listed interpreter does not exist, kconf_update skips the update. The update script uses python3, so decl

D26891: Upgrade theme to Breeze GTK on startup

gikari added a comment. @meven wrote: > What if users have a different default theme set on first launch? I would suggest to read the current theme instead of hardcoding Breeze. But I do not know where the information about the default GTK theme is located, so I do not know what to

D26941: [Task Manager] Remove strict URL handling

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The code tried hard to ignore garbage URLs, as Qt is quite lenient, e.g. `QUrl("Garbage Url"

D26895: Introduce an Info Center mode

mart updated this revision to Diff 74422. mart marked 6 inline comments as done. mart added a comment. - base behavior on executable name REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26895?vs=74307&id=74422 BRANCH mart/kinfoCenterMode REVISION

D26895: Introduce an Info Center mode

mart added inline comments. INLINE COMMENTS > meven wrote in ModuleView.cpp:349 > We might want to have a different url scheme like "kinfo" insteat of "kcm" > and "org.kde.kinfocenter" instead of "org.kde.systemsettings" that's a good point. Tough, at the moment we don't do anything with the st

D26935: context: add function to allow loading and unloading modules

sitter added inline comments. INLINE COMMENTS > context.cpp:600 > > +void Context::loadModule(const QString &name, const QString &argument) > +{ Should this maybe return a bool? If the operation as a whole fails it seems that should be reflected somehow. Or does this emit an error via event

D26937: Add a convenience property to retrieve the size of the decorated client

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY It can be useful if we want to know both width and height or react to any changes in the size of the decora

D26935: context: add function to allow loading and unloading modules

bshah updated this revision to Diff 74417. bshah added a comment. add ::unloadModule which takes Module* parameter REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26935?vs=74414&id=74417 BRANCH add-load-unload-module REVISION DETAIL http

D26935: context: add function to allow loading and unloading modules

bshah added a comment. > unloadModule should work with a Module* given the rest of the API deals with them rather than their index I think Yes, it does indeed make sense, maybe I can add a another signature of unloadModule which takes Module* as argument. > I was about to say someth

D26935: context: add function to allow loading and unloading modules

bshah created this revision. bshah added reviewers: sitter, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY Current usecase is dialer wanting to load the loopback modules during runtime. REPOSITOR

D26935: context: add function to allow loading and unloading modules

nicolasfella added a comment. I was about to say something similar. Where would one get the index from? REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D26935 To: bshah, sitter, nicolasfella Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh

D26935: context: add function to allow loading and unloading modules

sitter added a comment. unloadModule should work with a Module* given the rest of the API deals with them rather than their index I think REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D26935 To: bshah, sitter, nicolasfella Cc: plasma-devel, Orage, Le

Notes for 27/01/2020 monday meeting

Kai Uwe: * Wrote a blog post on some of the non-KDE code that still benefits our overall ecosystem I did: https://blog.broulik.de/2020/01/venturing-out/ Notifications: * Added quick reply to Telegram Desktop client \o/ Supposedly that release is already out. * When there is only a reply action, now

D26934: KCM/Autostart Add a model to separate logic from UI

meven created this revision. meven added reviewers: mlaurent, ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Adds the complete fileName of the autastart entries as tooltips. TEST PLAN - Add a de

D26926: Fix Windows build (Qt5.14 deprecation)

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. LGTM. Not that I understand where the sprintf function disappeared to. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D26926 To: jjazeix, #plasma, sitter Cc: sitte