D26850: [SystemTray] Fix model update in settings (missing icon)

This revision was automatically updated to reflect the committed changes. kmaterka marked an inline comment as done. Closed by commit R120:3ba955f4f5c5: [SystemTray] Fix model update in settings (missing icon) (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26924: [SystemTray] Remove scrolbar paddings

kmaterka added a comment. In D26924#601024 , @ngraham wrote: > The scrollbar changes are in 5.18; shouldn't this go to the stable branch instead of master-only? Yes, sorry, I forgot about this REPOSITORY R120 Plasma Workspace REVI

D26924: [SystemTray] Remove scrolbar paddings

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2f08da60981a: [SystemTray] Remove scrollbar paddings (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26924?vs=74383&id=74403 REVISI

D26530: ScrollView: Do not overlay scrollbars over contents

nicolasfella added a comment. This has caused a regression in the plasma-pa KCM. The scrollview content is now a bit larger than the scrollview itself which results in a horizontal scrollbar appearing F7965068: Screenshot_20200126_181545.PNG REPOS

D26928: Correctly process font, that has multiple words in family name

gikari added a comment. In D26928#601009 , @davidedmundson wrote: > Can't style names have a space too? If you add comma after style too, it would break font config reading. But there is a workaround for that - you can select font with t

D26924: [SystemTray] Remove scrolbar paddings

ngraham added a comment. The scrollbar changes are in 5.18; shouldn't this go to the stable branch instead of master-only? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D26924 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, brou

D26928: Correctly process font, that has multiple words in family name

This revision was automatically updated to reflect the committed changes. Closed by commit R99:8bf4efd76430: Correctly process font, that has multiple words in family name (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D26923: Fix systemtray configuration

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. @konrad you're part of the kde team now. Feel free to approve things you're comfortable with. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.18 REVISION DETAIL htt

D26928: Correctly process font, that has multiple words in family name

davidedmundson added a comment. Can't style names have a space too? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH apply-font-styles-correctly (branched from master) REVISION DETAIL https://phabricator.kde.org/D26928 To: gikari, ngraham Cc: davidedmundson, plasma-devel, Orage, LeGas

D26928: Correctly process font, that has multiple words in family name

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Separate family from other font characteristics with comma. It partially solves the issue, because font dialog in Fonts KCM allows

D26926: Fix Windows build (Qt5.14 deprecation)

jjazeix created this revision. jjazeix added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jjazeix requested review of this revision. REVISION SUMMARY Fixes https://build.kde.org/view/Failing/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/

D26891: Upgrade theme to Breeze GTK on startup

gikari updated this revision to Diff 74386. gikari marked 2 inline comments as done. gikari added a comment. Remove redundant theme update on startup REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26891?vs=74382&id=74386 BRANCH apply-th

D26891: Upgrade theme to Breeze GTK on startup

gikari added inline comments. INLINE COMMENTS > fvogt wrote in gtkconfig.cpp:207 > Now those two aren't needed anymore? Hm, yeah. Actually I think it is redundant to replace theme configuration on each start. It would make sense, if it was about syncing the settings, but since GTK theme is set

D26891: Upgrade theme to Breeze GTK on startup

fvogt added inline comments. INLINE COMMENTS > gtkconfig.cpp:207 > setEnableAnimations(); > +setDefaultGtk2Theme(); > +setDefaultGtk3Theme(); Now those two aren't needed anymore? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26891 To:

D26925: Add IntelliJ IDEA project files to ignored

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a2a2609048f0: Add IntelliJ IDEA project files to ignored (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26925?vs=74384&id=74385 RE

D26925: Add IntelliJ IDEA project files to ignored

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson, broulik, ngraham. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Used by some developers, IntelliJ IDEA has nice git, diff and replace tools. RE

D26924: [SystemTray] Remove scrolbar paddings

kmaterka updated this revision to Diff 74383. kmaterka added a comment. Just reverting last update, I will create separate revision. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26924?vs=74381&id=74383 BRANCH master REVISION DETAIL https://

D26891: Apply Breeze GTK theme on startup, if the config is empty

gikari updated this revision to Diff 74382. gikari added a comment. Provide kconf_script to upgrade themes from old ones. It is mostly the same as the one in `breeze-gtk` repo, but better. REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26

D26924: [SystemTray] Remove scrolbar paddings

kmaterka updated this revision to Diff 74381. kmaterka added a comment. - Add IntelliJ IDEA project files to ignored REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26924?vs=74380&id=74381 BRANCH master REVISION DETAIL https://phabricator.kde.

D26924: [SystemTray] Remove scrolbar paddings

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson, broulik, ngraham. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Removes additional paddings. Not needed when scrollbar is no longer overlaying

D26923: Fix systemtray configuration

kmaterka added a comment. Look good for me, but someone else from KDE team needs to approve this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26923 To: carewolf, #plasma_workspaces, davidedmundson Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-O

D26923: Fix systemtray configuration

carewolf updated this revision to Diff 74379. carewolf added a comment. Changed name of property instead REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26923?vs=74378&id=74379 BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D26

D26923: Fix systemtray configuration

kmaterka added a comment. Thanks for noticing! The `currentValue` property was introduced with QtQuick.Controls 2.14 (Qt 5.14). Very convenient, unfortunately Plasma 5.18 must support Qt 5.12. BTW. QML import

D26586: [SystemTray] Rework system tray settings

carewolf added a comment. In D26586#600864 , @kmaterka wrote: > In D26586#600853 , @carewolf wrote: > > > This change break settings for me due to currentValue in ConfigEntries.qml conflicting. It w

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. In D26586#600853 , @carewolf wrote: > This change break settings for me due to currentValue in ConfigEntries.qml conflicting. It works if I rename the variable to something else Are you using Qt 5.14? REPOSITORY

D26923: Fix systemtray configuration

carewolf created this revision. carewolf added reviewers: Plasma: Workspaces, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. carewolf requested review of this revision. REVISION SUMMARY The property currentValue is conflicting making the qml file not run

D26586: [SystemTray] Rework system tray settings

carewolf added a comment. This change break settings for me due to currentValue in ConfigEntries.qml conflicting. It works if I rename the variable to something else REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26586 To: kmaterka, #plasma_workspaces, #pl