D26891: Apply Breeze GTK theme on startup, if the config is empty

fvogt added a comment. In D26891#600837 , @gikari wrote: > @fvogt Do I understand correctly, that `kconf_update` script also run on Plasma update, if I add a new `Id` to one of .upd file (or add one with new `Id`)? For example from 5.17 to 5.18?

D26891: Apply Breeze GTK theme on startup, if the config is empty

gikari added a comment. @fvogt Do I understand correctly, that `kconf_update` script also run on Plasma update, if I add a new `Id` to one of .upd file (or add one with new `Id`)? For example from 5.17 to 5.18? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricato

D26891: Apply Breeze GTK theme on startup, if the config is empty

gikari added inline comments. INLINE COMMENTS > meven wrote in gtkconfig.cpp:215 > What if users have a different default / theme set on first launch ? > I would suggest to read the current theme instead of hardcoding Breeze. Where can I read the default value from? REPOSITORY R99 KDE Gtk Con

D26891: Apply Breeze GTK theme on startup, if the config is empty

meven added inline comments. INLINE COMMENTS > gtkconfig.cpp:215 > +if (currentGtk2Theme.isEmpty()) { > +setGtk2Theme(QStringLiteral("Breeze")); > +} What if users have a different default / theme set on first launch ? I would suggest to read the current theme instead of hardcodi

D26916: Allow to display in the kicker appliation context menu the recently accessed directories

meven created this revision. meven added reviewers: Plasma, hein, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Similar to D26915 Depends on D26407

D26915: Allow to display in the task context menu the recently accessed directories

meven created this revision. meven added reviewers: hein, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Useful for filemanagers, i.e Dolphin Depends on D26407 R

D24728: Ensure url from KActivity resources are properly built

meven abandoned this revision. meven added a comment. See comment in D22005 https://phabricator.kde.org/D22005#600706 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24728 To: meven, broulik, hein Cc: plasma-devel, Orage

D22005: Ensure url from KActivity resources are properly built

meven abandoned this revision. meven added a comment. After further check, my patch does not do much, just allowed me to discover bug about dolphin's recent folder list missing. if (QDir::isAbsolutePath(resource)) { resource = QUrl::fromLocalFile(resource).toString(); }

D26891: Apply Breeze GTK theme on startup, if the config is empty

fvogt added a comment. In D26891#600285 , @gikari wrote: > In D26891#600210 , @fvogt wrote: > > > It should only do the migration once, like the kconf_update script. > > > From where migration s

D25273: Enable selecting all installed color schemes in Cuttlefish

davidre updated this revision to Diff 74358. davidre marked an inline comment as done. davidre added a comment. Fix typo REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25273?vs=74332&id=74358 BRANCH colorschemes (branched from master) REVISION DETAIL

D25273: Enable selecting all installed color schemes in Cuttlefish

davidre added a comment. In D25273#600583 , @ngraham wrote: > Bad combobox width strikes again (https://bugs.kde.org/show_bug.cgi?id=403153), worsened by adding an icon: Bah we should fix it finally if possible > F7939162: Screenshot

D26912: Use Qt5 signal syntax, format files, optimizations

alex updated this revision to Diff 74355. alex added a comment. Implement requested changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26912?vs=74352&id=74355 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26912 AFFECTED FILES

D26912: Use Qt5 signal syntax, format files, optimizations

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > addscriptdialog.cpp:39 > +QVBoxLayout *lay = new QVBoxLayout; > +setLayout(lay); > +QLabel *lab = new QLabel(i18n("Shell script path:"), this);

D26912: Use Qt5 signal syntax, format files, optimizations

alex created this revision. alex added reviewers: mlaurent, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The files have been formatted according to the KDE/Qt conventions. The signals in the co