KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/9/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 18 Jan 2020 07:39:05 + Build duration: 1 min 8 sec and counting CONSOLE OUTPUT

D26747: Fix typo

alex created this revision. alex added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The word editing had one "t" to much TEST PLAN / REPOSITORY R119 Plasma Desktop BRANCH master REVIS

D26738: Fix typo, launch plugin with argument, change signals

alex updated this revision to Diff 73814. alex added a comment. As requested the update of the HACKING file will be committed separately. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26738?vs=73794&id=73814 REVISION DETAIL https://phabricator.kd

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham added a comment. In D26739#596363 , @ndavis wrote: > You can't shrink the size of it to fit within the blue border? That's what this patch does in its current form. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabr

D26739: [applets/Task Manager] Refine tooltip highlight effect

ndavis added a comment. In D26739#596355 , @ngraham wrote: > Yeah. I don't disagree. But if I just ensure that the highlight effect is the highest item, the borders still get obscured by the player controls and album art. And the rounded corners

D26739: [applets/Task Manager] Refine tooltip highlight effect

ndavis added inline comments. INLINE COMMENTS > ToolTipInstance.qml:185 > pressed: hoverHandler.containsPress > +z: > } I recall seeing a QML dos and don'ts webinar that said not to use large z values. REPOSITORY R119 Plasma Desktop REVISIO

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham added a comment. Yeah. I don't disagree. But if I just ensure that the highlight effect is the highest item, the borders still get obscured by the player controls and album art. And the rounded corners of the highlight leave a pixel or two of the art to escape the bounds too. F7

D26739: [applets/Task Manager] Refine tooltip highlight effect

filipf added a comment. In D26739#596320 , @ndavis wrote: > Not a fan of the inner frame. We should avoid making frames within frames. I don't think it really needs changing, except that the sides cover the blue border frame. > > F7889165: S

D26746: Add active, link, visited, negative, neutral and positive background colors

ndavis created this revision. ndavis added reviewers: Kirigami, Plasma. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY These colors were added to Kirigami and qqc2-desktop-style, so I had to add them h

D26745: Add active, link, visited, negative, neutral and positive background colors

ndavis created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Buttons colored with special text role colors as backgrounds don't always look nice with black text on light themes. They should have

D26739: [applets/Task Manager] Refine tooltip highlight effect

ndavis added a comment. Not a fan of the inner frame. We should avoid making frames within frames. I don't think it really needs changing, except that the sides cover the blue border frame. F7889165: Screenshot_20200117_211120.PNG REPOSITORY R11

D26743: Add active, link, visited, negative, neutral and positive background colors

ndavis created this revision. ndavis added reviewers: mart, Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Buttons colored with special text colors didn't look very good with black text on light the

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

victorr added a comment. Now there are a lot of errors with localization. There is a message about them. https://bugs.kde.org/show_bug.cgi?id=415541 Temporarily fixed this problem with attached patches when building packages. This error was originally described here https://phabricator

D26738: Fix typo, launch plugin with argument, change signals

apol added a comment. Looks good to me overall. Can you commit the HACKING change separately? it's completely unrelated. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26738 To: alex, broulik Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zac

D26719: [Battery Monitor] Glow icon on hover

kmaterka marked an inline comment as done. kmaterka added a comment. The question is: should I move this component somewhere else? PlasmaComponents3? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26719 To: kmaterka, #plasma_workspaces, #plasma, broulik, n

D26719: [Battery Monitor] Glow icon on hover

kmaterka updated this revision to Diff 73799. kmaterka added a comment. Remove leftovers from tests REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26719?vs=73767&id=73799 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26719 AFFEC

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham added a comment. I'm not 100% sold on drawing the highlight on top and tinting everything, and can revert that part if everyone else hates it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26739 To: ngraham, #plasma, #vdg Cc: plasma-devel, LeGast00n

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch implements the following visual tweaks: - Draws the highlight effect on top so

D26738: Fix typo, launch plugin with argument, change signals

alex created this revision. alex added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The typo in the HACKING file has been fixed, the kcms/runners plugin is now able to launch a specific plu

D26733: sync tooltip delay with systemsettings

ngraham added a comment. Yeah, it might be nice to extract this into a framework that can bee used by all three apps so it can't diverge this way again. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D26733 To: sitter Cc: ngraham, bcooksley, plasma-devel, LeGast

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 245 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/245/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 17 Jan 2020 17:56:08 + Build duration: 5 min 4 sec and counting JUnit Tests N

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 93 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/93/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 17 Jan 2020 17:56:08 + Build duration: 3 min 54 sec and counting JUnit Tests

D26733: sync tooltip delay with systemsettings

sitter added a comment. ugh :( Thanks for context though. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D26733 To: sitter Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D26733: sync tooltip delay with systemsettings

bcooksley added a comment. The code if memory serves originates from Dolphin, it was copied from there into System Settings (which was done by me - we weren't sure about API stability at the time for upstreaming to kdelibs as it was at the time), and then must have been copied again from the

D26733: sync tooltip delay with systemsettings

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY 50 is fairly short, 300 as used in systemsettings is much nicer and also makes the two uis behave the same BUG: 393722 FIXED-

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

ngraham abandoned this revision. ngraham added a comment. Abandoning in favor of those patches. Thanks @meven! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17372 To: ngraham, #plasma, #vdg, #frameworks, dfaure Cc: meven, GB_2, dfaure, abetts, davidedmundson

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

meven added a comment. In D17372#472624 , @dfaure wrote: > Writing into the user's home dir is a "hack". > > There are better ways for distros to set defaults (such as the global mimeapps.list) but it seems KIO ignores that... (to be checked.

D26731: KCM/Component Revamp Browser config

ngraham accepted this revision. ngraham added a reviewer: dfaure. ngraham added a comment. This revision is now accepted and ready to land. Works for me FWIW. REPOSITORY R119 Plasma Desktop BRANCH browser-settings REVISION DETAIL https://phabricator.kde.org/D26731 To: meven, ngraham,

D26731: KCM/Component Revamp Browser config

ngraham added a comment. The "Dans une application fondée sue le contenu d l'URL" setting is actually something I proposed removing in D17372 , and it got approval in theory, but it seems like this is quite a far-reaching change that requires many consider

D26731: KCM/Component Revamp Browser config

meven added inline comments. INLINE COMMENTS > componentchooserbrowser.cpp:79 > { > -return radioKIO->isChecked(); > +// no real default > +return true; Do we want to set falkon or konqueror as default ? > componentchooserbrowser.cpp:86 > -if (exec.isEmpty()) { > -radio

D26731: KCM/Component Revamp Browser config

meven created this revision. meven added reviewers: ngraham, Plasma, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Simplify UI: - Select option in the available browser - use mimeapps.list preferre

D26640: [applets/weather] Port weather station picker to QQC2+ListView

ngraham updated this revision to Diff 73780. ngraham marked 3 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26640?vs=73464&id=73780 BRANCH port-to-listview-in-scrollview (br

D26640: [applets/weather] Port weather station picker to QQC2+ListView

ngraham added inline comments. INLINE COMMENTS > broulik wrote in WeatherStationPicker.qml:144 > This is unlike any other list we have in settings? I copied it from the notifications KCM :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D26640 To: ngraham, #vdg,

D26730: pare xorg version for nicer display

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY instead of just printing a random integer lets try to print a nice looking version string. since I couldn't find cross-implementat

D26640: [applets/weather] Port weather station picker to QQC2+ListView

broulik added inline comments. INLINE COMMENTS > WeatherStationPicker.qml:44 > if (!success) { > noSearchResultReport.text = i18nc("@info", "No weather stations > found for '%1'", searchString); > noSearchResultReport.visible = true; Given the item is hidden a

D26729: do not disable getifaddrs use because of sa_len availablility

sitter updated this revision to Diff 73777. sitter added a comment. committing the latest working tree helps a lot -.- REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26729?vs=73776&id=73777 BRANCH ipv6 REVISION DETAIL https://phabricator.kde.org/D

D26729: do not disable getifaddrs use because of sa_len availablility

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY this fixes ipv6 support in nic listing. well, kinda. the getifaddrs branch is the only one supporting ipv6 properly so it seems

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham marked an inline comment as done. ngraham added a comment. Re-added the namespace but the state checking still doesn't seem to work properly. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmunds

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 73775. ngraham added a comment. Re-add namespace REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=73771&id=73775 BRANCH suspend-and-resume-and-monitor-indexing-from-the-kcm (branched from master) REVIS

D24706: [RFC] Change button style

ndavis added a comment. In D24706#595796 , @cfeck wrote: > If application developers need a rotated button, they need to rotate only the contents, not the frame. Good to know. I remembered seeing an earlier version of the KScreen redesign

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 320 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/320/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 17 Jan 2020 15:13:27 + Build duration: 2 min 24 sec and counting JUnit Tests Name: (root) Failed:

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 319 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/319/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 17 Jan 2020 15:08:17 + Build duration: 1 min 34 sec and counting CONSOLE OUTPUT [...truncated 429

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

ngraham added a comment. The goal is to have a sane default size. This patch in its current state seems to do that, since setting a minimum width and height on `m_editor` doesn't actually prevent it from being resized to be smaller due to its sizePolicy. REPOSITORY R119 Plasma Desktop

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:81 > Edit, no it wasn't wrong > > But I have found what is. > > I export this as the class Baloo, but the import is also under Baloo > > So for this to work against my patch it would be Baloo.Baloo.Suspend

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

davidedmundson added a comment. > Is there a better way? Depends what the goal is. To set a minimum size or to change the default size. Commit title says one thing, comment says another. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26695 To: ngrah

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 73771. ngraham added a comment. Adjust to changes in D25743 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=73768&id=73771 BRANCH suspend-and-resume-and-monitor-ind

D25634: Add kconf update script for ksmserver

davidedmundson added a comment. > -1 I'd prefer if the config value was kept Beta is shipped and the value is not kept, so I'd still like this. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25634 To: davidedmundson, #plasma Cc: broulik, plasm

D26699: [widgetexplorer] Animate column moves

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3a6795548fd7: [widgetexplorer] Animate column moves (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26699?vs=73662&id=73770 REV

D26698: [widgetexplorer] Fix animate in animation

This revision was automatically updated to reflect the committed changes. Closed by commit R119:977665254990: [widgetexplorer] Fix animate in animation (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26698?vs=73661&id=73769

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 73768. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=71013&id=73768 BRANCH suspend-and-resume-and-monitor-indexing-from-the-kcm (branched from master) REVISION DETAIL

D26719: [Battery Monitor] Glow icon on hover

kmaterka updated this revision to Diff 73767. kmaterka added a comment. Apply to notification icon REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26719?vs=73766&id=73767 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26719 AFFECT

D26640: [applets/weather] Port weather station picker to QQC2+ListView

ngraham added a comment. Ping REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D26640 To: ngraham, #vdg, #plasma, broulik Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D26726: [Breeze Cursors] Add some more cursor names

davidedmundson added a comment. Semi relevant: https://bugs.kde.org/show_bug.cgi?id=395247 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26726 To: broulik, #vdg, ngraham Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampa

D26719: [Battery Monitor] Glow icon on hover

kmaterka updated this revision to Diff 73766. kmaterka added a comment. Separate component REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26719?vs=73739&id=73766 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26719 AFFECTED FILES

D26726: [Breeze Cursors] Add some more cursor names

broulik added a comment. > even though they're still "up for discussion." Yeah, and then I looked at the date ;) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26726 To: broulik, #vdg, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zach

D26725: make sure Solid::Battery is not deleted from QML

This revision was automatically updated to reflect the committed changes. Closed by commit R102:764fce4aefbe: make sure Solid::Battery is not deleted from QML (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26725?vs=73758&id=73764 REV

D26717: [App Style KCM] Use QtQuick NewStuff dialogs

yurchor added a comment. No objections to breaking string freeze from the Ukrainian team. REPOSITORY R119 Plasma Desktop BRANCH change-exec (branched from master) REVISION DETAIL https://phabricator.kde.org/D26717 To: gikari, broulik, ngraham Cc: yurchor, ngraham, plasma-devel, LeGast

D26717: [App Style KCM] Use QtQuick NewStuff dialogs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks good, and this should go on the `plasma/5.18` branch to make sure it gets into Plasma 5.18 so this KCM isn't the odd one out. However it contains new and changed strings so I ha

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

wjohnson added a comment. If you wish to play with login and lock screen stuff, go to Main Login /usr/share/sddm/themes/your-login-theme/main.qml Lock Screen Login Helps to know that breeze is the default Plasma lock screen theme. If a lock screen is not part of whatever th

D26720: Cache single image wallpapers locally

ngraham added a comment. Good point, I totally forgot to consider that. I have no idea how it works and will need to look into it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26720 To: ngraham, #plasma Cc: broulik, filipf, plasma-devel, LeGast00n, The-F

D26726: [Breeze Cursors] Add some more cursor names

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I suppose it doesn't hurt anything to add these even though they're still "up for discussion." REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26726 To: broulik,

D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results

ngraham added a comment. When set to false, it makes the label look less lighter without manually setting the opacity to some value that we'll often forget to be consistent on which would (and does) result in labels of opacity values varying between 0.3 and 0.6. I'm working on making a

D18006: Include only the largest size for the "Next" wallpaper

ngraham abandoned this revision. ngraham added a comment. All right, no problem! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D18006 To: ngraham, #vdg, #breeze, mart Cc: apol, davidedmundson, mart, filipf, kvermette, plasma-devel, LeGast00n, The-Feren-OS-Dev, jralei

D26726: [Breeze Cursors] Add some more cursor names

broulik created this revision. broulik added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY They are "up for discussion" [1] but seem to be used by e.g. Chrome. [1] https://www.freedesktop

D24751: installdbgsymbols_suse: Pass --plus-content debug to zypper

This revision was automatically updated to reflect the committed changes. Closed by commit R871:807d9dccab08: installdbgsymbols_suse: Pass --plus-content debug to zypper (authored by fvogt, committed by cgiboudeaux). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D26725: make sure Solid::Battery is not deleted from QML

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY Battery objects are casted DeviceInterface objects and those are owned by Solid. deleting them out

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

leinir updated this revision to Diff 73756. leinir added a comment. Rebase on master - Add the provider and service files (these use temp client data for now) - Actually install the service and provider files - Add functionality to open the accounts kcm on saveCredentials calls REPOSI

D26689: [MPRIS Data Engine] Refactor to reduce code duplication

broulik abandoned this revision. broulik added a comment. Incorporated in D26702 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26689 To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, z

D26330: [MPRIS Data Engine] Ignore players with CanControl false in multiplexer

broulik abandoned this revision. broulik added a comment. Superseded by D26702 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26330 To: broulik, #plasma Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zac

D26717: [App Style KCM] Port GTK GHNS dialogs from exec()

gikari updated this revision to Diff 73755. gikari added a comment. Port dialogs to QtQuick REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26717?vs=73738&id=73755 BRANCH change-exec (branched from master) REVISION DETAIL https://phabricator.kde

D26185: Fix font rendering when compiled against Qt >= 5.14

davidedmundson added a comment. Ack. Thanks for chasing up on indentifying causes. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma, apol, davidedmundson Cc: acooligan, fvogt, asturmlechner, dfaure, davidedmundson, anthonyfieroni,

D26705: KCM/Component Revamp Terminal Emulator UI

meven added inline comments. INLINE COMMENTS > componentchooserterminal.cpp:47 > +void CfgTerminalEmulator::selectTerminalEmulator(int index) { > +Q_UNUSED(index) > + remove REPOSITORY R119 Plasma Desktop BRANCH terminal-config REVISION DETAIL https://phabricator.kde.org/D26705 To:

D26714: KCM/Component Revamp FileManager UI

meven added inline comments. INLINE COMMENTS > componentchooserfilemanager.cpp:116 > + > +// add a other option to add a new file manager with keditfiletype5 > + > combofileManager->addItem(QIcon::fromTheme(QStringLiteral("application-x-shellscript")), > i18n("Other..."), QStringLiteral(

D18006: Include only the largest size for the "Next" wallpaper

filipf added a comment. In D18006#595782 , @ngraham wrote: > The whole point was to save some space on the user's machine. However trading space savings for load time maybe isn't the best trade-off? 18 MB isn't really all that much of a savings.

D26722: Load user information once on startup

This revision was automatically updated to reflect the committed changes. Closed by commit R133:08178c059fd3: Load user information once on startup (authored by fvogt). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26722?vs=73749&id=73751 REVISION DETA

D26705: KCM/Component Revamp Terminal Emulator UI

meven updated this revision to Diff 73750. meven added a comment. Clean two bad lines REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26705?vs=73718&id=73750 BRANCH terminal-config REVISION DETAIL https://phabricator.kde.org/D26705 AFFECTED FIL

D26722: Load user information once on startup

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Apparently the seccomp filter can break KUser in certain setups, so load the info before the sandbox is active. TEST PLAN Provided a test pa

[plasmashell] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 Konrad Materka changed: What|Removed |Added Component|general |Battery Monitor CC|

D26719: [Battery Monitor] Glow icon on hover

kmaterka added a comment. As proposed by @broulik in Bug 416310 it might be a good idea to create IconEffects.qml (or IconEffect.qml?). Ideally, it should have a feature parity with KIconEffect. Any recommendations? Where to put this component (

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 92 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/92/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 17 Jan 2020 08:47:50 + Build duration: 58 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 244 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/244/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 17 Jan 2020 08:46:37 + Build duration: 1 min 52 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 91 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/91/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 17 Jan 2020 08:46:22 + Build duration: 29 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 243 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/243/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 17 Jan 2020 08:45:33 + Build duration: 1 min 2 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 90 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/90/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 17 Jan 2020 08:45:33 + Build duration: 37 sec and counting CONSOLE OUTPUT

D26705: KCM/Component Revamp Terminal Emulator UI

meven added inline comments. INLINE COMMENTS > componentchooserterminal.cpp:138 > +changed(index != m_currentIndex); > +m_currentIndex = terminalCombo->currentIndex(); > +} else { Remove > componentchooserterminal.cpp:143 > +terminalCombo->setCurrentIndex(terminalCom

D26565: KCM/Component Revamp email config

meven updated this revision to Diff 73747. meven marked an inline comment as done. meven added a comment. Remove a bad line REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26565?vs=73695&id=73747 BRANCH email-config REVISION DETAIL https://phabr

D26565: KCM/Component Revamp email config

meven added inline comments. INLINE COMMENTS > componentchooseremail.cpp:144 > +// select newly inserted email client > +m_currentIndex = emailClientsCombo->count() - 2; > +emailClientsCombo->setCurrentIndex(m_currentIndex); remove REPOSITORY R119 Plasma De

D26714: KCM/Component Revamp FileManager UI

meven updated this revision to Diff 73746. meven added a comment. Use KOpenWithDialog instead of keditfiletype5 to select the filemanager + small fix REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26714?vs=73731&id=73746 BRANCH filemanager-settin

D26185: Fix font rendering when compiled against Qt >= 5.14

fvogt added a comment. The change itself is correct, but not in relation to the title and summary which are about https://bugreports.qt.io/browse/QTBUG-80967, which was a genuine bug in Qt, fixed in 5.14.1. What this change fixes is double scaling in applications which enable `Qt::AA_Enabl

D24706: [RFC] Change button style

cfeck added a comment. If application developers need a rotated button, they need to rotate only the contents, not the frame. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: cfeck, The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plas

D26714: KCM/Component Revamp FileManager UI

meven planned changes to this revision. meven added a comment. In D26714#595786 , @ngraham wrote: > Selecting the "Other..." option for this one takes me to the filetype editor for `inode/directory` instead of the app chooser as in the other pat