D26312: [applets/digital-clock] Fix truncated Long Date display in a vertical panel

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Actually, this does have some negative effects on the appearance. before: F7857082: Screenshot_20200103_015814.PNG after: F7857084:

D26312: [applets/digital-clock] Fix truncated Long Date display in a vertical panel

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. This works for me. Is it possible to enforce a minimum font size? REPOSITORY R120 Plasma Workspace BRANCH fix-clock-long-date-in-vertical-panel (branched from master) REVISION DETAIL

D26379: [KCMs/Notifications] Tweak layout and strings to have a bit more visual grouping for the logical sections

ndavis added a comment. In D26379#586767 , @ngraham wrote: > Would it make more sense if it was like this? > > Popup: (o) Show near notification icon > ( ) [Choose custom Position...] > Hide after: [5 seconds ^v] >

D26379: [KCMs/Notifications] Tweak layout and strings to have a bit more visual grouping for the logical sections

ngraham added a comment. Would it make more sense if it was like this? Popup: (o) Show near notification icon ( ) [Choose custom Position...] Hide after: [5 seconds ^v] REPOSITORY R119 Plasma Desktop BRANCH section-grouping-in-notifications-kcm (branched from

D26379: [KCMs/Notifications] Tweak layout and strings to have a bit more visual grouping for the logical sections

ndavis added a comment. Within that context, I see why it makes sense to indent "Toggle with", but I still don't think it makes sense to indent "Hide after"/"Hide popup after". The label above is "Popup position" and "Hide popup after" is not at all related to the popup position. REPOSITORY

D26379: [KCMs/Notifications] Tweak layout and strings to have a bit more visual grouping for the logical sections

ngraham added a comment. The indentation here was done to be consistent with the other one, but the reason why they're indented is to make it clear that they're a part of the logical group of controls that's "introduced" by the first left label in the formlayout section. Ideally every sectio

D26379: [KCMs/Notifications] Tweak layout and strings to have a bit more visual grouping for the logical sections

ndavis added a comment. Is it intentional that "Hide after" is aligned with the checkboxes above? I'm not convinced this part is an improvement. Same with the indented "Toggle with" although that was there to begin with. +1 to the rest of these changes. REPOSITORY R119 Plasma Desktop

D26378: [Download Plugin] Register downloaded files as recent documents

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense to me conceptually. Speaking personally, I would benefit from this as I often want to immediately do something with a file I just downloaded. Often the notification pop-up suf

D26378: [Download Plugin] Register downloaded files as recent documents

broulik added a comment. Should it purge the entry from kactivities stats when you manually remove the download from the download list in the browser? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D26378 To: broulik, #plasma, hein, #vdg, fvogt Cc

D26379: [KCMs/Notifications] Tweak layout and strings to have a bit more visual grouping for the logical sections

broulik added a comment. > by disabling the display of critical notifications. It doesn't disable them. Merely keeps them behind full screen windows. I think the option is fine as it is. (You know, if we had some kuserfeedback data to prove that nobody disables this option... :p) REPOSI

D26379: [KCMs/Notifications] Add a bit of grouping for the logical sections

ngraham added a comment. Also while looking at this, I started to think the checkbox for critical notifications maybe doesn't even need to exist. We probably shouldn't make it easy to shoot yourself in the foot by disabling the display of critical notifications. They're critical for a reason

D26379: [KCMs/Notifications] Add a bit of grouping for the logical sections

ngraham created this revision. ngraham added reviewers: broulik, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. TEST PLAN F7856427: grouping.png REPOSITORY R119 Plasma Desk

D26378: [Download Plugin] Register downloaded files as recent documents

broulik updated this revision to Diff 72656. broulik added a comment. - Ignore incognito downloads REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26378?vs=72655&id=72656 REVISION DETAIL https://phabricator.kde.org/D26378 AFFECTED FILE

D26378: [Download Plugin] Register downloaded files as recent documents

broulik created this revision. broulik added reviewers: Plasma, hein, VDG, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes them more easily accessible throughout the shell. TEST PLAN I'm a bit to

D26121: Kicker/RecentDocument display file path as decoration

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9099652598fa: Kicker/RecentDocument display file path as decoration (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26121?vs=71950&id=7

D26147: Kickoff computer tab : don't display filepath for places in description

This revision was automatically updated to reflect the committed changes. Closed by commit R120:861e465951a0: Kickoff computer tab : don't display filepath for places in description (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D26375: Respect GTK2_RC_FILES environmental variable

This revision was automatically updated to reflect the committed changes. Closed by commit R99:5734413d8105: Respect GTK2_RC_FILES environmental variable (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26375?vs=72646&id=7

D26375: Respect GTK2_RC_FILES environmental variable

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY If the above variable is set and it does not contain multiple paths, write GTK2 config into the designated config file, instead of t

D26147: Kickoff computer tab : don't display filepath for places in description

meven added a comment. ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26147 To: meven, ngraham, #plasma, #vdg, hein Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himces

D26363: [KCM/Activities] Clean unused code

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bd05813d8784: [KCM/Activities] Clean unused code (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26363?vs=72609&id=72621 REVISION DETAIL

D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).

ouwerkerk abandoned this revision. ouwerkerk added a comment. Cleanup. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D24193 To: ouwerkerk, mart, #plasma, ngraham Cc: ngraham, anthonyfieroni, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, d

D26344: Fix building plasma-desktop without X11 cursor development headers

ouwerkerk abandoned this revision. ouwerkerk added a comment. Superseded by: https://phabricator.kde.org/D26367 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26344 To: ouwerkerk, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-

D26367: Make the lookandfeel KCM build without XCursor support

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1c43e1b4f7b1: Make the lookandfeel KCM build without XCursor support (authored by ouwerkerk). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26367?vs=72617&i

D26367: Make the lookandfeel KCM build without XCursor support

ouwerkerk created this revision. ouwerkerk added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ouwerkerk requested review of this revision. REVISION SUMMARY With this change the lookandfeel KCM can be built without X11 cursor development he

D26363: [KCM/Activities] Clean unused code

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26363 AFFECTED FIL

D25374: [ResultDelegate] Fix bad text legiblity with certain 3rd party themes

This revision was automatically updated to reflect the committed changes. Closed by commit R112:33f31fb79ff2: [ResultDelegate] Fix bad text legiblity with certain 3rd party themes (authored by filipf). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25374?vs=6994

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

kkoma added a comment. In D18078#398771 , @filipf wrote: > In D18078#398570 , @ngraham wrote: > > > Where are we with replacing one of those flower images with another one? > > > We could add o

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #45 from Alexander Fieroch --- Created attachment 124844 --> https://bugs.kde.org/attachment.cgi?id=124844&action=edit no battery widget shows battery vendor LGC and model number as well as serial number but 0% for battery load in task b

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #44 from Alexander Fieroch --- Created attachment 124843 --> https://bugs.kde.org/attachment.cgi?id=124843&action=edit battery is detected detected battery and no battery detected switches in minutes -- You are receiving this mail beca

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fd4fd031eb6b: [KCM/Component] filemanager: make dolphin the default filemananger (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26324?vs