D26267: Replace deprecated QWeakPointer::data() with .toStrongRef().data()

ndavis created this revision. ndavis added reviewers: Breeze, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY As stated in https://doc.qt.io/qt-5/qweakpointer-obsolete.html : QWeakPointer::data() "Retur

D26261: Rewrite GTK KCM

baberts added a comment. In D26261#584039 , @gikari wrote: > In D26261#584037 , @ngraham wrote: > > > Everything that's left here could easily fit into a popup on that KCM, or we could use the multi

D26266: Change remove action's icon to "edit-delete"

trmdi created this revision. trmdi added reviewers: Latte Dock, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Follow Plasma codes https://github.com/KDE/plasma-framework/blob/ccceb83b107213ba5d2077fc346d

D25889: Polish the "review this review" UI and presentation

ndavis added a comment. Review summary area: F7847927: discover-review_summary_area.svg.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D25889 To: ngraham, #vdg, apol, #discover_software_store Cc: ndavis, pla

D25889: Polish the "review this review" UI and presentation

ngraham updated this revision to Diff 72312. ngraham added a comment. Rebase REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25889?vs=71290&id=72312 BRANCH polish-review-reviewing (branched from master) REVISION DETAIL https://phabricat

D25889: Polish the "review this review" UI and presentation

ndavis added a comment. In D25889#584040 , @apol wrote: > I'm not convinced about using emoji in place of icons. Are we sure about that? > > I like ndavis's suggestion, but as a delegate, having so many lines could look cluttered. > > Sh

D26264: Add record keystrokes feature to the hotkeys KCM module

martonmiklos created this revision. martonmiklos added reviewers: mlaurent, lunakl, jriddell. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. martonmiklos requested review of this revision. REVISION SUMMARY To add a keystroke sending shortcut to KDE the user had to under

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. In D26185#583991 , @anthonyfieroni wrote: > Can forcing bigger font DPI make things better? AFAICS no. If scaling is conceptually enabled, i.e. if an application //would// be scaled //if// you attached a high D

D25889: Polish the "review this review" UI and presentation

apol added a comment. I'm not convinced about using emoji in place of icons. Are we sure about that? I like ndavis's suggestion, but as a delegate, having so many lines could look cluttered. Should we consider using cards? REPOSITORY R134 Discover Software Store REVISION DETAIL

D26261: Rewrite GTK KCM

gikari added a comment. In D26261#584037 , @ngraham wrote: > Everything that's left here could easily fit into a popup on that KCM, or we could use the multi-page KCM system to put all of this stuff on a sub-page on that KCM. By the way,

D26261: Rewrite GTK KCM

ngraham added a comment. Nice work, but I think we should shoot for moving the remaining (small) functionality into the Application Style KCM for Plasma 5.18. Everything that's left here could easily fit into a popup on that KCM, or we could use the multi-page KCM system to put all of this s

D26256: [WIP][Applet] Make 'raise maximum volume' global

gvgeo added a comment. Actually I never touch volume control, so don't have strong opinion. Either way I'm good, no worries. But in general believe, that should simplify UI and usability, while trying to keep features. This patch removes 2 options. While the other could have the mock

D26261: Rewrite GTK KCM

gikari created this revision. gikari added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY After several changes, GTK Applications settings are now in sync with KDE equivalent ones, so that GT

D26185: Fix font rendering when compiled against Qt >= 5.14

anthonyfieroni added a comment. Can forcing bigger font DPI make things better? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma, apol, davidedmundson Cc: asturmlechner, dfaure, davidedmundson, anthonyfieroni, plasma-devel, LeGas

D26256: [WIP][Applet] Make 'raise maximum volume' global

ngraham added reviewers: VDG, Plasma, drosca. ngraham added a subscriber: drosca. ngraham added a comment. Thanks for this patch. I won't try to make you go forward with something you don't agree with, so let's continue the discussion here and hopefully we can reach a consensus of some sort.

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. It's probably okay to still say that scaling is enabled "in general" but for scaling <2, and why not, maybe even greater, hinting should not be inhibited. The screen is still made of pixels. Qt is not going to be able to throw out all the hinting and subpixel code

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

ngraham added a comment. Heh, you asked for it! :) T12441: Consider using a vertical Icons-Only Task Manager populated with apps by default REPOSITORY R119 Plasma Desktop BRANCH some-apps-by-default (branched from master) REVISION DETAIL https

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. I think I see the problem. You pay for the //possibility// to have scaling with unhinted fonts. I am pretty sure that that isn't an acceptable way of handling it. Most Linux desktop fonts are intended to be used with some hinting (slight hinting usually?). QHighDpi

D26147: Kickoff computer tab : don't display filepath for places in description

meven added a comment. ping @hein REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26147 To: meven, ngraham, #plasma, #vdg, hein Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D26256: [WIP][Applet] Make 'raise maximum volume' global

gvgeo updated this revision to Diff 72295. gvgeo added a comment. Fixed shortcut keys. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26256?vs=72293&id=72295 BRANCH global (branched from master) REVISION DETAIL https://phabricator.k

D26256: [WIP][Applet] Make 'raise maximum volume' global

gvgeo added a comment. Have a problem that marked with a TODO comment in code, but the desired functionality is working. @ngraham I should mention that I still oppose to the functionality of this patch, and I believe the better way is D26234 that maybe

D26256: [WIP][Applet] Make 'raise maximum volume' global

gvgeo created this revision. gvgeo added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Remove maximum volume control from configuration. Remove individual maximum volume. Add a checkbox

D26225: Change frameRadius to use pen widths, add newPenWidthFrameRadius, add PenWidth::NoPen

ndavis updated this revision to Diff 72281. ndavis added a comment. - Change newPenWidthFrameRadius to frameRadiusNewPenWidth This sounds slightly better to me and allows it to show up next to frameRadius when autocompleting. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://p