D26111: KRunner add a recentlyused runner accessing KActivityStats data

2019-12-19 Thread Méven Car
meven updated this revision to Diff 71865. meven added a comment. Better Name in json REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26111?vs=71858&id=71865 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26111 AFFECTED FILES CM

KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 2 - Still Failing!

2019-12-19 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/2/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Dec 2019 06:43:19 + Build duration: 22 min and counting CONSOLE OUTPUT [...t

KDE CI: Plasma » plasma-phone-components » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Failing!

2019-12-19 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20SUSEQt5.12/2/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 20 Dec 2019 06:43:19 + Build duration: 13 min and counting CONSOLE OUTPUT [...truncat

D26111: KRunner add a recentlyused runner accessing KActivityStats data

2019-12-19 Thread Méven Car
meven added a comment. Two points raised by @broulik but not resolved : - should display a specific icon based on file mimetype ? - should we allow to open a folder's parent folder through an action I am in favor of keeping those two behaviors, but I would welcome other constructiv

D26111: KRunner add a recentlyused runner accessing KActivityStats data

2019-12-19 Thread Méven Car
meven updated this revision to Diff 71858. meven marked 5 inline comments as done. meven added a comment. address review REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26111?vs=71857&id=71858 BRANCH master REVISION DETAIL https://phabricator.

D26111: KRunner add a recentlyused runner accessing KActivityStats data

2019-12-19 Thread Kai Uwe Broulik
broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Why not change the recentdocuments runner? We have various places where we whitelist recentdocuments as a runner and if a user disabled it, this would not be carried over withou

D26111: KRunner add a recentlyused runner accessing KActivityStats data

2019-12-19 Thread Méven Car
meven added a comment. I am planning to remove recentdocument later. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBo

D26111: KRunner add a recentlyused runner accessing KActivityStats data

2019-12-19 Thread Méven Car
meven created this revision. meven added reviewers: Plasma, ivan, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY It is much more versatile over the current recentdocument runner : - It is activity a

D26093: Use a fixed icon size for the notification popup close button

2019-12-19 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. Closed by commit R120:66aaaf72a4df: Use a fixed icon size for the notification popup close button (authored by ahiemstra). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26093?v

D26094: Add shadow rendering helper functions

2019-12-19 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R31:4a78561a3ae6: Add shadow rendering helper functions (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26094?vs=71845&id=71846 REVISION DETAIL htt

D26094: Add shadow rendering helper functions

2019-12-19 Thread Noah Davis
ndavis updated this revision to Diff 71845. ndavis added a comment. Update ellipse shadow comment again and rounded rect shadow parameter name REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26094?vs=71825&id=71845 BRANCH replace-hardcoded (branched from ma

D25874: [Task Manager] Consider parent PID for audio stream

2019-12-19 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:09a258a22ed4: [Task Manager] Consider parent PID for audio stream (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25874?vs=71251&id=718

D26094: Add shadow rendering helper functions

2019-12-19 Thread Hugo Pereira Da Costa
hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Looks good and sensible. Very nice consolidation. Thanks ! REPOSITORY R31 Breeze BRANCH replace-hardcoded (branched from master) REVISION DETAIL https://phabricator

D24070: Don't use toolTipMainText to show info, rather use the second line

2019-12-19 Thread Nathaniel Graham
ngraham added a comment. Oh you know me, I'll be doing KDE stuff on Christmas eve. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, ndavis Cc: GB_2, ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleig

D25780: [Notifications] Set total amount to processed amount if no total and no error

2019-12-19 Thread Kai Uwe Broulik
broulik abandoned this revision. broulik added a comment. Given the trash issue and the fact that fixing KDE Connect was easy, let's abandon this: https://invent.kde.org/kde/kdeconnect-kde/merge_requests/188/diffs REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.o

D24070: Don't use toolTipMainText to show info, rather use the second line

2019-12-19 Thread Matej Mrenica
mthw added a comment. @ngraham could you please look at this? I would say it's finished and there isn't much time left until the next freeze. I also don't expect you to do this during the holidays, so it would be nice to have it finished, before them. I am sorry for being impatient. REPOSIT

D26094: Add shadow rendering helper functions

2019-12-19 Thread Nathaniel Graham
ngraham added a comment. Very nice! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26094 To: ndavis, #breeze, hpereiradacosta, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf,

D25851: [Notifications] Add quick reply feature

2019-12-19 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > notification.cpp:637 > > +if (!d->hasReplyAction && name == QLatin1String("reply")) { > +d->hasReplyAction = true; I'll change that to "inline-reply" to avoid potential clashes > server_p.cpp:234 > QStringLiteral("a

D26104: Add KIOFuse to mapping

2019-12-19 Thread Alexander Saoutkin
feverfew created this revision. feverfew added a reviewer: fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. feverfew requested review of this revision. REVISION SUMMARY Adds the KIOFuse binary to the mapping for bug reporting. TEST PLAN None REPOSITORY R871 D

D26088: [XembedSNIProxy] Regression - really resize instead of notifying only.

2019-12-19 Thread Konrad Materka
This revision was automatically updated to reflect the committed changes. Closed by commit R120:21a89dd6e1ae: [XembedSNIProxy] Regression - really resize instead of notifying only. (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D26078: Ship plasma-logo in repo

2019-12-19 Thread David Redondo
davidre added a comment. In D26078#579676 , @ngraham wrote: > +1 for the concept, but will this implementation work for users? Should we maybe use the QRC mechanism instead? This should work for the users. Qt.resolvedUrl will return a url

D25915: Don't set a new palette if the application has a custom color scheme set

2019-12-19 Thread David Redondo
davidre added a comment. Ping REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D25915 To: davidre, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himc

D14949: Add option for whether to show the volume change OSD

2019-12-19 Thread Roman Gilg
romangg added a comment. In D14949#580117 , @alexde wrote: > Additional there could be a radiobutton > > - Display none in full screen apps How about "Display compact version in full screen apps". And then make this behavior the defau

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

2019-12-19 Thread Méven Car
meven created this revision. meven added reviewers: crossi, Plasma, ngraham, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN kcmshell5 componentchooser REPOSITORY R119 Plasma Desktop BRANCH component-browser

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 332 - Still unstable!

2019-12-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/332/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Dec 2019 11:10:28 + Build duration: 4 min 49 sec and counting JUnit Tests Name:

D26088: [XembedSNIProxy] Regression - really resize instead of notifying only.

2019-12-19 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kmaterka wrote in sniproxy.cpp:228 > xcb_configure_notify_event_t > > @davidedmundson In this commit >

D14949: Add option for whether to show the volume change OSD

2019-12-19 Thread Alex Debus
alexde added a comment. Personally I am in favour of the current Windows 10 style, a compact version in the top left corner. I tried to to create a mockup to demonstrate how it could look like: F7825127: Mockup.png To make hopefully everyone happy