D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

2019-12-08 Thread Aleix Pol Gonzalez
apol added a comment. Plasma master can depend on kf5 master. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH prov REVISION DETAIL https://phabricator.kde.org/D25701 To: nicolasfella, #plasma, #frameworks, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D11748: Assign notification area category

2019-12-08 Thread Nathaniel Graham
ngraham closed this revision. ngraham added a comment. Thanks! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11748 To: wsdfhjxc, #plasma, ngraham Cc: apol, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Z

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

2019-12-08 Thread Nicolas Fella
nicolasfella added a comment. Can Plasma depend on Frameworks master or does this have to wait until 5.66 release? REPOSITORY R135 Integration for Qt applications in Plasma BRANCH prov REVISION DETAIL https://phabricator.kde.org/D25701 To: nicolasfella, #plasma, #frameworks, apol Cc:

D25580: [System Tray] Unified data model for System Tray items

2019-12-08 Thread Nicolas Fella
nicolasfella added a comment. Looks very good in general. A few style nitpicks INLINE COMMENTS > ConfigEntries.qml:68 > var list = []; > -for (var i = 0; i < statusNotifierModel.count; ++i) { > -var item = statusNotifierModel.get(i); > -list.push({ > -

D11748: Assign notification area category

2019-12-08 Thread Aleix Pol Gonzalez
apol added a comment. Already landed https://cgit.kde.org/kdeplasma-addons.git/commit/?id=d744370117bef4384bbd0e92fbcee4805169acaa REPOSITORY R134 Discover Software Store BRANCH patch-1 REVISION DETAIL https://phabricator.kde.org/D11748 To: wsdfhjxc, #plasma, ngraham Cc: apol, ngra

D24947: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

2019-12-08 Thread Méven Car
meven added a comment. Somewhat depends on D25089 and D25088 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24947 To: meven, fvogt, apol, #plasma Cc: ngraham, plasma

D25806: [Cuttlefish] Make it clear that picker mode still works

2019-12-08 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R118:5f9d11836097: [Cuttlefish] Make it clear that picker mode still works (authored by davidre). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25806?vs=71073&id=710

D25807: Allow to set the available screen rect/region from outside through dbus

2019-12-08 Thread Tranter Madi
trmdi updated this revision to Diff 71079. trmdi added a comment. - Fix typo REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71077&id=71079 BRANCH add-otherShellHelper REVISION DETAIL https://phabricator.kde.org/D25807 AFFECTED FILES

D25807: Allow to set the available screen rect/region from outside through dbus

2019-12-08 Thread Michail Vourlakos
mvourlakos added a comment. @trmdi this is a big change so it needs first to be approved theoretically from main plasma devs INLINE COMMENTS > shellcorona.cpp:1046 > > QRegion ShellCorona::availableScreenRegion(int id) const > +if > (!m_otherShellHelper->availableScreenRegion(static_cast

D25736: Make it compile without deprecated method

2019-12-08 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R115:c38b6a9f2953: Make it compile without deprecated method (authored by mlaurent). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25736?vs=70896&id=

D25807: Allow to set the available screen rect/region from outside through dbus

2019-12-08 Thread Tranter Madi
trmdi created this revision. trmdi added reviewers: Plasma, mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Allow to set the available screen rect/region from outside through dbus. REPOSITORY R120 P