D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added inline comments. INLINE COMMENTS > main.qml:93 > +// FIXME: this doesn't work; it's always invisible > +visible: (monitor.State == Baloo.Baloo.FirstRun || > +monitor.State == Baloo.Baloo.NewFiles || Monitor's proper

D22684: [Klipper] Fix clipboard history management

pdabrowski added a comment. Is this OK now? I think the privacy issue caused by that reported regression (#409366) should really be fixed, one way or another. Most people are probably totally unaware their clipboard still contains the last content after they command it to be cleared...

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

ognarb added inline comments. INLINE COMMENTS > main.qml:46 > titleIcon: "preferences-desktop-theme" > +modal: true; > +collapsible: false; This sadly didn't work :( REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D25778 To: ognarb, #vdg, #p

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY I wasn't able to convert the conbox box :( I'm getting a strange error TEST PLAN Screenshot comming REPOSITORY R118 Plasma

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham added a comment. Thanks @davidedmundson. There's one more `FIXME` in the code that I could use your help with, if you don't mind. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson Cc: david

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 70998. ngraham marked 2 inline comments as done. ngraham added a comment. Adjust to D25743 some more REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=70990&id=70998 BR

D11748: Assign notification area category

ngraham added a comment. You can see the name at https://cgit.kde.org/plasma-desktop.git/commit/?id=1db79dc54c464d159d4ff8e8c91452758c9aa220 REPOSITORY R134 Discover Software Store BRANCH patch-1 REVISION DETAIL https://phabricator.kde.org/D11748 To: wsdfhjxc, #plasma, ngraham Cc: ap

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:81 > This is the wrong way round Edit, no it wasn't wrong But I have found what is. I export this as the class Baloo, but the import is also under Baloo So for this to work against my patch it would be Ba

D11748: Assign notification area category

apol added a comment. Yes, I'd say so. wsdfhjxc, can you please give us your name to properly track the copyright of the line? REPOSITORY R134 Discover Software Store BRANCH patch-1 REVISION DETAIL https://phabricator.kde.org/D11748 To: wsdfhjxc, #plasma, ngraham Cc: apol, ngrah

D20222: Plasma-Workspace. The last checkbox in the widget settings

davidedmundson closed this revision. davidedmundson added a comment. https://commits.kde.org/plasma-workspace/eb6f6c2566622b883ca43138f8adee3c29f1f3fa REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20222 To: pavelmos, broulik, #plasma, davidre, ngraham, da

D25777: Avoid deprecated method

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Does the same thing REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.or

D20222: Plasma-Workspace. The last checkbox in the widget settings

davidedmundson added a comment. If it's just a rebase needed, I'll land it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20222 To: pavelmos, broulik, #plasma, davidre, ngraham, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D20222: Plasma-Workspace. The last checkbox in the widget settings

ngraham added a comment. @pavelmos would you like to continue working on this or should someone else take it over? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20222 To: pavelmos, broulik, #plasma, davidre, ngraham, davidedmundson Cc: davidedmundson, pla

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

broulik added a comment. 1. Windows has those entries by default and they probably know what they're doing 2. It introduces the user to the fact that you can actually pin apps to the task bar REPOSITORY R119 Plasma Desktop BRANCH some-apps-by-default (branched from master) REVISION D

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

ngraham added a comment. @siddharthasahu would you like to continue working on this? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21192 To: siddharthasahu, ngraham, #plasma, #vdg Cc: filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jral

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

ngraham added a comment. I guess it depends on whether you see pinned apps as clutter. Personally, I think these are useful, especially for less experienced users. And we have anecdotal evidence that experienced users (e.g. us) add these to their task managers manually. So I don't think this

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

hein added a comment. I don't really understand why the panel being bare by default is a problem. Isn't it nicer when users don't have to opt out of clutter like this? REPOSITORY R119 Plasma Desktop BRANCH some-apps-by-default (branched from master) REVISION DETAIL https://phabricator

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added inline comments. INLINE COMMENTS > main.qml:81 > +id: toggleButton > +text: monitor.state == Baloo.Suspended ? i18n("Resume") : > i18n("Suspend") > +onClicked: monitor.toggleSuspendState() This is the wrong way round REPOSITO

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 70990. ngraham added a comment. Update to work with D25743 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=70904&id=70990 BRANCH suspend-and-resume-and-monitor-inde

D12851: Change preview text background color to match with default combobox background color

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, this doesn't look so great all on its own: F7801317: Screenshot_20191205_143423.png I think the graphical representations of

D5346: DigitalClock: Use correct language for month and day names

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Marking as request changes to get it out my queue, as I think it needs more discussion after my comment above I could be maybe persuaded, but adding a bad hack

D5346: DigitalClock: Use correct language for month and day names

davidedmundson added a comment. The thing this fixes is there. It's arguably a tiny bit less relevant as people might now use a custom date format in just the digital clock, instead of choosing a different locale for times. FWIW, I submitted a change that did exactly this at the "co

D25772: [Notifications] Add ServerInfo class

broulik added inline comments. INLINE COMMENTS > server_p.cpp:93 > if (!master) { > -connect(dbusIface, &QDBusConnectionInterface::serviceUnregistered, > this, [=](const QString &serviceName) { > -if (serviceName == notificationService) { > -qCDebug(NOTIF

D11750: Assign notification area category for Keyboard indicator

This revision was automatically updated to reflect the committed changes. Closed by commit R114:d744370117be: Assign notification area category for Keyboard indicator (authored by wsdfhjxc, committed by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde

D11748: Assign notification area category

ngraham added a subscriber: apol. ngraham added a comment. @apol does this still make sense to do in `org.kde.discover.notifier.desktop.cmake`? REPOSITORY R134 Discover Software Store BRANCH patch-1 REVISION DETAIL https://phabricator.kde.org/D11748 To: wsdfhjxc, #plasma, ngraham Cc:

D11749: Assign notification area category for Touchpad indicator

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1db79dc54c46: Assign notification area category for Touchpad indicator (authored by wsdfhjxc, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kd

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

ngraham added a comment. @vpilo to move this forward, maybe just remove the header/title in the menu entirely. It's not really necessary after all. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18504 To: vpilo, #vdg, jgrulich Cc: mart, Cod

D19947: systray: show a small animation on the icons when activated

ngraham added a comment. @apol Ping! REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D19947_1 REVISION DETAIL https://phabricator.kde.org/D19947 To: apol, #plasma, ngraham Cc: filipf, broulik, anthonyfieroni, davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jralei

D5346: DigitalClock: Use correct language for month and day names

ngraham added a comment. Is this still relevant? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D5346 To: drosca, #plasma, mck182 Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexey

D25462: [Colors KCM] Use Kirigami.SearchField

broulik planned changes to this revision. broulik added a comment. I'd prefer if the translation were fixed, but I can override `placeholderText` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25462 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, aspotashev,

D24940: [Applet] Show more information in the Details tab

This revision was automatically updated to reflect the committed changes. Closed by commit R116:0b3ae9737cc8: [Applet] Show more information in the Details tab (authored by mibofra, committed by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phab

D25462: [Colors KCM] Use Kirigami.SearchField

ngraham added a comment. @broulik ping! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25462 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, aspotashev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, hi

D24940: Enchanting/Showing more informations on the info section of plasma-nm plasmoid

mibofra added a comment. In D24940#572830 , @ngraham wrote: > @mibofra sorry this got lost. Can you provide your email address so we can land the patch with correct authorship information? Sure, mibo...@parrotsec.org REPOSITORY R116 Pl

D15888: new icons (Breeze style)

ngraham added a comment. @zren can you merge this if it's still relevant and useful? REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D15888 To: borisg, martinkostolny, #plasma, #vdg, broulik, ngraham Cc: Zren, IlyaBizyaev, ngraham, plas

D13175: List the Activity Pager also as an alternative to e.g. the Activity Bar

ngraham added a comment. Can this land? REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D13175 To: hein, broulik, mart Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf,

D24947: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

ngraham added a comment. What's the status of this patch? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24947 To: meven, fvogt, apol, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Z

D24940: Enchanting/Showing more informations on the info section of plasma-nm plasmoid

ngraham added a comment. @mibofra sorry this got lost. Can you provide your email address so we can land the patch with correct authorship information? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24940 To: mibofra, jgrulich Cc: ngraham,

D13243: [applet] Add checkbox to show virtual streams

ngraham added a comment. @sefaeyeoglu what do you think about the above? ^^ REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D13243 REVISION DETAIL https://phabricator.kde.org/D13243 To: sefaeyeoglu, #plasma, drosca, #vdg, ngraham Cc: baberts, davidedmundson, ngraham, plasma

D6056: [Run Command] Auto-close on focus loss only if query field is empty

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Actually I see a problem with this now that I try it out again: if you switch away from Krunner while it's still open with input and then trigger it again, a second one opens!

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

broulik updated this revision to Diff 70981. broulik added a comment. - Use `NotificationManager.ServerInfo` from D25772 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25097?vs=69123&id=70981 REVISION DETAIL h

D25761: Fix margins of ToolBarHeader

This revision was automatically updated to reflect the committed changes. Closed by commit R169:277fc7222021: Fix margins of ToolBarHeader (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25761?vs=70950&id=70979 REVISION DETAIL https

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

ndavis added a comment. I personally prefer file manager, web browser for the order. REPOSITORY R119 Plasma Desktop BRANCH some-apps-by-default (branched from master) REVISION DETAIL https://phabricator.kde.org/D25773 To: ngraham, #plasma, broulik, #vdg, hein, filipf, ndavis Cc: filip

D25761: Fix margins of ToolBarHeader

ngraham added a comment. Would be good to land this before tagging in 2 days. REPOSITORY R169 Kirigami BRANCH headermargins REVISION DETAIL https://phabricator.kde.org/D25761 To: ahiemstra, #kirigami, ngraham Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, a

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. +1 from me as well for the reasons listed in the commit message REPOSITORY R119 Plasma Desktop BRANCH some-apps-by-default (branched from master) REVISION DETAIL https://phabricator.

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

broulik added a comment. +1! I remember seeing this in Plasma 4 times and also always pin those two on my setup. Windows has browser first, then file manager. I don't really mind either order, though. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25773 T

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

ngraham created this revision. ngraham added reviewers: Plasma, broulik, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The default panel is quite bare and does not do an amazing job of exposing the fact

D25772: [Notifications] Add ServerInfo class

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It can be used to query information about the current notification server (vendor, name, version,

D25751: [Notifications] Split draggable thumbnail area into its own component

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d1d9a2c7b37f: [Notifications] Split draggable thumbnail area into its own component (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

This revision was automatically updated to reflect the committed changes. Closed by commit R124:64fb5eb98eb8: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs (authored by filipf). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D25751: [Notifications] Split draggable thumbnail area into its own component

ngraham added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25751 To: broulik, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jen

D25761: Fix margins of ToolBarHeader

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R169 Kirigami BRANCH headermargins REVISION DETAIL https://phabricator.kde.org/D25761 To: ahiemstra, #kirigami, ngraham Cc: ngraham, plasma-devel, fbampaloukas,

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

ngraham added a comment. Go ahead! REPOSITORY R124 System Settings BRANCH no-double-titles (branched from master) REVISION DETAIL https://phabricator.kde.org/D25726 To: filipf, #plasma, davidedmundson, ngraham Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jr

D25637: Port away from kglobalsettings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e50eafbf7fe2: Port away from kglobalsettings (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25637?vs=70632&id=70963 REVISION D

D24866: Wired setting: improve handling of link negotiation

jgrulich marked an inline comment as done. jgrulich added inline comments. INLINE COMMENTS > davidedmundson wrote in wiredconnectionwidget.cpp:79 > can loadConfig can be called multiple times? > > If so we need an explicit > > else { >setCurrentIndex(LinkNegotiation::Ignore); > } No, i

D24866: Wired setting: improve handling of link negotiation

This revision was automatically updated to reflect the committed changes. jgrulich marked an inline comment as done. Closed by commit R116:8b9eb87388cc: Wired setting: improve handling of link negotiation (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LA

D24866: Wired setting: improve handling of link negotiation

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > wiredconnectionwidget.cpp:79 > +m_widget->linkNegotiation->setCurrentIndex(LinkNegotiation::Manual); > +} > can loadConfig can be called m

D25760: Unset X-Plasma-MainScript for wallpaper plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R114:e60c22ff27c6: Unset X-Plasma-MainScript for wallpaper plugins (authored by zzag). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25760?vs=70949&id=70956 REVI

D25762: Don't bother serializing window icon pixmap for known services

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY A service usually has a proper icon somewhere on disk. `QIcon::name()` only works with them

D25759: Do not crash when icon's source is empty

This revision was automatically updated to reflect the committed changes. Closed by commit R169:a85e5f354c9c: Do not crash when icon's source is empty (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25759?vs=70947&id=70952 REVISION DE

D24866: Wired setting: improve handling of link negotiation

jgrulich added a comment. In D24866#569410 , @ngraham wrote: > UI looks good to me. Do you maybe want to review the code itself? It's not that complicated and nobody else seems to be interested. REPOSITORY R116 Plasma Network Managemen

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4bdbd44facf0: Make startplasma more flexible so it can be leveraged by plasma mobile (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25750?vs=70920&id=70951#toc REPOSITORY

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > bshah wrote in main.cpp:93 > On second thought, scratch all this. For completion, this was already doable as is. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.or

D25761: Fix margins of ToolBarHeader

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY I apparently accidentally changed the toolbar header's left margin to Units.smallSpaci

D25760: Unset X-Plasma-MainScript for wallpaper plugins

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY The file path of the main script is hard-coded to ui/main.qml. REPOSITORY R114 Plasma Addons BRANCH u

D25759: Do not crash when icon's source is empty

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Kirigami gallery would crash on the overlay sheet page due to trying to access m_theme

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 565 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/565/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 05 Dec 2019 10:36:08 + Build duration: 8 min 25 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 300 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/300/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 05 Dec 2019 10:36:04 + Build duration: 4 min 42 sec and counting JUnit Tests Name:

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 564 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/564/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 05 Dec 2019 10:00:53 + Build duration: 5 min 14 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 299 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/299/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 05 Dec 2019 10:00:53 + Build duration: 3 min 40 sec and counting CONSOLE OUTPUT [...

D25744: support userBackgroundhints in the scripting ui

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:786951fec803: support userBackgroundhints in the scripting ui (authored by mart). REPOSITORY R120 Plasma Workspace

D25459: fix(kcm): improve i18n of device combobox

romangg added a comment. In D25459#572452 , @guoyunhe wrote: > Should we reassign a reviewer? No, let me test it later today. But since it's a string change it can only go in master. If the translation team gives permission though it can

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

broulik added inline comments. INLINE COMMENTS > startplasma-wayland.cpp:88 > +args.reserve(argc); > +for(int i=1; i +args << QString::fromLocal8Bit(argv[i]); Coding style, please. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabric