D25709: Make it compile against qt5.14 without deprecated method

mlaurent created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY Compile against 5.14 without deprecated method REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH fix_compile_qt5.14

D14581: support for multilevel kcms

filipf added a comment. Hi, this patch triggered a bug in icon view: https://bugs.kde.org/show_bug.cgi?id=400876 I've confirmed the bug can't be reproduced when these lines are removed. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D14581 To: mart, #pl

D25428: Improved support for desktop "Folder View"

ngraham added a comment. I'm afraid it's still not consistently fixed for me when using double-click. Most of the time, a tap will still select and then immediately de-select the item. Only about 1/4 of my taps actually open the item. With single-click, about 3/4 open the item, but the rest

D25703: Sync scrollbar behavior with GTK applications

ngraham added a comment. Nice, works great. Wanna remove the option in the KCM in this patch too? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25703 To: gikari, cblack, #vdg Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampa

D25694: Port away from DesktopIcon

apol added a comment. The change looks good to me, can you provide a screenshot of before/after? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25694 To: nicolasfella, #plasma Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D25692: Rename Look and Feel Explorer to Plasma Global Theme Explorer

This revision was automatically updated to reflect the committed changes. Closed by commit R118:49a2d8a4988a: Rename Look and Feel Explorer to Plasma Global Theme Explorer (authored by ognarb). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25692?vs=70774&i

D25703: Sync scrollbar behavior with GTK applications

gikari created this revision. gikari added a reviewer: cblack. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Previously GTK applications respected their own setting on what should happen when an user clicks be

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

nicolasfella created this revision. nicolasfella added reviewers: Plasma, Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY setPixmapProvider will be deprecated with D25700

D25691: [KDecoration] Use QIcon::paint

This revision was automatically updated to reflect the committed changes. Closed by commit R113:4afa55e27433: [KDecoration] Use QIcon::paint (authored by broulik). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25691?vs=70772&id=70786 REVISION DETAIL h

D25670: Synchronize decorations buttons order in GTK headerbars

gikari updated this revision to Diff 70782. gikari added a comment. - Change appmenu to icon REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25670?vs=70778&id=70782 BRANCH gtk-decoration-order-sync (branched from master) REVISION DETAIL

D25670: Synchronize decorations buttons order in GTK headerbars

gikari updated this revision to Diff 70778. gikari edited the test plan for this revision. gikari added a comment. - Use KConfigWatcher instead of KWin dbus signal REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25670?vs=70705&id=70778 BRA

D25694: Port away from DesktopIcon

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH fo REVISION DETAIL https://phabricator.kde.org/D25694 AFFECTED FILES kcms/kfontinst/kcmfonti

D25692: Rename Look and Feel Explorer to Plasma Global Theme Explorer

ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. TEST PLAN not tested REPOSITORY R118 Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D25692 AFFECTED FILES lookandfeel

D25691: [KDecoration] Use QIcon::paint

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Thanks ! REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D25691 To: broulik, #plasma, hpereiradacosta Cc: plasma-devel, LeGast00n, The-Feren-

D25691: [KDecoration] Use QIcon::paint

broulik created this revision. broulik added reviewers: Plasma, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Properly takes into account device pixel ratio. It's what Breeze decoration code

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

This revision was automatically updated to reflect the committed changes. Closed by commit R119:759cec4645e0: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar… (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.

D25690: [Style KCM] Forward geometryChanged to parent class

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Required so properties `width` and `height` are correct. TEST PLAN Tried to `anchors.fill: pare

D25688: [Style KCM] Set implicit size after show

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Most of the widgets used in the preview initialize only on show, making the size hint invalid bef

D25375: Start of the accessibility KCM

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. All the left labels in the formLayouts need to end with a colon, e.g.: Delay: [ 0] Don't use `onCheckStateChanged` or `onCheckedChanged` for checkboxes when you want

D25614: [System Tray] Clean up popup code

This revision was automatically updated to reflect the committed changes. Closed by commit R120:beac5919274c: [System Tray] Clean up popup code (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25614?vs=70748&id=70762 REVISION DETA

D25375: Start of the accessibility KCM

tcanabrava added a comment. Missing apply button being enabled seems something related to ManagedConfigModule. I don't know what to do there yet. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25375 To: tcanabrava, ngraham Cc: ognarb, mart, ngraham, plasma-d

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 70754. tcanabrava marked 6 inline comments as done. tcanabrava added a comment. - Add missing setButtons - Fix Typo REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25375?vs=70751&id=70754 BRANCH kcm_acess

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 70751. tcanabrava marked an inline comment as done. tcanabrava added a comment. - Fix factory name REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25375?vs=70749&id=70751 BRANCH kcm_acess REVISION DETAIL

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 70749. tcanabrava added a comment. - Fixes - Fixes texts and UI - Simplify Algorithm - Fix Enable / Disable status REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25375?vs=70103&id=70749 BRANCH kcm_ace

D25614: [System Tray] Clean up popup code

filipf updated this revision to Diff 70748. filipf added a comment. onToggled instead of onClicked REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25614?vs=70577&id=70748 BRANCH code-cleanup (branched from master) REVISION DETAIL https://phabr

D25681: Get icon size from QStyle

This revision was automatically updated to reflect the committed changes. Closed by commit R103:3e01b440e53a: Get icon size from QStyle (authored by davidre). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25681?vs=70740&id=70741 REVISION DETAIL https:

D25681: Get icon size from QStyle

davidre updated this revision to Diff 70740. davidre added a comment. const REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25681?vs=70739&id=70740 BRANCH iconsize (branched from master) REVISION DETAIL https://phabricator.kde.org/D25681 AFFECTED

D25681: Get icon size from QStyle

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY The KIconLoader method will go away REPOSITORY R103 KMenu Editor BRANCH iconsize (branched from master) REVISION DETAIL htt

Monday meeting notes for 2/11/2019

Kai Uwe plasma-browser-integration: * Made a new release \o/ https://blog.broulik.de/2019/11/plasma-browser-integration-1-7/ * Figured out how to fix Spotify Web player for Firefox: D25569 Diff 25569 "Also overwrite document.createElement using exportFunction" [Accepted] https://phabricator.kde.org

D25672: Port to std::sort

broulik added a comment. Does this not need an `#include `? REPOSITORY R122 Powerdevil BRANCH qsort REVISION DETAIL https://phabricator.kde.org/D25672 To: nicolasfella, #plasma, apol Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBo

D25671: Fix git builds against Qt 5.14

This revision was automatically updated to reflect the committed changes. Closed by commit R129:771ed0c4f8c2: Fix git builds against Qt 5.14 (authored by apol). REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25671?vs=70706&id=70734 REVISION

D25614: [System Tray] Clean up popup code

broulik added inline comments. INLINE COMMENTS > filipf wrote in ExpandedRepresentation.qml:103 > @broulik? Both are fine I guess but `onToggled` is indeed more correct REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25614 To: filipf, #plasma, broulik Cc: ngr

D25614: [System Tray] Clean up popup code

filipf added inline comments. INLINE COMMENTS > ngraham wrote in ExpandedRepresentation.qml:103 > `onToggled`? @broulik? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25614 To: filipf, #plasma, broulik Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Fere

D25637: Port away from kglobalsettings

davidedmundson added inline comments. INLINE COMMENTS > apol wrote in componentchooserterminal.cpp:87 > No need to notify here? I can't find someone else listening to this REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25637 To: davidedmundson, #plasma Cc: apo

D25668: Port away from deprecated KIconLoader::SmallIcon

This revision was automatically updated to reflect the committed changes. Closed by commit R102:121da761bef1: Port away from deprecated KIconLoader::SmallIcon (authored by davidedmundson). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25668?vs=70702&id=70

D25670: Synchronize decorations buttons order in GTK headerbars

broulik added a comment. > It would be sensible to use an individual signal. I would like to hear an advice about its naming. Alternatively you could have the KWin decoration KCM use `writeEntry` with `Notify` flag and then use a `KConfigWatcher` here instead of connecting to KWin's gen