D25624: Don't use qmlRegisterType with QT-5.14

plevine updated this revision to Diff 70645. plevine added a comment. Use QT_VERSION_CHECK for clarity. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25624?vs=70596&id=70645 REVISION DETAIL https://phabricator.kde.org/D25624 AFFECTED FILES src/kcm.cpp To: plevine, jriddell, #

D25633: Fix Cuttlefish mouse click selection in icon grid

This revision was automatically updated to reflect the committed changes. Closed by commit R118:dd263acd2f62: Fix Cuttlefish mouse click selection in icon grid (authored by GB_2). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25633?vs=70626&id=70637 REVIS

D25633: Fix Cuttlefish mouse click selection in icon grid

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch REPOSITORY R118 Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D25633 To: GB_2, #plasma, #vdg, ngraham Cc: ngraham, #vdg, plasma-devel, #plasma

D25637: Port away from kglobalsettings

apol added inline comments. INLINE COMMENTS > componentchooserterminal.cpp:87 > Kdelibs4SharedConfig::syncConfigGroup(QLatin1String("General"), > "kdeglobals"); > > QDBusMessage message = > QDBusMessage::createMethodCall(QStringLiteral("org.kde.klauncher5"), No need to not

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

kossebau updated this revision to Diff 70633. kossebau added a comment. - keep old CMake Config files installed - no longer create unused version.h file REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23005?vs=63296&id=70633 BRA

D25637: Port away from kglobalsettings

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This was there only to support notifying kdeinit4, which we no longer care

D25635: Add icon to browser integration do not remind menu item

This revision was automatically updated to reflect the committed changes. Closed by commit R856:e37eef54ab35: Add icon to browser integration do not remind menu item (authored by GB_2). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25635?vs

D25636: Fixup deprecated use of QWeakPointer::data

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY At the point init is run we can be sure that our decoration->client() point

D25635: Add icon to browser integration do not remind menu item

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7791325: Plasma Browser Integration Do Not Remind Menu Item Icon.png

D25634: Add kconf update script for ksmserver

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Config enum value was moved in a recent commit to kcfg we should port the v

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

apol added a comment. Maybe you can install one with the typo and one without, so Plasma and whatever else can be ported and start doing things properly. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D23005 To: kossebau, mart, broulik Cc:

D25633: Fix Cuttlefish mouse click selection in icon grid

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Fixes the selection preview being changed before the selection rectangle changes. TEST PLAN Click o

D25624: Don't use qmlRegisterType with QT-5.14

zzag added inline comments. INLINE COMMENTS > kcm.cpp:55 > { > +#if QT_VERSION < 0x050140 > qmlRegisterType(); You could use `QT_VERSION_CHECK` to make the code more readable, e.g. #if QT_VERSION < QT_VERSION_CHECK(5, 14, 0) qmlRegisterType(); qmlRegisterType(); #else

D25624: Don't use qmlRegisterType with QT-5.14

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. You'll find this with the other repos too. In general I've been reverting the relevant path of the cmake that forces no deprecated. REPOSITORY R124 System Settings R

D25428: Improved support for desktop "Folder View"

steffenh updated this revision to Diff 70597. steffenh added a comment. don't use simulated double mouse click to open/launch an item. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25428?vs=70247&id=70597 BRANCH arcpatch-D25428 REVISION DETAIL