D25191: replace bespoke xkb geometry parser with xkb

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:c7a1f606ca96: replace bespoke xkb geometry parser with xkb (authored by sitter). CHANGED PRIOR TO COMMIT https://pha

D25604: Properly add data root to XDG_DATA_DIRS and only when necessary

sniperrifle updated this revision to Diff 70537. sniperrifle added a comment. Diff to the proper upstream REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25604?vs=70536&id=70537 REVISION DETAIL https://phabricator.kde.org/D25604 AFFECTED FILES

D25604: Properly add data root to XDG_DATA_DIRS and only when necessary

sniperrifle updated this revision to Diff 70536. sniperrifle added a comment. Condensed the overly verbose comments into a single sentence capturing the essence of the original comments and use splitRef instead of split. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://

D25604: Properly add data root to XDG_DATA_DIRS and only when necessary

apol requested changes to this revision. apol added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > startplasma.cpp:188 > > -// Make sure that the KDE prefix is first in XDG_DATA_DIRS and that it's > set at all. > -// The spec allows XDG_DATA_DIRS to b

D25602: [System Tray] Restore old pin button size

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I don't like this * 1.25 business, but you are correct that's what the old code did. REPOSITORY R120 Plasma Workspace BRANCH old-pinbutton-size (branched from master)

D25604: Properly add data root to XDG_DATA_DIRS and only when necessary

sniperrifle created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sniperrifle requested review of this revision. REVISION SUMMARY This patch ensures the XDG_DATA_DIRS will be properly altered and only when necessary. This implies: - If the data roo

D25603: [XembedSNIProxy] Send all container windows to background on KWin restart

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Alternatively, if we need to reset something when our window gets moved...could we watch for our window getting moved? It'll be the more technically correct, and keeps this

Re: Add D24530 to 5.17.4

Any dev can cherry-pick things to the stable branch. Where possible we prefer putting into 5.17 first and then merging 5.17 to master so git tracks it better, but in this case it's already merged. To repeat the full rules for any future questions or anyone else wondering: - we only backport fixe

Re: Add D24530 to 5.17.4

Yeah, at this point, you can cherry-pick it onto the Plasma/5.17 branch. Nate On 11/28/19 3:07 PM, Konrad Materka wrote: Hi, I fixed one issue in D24530 but it didn't manage to be in the 5.17 release. I thoughtit is not important but seems it is quite annoying for users. How can I add this f

Add D24530 to 5.17.4

Hi, I fixed one issue in D24530 but it didn't manage to be in the 5.17 release. I thought it is not important but seems it is quite annoying for users. How can I add this fix to Plasma 5.17.4? Can I just cherry-pick and push or some official approval is needed? -- Regards: Konrad Materka

D25603: [XembedSNIProxy] Send all container windows to background on KWin restart

kmaterka updated this revision to Diff 70528. kmaterka added a comment. Empty line removed REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25603?vs=70527&id=70528 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25603 AFFECTED FILES

D25603: [XembedSNIProxy] Send all container windows to background on KWin restart

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY For each tray icon XEmbedSNIProxy is creating container window 32x32 in size. It is black with opa

D25602: [System Tray] Restore old pin button size

filipf updated this revision to Diff 70526. filipf added a comment. use Layout.preferredHeight/Width instead of implicitHeight/Width REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25602?vs=70525&id=70526 BRANCH old-pinbutton-size (branched from

D25593: [kdecoration] Use QVariantAnimation instead of QPropertyAnimation

hpereiradacosta accepted this revision. hpereiradacosta added a comment. Thanks ! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25593 To: broulik, #vdg, hpereiradacosta, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragr

D25602: [System Tray] Restore old pin button size

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This size was used before the rewrite (D24720 ). REPOSITORY R120 Plasma Workspace BRANCH ol

Re: New Gesture Implementation

Hi Leonardo, Reaching out to the Plasma developers mailing list, since it's where I guess this would be developed. Providing more details into how this could be included in Plasma would be useful to decide how your project would integrate. Aleix On Thu, Nov 28, 2019 at 9:24 AM Leonardo Pennino

D25591: support for the shadow and effectiveBackgroundhints

mart updated this revision to Diff 70515. mart added a comment. - adapt to api changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25591?vs=70497&id=70515 BRANCH mart/effectiveBackgroundHints REVISION DETAIL https://phabricator.kde.org/D25

D25592: handle action for custom shadow background hint

mart updated this revision to Diff 70514. mart added a comment. - adapt to api changes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25592?vs=70505&id=70514 BRANCH mart/effectiveBackgroundHints REVISION DETAIL https://phabricator.kde.org/D2559

D23413: [System Tray] Unified data model for System Tray items

kmaterka abandoned this revision. kmaterka added a comment. Smaller subset of changes (model only for configuration page) extracted to D25580 , needed for the D22176 . If D25580 gets

D25592: handle action for custom shadow background hint

mart updated this revision to Diff 70505. mart added a comment. - move Layout.fillWidth on top REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25592?vs=70501&id=70505 BRANCH mart/effectiveBackgroundHints REVISION DETAIL https://phabricator.kde.o

D25594: [Style KCM] Force active palette on widgets

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d3b1163f8f2b: [Style KCM] Force active palette on widgets (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25594?vs=70502&id=70504 REVI

D25594: [Style KCM] Force active palette on widgets

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since there isn't a real window, the widgets think they're inactive, leading to dull appearance.

D25592: handle action for custom shadow background hint

davidedmundson added a comment. Generally +1. Will approve once I've got through the applet change INLINE COMMENTS > ActionButton.qml:36 > > -opacity: action==undefined||action.enabled?1:0.6 > - > -Behavior on opacity { > -NumberAnimation { > -duration: unit

D25592: handle action for custom shadow background hint

mart updated this revision to Diff 70501. mart added a comment. - add missing Actionbutton refactor REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25592?vs=70498&id=70501 BRANCH mart/effectiveBackgroundHints REVISION DETAIL https://phabricator.

D25593: [kdecoration] Use QVariantAnimation instead of QPropertyAnimation

broulik created this revision. broulik added reviewers: VDG, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We don't need to go through the property system to update a value, just use a lambda

D25592: handle action for custom shadow background hint

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY The handle now uses ToolButtons to support the checkable background toggle The new handle action enables

D25591: support for the shadow and effectiveBackgroundhints

mart created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY support the automatic shadow hint When the hint is shadowedBackground, do an automatic shadow with a shader, and change applet's co

D25584: [TabBar] Add a border property

filipf added a subscriber: mart. filipf added a comment. Ah right, it will complain about a non-existing property. Yeah it would be good if we could just drop it. Maybe @mart knows why we have it. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator

D25584: [TabBar] Add a border property

ahiemstra added a comment. Kai means a different QQC2 style. Which is indeed a problem with this approach, if you switch to say Material style with `QT_QUICK_CONTROLS_STYLE=material` the KCM will not load. I think the better question is: Does the line serve any purpose? Or can we simply

D25584: [TabBar] Add a border property

filipf added a comment. With this patch: Fusion: F7788319: image.png Windows 98: F7788322: image.png Oxygen: F7788324: image.png QtCurve: F7788326: im

D25581: [TabBar] Use window color instead of button color

davidre added a comment. In Breeze it uses the window color I think? See breezestyle.cpp#L5767 and the following lines REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH right-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D25581 To: filipf, #plasma,

D25581: [TabBar] Use window color instead of button color

filipf added a comment. In D25581#568711 , @broulik wrote: > Can you verify how the widgets `QTabBar` behaves in this scenario? It doesn't use the button color, but comparing the two reveals other dissimilarities: F7788275: image.png

D25322: Have the wallpaper combo managed by KConfigDialogManager

This revision was automatically updated to reflect the committed changes. Closed by commit R133:27d907610381: Have the wallpaper combo managed by KConfigDialogManager (authored by ervin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25322?vs=70430&id=7

D25321: Remove dead code

This revision was automatically updated to reflect the committed changes. Closed by commit R133:e5e8c9157cae: Remove dead code (authored by ervin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25321?vs=69790&id=70484 REVISION DETAIL https://phabricat

D25287: Integrate the lnf and wallpaper settings with the KCM logic

This revision was automatically updated to reflect the committed changes. Closed by commit R133:33857261ccd7: Integrate the lnf and wallpaper settings with the KCM logic (authored by ervin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25287?vs=70432&id=70483#toc REPOSITORY R133 KScr

D25586: KCM WorkspaceOptioins port to KConfigXT. Take into account immutable properties

crossi updated this revision to Diff 70482. crossi added a comment. typo REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25586?vs=70480&id=70482 REVISION DETAIL https://phabricator.kde.org/D25586 AFFECTED FILES kcms/workspaceoptions/CMakeLists.t

D25567: Repair the wallpaper config dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3600bebcc79a: Repair the wallpaper config dialog (authored by ervin). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25567?vs=70434&id=70481 REVISION DETA

D25586: KCM WorkspaceOptioins port to KConfigXT. Take into account immutable properties

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2558

D25581: [TabBar] Use window color instead of button color

broulik added a comment. Can you verify how the widgets `QTabBar` behaves in this scenario? REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH right-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D25581 To: filipf, #plasma, #vdg, ngraham Cc: broulik, p