D25584: [TabBar] Add a border property

2019-11-27 Thread Kai Uwe Broulik
broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. I don't think the style is the right approach. What happens if you run the KCM with a different style, will it refuse to load? And `border` is quite a non-descript property, ho

D25539: feat(kcm): add revert timer

2019-11-27 Thread Zixing Liu
liushuyu updated this revision to Diff 70474. liushuyu added a comment. Address ndavis' comments REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25539?vs=70451&id=70474 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25539 AFFECTED FILES

D25539: feat(kcm): add revert timer

2019-11-27 Thread Zixing Liu
liushuyu added a comment. In D25539#568678 , @ndavis wrote: > Is there a way to tell the revert timer not to be used if the user only makes a change that requires a session restart? It wouldn't be very useful to ask a user to confirm if the scre

D25539: feat(kcm): add revert timer

2019-11-27 Thread Noah Davis
ndavis added a comment. Is there a way to tell the revert timer not to be used if the user only makes a change that requires a session restart? It wouldn't be very useful to ask a user to confirm if the screen is displaying correctly if the change can't be seen. REPOSITORY R104 KScreen R

D25539: feat(kcm): add revert timer

2019-11-27 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > main.qml:109 > +iconName: "document-save" > +text: i18n("Apply") > +onTriggered: { Since you are keeping the recently applied configuration rather than applying a new one, wouldn't it be

D25584: [TabBar] Add a border property

2019-11-27 Thread Filip Fila
filipf added a comment. In D25584#568669 , @ngraham wrote: > Feels like at this point we should just break down and create an actual `TabView` control all at once. :p Yep. Unfortunately it seems we'd still need this hacky property because

D25584: [TabBar] Add a border property

2019-11-27 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Feels like at this point we should just break down and create an actual `TabView` control all at once. :p REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH border-property (b

D25584: [TabBar] Add a border property

2019-11-27 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY In the Window Decorations and Audio KCMs we use QQC2 TabBars with a frame. The frame already draws a top border but then the tabb

D25581: [TabBar] Use window color instead of button color

2019-11-27 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY If some color scheme (not Breeze) doesn't use the same button and window colors the tab sticks out. BUG: 413311 FIXED-IN: 5.65

D22176: Rework system tray settings

2019-11-27 Thread Konrad Materka
kmaterka added a comment. As mentioned earlier: this is a great idea, but has issues with the model. Please check D25580 as a per-requirement. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22176 To: nicolasfella, #plas

D25580: [System Tray] Unified data model for System Tray items

2019-11-27 Thread Konrad Materka
kmaterka added a comment. This is a simplified version of D23413 needed for the D22176 to move forward. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25580 To: kmaterka, #plasma, br

D25580: [System Tray] Unified data model for System Tray items

2019-11-27 Thread Konrad Materka
kmaterka created this revision. kmaterka added reviewers: Plasma, broulik. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Currently there are two different sources of SystemTray items: - Plasmoids - Status Notifier Thi change adds new m

D24847: KCM Icons fix theme selected when we hit delete theme

2019-11-27 Thread Benjamin Port
bport updated this revision to Diff 70453. bport added a comment. Fix regression (apply button not activated when eeded) and ervin feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24847?vs=69037&id=70453 REVISION DETAIL https://phabricator.

D24846: Port kcm icons to kconfigxt

2019-11-27 Thread Benjamin Port
bport updated this revision to Diff 70452. bport added a comment. Take in consideration feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24846?vs=69036&id=70452 REVISION DETAIL https://phabricator.kde.org/D24846 AFFECTED FILES kcms/icons

D25539: feat(kcm): add revert timer

2019-11-27 Thread Zixing Liu
liushuyu added a comment. After applying the patches from https://cgit.kde.org/kirigami.git/commit/?id=8c1e5b1336e6dcae0a1b7756977fcd9368f853a2, it now looks like this: F7787159: image.png REPOSITORY R104 KScreen REVISION DETAIL https://phabr

D25539: feat(kcm): add revert timer

2019-11-27 Thread Zixing Liu
liushuyu updated this revision to Diff 70451. liushuyu added a comment. Update icons and stop the timer on actions pressed REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25539?vs=70390&id=70451 BRANCH master REVISION DETAIL https://phabricator.kde.org

Supported devicesof Plasma

2019-11-27 Thread Vignesh Rajendran
Hello Plasma, In the documentation, there are no information of supported devices. [Except Nexus?] I would like try Plasma and interested to know the supported devices of Plasma. Can you please list the supported devices? I really appreciate your effort on alternative to Android. Regards, Vign

D25305: Add Total/Available/Allocated memory sensors

2019-11-27 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. Closed by commit R106:05e26b28ebb7: Add Total/Available/Allocated memory sensors (authored by ahiemstra). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25305?vs=69748&id=70445 REVISI

D25306: Add translations for new memory sensors

2019-11-27 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. Closed by commit R111:eedf1ca73d1b: Add translations for new memory sensors (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25306?vs=69749&id=70446 REV

D25570: Fix InlineMessage actions always being placed in overflow menu

2019-11-27 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. Closed by commit R169:8c1e5b1336e6: Fix InlineMessage actions always being placed in overflow menu (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25570?vs=70440

D25566: [Notifications] Move out of the way of dialog rather than just hiding

2019-11-27 Thread Nathaniel Graham
ngraham added a comment. Nice, this works great. Just what I would expect. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25566 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBo

D25570: Fix InlineMessage actions always being placed in overflow menu

2019-11-27 Thread Arjen Hiemstra
ahiemstra created this revision. ahiemstra added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Due to some of the recent ActionToolBar work, InlineMessage ended up always placin

D25569: Also overwrite document.createElement using exportFunction

2019-11-27 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: fvogt, davidedmundson, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Ensures it works in Firefox on sites with content security policy like Spot

Re: KInit - Current state and benchmarks

2019-11-27 Thread Aleix Pol
On Tue, Nov 26, 2019 at 8:57 AM Milian Wolff wrote: > > On Montag, 25. November 2019 22:57:11 CET Albert Astals Cid wrote: > > El dissabte, 23 de novembre de 2019, a les 11:47:40 CET, Milian Wolff va > escriure: > > > On Mittwoch, 19. Juni 2019 19:57:56 CET Albert Astals Cid wrote: > > > > El dima

D25567: Repair the wallpaper config dialog

2019-11-27 Thread Kevin Ottens
ervin created this revision. ervin added reviewers: Plasma, mart, davidedmundson, crossi, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY This is full of mixed bindings/signal handlers for properties and of

D25566: [Notifications] Move out of the way of dialog rather than just hiding

2019-11-27 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When e.g. connecting to a network with captive portal, it leaves you sitting there wondering

D25287: Integrate the lnf and wallpaper settings with the KCM logic

2019-11-27 Thread Kevin Ottens
ervin updated this revision to Diff 70432. ervin added a comment. Fix typo REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25287?vs=70429&id=70432 REVISION DETAIL https://phabricator.kde.org/D25287 AFFECTED FILES greeter/lnf_integration.cpp gre

D25540: Add default value for cursor theme

2019-11-27 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R99:4090e899eddd: Add default value for cursor theme (authored by broulik). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25540?vs=70331&id=70431 REV

D25287: Integrate the lnf and wallpaper settings with the KCM logic

2019-11-27 Thread Kevin Ottens
ervin updated this revision to Diff 70429. ervin added a comment. Adjust for bugs found in the lnf and wallpaper integration This was missing some signalling and copying back in the item REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25287?vs=696

D25322: Have the wallpaper combo managed by KConfigDialogManager

2019-11-27 Thread Kevin Ottens
ervin updated this revision to Diff 70430. ervin added a comment. On some condition the assert would be triggered REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25322?vs=69791&id=70430 REVISION DETAIL https://phabricator.kde.org/D25322 AFFECTED FI