D25539: KScreen KCM: Add a revert timer to the settings page

ndavis added a comment. In D25539#567576 , @broulik wrote: > One of the key ideas of KScreen was that it will *not* have a revert timer. Could you expand on that? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D2

Re: KInit - Current state and benchmarks

On Montag, 25. November 2019 22:57:11 CET Albert Astals Cid wrote: > El dissabte, 23 de novembre de 2019, a les 11:47:40 CET, Milian Wolff va escriure: > > On Mittwoch, 19. Juni 2019 19:57:56 CET Albert Astals Cid wrote: > > > El dimarts, 18 de juny de 2019, a les 12:04:38 CEST, David Edmundson va

D25540: Add default value for cursor theme

broulik created this revision. broulik added a reviewer: gikari. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When using the default cursors, no `cursorTheme` entry is written into the config file, leading t

D25539: KScreen KCM: Add a revert timer to the settings page

broulik added a comment. One of the key ideas of KScreen was that it will *not* have a revert timer. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25539 To: liushuyu, #vdg, #plasma Cc: broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalou

D24691: Add support for WPA3

This revision was automatically updated to reflect the committed changes. Closed by commit R116:82e187663135: Add support for WPA3 (authored by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24691?vs=68155&id=70330#toc REPOSITORY R116 Plasma Network Management Applet CHANGES

D25539: KScreen KCM: Add a revert timer to the settings page

liushuyu updated this revision to Diff 70329. liushuyu added a comment. Fix the diff REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25539?vs=70328&id=70329 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25539 AFFECTED FILES kcm/config_h

D25539: KScreen KCM: Add a revert timer to the settings page

ndavis added a comment. +1 for this safety feature It would be nice to have a visible countdown timer though. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25539 To: liushuyu, #vdg, #plasma Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalo

D25539: KScreen KCM: Add a revert timer to the settings page

liushuyu created this revision. liushuyu added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. liushuyu requested review of this revision. REVISION SUMMARY Add a revert timer and an option for the user to revert the settings when they accidentally messe

D25537: [kaccess] Remove unneeded KService dependency

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN Builds REPOSITORY R119 Plasma Desktop BRANCH kacc REVISION DETAIL https://phabricator.kde.org/D25537 AFFECTED FILES k

Re: KInit - Current state and benchmarks

El dissabte, 23 de novembre de 2019, a les 11:47:40 CET, Milian Wolff va escriure: > On Mittwoch, 19. Juni 2019 19:57:56 CET Albert Astals Cid wrote: > > El dimarts, 18 de juny de 2019, a les 12:04:38 CEST, David Edmundson va > escriure: > > > > Are we sure it's fair to assume people have SSD? ou

D22053: [libtaskmanager] Track stacking order and window activation (on X11)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:c0acd1434147: [libtaskmanager] Track stacking order and window activation (on X11) (authored by hein). REPOSITORY R1

D24238: Port the pager applet away from QtWidgets

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:674dd5f7e090: Port the pager applet away from QtWidgets (authored by dfaure). REPOSITORY R119 Plasma Desktop CHANGE

D25514: Simpler theme deletion

davidedmundson added a comment. We have code here that validates the path, so there must be a pattern. We just need to instead of validating the path, construct it on the helper side. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D25514

D25514: Simpler theme deletion

filipf added a comment. As far as I can tell theme names don't always match the folder names they reside in. I'm guessing I have to dig up the actually path value that gets set when creating the theme folder and then construct the file path here in the helper? REPOSITORY R123 SDDM Con

D25526: KCM launch feedback : take into account immutable properties

crossi added inline comments. INLINE COMMENTS > broulik wrote in main.qml:45 > Imho this is confusing. > The property should be `readonly property bool cursorImmutable: > kcm.setings.immutable && ..` and then this would be `enabled: !immutable` Thanks for pointing this. Reworked the property t

D25526: KCM launch feedback : take into account immutable properties

crossi updated this revision to Diff 70304. crossi added a comment. Make the propery readonly, boolean condition to repeat the same pattern enabled: !immutable REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25526?vs=70300&id=70304 REVISION DETAIL

D25526: KCM launch feedback : take into account immutable properties

broulik added inline comments. INLINE COMMENTS > main.qml:45 > > +enabled: formLayout.cursorImmutable > Kirigami.FormData.label: i18n("Cursor:") Imho this is confusing. The property should be `readonly property bool cursorImmutable: kcm.setings.immutable && ..` and th

D25526: KCM launch feedback : take into account immutable properties

crossi updated this revision to Diff 70300. crossi added a comment. blank line REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25526?vs=70298&id=70300 REVISION DETAIL https://phabricator.kde.org/D25526 AFFECTED FILES kcms/launch/package/contents

D25526: KCM launch feedback : take into account immutable properties

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25526 AFFECTED FILES kcms/launch/package/contents/ui/main.qml To: cr

D25525: KCM Style : take into account immutable properties

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Depends on D25520 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.or

D25524: KCM KSplash : take into account immutable property

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25524 AFFECTED FILES kcms/ksplash/package/contents/ui/main.qml To: c

D25523: KCM LookAndFeel : take into account immutable property

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25523 AFFECTED FILES kcms/lookandfeel/package/contents/ui/main.qml T

D25522: KCM Colors : take into account immutable property

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25522 AFFECTED FILES kcms/colors/colors.cpp kcms/colors/colors.h

D25428: Improved support for desktop "Folder View"

ngraham added a comment. I'm using an HP Spectre x360 convertible laptop with a touchscreen. Test results using the systemwide double-click setting: - With your patch: result is inconsistent: very occasionally, the item opens. Other times, the item becomes selected and then immediate

D24691: Add support for WPA3

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Nice, I am properly not the best reviewer here, but it looks ok to me. INLINE COMMENTS > wifisecurity.cpp:118 > +} else if (securityIndex == SAE) { > +return !m_ui->psk->text().is

D24866: Wired setting: improve handling of link negotiation

jgrulich added a comment. Ping? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24866 To: jgrulich, #plasma Cc: dvalter, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D24691: Add support for WPA3

jgrulich added a comment. Ping? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24691 To: jgrulich, #plasma Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, l

D25519: Fix broken multimedia control on lockscreen

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e2cbf51aa516: Fix broken multimedia control on lockscreen (authored by ajyotirmay, committed by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25

D25519: Fix broken multimedia control on lockscreen

ajyotirmay added a comment. apjyotir...@gmail.com REPOSITORY R120 Plasma Workspace BRANCH media-control-layout-constraint REVISION DETAIL https://phabricator.kde.org/D25519 To: ajyotirmay, broulik Cc: davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbamp

D25519: Fix broken multimedia control on lockscreen

davidedmundson added a comment. yes REPOSITORY R120 Plasma Workspace BRANCH media-control-layout-constraint REVISION DETAIL https://phabricator.kde.org/D25519 To: ajyotirmay, broulik Cc: davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D25466: Add Captive Portal auto-refresh handling

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. IMO this should be addressed outside of PBI instead: - If a captive portal is detected, call `CheckConnectivity` with a higher frequency (I've never had any issues with this, ac

D25519: Fix broken multimedia control on lockscreen

ajyotirmay added a comment. Do I share my email right here, in the comments? REPOSITORY R120 Plasma Workspace BRANCH media-control-layout-constraint REVISION DETAIL https://phabricator.kde.org/D25519 To: ajyotirmay, broulik Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jrale

D25519: Fixes bugzilla bug-414487 broken multimedia control on lockscreen

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Perfect! I'll need an email address from you in order to merge this. REPOSITORY R120 Plasma Workspace BRANCH media-control-layout-constraint REVISION DETAIL https://phabricator.k

D25519: Fixes bugzilla bug-414487 broken multimedia control on lockscreen

ajyotirmay created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ajyotirmay requested review of this revision. REVISION SUMMARY Fix for bugs.kde.org bug-414487 TEST PLAN Play "Checking out online shopping..." podcast episode on clementine from Mozill

D25428: Improved support for desktop "Folder View"

steffenh added a comment. First, thank for testing @nicolasfella and @ngraham Ok, now I am clueless. @ngraham maybe you can tell me, witch tablet and software version you used? If you have time, perhaps you can make a test without my patch. Move the cursor with the mouse over

monday meeting notes for 25/11/2019

Kai Uwe plasma-browser-integration: * Did German translation * Found a bug in PO to JSON handling, d_ed just fixed * Some minor code cleanups * Will do a new release tomorrow \o/ Other: * qqc2-desktop-style ToolTip now mimics QToolTip behavior (timeout based on text length) Frameworks 6 Sprint:

D25290: KCM launchfeedback : port to KConfig XT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ff86f0abb454: KCM launchfeedback : port to KConfig XT (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25290?vs=69794&id=70281 REVISION

D25220: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound to settings, making it a bit simpler.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:561401636f7d: KCM Style : kcm state is handled by ManagedConfigModule, properties are bound… (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.

D25274: KCM LookAndFeel : port to KConfig XT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:613d5e12871c: KCM LookAndFeel : port to KConfig XT (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25274?vs=69643&id=70280 REVISION DET

D25514: Simpler theme deletion

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I also interpret it as such. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D25514 To: filipf, davidedmundson, #pl

D25514: Simpler theme deletion

broulik added a comment. I read the bug the other way round: instead of passing a full path (which would allow arbitrarily deleting folders as root?), pass a theme name and then do the lookup in the helper REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricato

D25514: Simpler theme deletion

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY openSUSE requested that we just directly delete a theme based on its file path, instead of first checking if the theme exists in the