KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 277 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/277/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 23 Nov 2019 04:37:10 + Build duration: 17 min and counting JUnit Tests Name: project

KDE CI: Plasma » kinfocenter » kf5-qt5 FreeBSDQt5.13 - Build # 69 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/69/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 23 Nov 2019 02:29:35 + Build duration: 1 min 47 sec and counting

D25476: [GTK3] Fix invalid colour name in treeview

cblack created this revision. cblack added reviewers: Breeze, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Treeview used an invalid colour: `@theme_base_fg_color` instead of `@theme_fg_color`. BUG: 414

D25369: Shorten POTD provider names and remove description that is not used anywhere

guoyunhe added a comment. I didn't find good solutions for QQC2. It has been a blocker for a long time https://bugs.kde.org/show_bug.cgi?id=403153 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25369 To: guoyunhe, #plasma, ngraham Cc: broulik, plasma-devel, L

D25369: Shorten POTD provider names and remove description that is not used anywhere

broulik added a comment. How about we fix the size or the combo instead? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25369 To: guoyunhe, #plasma, ngraham Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot

D25466: Add Captive Portal auto-refresh handling

broulik created this revision. broulik added reviewers: Plasma, bcooksley, fvogt, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When configured to detect captive portals, NetworkManager prompts the u

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. In D25381#566128 , @ndavis wrote: > `oxygen-demo5` Thanks for the tip! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25381 To: guoyunhe, #breeze, #plasma, ngraham, ndavis Cc: ndavis, GB

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

ngraham added a comment. Personally I don't see this setting as a super niche thing. The bug report has four duplicates, so there is clearly quite a bit of demand from users. On macOS, this is literally the first thing I change on a new install, and it's displayed very prominently in the "Ge

D25459: fix(kcm): improve i18n of device combobox

romangg added subscribers: broulik, romangg. romangg added a comment. Thanks for the patch. @broulik: since you changed it last iirc is this good to go? Since it's a string change only master? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25459 To: guoyunhe, kde-i

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

davidedmundson added a comment. My primary concern is that it's a really super niche tweak thing. It's valid but certainly as niche as whether you show the up/down arrows or whatever, yet we're presenting it on the very first level of "Workspace Behaviour". I also fear workspace behaviou

D25462: [Colors KCM] Use Kirigami.SearchField

aspotashev added a comment. In D25462#566157 , @ngraham wrote: > In the worst-case scenario, you can override `placeholderText` here and provide a translated string. Ah, right. Thanks for the reminder! How about including the workaro

D25462: [Colors KCM] Use Kirigami.SearchField

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. In D25462#566149 , @aspotashev wrote: > The translation part of SearchField is indeed buggy: https://bugs.kde.org/show_bug.cgi?id=413900

D25462: [Colors KCM] Use Kirigami.SearchField

aspotashev added a comment. The translation part of SearchField is indeed buggy: https://bugs.kde.org/show_bug.cgi?id=413900 May be it's not time to adopt it yet? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25462 To: broulik, #plasma, #vdg Cc: aspota

D25462: [Colors KCM] Use Kirigami.SearchField

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Gets rid of some code duplication. TEST PLAN - Filtering works - Clear button works

D25381: Make QPushButton/QToolButton the same height as QLineEdit

ndavis added a comment. In D25381#566100 , @guoyunhe wrote: > Yes, this patch needs minimization. What is the software in your screenshot? @ndavis `oxygen-demo5` REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D253

D25406: [ToolTip] Base timeout on text length

This revision was automatically updated to reflect the committed changes. Closed by commit R858:5ca508bd6adc: [ToolTip] Base timeout on text length (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25406?vs=70002&

D25381: Make QPushButton/QToolButton the same height as QLineEdit

guoyunhe added a comment. Yes, this patch needs minimization. What is the software in your screenshot? @ndavis REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25381 To: guoyunhe, #breeze, #plasma, ngraham, ndavis Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n, The

D25439: Don't CacheUser/UnCacheUser when editing Realname

This revision was automatically updated to reflect the committed changes. Closed by commit R128:a2f7d308f9b5: Don't CacheUser/UnCacheUser when editing Realname (authored by meven). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25439?vs=70108&id=70153 RE

D25459: Device ComboBox: fix label and layout

guoyunhe updated this revision to Diff 70151. guoyunhe added a comment. update commit message REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25459?vs=70149&id=70151 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25459 AFFECTED FILES kcm

D25459: Device ComboBox: fix label and layout

ltoscano added a comment. Before anything else you need to change the commit message (yes, just here, because reasons): https://marc.info/?l=kde-devel&m=157350852208190&w=2 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25459 To: guoyunhe, kde-i18n-doc, #plasma,

D25459: Device ComboBox: fix label and layout

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY The original label cause i18n problems, the parameter %1 is never given. The layout doesn't fit the form. This patch uses Kirigam