KDE CI: Plasma » kde-gtk-config » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/28/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 22 Nov 2019 04:41:38 + Build duration: 1 min 41 sec and counting JUnit Tests Name: proj

D25415: Improve package documentation

This revision was automatically updated to reflect the committed changes. Closed by commit R123:1efecc9608cc: Improve package documentation (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25415?vs=70130&id=70131 REV

D25415: Improve package documentation

filipf updated this revision to Diff 70130. filipf added a comment. minor indentation fix REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25415?vs=70082&id=70130 BRANCH better-documentation (branched from master) REVISION DETAIL

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

ngraham added a comment. Does the above make sense to you, @davidedmundson? REPOSITORY R119 Plasma Desktop BRANCH left-click-warps-scrollbar-settings-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D25361 To: ngraham, #plasma, #vdg, ndavis Cc: davidedmundson, nda

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

ngraham added a comment. I haven't found a way to detect transparency in a QML `Image` the way you can with `QImage`. :/ REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13415 To: ngraham, sharvey, #vdg, #plasma Cc: filipf, sefaeyeoglu, hein, plasma-devel, LeG

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

filipf added a comment. I'm thinking users might use PNGs with transparency for their avatars, which means they might not want to have a border around it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13415 To: ngraham, sharvey, #vdg, #plasma Cc: filipf, se

D25418: [Folder view] Use selected text color for selected items in full representation

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a9291006771d: [Folder view] Use selected text color for selected items in full representation (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kd

D25418: [Folder view] Use selected text color for selected items in full representation

ngraham added a comment. Yeah for the future, we'll need to definitively sort out the visual appearance of the selected/highlighted vs hovered states. REPOSITORY R119 Plasma Desktop BRANCH fix-folderview-selected-text (branched from Plasma/5.17) REVISION DETAIL https://phabricator.kde

D25418: [Folder view] Use selected text color for selected items in full representation

ngraham updated this revision to Diff 70125. ngraham added a comment. Use a more comprehensible way to conditionally define the text color REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25418?vs=70028&id=70125 BRANCH fix-folderview-selected-text (

D13202: Circular user avatar for Kickoff

ngraham abandoned this revision. ngraham added a comment. Let's continue in D13415 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13202 To: ngraham, hein, #plasma, sharvey Cc: mart, apol, davidedmundson, plasma-devel, abe

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

ngraham updated this revision to Diff 70124. ngraham added a comment. Handle the software rendering case REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13415?vs=70123&id=70124 REVISION DETAIL https://phabricator.kde.org/D13415 AFFECTED FILES ap

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

ngraham updated this revision to Diff 70123. ngraham added a comment. Rebase and simplify REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13415?vs=35786&id=70123 REVISION DETAIL https://phabricator.kde.org/D13415 AFFECTED FILES applets/kickoff/p

D25449: Start of the new Formats KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Detangle the code, implement models and start the Qml REPOSITORY R119 Plasma Desktop BRANCH kcm_formats REVISION DETAIL

D13415: Reshape Kickoff avatar to a circle with Opacity Mask

ngraham commandeered this revision. ngraham edited reviewers, added: sharvey; removed: ngraham. ngraham added a comment. I'm not 100% sure why, but the outstanding issues with this patch appear to be totally fixed with D25439 . I'll finish it up. REPOSITOR

D25280: [Baloo KCM] Purge index when disabling indexing

ngraham added a comment. Here's a patch that does that: D25447 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25280 To: ngraham, tcanabrava, #plasma, #vdg, #baloo Cc: bruns, cfeck, davidedmundson, plasma-devel, LeGast00n,

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham created this revision. ngraham added reviewers: VDG, Plasma, Baloo, bruns. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Most of this code is lifted straight from the file indexing monitor KInfoCenter

D25280: [Baloo KCM] Purge index when disabling indexing

ngraham added a comment. In D25280#565711 , @bruns wrote: > Agree with David/Thomas, first we need a "Suspend" button or similar. In fact there's already a bug report asking for this: https://bugs.kde.org/show_bug.cgi?id=374474 I'll

D25280: [Baloo KCM] Purge index when disabling indexing

bruns added a comment. Agree with David/Thomas, first we need a "Suspend" button or similar. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25280 To: ngraham, tcanabrava, #plasma, #vdg, #baloo Cc: bruns, cfeck, davidedmundson, plasma-devel, LeGast00n, The-Fer

D25439: Don't CacheUser/UnCacheUser when editing Realname

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fantastic. Such a silly bug :p REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D25439 To: meven, ngraham, #plasma Cc: plasma-devel, LeGast00

D25426: use the new GlobalDrawer header property

apol added inline comments. INLINE COMMENTS > DiscoverDrawer.qml:158 > } > - > -states: [ How's that related? at least the drawerOpen bit should stay. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D25426 To: mart, #discover_software_s

D25430: fix layout of overlaysheet

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Change looks good to me. Please resolve the comments before landing. INLINE COMMENTS > DummyTransaction.cpp:52 > setProgress(qBound(0, progress()+(KRandom::random()%30), 100)); > -

D25398: Check values have changed before setting the model

meven added a comment. In D25398#565210 , @ngraham wrote: > Agreed. Works for me and looks safe, but maybe let's do master only for safety. > > Can you file a bug upstream on the odd behavior in AccountsService? No need in the end. I

D25439: Don't CacheUser/UnCacheUser when editing Realname

meven created this revision. meven added reviewers: ngraham, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY 1d10226d and 83549

D25375: Start of the accessibility KCM

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. In general the UI here is pretty good. I think we can polish it a bit. In particular, instead of having a header for a section and then a checkbox below it to enable that sectio

D25398: Check values have changed before setting the model

This revision was automatically updated to reflect the committed changes. Closed by commit R128:b279882ad9e4: Check values have changed before setting the model (authored by meven). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25398?vs=69988&id=70106 R

D25278: [Baloo KCM] Mention the brand name "Baloo" in user-visible strings

davidedmundson added a subscriber: bruns. davidedmundson added a comment. > release announcements, and social media comments and postings Lets be careful about mixing up the users that we interact with vs our actually wider userbase who don't really care about or follow anything KDE. The

D25428: Improved support for desktop "Folder View"

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks! However this does not work 100% for me with my laptop's touchscreen. Touch-and-drag works to move items, and touch-and-hold works to show the context menu, but I cannot

D25375: Start of the accessibility KCM

tcanabrava updated this revision to Diff 70103. tcanabrava added a comment. - Fixes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25375?vs=69947&id=70103 BRANCH kcm_acess REVISION DETAIL https://phabricator.kde.org/D25375 AFFECTED FILES kcm

D25379: WIP: Beginning of the work for Simplifying the Emoticon KCM

tcanabrava added a comment. In D25379#565509 , @davidedmundson wrote: > I was under the impression we were killing this KCM in the very near future. > > The relevant workboard entry: https://phabricator.kde.org/T7292 While the KCM doe

D25280: [Baloo KCM] Purge index when disabling indexing

tcanabrava added a comment. I gree with david's questioning, sometimes I disable indexing when I'm about to do something heavy, to re-enable it later. I don't want to lose all my data. perhaps there should be a box `purge database data` instead of purging on disable? INLINE COMMENTS > ma

D25381: Make QPushButton/QToolButton the same height as QLineEdit

ndavis requested changes to this revision. ndavis added a comment. This is what happens when icon size is set to 32px or more (48px here): F7776520: Screenshot_20191121_062030.png `size.setHeight(toolButtonOption->fontMetrics.height());` doesn't take ic

D25403: Drop Position change signal and support Seeked signal

fvogt added a comment. This would work, but why not just emit `Seeked(m_position)` in `setPosition`? INLINE COMMENTS > mprisplugin.h:55 > Q_PROPERTY(qreal Volume READ volume WRITE setVolume) > Q_PROPERTY(qlonglong Position READ position) > Q_PROPERTY(double Rate READ playbackRa

D25379: WIP: Beginning of the work for Simplifying the Emoticon KCM

davidedmundson added a comment. I was under the impression we were killing this KCM in the very near future. The relevant workboard entry: https://phabricator.kde.org/T7292 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25379 To: tcanabrava Cc: davidedmu