D24743: Update GTK settings according to Plasma settings

broulik added a comment. Pretty cool! Some minor nitpicks. Once all the KCMs have been ported to KConfigXT (XML config description, currently ongoing) we'll have a compile-time checked way to read KDE settings and easier way to get the default values. INLINE COMMENTS > CMakeLists.txt:9

D24749: Fix build with older glibc: link there to librt for clock_gettime

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Only since glibc version 2.17 -lrt is no longer needed See same fix done for processui in

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#549249 , @ngraham wrote: > Give the scrollview a frame and a white background or else apps look cut off and weird and there's a mysteriously hovering scroller: F7616694: Screenshot_20191017_111833.png

D24744: Remove unneeded options in GTK KCM

gikari added a comment. In D24744#549450 , @GB_2 wrote > Well, it'll be gone completely soon and the GTK theme comboboxes will be in the Application Style KCM. Where would gtk theme installation buttons go? REPOSITORY R99 KDE Gtk Confi

D24479: [KCM] Make multi-screen draggability more obvious

ngraham added a comment. Ping. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24479 To: ngraham, romangg, #plasma, #vdg Cc: GB_2, davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himce

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Otherwise we block containment actions on the left button BUG: 413104 T

D24733: feedback kcm: Make it about Plasma

apol added a comment. Oh, I see what you mean, this text is entirely coming from KUserFeedback. Maybe it's something we can tackle there: https://phabricator.kde.org/source/kuserfeedback/browse/master/src/provider/core/feedbackconfiguicontroller.cpp$187 REPOSITORY R120 Plasma Workspace

D24744: Remove unneeded options in GTK KCM

GB_2 added a comment. In D24744#549444 , @filipf wrote: > So much nicer, awesome work. +1 for the visuals of the rehauled kcm. Well, it'll be gone completely soon and the GTK theme comboboxes are going to be in the Application Style KCM.

D24744: Remove unneeded options in GTK KCM

filipf added a comment. So much nicer, awesome work. +1 for the visuals of the rehauled kcm. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: filipf, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkin

D24720: [applets/systemtray] Rewrite popups with layouts

filipf added a comment. In D24720#549292 , @ngraham wrote: > Nice, this feels indistinguishible from the current one, which is a good sign. I see what you mean about the Headings in RTL. Does the Kirigami version work properly? If so, I wonder i

D24720: [applets/systemtray] Rewrite popups with layouts

filipf updated this revision to Diff 68201. filipf added a comment. make all this work right with RTL layouts REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24720?vs=68182&id=68201 BRANCH popup-rewrite (branched from master) REVISION DETAIL h

D24744: Remove unneeded options in GTK KCM

GB_2 added a comment. Wow, it's so empty now! Great job! REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himce

D22005: Ensure url from KActivity resources are properly built

meven updated this revision to Diff 68193. meven added a comment. Avoid an unnecessary dereference REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22005?vs=68132&id=68193 BRANCH arcpatch-D22005 REVISION DETAIL https://phabricator.kde.org/D22005

D24727: Fix NOAA picture of the day provider

ngraham added a comment. I don't know what to tell you; it's still broken for me. It looks like the first part of the URL isn't getting added onto the second, maybe. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24727 To: guoyunhe, #plasma Cc: ngraham, plasm

D21860: Set a font for gtk applications in the fonts kcm

gikari abandoned this revision. gikari added a comment. Abandoned in favor of D24743 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol, davidedmundson, cfeck Cc: cfeck, davidedmundson, nicolasf

D24543: Set an icon theme for gtk applications in the icons kcm

gikari abandoned this revision. gikari added a comment. Abandoned in favor of D24743 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24543 To: gikari, ngraham, meven Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jra

D23414: Remove font configuration from GTK KCM

gikari abandoned this revision. gikari added a comment. Abandoned in favor of D24744 REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D23414 To: gikari, apol, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n, The

D24737: Correctly highlight the icon in the system tray

This revision was automatically updated to reflect the committed changes. Closed by commit R114:7ad4b59b7047: Correctly highlight the icon in the system tray (authored by kmaterka). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24737?vs=68147&id=68190

D24744: Remove unneeded options in GTK KCM

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Since font, icons, cursor theme, toolbar style, icons in menus and buttons settings are now in sync with corresponding plasma setting

D24727: Fix NOAA picture of the day provider

guoyunhe added a comment. In D24727#549327 , @ngraham wrote: > Still broken, I'm afraid. Among the console output is the following, which may be helpful: > > kf5.kio.core: Invalid URL: QUrl("/sites/default/files/bomb-cycle-1.jpg") >

D24727: Fix NOAA picture of the day provider

ngraham added a comment. Still broken, I'm afraid. Among the console output is the following, which may be helpful: kf5.kio.core: Invalid URL: QUrl("/sites/default/files/bomb-cycle-1.jpg") REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24727 To: guoyun

D24743: Update GTK settings according to Plasma settings

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY To increase usability, - fonts - icon theme - cursor theme - toolbar style (icons-only, text below buttons etc) - icons v

D24733: feedback kcm: Make it about Plasma

ngraham added a comment. The introductory "We make plasma for you..." text is still inappropriately shown in the explanatory text for the Disabled state rather than on top:F7617232: demo-2019-10-17_12.31.04.webm REPOSITORY R120 Plasma Workspace REVI

D24727: Fix NOAA picture of the day provider

guoyunhe updated this revision to Diff 68185. guoyunhe edited the summary of this revision. guoyunhe added a comment. Change back to the original page URL REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24727?vs=68126&id=68185 BRANCH master REVISIO

D24727: Fix NOAA picture of the day provider

guoyunhe added a comment. In D24727#549199 , @ngraham wrote: > This doesn't fix the problem for me. :( Can you run `plasmashell --replace` in terminal and check the error output? REPOSITORY R114 Plasma Addons REVISION DETAIL https://

D24733: feedback kcm: Make it about Plasma

apol updated this revision to Diff 68184. apol added a comment. update the description with the applicationName change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24733?vs=68181&id=68184 BRANCH nokillswitch REVISION DETAIL https://phabrica

D24713: [Updates page] use fancier logic for handling elided Old+New version strings

This revision was automatically updated to reflect the committed changes. Closed by commit R134:bbc88da3f93c: [Updates page] use fancier logic for handling elided Old+New version strings (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabrica

D24720: [applets/systemtray] Rewrite popups with layouts

ngraham added a comment. Nice, this feels indistinguishible from the current one, which is a good sign. I see what you mean about the Headings in RTL. Does the Kirigami version work properly? If so, I wonder if it might be worth it to just use that instead given that the future of PlasmaComp

D24720: [applets/systemtray] Rewrite popups with layouts

filipf added a comment. Agreed, let's not change the padding. One issue that remains is that headings don't work well with RTL layouts but I can't quite figure out a solution yet. INLINE COMMENTS > ExpandedRepresentation.qml:55 > } else if (activeApplet && hiddenItemsVi

D24733: feedback kcm: Make it about Plasma

ngraham added a comment. Yay, that update fixed the issue, phew! However the strings are still a little garbled: F7616876: Screenshot_20191017_115423.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24733 To: a

D24720: [applets/systemtray] Rewrite popups with layouts

filipf updated this revision to Diff 68182. filipf added a comment. don't alter padding REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24720?vs=68103&id=68182 BRANCH popup-rewrite (branched from master) REVISION DETAIL https://phabricator.kde

D22005: Ensure url from KActivity resources are properly built

ivan added inline comments. INLINE COMMENTS > backend.cpp:322 > while (actionCount < 5 && resultIt != results.end()) { > -const QString resource = (*resultIt).resource(); > +QString resource = (*resultIt).resource(); > +if (QDir::isAbsolutePath(resource)) { `resultIt

D24733: feedback kcm: Make it about Plasma

apol updated this revision to Diff 68181. apol added a comment. Ehm... REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24733?vs=68153&id=68181 BRANCH nokillswitch REVISION DETAIL https://phabricator.kde.org/D24733 AFFECTED FILES kcms/feedba

D24713: [Updates page] use fancier logic for handling elided Old+New version strings

ngraham updated this revision to Diff 68180. ngraham marked an inline comment as done. ngraham added a comment. Fix binding loop REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24713?vs=68098&id=68180 BRANCH fancier-long-version-string-han

D24719: Fix laptop screen being off when opening the lid

This revision was automatically updated to reflect the committed changes. Closed by commit R104:e47dc21a7b78: Fix laptop screen being off when opening the lid (authored by nicolasfella). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24719?vs=68110&id=68179 R

D24740: [Media Controller] Multiple artists support

broulik added inline comments. INLINE COMMENTS > lesf0 wrote in main.qml:61 > That would make much more sence, but (at least for now) `QStringList` is > array-like object and not an actual `Array` instance, and I don't really feel > like I want to mess with all those "is-arrayish >

D24732: Rewrite AppChooser dialog

ngraham added a comment. Give the scrollview a frame and a white background or else apps look cut off and weird and there's a mysteriously hovering scroller: F7616694: Screenshot_20191017_111833.png Also why are there duplicates in here? Finall

D24723: Fix slideshow crashing in invalidate()

davidre added inline comments. INLINE COMMENTS > slidefiltermodel.cpp:51 > +if(sourceModel) { > +connect(sourceModel, &QAbstractItemModel::rowsInserted, this, > &SlideFilterModel::invalidate); > +connect(sourceModel, &QAbstractItemModel::rowsRemoved, this, > &SlideFilterMode

D24732: Rewrite AppChooser dialog

GB_2 added inline comments. INLINE COMMENTS > AppChooserDialog.qml:47 > +horizontalAlignment: Text.AlignHCenter > +text: i18n("Select application to open %1. Other applications > are available in Discover.", fileName) > +textFormat: Text.RichText "Select an application t

D24732: Rewrite AppChooser dialog

jgrulich added a comment. Use Dolphin from Flathub to open some file. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D24732 To: jgrulich, #plasma Cc: ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbam

D24734: [KCM] remove the page indicator dots

broulik added a comment. I don't think the complaints are about the dots, it's a complaint that they're the only means of accessing disabled outputs (discount swiping), which is rectified by the combo box. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24734 To: n

D24740: [Media Controller] Multiple artists support

lesf0 added a comment. > Do you have commit access? If not, I need an E-Mail address so I can land this for you. I don't, you can add my email: me@lxlz.space > Bonus points if you also look at media controls in task manager (the ones when you hover a window): https://cgit.kde.org/p

D24723: Fix slideshow crashing in invalidate()

broulik added inline comments. INLINE COMMENTS > slidefiltermodel.cpp:51 > +if(sourceModel) { > +connect(sourceModel, &QAbstractItemModel::rowsInserted, this, > &SlideFilterModel::invalidate); > +connect(sourceModel, &QAbstractItemModel::rowsRemoved, this, > &SlideFilterMode

D24740: [Media Controller] Multiple artists support

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks for your patch! I am not sure if the property should be perhaps changed to a `property var` and always contain an `Array`. But that would mean changing the tooltip, full represen

D24683: [KWindowSystem] in icon() return realistic icon size

This revision was automatically updated to reflect the committed changes. Closed by commit R130:8339cba19e9a: [KWindowSystem] in icon() return realistic icon size (authored by meven). REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.k

D24727: Fix NOAA picture of the day provider

ngraham added a comment. This doesn't fix the problem for me. :( REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24727 To: guoyunhe, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himc

D24737: Correctly highlight the icon in the system tray

davidedmundson added a comment. Interestingly the very original code was +active: parent.containsMouse || root.capsLock The rationale, I assume was because number lock takes precedent over caps lock in the icon, so this gives you a way of seeing when you have both. Albeit

D24706: Don't use focus color on checkable button backgrounds

ngraham added a comment. Yeah I kind of think this should be a master-only re-think of Breeze's button focus indication in general rather than a targeted 5.17.1 patch. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: ngraham, plasma-

D24733: feedback kcm: Make it about Plasma

ngraham added a comment. It already is: F7616320: Screenshot_20191017_101011.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24733 To: apol, #plasma, vkrause, davidedmundson, ngraham Cc: plasma-devel, LeGast00n, Th

D24733: feedback kcm: Make it about Plasma

apol added a comment. In D24733#549186 , @ngraham wrote: > In D24733#549185 , @apol wrote: > > > It's changed in the last iteration of the patch. You probably enabled the kill switch on the present v

D24721: Show backend name and version in app delegates

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I like the idea behind this but I'm not sure this is the right way to do it. Instead of changing the strings in the backend, we should add the new text (plus icons, preferably)

D24733: feedback kcm: Make it about Plasma

ngraham added a comment. In D24733#549185 , @apol wrote: > It's changed in the last iteration of the patch. You probably enabled the kill switch on the present version of the kcm. Yeah, I did. So now how do I turn it off? 😂 Is there a CLI

D24733: feedback kcm: Make it about Plasma

apol added a comment. It's changed in the last iteration of the patch. You probably enabled the kill switch on the present version of the kcm. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24733 To: apol, #plasma, vkrause, davidedmundson, ngraham Cc: plas

D24683: [KWindowSystem] in icon() return realistic icon size

meven marked 2 inline comments as done. meven added a comment. Anyone to care to review and accept this small code change ? REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D24683 To: meven, #kwin, davidedmundson Cc: anthonyfieroni,

D24733: feedback kcm: Make it about Plasma

ngraham added a comment. Ok, now I see this: F7616194: Screenshot_20191017_095308.png Is that caused by a change here, or did something truly change on my system in the last hour? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabri

D24740: [Media Controller] Multiple artists support

lesf0 created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. lesf0 requested review of this revision. REVISION SUMMARY According to the spec, xesam:artist should be a string array, but majority of players uses string instead. This patch adds support fo

D24732: Rewrite AppChooser dialog

ngraham added a comment. What's the best way to test this out? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D24732 To: jgrulich, #plasma Cc: ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalouka

D24720: [applets/systemtray] Rewrite popups with layouts

ngraham added a comment. In D24720#549139 , @kmaterka wrote: > In D24720#549097 , @kmaterka wrote: > > > Pin button is no longer working,which is surprising :) > > > In fact it is working, but

D24734: [KCM] remove the page indicator dots

ngraham added a comment. I guess we actually have three ways to switch the settings view: - Click on screen in the visualization (currently broken for some use cases) - Use the combobox - Click on one of the page indicator dots Of these three, I think the dots are by far the least

D24738: Highlight the icon in the system tray on mouse over

This revision was automatically updated to reflect the committed changes. Closed by commit R120:532d4da7bfb5: Highlight the icon in the system tray on mouse over (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24738?vs=68150&id=

D24732: Rewrite AppChooser dialog

apol added a comment. +1 looks much better REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D24732 To: jgrulich, #plasma Cc: apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ng

D24720: [applets/systemtray] Rewrite popups with layouts

kmaterka added a comment. In D24720#549097 , @kmaterka wrote: > Pin button is no longer working,which is surprising :) In fact it is working, but there is no background change. Old version had blue background when pinned. REPOSITORY R1

D24734: [KCM] remove the page indicator dots

romangg added a comment. I didn't change mine. And I have mentioned it multiple times before and explicitly in the review request to add the combobox: I see the combobox only as an intermediate solution. By that we have now two different ways of selecting outputs, one through the graphical v

D24734: [KCM] remove the page indicator dots

ngraham added a comment. But Kai changed his mind after reading https://phabricator.kde.org/D24734#549029 :-) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24734 To: ngraham, romangg, broulik, #vdg, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24734: [KCM] remove the page indicator dots

romangg added a comment. I agree with Kai that the dots should stay. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24734 To: ngraham, romangg, broulik, #vdg, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngr

D24683: [KWindowSystem] in icon() return realistic icon size

meven marked 5 inline comments as done. meven added inline comments. INLINE COMMENTS > anthonyfieroni wrote in windowsystem.cpp:173 > That's adjustment, 16, 32, 48, 64, 128, 256 are standard icon sizes, when you > got a value between 2 sizes you adjust it by lower bound. Say (256 - 128) / 2 > =

D24720: [applets/systemtray] Rewrite popups with layouts

ngraham added a comment. +1, let;s not change the paddings here. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24720 To: filipf, #plasma, #vdg Cc: ngraham, kmaterka, mart, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Z

D24691: Add support for WPA3

jgrulich updated this revision to Diff 68155. jgrulich added a comment. Simplify code REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24691?vs=68036&id=68155 BRANCH wpa3 REVISION DETAIL https://phabricator.kde.org/D24691 AFFEC

D24734: [KCM] remove the page indicator dots

ngraham added a comment. D24735 just landed; can you and or @romangg approve this if you're okay with it? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24734 To: ngraham, romangg, broulik, #vdg, #plasma Cc: plasma-devel, LeGast

D24720: [applets/systemtray] Rewrite popups with layouts

kmaterka added a comment. Pin button is no longer working,which is surprising :) About padding: I would vote for **not** changing padding nor margins, at least not in this change. It will be easier to review and test it you split this into two changes. This popup size is pretty small, if

D24733: feedback kcm: Make it about Plasma

apol updated this revision to Diff 68153. apol marked an inline comment as done. apol added a comment. Remove duplicated text, disable when the kill switch is on REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24733?vs=68135&id=68153 BRANCH nokil

D24715: Show a message indicating that no TB devices are connected when the list is empty

This revision was automatically updated to reflect the committed changes. Closed by commit R1044:cf47147b3c2b: Show a message indicating that no TB devices are connected when the list is… (authored by ngraham). REPOSITORY R1044 Plasma Thunderbolt Integration CHANGES SINCE LAST UPDATE https:/

D24738: Highlight the icon in the system tray on mouse over

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24738 To: kmaterka, #plasma, davidedmundson, #plasma_workspaces, broulik Cc: bro

D24738: Highlight the icon in the system tray on mouse over

kmaterka created this revision. kmaterka added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Icon should be highlighted hover, as any other icons in the system tray. CC

D24735: Gracefully replace outputModel

This revision was automatically updated to reflect the committed changes. Closed by commit R104:2ab4c2f136c5: Gracefully replace outputModel (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24735?vs=68145&id=68149#toc REPOSITORY R104 KScreen CHANGES SINCE LAST UPD

D24735: Gracefully replace outputModel

romangg added a comment. 5.17 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24735 To: broulik, #plasma, romangg, davidedmundson Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai,

D24735: Gracefully replace outputModel

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. In D24735#549048 , @broulik wrote: > I call `release()` instead of `get()` so I reset the pointer to null so that when I signal `outputModel

D24737: Correctly highlight the icon in the system tray

kmaterka created this revision. kmaterka added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Icon is highlighted when CapsLock or NumLock are locked. It should not be used

D24735: Gracefully replace outputModel

broulik added a comment. I call `release()` instead of `get()` so I reset the pointer to null so that when I signal `outputModelChanged` it returns `null` and QtQuick resets everything and only then I delete it. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24735

D24735: Gracefully replace outputModel

broulik updated this revision to Diff 68145. broulik added a comment. - Delete the old model REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24735?vs=68141&id=68145 REVISION DETAIL https://phabricator.kde.org/D24735 AFFECTED FILES kcm/kcm.cpp To: brou

D24735: Gracefully replace outputModel

ngraham added a comment. For me this fixes the crash when unplugging a screen with the KCM open, FWIW. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24735 To: broulik, #plasma, romangg, davidedmundson Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh

D24735: Gracefully replace outputModel

broulik added a comment. Oh I'm an idiot, I forgot to delete the model. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24735 To: broulik, #plasma, romangg, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D24735: Gracefully replace outputModel

davidedmundson added a comment. Urgh, so the order of events is: KCMKScreen::~KCMKScreen() <-- deletes the config and exposed properties KCModuleQML::~KCModuleQML() <-- tears down the UI, which now references dangling things. I think thats's a sign of a more generic that it would b

D24735: Gracefully replace outputModel

broulik added a comment. > But just destroying and recreating is much simpler. ;) And causes crashes by leaving things on the QML side in an inconsistent state. Not sure `deleteLater` will help you since `GetConfigOperation()` could take longer than that. We could perhaps delete the

D24735: Gracefully replace outputModel

romangg added a comment. But just destroying and recreating is much simpler. ;) Regarding the change: if we release without delete afterwards we leak memory. Maybe deleteLater? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24735 To: broulik, #plasma, romangg,

D24734: [KCM] remove the page indicator dots

broulik added a comment. Alright, convinced. See D24735 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24734 To: ngraham, romangg, broulik, #vdg, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2

D24734: [KCM] remove the page indicator dots

ngraham added a comment. Ok. However once you deem the combobox perfectly reliably I would like to remove these. They're redundant; their function is to give you a clickable method to change a swipe view's pages, but you've added a combobox which already provides that. We don't need two

D24735: Gracefully replace outputModel

broulik created this revision. broulik added reviewers: Plasma, romangg, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This patch has it signal the disappearance of the `outputModel` and only t

D24732: Rewrite AppChooser dialog

jgrulich added a comment. Is this better? F7615448: Screenshot_20191017_155608.png REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D24732 To: jgrulich, #plasma Cc: ognarb, plasma-devel, L

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68140. jgrulich added a comment. Add text to the button rather then using tooltip REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68137&id=68140 BRANCH new-app-dialog REV

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#548992 , @ognarb wrote: > I would add text on the button e.g "Show more", otherwise it's quite difficult to know how to show more apps There is a tooltip, but maybe showing text next to it might be bett

D24734: [KCM] remove the page indicator dots

broulik added a comment. I would prefer they stay in. It's a swiping sliding view, they do no harm. Also I'm having trouble with the `ComboBox` right now, please hold this for now. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24734 To: ngraham, romangg, broulik

D24732: Rewrite AppChooser dialog

ognarb added a comment. I would add text on the button e.g "Show more", otherwise it's quite difficult to know how to show more apps REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D24732 To: jgrulich, #plasma Cc: ognarb, plasma-de

D24734: [KCM] remove the page indicator dots

ngraham created this revision. ngraham added reviewers: romangg, broulik, VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Now that D24687 has landed, settings p

D24732: Rewrite AppChooser dialog

jgrulich added a comment. This is the initial state of the dialog, which presents only apps associated with given mimetype. Then if you click at the button below, it will show all the apps and provide a search bar. F7615342: Screenshot_20191017_154506.png

D24688: [KCM] Disallow dropping screen outside of reachable area

ngraham added a comment. +1 for auto-zoom and making the screens bigger. Then we can remove the buttons that centers the view too. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24688 To: broulik, #plasma, #vdg, romangg Cc: ngraham, mart, plasma-devel, LeGast00n, T

D24719: Fix laptop screen being off when opening the lid

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. 👍 5.17 REPOSITORY R104 KScreen BRANCH fixit REVISION DETAIL https://phabricator.kde.org/D24719 To: nicolasfella, #plasma, romangg Cc: plasma-devel, LeGast00n, The-Feren-OS-De

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68137. jgrulich added a comment. Do not duplicate desktop files REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68134&id=68137 BRANCH new-app-dialog REVISION DETAIL htt

D24733: feedback kcm: Make it about Plasma

ngraham added a comment. Indeed, this is much nicer. The explanatory text for "Disabled" appears to duplicate some of the text above it though: F7615296: Screenshot_20191017_074048.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://p

D24733: feedback kcm: Make it about Plasma

davidedmundson added a comment. +++ INLINE COMMENTS > feedback.h:31 > > -Q_PROPERTY(bool feedbackEnabled READ feedbackEnabled WRITE > setFeedbackEnabled NOTIFY feedbackEnabledChanged) > Q_PROPERTY(int plasmaFeedbackLevel READ plasmaFeedbackLevel WRITE > setPlasmaFeedbackLevel NOT

  1   2   >