D24615: Fix crash with sortAllByName/Description

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. it seems ok for me. Thanks REPOSITORY R103 KMenu Editor BRANCH ahmad/takechildren-crash-on-index-rootItem (branched from master) REVISION DETAIL https://phabricator.kde.org/D24

D24623: Missing links to pagepool source files

camiloh created this revision. camiloh added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REVISION SUMMARY failing to build on android with qmake REPOSITORY R169 Kirigami BRANCH missing_pri_

D24454: Include an emoji picker

apol added a comment. In D24454#546320 , @davidedmundson wrote: > > Why isn't it managing to send the paste data to klipper before quitting? > > How? > > 1. We announce "I have some new data" to X. > 2. Then klipper sees that, then asks

D24616: [applets/systemtray] Remove unused imports

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Could also port entirely away from PlasmaComponents and PlasmaExtras without too much effort. I suppose that's best done on a separate patch though. REPOSITORY R120 Plasma Workspace BR

D24616: [applets/systemtray] Remove unused imports

filipf updated this revision to Diff 67857. filipf added a comment. remove some more REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24616?vs=67856&id=67857 BRANCH systray-remove-unused-imports (branched from master) REVISION DETAIL https://ph

D24616: [applets/systemtray] Remove unused imports

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH systray-remove-unused-imports (branched from master) REVISION DETAIL https://phabricator.kde.org/D24616

D24615: Fix crash with sortAllByName/Description

ahmadsamir created this revision. ahmadsamir added a reviewer: mlaurent. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahmadsamir requested review of this revision. REVISION SUMMARY Calling QTreeWidgetItem::takeChildren() on invisibleRootItem() results in a crash bec

D24614: Micro optimizations

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY Add some const & for things that return const & so there's no need to make a copy Add a std::move for a thing that we pass by copy an

D24011: Provide a telemetrics kcm module for Plasma

davidedmundson added a comment. Lets all follow up here: https://bugs.kde.org/show_bug.cgi?id=412913 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24011 To: apol, #plasma, vkrause, ngraham Cc: GB_2, aspotashev, ngraham, bcooksley, davidedmundson, ognarb, b

D24613: Use a lighter star color for non-default devices

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Since announcing the relevant feature, user feedback has indicated that people prefer for the star

D24591: Set preview to correct device size

This revision was automatically updated to reflect the committed changes. Closed by commit R123:9e0f84672748: Set preview to correct device size (authored by davidedmundson). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24591?vs=67788&

D24607: Fix showing menu toolbutton when no drawer is available

nicolasfella updated this revision to Diff 67841. nicolasfella added a comment. - Check if isMenu is undefined REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24607?vs=67839&id=67841 BRANCH veggie REVISION DETAIL https://phabricator.kde.org/D24607 AF

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 17 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/17/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 13 Oct 2019 12:50:36 + Build duration: 18 min and counting CONSOLE OUTPUT [...truncate

D24601: [mobile/wifi] Use network name as title for settings page

nicolasfella added inline comments. INLINE COMMENTS > apol wrote in ConnectionItemDelegate.qml:114 > Just make it `title: ItemUniqueName` That doesn't seem to work REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24601 To: nicolasfella, jgrulic

D24607: Fix showing menu toolbutton when no drawer is available

GB_2 added a comment. Love the test plan 😂 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D24607 To: nicolasfella, mart Cc: GB_2, plasma-devel, fbampaloukas, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein

D24607: Fix showing menu toolbutton when no drawer is available

nicolasfella created this revision. nicolasfella added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN KCMs are vegan now REPOSITORY R169 Kirigami BRANCH veggie REVISION DETAIL https:/

D24603: Port away from deprecated KDELibs4Support

This revision was automatically updated to reflect the committed changes. Closed by commit R103:e3b8910670e3: Port away from deprecated KDELibs4Support (authored by ahmadsamir). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24603?vs=67820&id=67831 REVIS

D24603: Port away from deprecated KDELibs4Support

vkrause accepted this revision. vkrause added a comment. Thanks! REPOSITORY R103 KMenu Editor BRANCH master REVISION DETAIL https://phabricator.kde.org/D24603 To: ahmadsamir, mlaurent, vkrause Cc: vkrause, plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fba