D24127: Fix toggle button colours

2019-09-21 Thread Noah Davis
ndavis added a comment. In D24127#535826 , @cblack wrote: > In D24127#53 , @ndavis wrote: > > > @cblack Can you change the focus state to only have a blue outline? This behavior is really confusi

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

2019-09-21 Thread Kishore Gopalakrishnan
kishoreg added a comment. @ngraham There are no issues on the login screen. Everything fits fine there. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23786 To: kishoreg, #plasma, #vdg, ngraham Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

2019-09-21 Thread Nathaniel Graham
ngraham added a comment. @kishoreg since you have a smaller display handy, does the same thing happen on the login screen? If so, can you also apply the same fix to it in this patch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23786 To: kishoreg, #plasm

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

2019-09-21 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Still LGTM. @filipf or anyone else in #VDG or #plasma , are there any objections to this patch in its current form? REPOSITORY R120 Plasma Workspace RE

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

2019-09-21 Thread Kishore Gopalakrishnan
kishoreg updated this revision to Diff 66601. kishoreg added a comment. Rebase on `Plasma/5.17` branch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23786?vs=65896&id=66601 REVISION DETAIL https://phabricator.kde.org/D23786 AFFECTED FILES lo

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

2019-09-21 Thread Nathaniel Graham
ngraham added a comment. LGTM but can you rebase it on the `Plasma/5.17` branch please? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23786 To: kishoreg, #plasma, #vdg, ngraham Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbam

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

2019-09-21 Thread Kishore Gopalakrishnan
kishoreg added a comment. Is this fine, or should I revert to the previous diff I uploaded? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23786 To: kishoreg, #plasma, #vdg, ngraham Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24127: Fix toggle button colours

2019-09-21 Thread Nathaniel Graham
ngraham added a comment. Weird, this happens with the regular old breeze color scheme for me. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24127 To: cblack, #breeze, ndavis, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalouk

D24127: Fix toggle button colours

2019-09-21 Thread Carson Black
cblack added a comment. In D24127#535551 , @ngraham shared an image: > F7398590: Screenshot_20190920_194959.png That doesn't match the color of what I have on my machine. F7405543: image.png

D24127: Fix toggle button colours

2019-09-21 Thread Carson Black
cblack added a comment. In D24127#53 , @ndavis wrote: > @cblack Can you change the focus state to only have a blue outline? This behavior is really confusing, even though it seems consistent with Breeze: F7398663: gtk_togglebuttons-2019-09-2

D24122: [GTK3] Generate Breeze Light assets

2019-09-21 Thread Carson Black
cblack added a comment. Filed a bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1006573 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24122 To: cblack, #breeze Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, r

D24124: [GTK3] Inactive windows now show button hover decoration

2019-09-21 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R98:91b89373cd69: [GTK3] Inactive windows now show button hover decoration (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24124?vs=66565&id=6

D24126: [GTK3] CSD windows show handles on .solid-csd

2019-09-21 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R98:5ded281f8e5f: [GTK3] CSD windows show handles on .solid-csd (authored by cblack, committed by ngraham). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24126?vs

D21860: Set a font for gtk applications in the fonts kcm

2019-09-21 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 66597. gikari added a comment. Make the daemon independent Remove explicit call from the fonts kcm and make the daemon update font configuration automatically REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

2019-09-21 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > Screen.qml:51 > +Kirigami.Theme.colorSet: Kirigami.Theme.View > +Kirigami.Theme.inherit: false > + You actually don't need these two lines, because a framed scrollview uses the view background color by default anyway REPOSITORY R104 KS

KFusion style

2019-09-21 Thread René J . V . Bertin
Hi, A while back I asked for some guidance in getting the Fusion style to inherit KStyle. Apparently there was no real interest in doing such a thing so in the end I rolled my own implementation, using a private, adapted copy of the KStyle class. Contrary to that I thought, you cannot override

D24130: Remove unused include

2019-09-21 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN builds REPOSITORY R120 Plasma Workspace BRANCH icl REVISION DETAIL https://phabri

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

2019-09-21 Thread Björn Feber
GB_2 updated this revision to Diff 66577. GB_2 added a comment. Fix more REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24129?vs=66576&id=66577 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24129 AFFECTED FILES kcm/package/contents/ui/

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

2019-09-21 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY F7401179: Fixed Display Configuration KCM Clipping.png The ol

D23783: [kcm] Fix i18n output file name and split texts

2019-09-21 Thread Victor Ryzhykh
victorr added a comment. In D23783#535434 , @victorr wrote: > Need to add this patch. > F7397510: kscreen-5.16.90.patch Need to fix the wrong -DTRANSLATION_DOMAIN REPOSITORY R104 KScreen REVISI