D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. Yeah, please do file a bug on Chromium. I'm hesitant to approve this because once we create a "Breeze Light" GTK theme, will we actually be able to remove it? Also, is the number of people who know that you'll need to use this new GTK theme to solve that specific

D24127: Fix toggle button colours

ngraham added a comment. Yeah, it's definitely more obvious in Breeze dark, but I've always felt that a more colorful color was appropriate for the default button. Maybe it's just my history in macOS, where it's been like that for 20 years, but I've always appreciated being able to visually

D24127: Fix toggle button colours

ndavis added a comment. In D24127#535558 , @ngraham wrote: > In D24127#53 , @ndavis wrote: > > > This behavior is really confusing, even though it seems consistent with Breeze > > > I reall

D24127: Fix toggle button colours

ngraham added a comment. In D24127#53 , @ndavis wrote: > This behavior is really confusing, even though it seems consistent with Breeze I really dislike this about Breeze itself and would welcome a fix there too. Then maybe we can ma

D24127: Fix toggle button colours

ndavis added a comment. In the beginning of the video where it looks like I'm just hovering, I'm actually clicking once a second. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24127 To: cblack, #breeze, ndavis, ngraham Cc: ngraham, plasma-devel, LeGast00n, T

D24127: Fix toggle button colours

ndavis added a comment. @cblack Can you change the focus state to only have a blue outline? This behavior is really confusing, even though it seems consistent with Breeze: F7398663: gtk_togglebuttons-2019-09-20_21.55.35.webm REPOSITORY R98 Breeze for

D24127: Fix toggle button colours

ndavis added a comment. Ah, I only tested Breeze Dark, which uses the same white text color for everything. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24127 To: cblack, #breeze, ndavis, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jrale

D24127: Fix toggle button colours

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I was actually just about to report this, hah. The text color for the checked state looks too light for Breeze and Breeze light though: F7398590: Screenshot_20190920_194959.png

D24127: Fix toggle button colours

cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Toggle button colors are now correct. REPOSITORY R98 Breeze for Gtk BRANCH fix-toggle-state (br

D24123: [GTK3] Fix menu bugs

ngraham added a comment. Which patch does fix https://bugs.kde.org/show_bug.cgi?id=412078 then? It was listed as one of the fixed bugs in your original combined-together patch. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24123 To: cblack, #breeze, ngraham

D24126: [GTK3] CSD windows show handles on .solid-csd

ngraham accepted this revision. ngraham added a comment. Yep, fixed in Gedit too now. REPOSITORY R98 Breeze for Gtk BRANCH window-handle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24126 To: cblack, #breeze, ngraham, ndavis Cc: ngraham, ndavis, plasma-devel, Le

D24125: [GTK3] Scrollbars now have proper states

ndavis added a comment. Sliders look fixed, but the scrollbar still isn't right. The scrollbar should have the same groove color as the sliders. const auto color( _helper->alphaColor( palette.color( QPalette::WindowText ), 0.3 * (animated ? opacity : 1) ) ); If animated, use anima

D24125: [GTK3] Scrollbars now have proper states

ngraham added a comment. Now with Breeze Light, the scrollbar handle is back to being dark when the window is inactive. :) REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24125 To: cblack, #breeze, ngraham Cc: ndavis, ngraham, plasma-devel, LeGast00n, The-Fere

D24125: [GTK3] Scrollbars now have proper states

cblack updated this revision to Diff 66573. cblack added a comment. Fix sliders REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24125?vs=66572&id=66573 BRANCH fix-scrollbar-states (branched from master) REVISION DETAIL https://phabricator.kde.org

D24125: [GTK3] Scrollbars now have proper states

ndavis added a comment. Nothing changed REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24125 To: cblack, #breeze, ngraham Cc: ndavis, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesl

D24126: [GTK3] CSD windows show handles on .solid-csd

ndavis added a comment. Looks fixed on my end REPOSITORY R98 Breeze for Gtk BRANCH window-handle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24126 To: cblack, #breeze, ngraham Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalouk

D24125: [GTK3] Scrollbars now have proper states

cblack updated this revision to Diff 66572. cblack added a comment. Swap out colors REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24125?vs=66569&id=66572 BRANCH fix-scrollbar-states (branched from master) REVISION DETAIL https://phabricator.kde

D24125: [GTK3] Scrollbars now have proper states

ndavis added a comment. I think the alpha levels need to be swapped. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24125 To: cblack, #breeze, ngraham Cc: ndavis, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenB

D24125: [GTK3] Scrollbars now have proper states

ndavis added a comment. F7398276: Screenshot_20190920_210750.png F7398279: Screenshot_20190920_210811.png The slider backgrounds are too bright on Breeze REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D24126: [GTK3] CSD windows show handles on .solid-csd

cblack added a comment. In D24126#535497 , @ngraham wrote: > Actually now that I look closely I still see the transparent pixel in the corner from a transparent border radius: F7397916: Screenshot_20190920_175233.png

D24126: [GTK3] CSD windows show handles on .solid-csd

cblack updated this revision to Diff 66571. cblack added a comment. Add selectors for applications like gedit that do not have headerbar as direct child of window REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24126?vs=66568&id=66571 BRANCH window

D24123: [GTK3] Fix menu bugs

cblack added a comment. In D24123#535491 , @ngraham wrote: > Does this fix https://bugs.kde.org/show_bug.cgi?id=412078? I can't reproduce it myself so I can't tell. This patch doesn't touch any of the style nodes that would be affecting t

D24123: [GTK3] Fix menu bugs

This revision was automatically updated to reflect the committed changes. Closed by commit R98:51384880cb21: [GTK3] Fix menu bugs (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24123?vs=66564&id=66570 REVISION DETAIL https://phabr

D24125: [GTK3] Scrollbars now have proper states

cblack updated this revision to Diff 66569. cblack added a comment. Fix alpha values REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24125?vs=66566&id=66569 BRANCH fix-scrollbar-states (branched from master) REVISION DETAIL https://phabricator.kd

D24125: [GTK3] Scrollbars now have proper states

ndavis added a comment. Actually, not sure if this code works how I think it works. 0.2 should actually be less dark than 0.3 if I understand it correctly. This is the code in the Breeze QStyle: const auto grooveColor( _helper->alphaColor( palette.color( QPalette::WindowText ), 0.

D24125: [GTK3] Scrollbars now have proper states

ndavis added inline comments. INLINE COMMENTS > _scrollbar.scss:123 > &:backdrop { > -background-color: $scrollbar_color_backdrop; > +background-color: gtkalpha($scrollbar_color_backdrop, 0.2); > } This needs to be 0.3 to match the Breeze QStyle REPOSITORY R98 Bree

D24126: [GTK3] CSD windows show handles on .solid-csd

ngraham added a comment. Actually now that I look closely I still see the transparent pixel in the corner from a transparent border radius: F7397916: Screenshot_20190920_175233.png REPOSITORY R98 Breeze for Gtk BRANCH window-handle (branched from m

D24122: [GTK3] Generate Breeze Light assets

cblack added a comment. In D24122#535494 , @ngraham wrote: > (BTW It would be nice if that information were spelled out clearly in the Test Plan section :) ) > > Oh, gross. Better than nothing I guess, if it's impossible to fix the bug any o

D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. (BTW It would be nice if that information were spelled out clearly in the Test Plan section :) ) Oh, gross. Better than nothing I guess, if it's impossible to fix the bug any other way. On the other hand, this feels like it kind of partially defeats the point of

D24123: [GTK3] Fix menu bugs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Does this fix https://bugs.kde.org/show_bug.cgi?id=412078? I can't reproduce it myself so I can't tell. REPOSITORY R98 Breeze for Gtk BRANCH fix-menu-curve (branched from master) RE

D24122: [GTK3] Generate Breeze Light assets

cblack added a comment. In D24122#535486 , @ngraham wrote: > Window decoration buttions in Chromium with CSDs and the Breeze Light color scheme don't show any difference with the patch applied and deployed. This isn't elegant, but it's be

D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. Window decoration buttions in Chromium with CSDs and the Breeze Light color scheme don't show any difference with the patch applied and deployed. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24122 To: cblack, #breeze Cc: ngraham, pl

D24125: [GTK3] Scrollbars now have proper states

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, I don't think this is the right fix. Now active scrollbars look much too dark compared to the QWidgets version (at least with a breeze-not-dark color scheme): F7397832: Scr

D24122: [GTK3] Generate Breeze Light assets

cblack added a comment. In D24122#535474 , @ngraham wrote: > Hmm, this doesn't seem to work for me. Could you elaborate? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24122 To: cblack, #breeze Cc: ngraha

D24126: [GTK3] CSD windows show handles on .solid-csd

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Sweet, this is a great usability fix. REPOSITORY R98 Breeze for Gtk BRANCH window-handle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24126 To: cblack, #bre

D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. Hmm, this doesn't seem to work for me. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24122 To: cblack, #breeze Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesj

D24126: [GTK3] CSD windows show handles on .solid-csd

cblack updated this revision to Diff 66568. cblack added a comment. Remove superfluous border radius REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24126?vs=66567&id=66568 BRANCH window-handle (branched from master) REVISION DETAIL https://phabr

D24126: [GTK3] CSD windows show handles on .solid-csd

ndavis added a comment. > F7397003: image.png What is that white dot in the corner? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24126 To: cblack, #breeze Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jral

D24126: [GTK3] CSD windows show handles on .solid-csd

cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY CSD windows will now show 5px handles on windows with .solid-csd (CSD windows in window managers tha

D24125: [GTK3] Scrollbars now have proper states

cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Scrollbars now use the proper colours for active and inactive windows. TEST PLAN Scrollbars before

D24124: [GTK3] Inactive windows now show button hover decoration

cblack created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Buttons on unfocused windows now show a focus decorator when hovered over. REPOSITORY R98 Breeze for Gtk BRANCH inactive-button-

D23783: [kcm] Fix i18n output file name and split texts

victorr added a comment. Need to add this patch. F7397510: kscreen-5.16.90.patch REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D23783 To: romangg, #plasma, victorr, yurchor Cc: aspotashev, ltoscano, zzag, pino, plasma-devel,

D24123: [GTK3] Fix menu highlights being curved

cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY GtkMenus no longer have a curved highlight. TEST PLAN Menu, before: F7396971: image.png

D24122: [GTK3] Generate Breeze Light assets

cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Breeze Light assets are now generated to allow bypassing a bug with Chromium where recolorable icons

D24121: [GTK3] Assorted bugfixes

ngraham added a comment. +1, please split. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24121 To: cblack, #breeze Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai

D24121: [GTK3] Assorted bugfixes

ndavis added a comment. Could you separate these into different patches? It's generally not good practice to land a bunch of unrelated changes in one commit. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24121 To: cblack, #breeze Cc: ndavis, plasma-devel, Le

D24121: [GTK3] Assorted bugfixes

cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This patch includes a series of assorted bugfixes. - Menus no longer have a curved highlight unl

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 45 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/45/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 20 Sep 2019 18:49:26 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 0 tes

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.12 - Build # 27 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.12/27/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 20 Sep 2019 18:48:16 + Build duration: 2 min 38 sec and counting JUnit Tests Name: (root) Fai

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.13 - Build # 11 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.13/11/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Sep 2019 18:48:13 + Build duration: 1 min 21 sec and counting JUnit Tests Name: proj

D24110: Enable removing multiple devices at once

ngraham added a comment. Done in c020ce51a0d6861ce75856f0165bd5cd8bd5508f ; you can rebase and copy the format now. REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D24110 To: umanovskis, #vdg

D24110: Enable removing multiple devices at once

umanovskis added inline comments. INLINE COMMENTS > ngraham wrote in devices.cpp:235 > Need to override the button titles so they say "Remove" and "Cancel". "Yes" > and "No" are never acceptable dialog button text. > > Also, are you sure this needs a confirmation dialog at all? These are usuall

D23378: Check if sddm user exists

filipf updated this revision to Diff 66544. filipf added a comment. Address David's comment, remove one entry from the map REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23378?vs=65000&id=66544 BRANCH sddm-user-check (branched from

D24110: Enable removing multiple devices at once

ngraham added reviewers: VDG, Plasma. ngraham added inline comments. INLINE COMMENTS > devices.cpp:235 > +if (KMessageBox::questionYesNo(this, i18n("Are you sure that you want to > remove %1 devices from the list of known devices?", indexes.size()), > + i18n

D24110: Enable removing multiple devices at once

ngraham added a comment. Sorry, I totally missed that there's already a confirmation dialog when removing a device. It's fine to add a new one; we can make all of this better with an undo stack in a future commit. For now I will push a commit that improves the UX of the existing message box,

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham added a comment. @davidedmundson this missed 5.17. I could still use a hand with the changes you requested to land this in 5.18. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23158 To: ngraham, #vdg, #plasma, davidedmundson, GB_2, hein Cc: hein, GB_

D24110: Enable removing multiple devices at once

umanovskis added a comment. Screenshot of the new action: F7393590: image.png REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D24110 To: umanovskis Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D24110: Enable removing multiple devices at once

umanovskis created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. umanovskis requested review of this revision. REVISION SUMMARY With the device list only allowing one item to be selected, removing many devices takes a lot of clicking. Allowing multiple

D24108: [Kicker] Add guards for appletInterface

This revision was automatically updated to reflect the committed changes. Closed by commit R120:54a53bc40948: [Kicker] Add guards for appletInterface (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24108?vs=66526&id=66531 REVISI

D24108: [Kicker] Add guards for appletInterface

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY They were present in most cases but missing in some. TEST PLAN Can now use Kicker backend