Re: Plasma 5.12.9 LTS

On Wed, Sep 11, 2019 at 9:20 PM Vlad Zagorodniy wrote: > > On 9/11/19 9:39 PM, Christoph Feck wrote:> sizeInBytes() can be emulated > with bytesPerLine() * height(). > > The issue is already fixed. Please roll out new tar. > > > Would it be possible to adopt the convention "tars are announced a fe

D23712: [Cuttlefish] Overhaul program, use Kirigami

ngraham added a comment. Ctrl+Q no longer quits the program now. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack, #vdg, ngraham Cc: GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, plasma-devel, #vdg, LeGast00n, The-Feren-OS

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

kishoreg updated this revision to Diff 65896. kishoreg added a comment. @filipf Is this better? Screenshot on small display (1366x768): F7342190: Screenshot_20190912_082244.png Screenshot on big display (1920x1080): F7342191: Screenshot_2019091

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 65895. cblack added a comment. Passive notification on clipboard copy REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65894&id=65895 BRANCH modernization (branched from master) REVISION DETAIL https://ph

D23389: Use "Make default" buttons to switch the default device

ngraham added a comment. If possible I'd like target this for Plasma 5.17, which branches in 8 days, and I'd appreciate a review from @drosca or a #plasma person first. REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D23389 REVISION

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 65894. cblack added a comment. Port to QQmlApplicationEngine REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65893&id=65894 BRANCH modernization (branched from master) REVISION DETAIL https://phabricator

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 65893. cblack added a comment. Sidebar updates REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65878&id=65893 BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D2371

D23389: Use "Make default" buttons to switch the default device

ngraham updated this revision to Diff 65892. ngraham added a comment. Remove remaining FIXME because it's now fixed REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23389?vs=65891&id=65892 BRANCH arcpatch-D23389 REVISION DETAIL https:

D23389: Use "Make default" buttons to switch the default device

ngraham updated this revision to Diff 65891. ngraham added a comment. Used filled stars everywhere REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23389?vs=65888&id=65891 BRANCH arcpatch-D23389 REVISION DETAIL https://phabricator.kde

D23389: Use "Make default" buttons to switch the default device

ndavis added a comment. I find the use of filled and empty stars visually odd. They're like Jerry-rigged radio buttons that look like PushButtons. We also can't guarantee that `star-shape` will be empty and `favorite` will be filled in 3rd party icon themes. REPOSITORY R115 Plasma Audio V

D23389: Use "Make default" buttons to switch the default device

ngraham updated this revision to Diff 65888. ngraham marked an inline comment as done. ngraham added a comment. - Fix it by using `Button` from PlasmaComponents3, which handles exclusive checkable state properly (it's impossible to do with PC2) - Use an outline-style star for the non-default

D23712: [Cuttlefish] Overhaul program, use Kirigami

ngraham added a comment. Some general comments: - Try to use QML Layouts as much as possible; for the most part, everything should be in a layout. - Anytime you're tempted to create a `Rectangle` with `color: "transparent"`, don't. Just use an `Item` instead. But you may not even need

D22885: Add global animation speed slider to workspace options KCM

davidedmundson updated this revision to Diff 65886. davidedmundson added a comment. update names as per discussion REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22885?vs=63844&id=65886 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D23876: [applets/kickoff] Tweak padding for lists

filipf planned changes to this revision. filipf added a comment. In D23876#529485 , @ngraham wrote: > Better, but now the padding is inconsistent between the sides and bottom: F7340987: Screenshot_20190911_085301.png

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

davidedmundson added a comment. From my header: /** - Performs direct system actions that could kill the session * - Semi-internal. Symbols exported, but not the header - To be used only by the daemon that performs logout (currently ksmserver) * - All other users should go via t

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

davidedmundson added a comment. what for? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23883 To: heikobecker, #plasma Cc: davidedmundson, asturmlechner, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, him

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 65878. cblack added a comment. Return of the sidebar REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65877&id=65878 BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 65877. cblack added a comment. Wording change REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65876&id=65877 BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 65876. cblack added a comment. Reorder menu items REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65875&id=65876 BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 65875. cblack added a comment. Add option to take screenshot of both light/dark at once REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65874&id=65875 BRANCH modernization (branched from master) REVISION D

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 65874. cblack added a comment. Add colorscheme changer REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65530&id=65874 BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.o

Re: Plasma 5.12.9 LTS

On 9/11/19 9:39 PM, Christoph Feck wrote:> sizeInBytes() can be emulated with bytesPerLine() * height(). The issue is already fixed. Please roll out new tar. Would it be possible to adopt the convention "tars are announced a few days before the tag/release" used by Frameworks and Applications

Re: Plasma 5.12.9 LTS

On 09/11/19 19:35, Rik Mills wrote: On 10/09/2019 17:21, Jonathan Riddell wrote: Plasma 5.12.9 LTS is now released https://www.kde.org/announcements/plasma-5.12.9.php Kwin to fails to build with Qt 5.9. Plasma 5.12 should build with 5.9. /effects/screenshot/screenshot.cpp:110:15: error: ‘co

D23876: [applets/kickoff] Tweak padding for lists

ngraham added a comment. I'm talking about the margins outside the selection highlight effect, which should be equal on the bottom as on the sides. I hadn't even noticed the difference in margins within the selection highlight lol (and yes, I do use non-default fonts and sizes: 11pt Ubuntu f

Re: Plasma 5.12.9 LTS

On 10/09/2019 17:21, Jonathan Riddell wrote: > Plasma 5.12.9 LTS > is now released https://www.kde.org/announcements/plasma-5.12.9.php Kwin to fails to build with Qt 5.9. Plasma 5.12 should build with 5.9. /effects/screenshot/screenshot.cpp:110:15: error: ‘const class QImage’ has no member name

D23845: Add a mode to center actions and omit the title when using a ToolBar style

ngraham updated this revision to Diff 65866. ngraham added a comment. Fix typo REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23845?vs=65864&id=65866 BRANCH optional-centered-actions-with-no-title (branched from master) REVISION DETAIL https://phabri

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. TEST PLAN header gets installed, plasma-workspace builds fine against a previously and separately built libkworkspace REPOSITORY R120 Pl

D23845: Add a mode to center actions and omit the title when using a ToolBar style

ngraham added a comment. Thanks, hopefully this is better. Now there's a Qt.Alignment property. Not sure what you mean about the icon position enum though. Would appreciate clarification. REPOSITORY R169 Kirigami BRANCH optional-centered-actions-with-no-title (branched from master) REV

D23845: Add a mode to center actions and omit the title when using a ToolBar style

ngraham updated this revision to Diff 65864. ngraham marked 2 inline comments as done. ngraham added a comment. Make it better REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23845?vs=65790&id=65864 BRANCH optional-centered-actions-with-no-title (branche

D23877: Remove unneeded dependencies on X11 and QtX11Extras

This revision was automatically updated to reflect the committed changes. Closed by commit R123:b6d6897bad6f: Remove unneeded dependencies on X11 and QtX11Extras (authored by heikobecker). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D23768: Set maximum volume of streams properly even if the user has configured a maximum volume <100% in the applet.

This revision was automatically updated to reflect the committed changes. Closed by commit R115:f20b6b15ba96: Set maximum volume of streams properly even if the user has configured a… (authored by kishoreg, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UP

D23768: Set maximum volume of streams properly even if the user has configured a maximum volume <100% in the applet.

ngraham added a comment. All right, makes sense. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23768 To: kishoreg, ngraham, romangg, #plasma, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pi

D23878: Use QTEST_GUILESS_MAIN for systeminformationtest

heikobecker created this revision. heikobecker added reviewers: Plasma, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY The test still works fine with it, allowing it to run without a display serve

D23845: Add a mode to center actions and omit the title when using a ToolBar style

mart added a comment. Like the concept, API may need a bit of improvement INLINE COMMENTS > PageRow.qml:146 > * * showNavigationButtons: OR flags combination of > ApplicationHeaderStyle.ShowBackButton and > ApplicationHeaderStyle.ShowForwardButton > + * * toolbarButtonsCenteredWit

D23877: Remove unneeded dependencies on X11 and QtX11Extras

heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY No longer needed after 34fc153b25935b693ece5048523c702246c6a0a8

D23876: [applets/kickoff] Tweak padding for lists

ndavis added a comment. In D23876#529485 , @ngraham wrote: > Better, but now the padding is inconsistent between the sides and bottom: F7340987: Screenshot_20190911_085301.png Are you talking about t

D23876: [applets/kickoff] Tweak padding for lists

ndavis added a comment. > F7340957: Screenshot_20190911_163422.png > F7340963: Screenshot_20190911_163617.png Look at the top of the view in both screenshots and bottom of the view in the 2nd. Rather than c

D23803: [Folder View] Add subtle shadows to icons

This revision was automatically updated to reflect the committed changes. Closed by commit R119:37469c7dd02d: [Folder View] Add subtle shadows to icons (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23803?vs=65693&id=65851 REVISI

D23876: [applets/kickoff] Tweak padding for lists

ngraham added a comment. Better, but now the padding is inconsistent between the sides and bottom: F7340987: Screenshot_20190911_085301.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23876 To: filipf, #vdg, #plasma,

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. I also didn't point this out in my original post, but I fixed a misuse of `pam_end()`. The status passed to `pam_end()` should be the returned status of the last PAM library call. This is noted in the documentation for Linux-PAM. REPOSITORY R133 KScreenLocker

D23876: [applets/kickoff] Tweak padding for lists

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Add padding on top and at the bottom of lists in Kickoff so the highlight effect doesn't overlap the separator. REPOSITORY R119 Pl

D22885: Add global animation speed slider to workspace options KCM

ngraham added a comment. Is this going to be able to land before Plasma 5.17 branches in 8 days? REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D22885 To: davidedmundson, #plasma, broulik Cc: ngraham, GB_2, broulik, anthonyfieroni, plasma-deve

D23389: Use "Make default" buttons to switch the default device

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in ListItemBase.qml:231 > I tried that, but it looked sort of weird. I kind of like how the presence of > the icon helps to show what's the default device. Maybe you can also use `star-shape` REPOSITORY R115 Plasma Audio Volume Appl

D23389: Use "Make default" buttons to switch the default device

GB_2 added a comment. In D23389#525358 , @ngraham wrote: > See the new `FIXME`: I can't figure out how to get the non-default device's button to become unchecked. It seems like the binding is broken. The non-default button disables itself flawle

D23868: kfontinst HiDPI icons

guoyunhe updated this revision to Diff 65841. guoyunhe added a comment. Fix the font preview size in HiDPI REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=65827&id=65841 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23868

D21860: Set a font for gtk applications in the fonts kcm

GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol, davidedmundson Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ra

D23868: kfontinst HiDPI icons

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Use QIcon instead of QPixmap for icons. Use QPushButton for the filter menu instead of a QLabel. REPOSITORY R119 Plasma Deskto