KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 36 - Still unstable!

2019-09-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/36/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 06 Sep 2019 05:34:29 + Build duration: 2 min 56 sec and counting JUnit Tests Na

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 11 - Still unstable!

2019-09-05 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/11/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 06 Sep 2019 05:34:30 + Build duration: 1 min 59 sec and counting JUnit Tests

D22106: [Separator] Match Breeze borders' color

2019-09-05 Thread Ben Cooksley
bcooksley added a comment. Please note that depending on the repository. Phabricator can take anywhere from a minute or two, to update to an hour to pick up changes to a repository (it polls repositories unfortunately, and those with more frequent changes are polled more often by Phabricator

D23728: [kicker/kickoff] Use icon from appstream handler

2019-09-05 Thread Eike Hein
hein added a comment. Thanks! REPOSITORY R119 Plasma Desktop BRANCH appstream REVISION DETAIL https://phabricator.kde.org/D23728 To: nicolasfella, hein Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Nathaniel Graham
ngraham added a comment. In D22468#526448 , @romangg wrote: > In D22468#526447 , @victorr wrote: > > > I collected another package with a new patch.F7322491: qml.patch

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Victor Ryzhykh
victorr added a comment. I don’t understand what package is missing in CMakeLists.txt I get an error during assembly DEBUG: Warning: Could not locate service type file kservicetypes5/kcmodule.desktop, tried ("/builddir/.local/share", "/usr/local/share", "/usr/share") and ":/kservicet

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Roman Gilg
romangg added a comment. In D22468#526447 , @victorr wrote: > I collected another package with a new patch.F7322491: qml.patch > > F7322492: Screenshot_20190906_002723.jpeg

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Victor Ryzhykh
victorr added a comment. I collected another package with a new patch.F7322491: qml.patch F7322492: Screenshot_20190906_002723.jpeg REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D224

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Roman Gilg
romangg added a comment. In D22468#526445 , @victorr wrote: > The CMakeLists.txt file lacks the packages needed for the build. > Installed many additional kf5 and plasa packages for assembly, > since I was too lazy to figure out which packa

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Victor Ryzhykh
victorr added a comment. The CMakeLists.txt file lacks the packages needed for the build. Installed many additional kf5 and plasa packages for assembly, since I was too lazy to figure out which package is missing. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D2

D22106: [Separator] Match Breeze borders' color

2019-09-05 Thread Filip Fila
filipf closed this revision. filipf added a comment. Phab hasn't picked up on the commit: https://cgit.kde.org/kirigami.git/commit/?id=9af92cc8b750b59629eeb3446108b2f8086629f7 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22106 To: filipf, #kirigami, #vdg, ngraha

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > view.cpp:41 > +setMinimumHeight(800); > +setMinimumWidth(800); > + Probably makes sense to reduce this to 600 if we can get the layout to adjust adequately. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D237

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread Nathaniel Graham
ngraham added a comment. Better, thanks. The only remaining issue I can see is the problem with the slider values. I also noticed that the first value does nothing to change the view and spits out the following errors on the console: file:///home/nate/kde/usr/share/plasma/packages/org

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread Carson Black
cblack updated this revision to Diff 65483. cblack added a comment. Update based off of feedback REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65417&id=65483 BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.

D23746: Set a minimum window size to reasonable 800x600 px

2019-09-05 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R102:dd9bc6a3cb01: Set a minimum window size to reasonable 800x600 px (authored by alexde, committed by ndavis). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23746

D23746: Set a minimum window size to reasonable 800x600 px

2019-09-05 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Never mind, a KWin rule I had was messing things up. You're good to go. REPOSITORY R102 KInfoCenter BRANCH minimum-window-size (branched from master) REVISION DETAIL https://phabrica

D23746: Set a minimum window size to reasonable 800x600 px

2019-09-05 Thread Nathaniel Graham
ngraham added a comment. Works for me. Are you sure you're opening the built-from-source version of KInfoCenter rather than the system-provided one? REPOSITORY R102 KInfoCenter BRANCH minimum-window-size (branched from master) REVISION DETAIL https://phabricator.kde.org/D23746 To: al

D23746: Set a minimum window size to reasonable 800x600 px

2019-09-05 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. This doesn't seem to do anything, unless I'm testing the wrong thing. KInfocenter with main page selected: F7322186: Screenshot_20190905_155743.png

D22106: [Separator] Match Breeze borders' color

2019-09-05 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Long term, we should make this more programmatic. But since there's already a magic number in there, I think it makes sense to use a better one for the time being. REPOSITORY R169

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Roman Gilg
romangg added a comment. In D22468#526341 , @victorr wrote: > If you apply the attached file, the lines are added to the localization file, and the translation works.F7322054: messages2.patch > > F73220

D23746: Set a minimum window size to reasonable 800x600 px.

2019-09-05 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems like a reasonable minimum size to me. This way none of the KCMs can get cut off (except for the Energy KCM when using a laptop). REPOSITORY R102 KInfoCenter BRANCH minimum-wind

D23746: Set a minimum window size to reasonable 800x600 px.

2019-09-05 Thread Alex Debus
alexde created this revision. alexde added reviewers: VDG, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexde requested review of this revision. REPOSITORY R102 KInfoCenter BRANCH minimum-window-size (branched from master) REVISION DETAIL https://phabr

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Victor Ryzhykh
victorr added a comment. If you apply the attached file, the lines are added to the localization file, and the translation works.F7322054: messages2.patch F7322055: skreen3.jpeg Attached a picture REPOSITORY

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Roman Gilg
romangg added a comment. In D22468#526323 , @victorr wrote: > Are you talking about this?F7321902: messages.patch I thought there was also markup missing in the QML files. REPOSITORY R104 KScreen

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Victor Ryzhykh
victorr added a comment. Are you talking about this?F7321902: messages.patch REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg, #plasma, #kwin, #vdg Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, m

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Roman Gilg
romangg added a comment. Since you found already the root issue want to write a quick patch to fix it? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg, #plasma, #kwin, #vdg Cc: victorr, #vdg, GB_2, gvarsanyi, davidedmundson, ngraham, mvourlakos, kn

D23737: Extract mimetype from recentlyused.xbel

2019-09-05 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R161:3cd9e64d359b: Extract mimetype from recentlyused.xbel (authored by meven). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23737?vs=65466&id=65469

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Victor Ryzhykh
victorr added a comment. File /kscreen-5.16.4/kcm/kcm.cpp contains name «KAboutData *about = new KAboutData(QStringLiteral("kcm_kscreen"),» After renaming, the translation is displayed. Attached a picture 2.F7321822: skreen2.jpeg REPOSITORY R104

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Victor Ryzhykh
victorr added a comment. Incorrect filename "kcm_displayconfiguration" in the /kscreen/kcm/Messages.sh file. Translation is not displayed. Attached a picture 1. F7321805: screen1.jpeg REPOSITORY R104 KScreen REVISION DETAIL https://phabricator

D23734: Remove the "fail_delay()" function

2019-09-05 Thread Jason Franklin
jfranklin added a comment. In D23734#526285 , @zzag wrote: > Hmm, "Unlocking failed" doesn't show up immediately if I type wrong password. "Unlocking failed" shows up immediately when I type in the wrong password with the change in place

D23737: Extract mimetype from recentlyused.xbel

2019-09-05 Thread Méven Car
meven updated this revision to Diff 65466. meven added a comment. const QString &mimetype REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23737?vs=65436&id=65466 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23737 AFFECT

D23734: Remove the "fail_delay()" function

2019-09-05 Thread Vlad Zagorodniy
zzag requested changes to this revision. zzag added a comment. This revision now requires changes to proceed. Hmm, "Unlocking failed" doesn't show up immediately if I type wrong password. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23734 To: jfranklin, #pla

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Victor Ryzhykh
victorr added a comment. Not all lines entered the localization file. Text in patch +text: i18n("New global scale applied. " + + "Change will come into effect after restart.") Line «Change will come into effect after restart.» is ignored REPOSITO

D23734: Remove the "fail_delay()" function

2019-09-05 Thread Jason Franklin
jfranklin added a comment. In D23734#526274 , @zzag wrote: > We want to notify the user as soon as possible about authentication failure. This makes complete sense! You definitely want the user to be notified immediately. However, the s

D23734: Remove the "fail_delay()" function

2019-09-05 Thread Vlad Zagorodniy
zzag added a comment. > I'd be very curious to know if there is a reason for having a fail_delay() function that performs no action. Just let me know! We want to notify the user as soon as possible about authentication failure. REPOSITORY R133 KScreenLocker REVISION DETAIL https://p

D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to

2019-09-05 Thread Nathaniel Graham
ngraham added a comment. Thanks for the review, @gb_2. Have you tested it out? I did a lot of testing, but even more testing would be appreciated since I know this has the potential to introduce some regressions. I suspect all the #plasma people

D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to

2019-09-05 Thread Nathaniel Graham
ngraham updated this revision to Diff 65458. ngraham marked an inline comment as done. ngraham added a comment. Fix string capitalization REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23283?vs=64229&id=65458 BRANCH revamp-session-switching-ux

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus
alexde updated this revision to Diff 65457. alexde added a comment. Set correct right border for the grid lines and ticks. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=65428&id=65457 BRANCH energy-timeline (branched from master) REVISION

D23052: [Sidebar] Use new Kirigami ListSectionHeader component

2019-09-05 Thread Nathaniel Graham
ngraham added a comment. I'm going to land all these patches after Frameworks 5.62 has branched (in two days) to prevent the builds from failing until then due to new stricter ECM frameworks-version-finding behavior. REPOSITORY R124 System Settings BRANCH use-new-kirigami-section-header

D23733: [kded] Save replication source hash to config file

2019-09-05 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:1ee9b20b2559: [kded] Save replication source hash to config file (authored by romangg). REPOSITORY R104 KScreen CHA

D23283: When asked to switch sessions, jump to session creation if there's nothing to switch to

2019-09-05 Thread Björn Feber
GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. This revision is now accepted and ready to land. Makes sense to me UI- and behavior-wise. INLINE COMMENTS > LockScreenUi.qml:443 > +font.pointSize: theme.defaultFont.pointSize + 1 > +

D23052: [Sidebar] Use new Kirigami ListSectionHeader component

2019-09-05 Thread Björn Feber
GB_2 added a comment. Ping. REPOSITORY R124 System Settings BRANCH use-new-kirigami-section-header (branched from master) REVISION DETAIL https://phabricator.kde.org/D23052 To: ngraham, #plasma, #vdg, GB_2 Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, r

D23663: RandR: Replicate outputs with XRender extension

2019-09-05 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:31d71564874d: RandR: Replicate outputs with XRender extension (authored by romangg). CHANGED PRIOR TO COMMIT https:/

D23666: [kcm] Provide graphical interface to replicate outputs

2019-09-05 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:6e7fd472b111: [kcm] Provide graphical interface to replicate outputs (authored by romangg). Herald added a project: Pla

D23710: Introduce output replication API

2019-09-05 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:c8ef5444ee02: Introduce output replication API (authored by romangg). REPOSITORY R110 KScreen Library CHANGES SINCE

D23737: Extract mimetype from recentlyused.xbel

2019-09-05 Thread Ivan Čukić
ivan requested changes to this revision. ivan added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > GtkEventSpy.cpp:207 > > -void GtkEventSpyPlugin::addDocument(const QUrl &url, const QString > &application) > +void GtkEventSpyPlugin::addDocument(const QUrl &u

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:6309d33f092e: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami (authored by romangg). CHANGED PRIOR

D23731: Wayland: Set fractional output scale

2019-09-05 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:802b0c838213: Wayland: Set fractional output scale (authored by romangg). REPOSITORY R110 KScreen Library CHANGES S

D23732: [kded] Support fractional output scale

2019-09-05 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:305078f0258c: [kded] Support fractional output scale (authored by romangg). REPOSITORY R104 KScreen CHANGES SINCE L

D23727: Provide a simple test tool to see what autostart will look like

2019-09-05 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 65441. apol added a comment. add missing files REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23727?vs=65399&id=65441 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23727 AFFECTED FILES shell/

Re: Remote desktop on Plasma Wayland session

2019-09-05 Thread Aleix Pol
On Thu, Feb 14, 2019 at 12:29 PM Jan Grulich wrote: > > Hi, > > I've spent quite a bit time on remote desktop support for Plasma Wayland > sessions. I have full mouse support in xdg-desktop-portal-kde and also in Krfb > so it can be easily tested and used. Problem is that I'm currently blocked by

D23737: Extract mimetype from recentlyused.xbel

2019-09-05 Thread Méven Car
meven created this revision. meven added a reviewer: ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN Locally tested REPOSITORY R161 KActivity Manager Service BRANCH master REVISION DETAIL https://phabricat

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread David Redondo
davidre added a comment. In D23712#525974 , @ngraham wrote: > There are some inline comments that aren't done yet. Also, the slider's text label still says 81 and 162 instead of 64 and 128 for the last two slider values. I also noticed t

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > cuttlefish.qml:32 > > -width: units.gridUnit * 60 > -height: Math.round(width / 3 * 2) > - > property int iconSize: units.iconSizes.large > property bool darkScheme: false Why not Kirigami units here? REPOSITORY R118 Plasma

Plasma 5.17 repo freeze

2019-09-05 Thread Jonathan Riddell
Repo freeze is today so no new git repos can be added The list I have for 5.17 is + wdiff git-repositories-for-release-old git-repositories-for-release bluedevil breeze breeze-grub breeze-gtk breeze-plymouth discover drkonqi kactivitymanagerd kde-cli-tools kdecoration kde-gtk-config kdeplasma-addo

D23732: [kded] Support fractional output scale

2019-09-05 Thread Roman Gilg
romangg added a comment. In D23732#526007 , @cfeck wrote: > I believe 1.25 is a common scale factor. Is something else in the stack limited to one digit? Current ui only supports one digit. But we can make it two here, so people really n

D23732: [kded] Support fractional output scale

2019-09-05 Thread Kai Uwe Broulik
broulik added a comment. I'm pretty sure the startplasma that sets the Qt scaling variables for X also rounds to one digit REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D23732 To: romangg, #plasma Cc: broulik, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jrale

D23727: Provide a simple test tool to see what autostart will look like

2019-09-05 Thread Kai Uwe Broulik
broulik added a comment. Are you sure you added all files to this patch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23727 To: apol, #plasma Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, h

D23732: [kded] Support fractional output scale

2019-09-05 Thread Christoph Feck
cfeck added a comment. I believe 1.25 is a common scale factor. Is something else in the stack limited to one digit? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D23732 To: romangg, #plasma Cc: cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalouk

D23728: [kicker/kickoff] Use icon from appstream handler

2019-09-05 Thread Nathaniel Graham
ngraham added a comment. Wow, that was easy. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23728 To: nicolasfella, hein Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-

D23734: Remove the "fail_delay()" function

2019-09-05 Thread Jason Franklin
jfranklin created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jfranklin requested review of this revision. REVISION SUMMARY I'm a new contributor to kscreenlocker, so I thought I'd start with something very simple to see how the process goes. I hope

D23733: [kded] Save replication source hash to config file

2019-09-05 Thread Roman Gilg
romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY When a replication source is set write its output hash to the config file and load the value aga

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. There are some inline comments that aren't done yet. Also, the slider's text label still says 81 and 162 instead of 64 and 128 for the last two slider values. INLINE COMMENTS

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus
alexde updated this revision to Diff 65428. alexde added a comment. Move stroke() out of the loop. Reduce line with by pixel. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=65423&id=65428 BRANCH energy-timeline (branched from master) REVI

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Roman Gilg
romangg updated this revision to Diff 65426. romangg added a comment. - Add scale debug output CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22468?vs=65421&id=65426 BRANCH qmlize REVISION DETAIL https://phabricator.kde.org/D22468 AFFECTED FILES CMakeLists.txt common/contr

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus
alexde updated this revision to Diff 65423. alexde added a comment. Shrink plotWidth a little bit so the earliest date on the right side may fit. Change the way the division widths are defined to hopefully make the code easier to understand and to maintain. REPOSITORY R102 KInfoCenter

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

2019-09-05 Thread Roman Gilg
romangg updated this revision to Diff 65421. romangg added a comment. Rebase on D23732 . CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22468?vs=65370&id=65421 BRANCH qmlize REVISION DETAIL https://phabricator.kde.org/D22468 AFFECTED FILES

D23732: [kded] Support fractional output scale

2019-09-05 Thread Roman Gilg
romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Read and write fractional output scale values to conifg. We currently round to one digit. REPOS

D23731: Wayland: Set fractional output scale

2019-09-05 Thread Roman Gilg
romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY In order to use fractional scaling on Wayland the KScreen internal output scale must be set wit

D23712: [Cuttlefish] Overhaul program, use Kirigami

2019-09-05 Thread Carson Black
cblack updated this revision to Diff 65417. cblack added a comment. Give screenie button some text REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65401&id=65417 BRANCH modernization (branched from master) REVISION DETAIL https://phabricato

D23729: Add "freebsd" as supported platform key

2019-09-05 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:f8bb4695829b: Add "freebsd" as supported platform key (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23729?vs=65414&id=654

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus
alexde added a comment. For some reason the xGridOffset seems sometimes to be wrong, and I have no explanation why. It especially happens for 1 hour graphs. F7320671: Screenshot_20190905_132313.png REPOSITORY R102 KInfoCenter REVISION DETAIL https:

D23729: Add "freebsd" as supported platform key

2019-09-05 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Chrome documentation only mentions "openbsd" and so does Firefox's because it is ju

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus
alexde requested review of this revision. alexde added a comment. I have changed some stuff, can you please review it again. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23520 To: alexde, #vdg, ngraham, #plasma Cc: bcooksley, plasma-devel, LeGast00n, The-Feren

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus
alexde updated this revision to Diff 65413. alexde added a comment. Rename variables to make their function clearer. Decrease the lower loop border by 1 to make sure that all possible grid lines are drawn. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus
alexde updated this revision to Diff 65410. alexde added a comment. Fix issue that a date may be displayed unintentionally. Shrink right margin for grid lines and try to add an additional grid line on the right side if reasonable. Add more divisions for 2h and 24h graphs. REPOSITORY R1

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus
alexde updated this revision to Diff 65409. alexde added a comment. Use dashed grid lines instead of solid lines. Grid lines with tick labels are less faint. Rename variable to make its function clearer. Show grid lines at all five minutes for the 1 hour graph. REPOSITORY R102 KInfoCent

D23728: [kicker/kickoff] Use icon from appstream handler

2019-09-05 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH appstream REVISION DETAIL https://phabricator.kde.org/D237

D23520: Add time line to X axis

2019-09-05 Thread Alex Debus
alexde updated this revision to Diff 65407. alexde added a comment. Align grid to 10 minutes for the 1h graph. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=65321&id=65407 BRANCH energy-timeline (branched from master) REVISION DETAIL htt