D23342: Add a per-process network information plugin

meven added a comment. According to my testing, it does not measure traffic for root's processes such as apt. Am I missing something ? Can we improve on the situation ? REPOSITORY R106 KSysguard BRANCH network_plugin REVISION DETAIL https://phabricator.kde.org/D23342 To: ahiemstr

D23712: [Cuttlefish] Overhaul program, use Kirigami

ngraham added inline comments. INLINE COMMENTS > Preview.qml:135 > +} > +QQC2.ToolButton { > +visible: !iconPreview.screenshotting There's plenty of space for a button that has visible text. I'd recommend doing that instead of using a tiny icons-only butt

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 65401. cblack added a comment. Wrap those strings with i18n() REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65400&id=65401 BRANCH modernization (branched from master) REVISION DETAIL https://phabricato

D23712: [Cuttlefish] Overhaul program, use Kirigami

cblack updated this revision to Diff 65400. cblack marked an inline comment as done. cblack added a comment. Add changes based off of feedback, screenshot functionality REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23712?vs=65356&id=65400 BRANCH mode

D23727: Provide a simple test tool to see what autostart will look like

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY I wanted to debug why an application didn't start, this helped me see that it was found and in which phas

D23719: Don't parse autostart files n-phase times

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e28eaced917d: Don't parse autostart files n-phase times (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23719?vs=65392&id=65398 REVISIO

D23719: Don't parse autostart files n-phase times

apol updated this revision to Diff 65392. apol marked an inline comment as done. apol added a comment. QString isn't movable REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23719?vs=65371&id=65392 BRANCH master REVISION DETAIL https://phabrica

D23719: Don't parse autostart files n-phase times

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > davidedmundson wrote in autostart.h:34 > Are you sure? We can't memcpy a qstring, it has to update the ref count. I copied it over, now that you mention it, yes, it doesn't make much sense. REPOSITORY R120 Pl

D23663: RandR: Replicate outputs with XRender extension

romangg updated this revision to Diff 65384. romangg marked 3 inline comments as done. romangg added a comment. Improve source setting. REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23663?vs=65344&id=65384 BRANCH cloneX11 REVISION DETAIL http

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 65378. tcanabrava added a comment. - Name fixes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=65375&id=65378 BRANCH kcm_baloo_qml REVISION DETAIL https://phabricator.kde.org/D23718 AFFECTED FI

D23712: [Cuttlefish] Overhaul program, use Kirigami

ngraham added inline comments. INLINE COMMENTS > Tools.qml:30 > +width: parent.width > +RowLayout { > +anchors.verticalCenter: parent.verticalCenter The fake toolbar created here feels too short. I would make it taller by a few pixels so there's more room above and below the con

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 65375. tcanabrava added a comment. - Fix metadata installation - Fix model loading on Qml - Base work on the Qml REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=65369&id=65375 BRANCH kcm_baloo_q

D23712: [Cuttlefish] Overhaul program, use Kirigami

ngraham added a comment. Nice! I notice that for some reason, the slider's last two values now display 81 and 162 in the text field. Also while you're at it, could you make the icon grid alphabetically ordered? Right now I can't tell the sort order and it just looks random. INLINE

D23719: Don't parse autostart files n-phase times

davidedmundson added inline comments. INLINE COMMENTS > autostart.h:34 > +}; > +Q_DECLARE_TYPEINFO(AutoStartItem, Q_MOVABLE_TYPE); > Are you sure? We can't memcpy a qstring, it has to update the ref count. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabrica

D23719: Don't parse autostart files n-phase times

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D23719 To: apol, #plasma, davidedmundson Cc: davidedmundson, plasma

D23719: Don't parse autostart files n-phase times

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Load only once and share TEST PLAN Restarted. Also made a small test app that I'll submit once this is i

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham added inline comments. INLINE COMMENTS > main.qml:31 > + > +KCM.ConfigModule.quickHelp: i18n("This module lets you configure the > search in the system.") > + While we're at it, let's improve this string: "This module lets you configure the system-wide file search features" RE

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in OutputPanel.qml:85 > These need to be exclusive buttons. Currently you can select N at once. Thanks, the issue wasn't them being not exclusive buttons (this is automatically with ButtonGroup above), but that the RotationBu

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg updated this revision to Diff 65370. romangg added a comment. Fix and simplify rotation buttons. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22468?vs=65025&id=65370 BRANCH qmlize REVISION DETAIL https://phabricator.kde.org/D22468 AFFECTED

D23640: [kicker/kickoff] Add icon to hide application action

ngraham added a comment. Also, fixed the Dolphin icons in https://cgit.kde.org/dolphin.git/commit/?id=ac14383e95f96ec3c828d881a53a9c6d396e17a3 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23640 To: nicolasfella, #plasma, hein, ngraham Cc: plasma-devel, LeG

D23640: [kicker/kickoff] Add icon to hide application action

ngraham added a comment. Oh lol I already did it! https://cgit.kde.org/breeze-icons.git/commit/?id=bd07228a126446b35207fce903dcd3549604d208 The better icon names are `view-visible` and `view-hidden`. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23640

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

mart added a comment. please, include screenshots REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718 To: tcanabrava Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, a

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

mart added inline comments. INLINE COMMENTS > main.qml:33 > + > +QtControls.Label { > +text: i18n("File Search helps you quickly locate all your files > based on their content") should use a Kirigami.FormLayout to have checkboxes centered? REPOSITORY R119 Plasma Desktop REVI

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham added inline comments. INLINE COMMENTS > main.qml:23 > +import QtQuick.Layouts 1.1 > +import QtQuick.Controls 2.0 as QtControls > +import QtQuick.Dialogs 1.2 as QtDialogs `import QtQuick.Controls 2.5 as QQC2` (See T10862 ) REPOSITORY R119 Plasma De

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH kcm_baloo_qml REVISION DETAIL https://phabricator.kde.org/D23718 AFFECTED FILES kcms/baloo/CMake

D23651: WIP: Add support for a theming in Kicker Dashboard

ngraham added a comment. As a general concept, are we sure this makes sense? This is an overlay dashboard. It seems like it's supposed to always be dark. Making it respect the color scheme produces a result that, to be honest, I don't think works. The proposed light theme version has a backg

D23623: [kicker/kickoff] Use discover icon for manage application action

ngraham added a comment. In D23623#525410 , @hein wrote: > Distros can change the package manager to be run, so hard-coding the icon is wrong. It should be looked up from the configured application. That makes sense, yeah. REPOSITORY R

D23542: Promote KCM to top level and rename accordingly

ngraham added a comment. Since the only things that can appear in Multimedia now are CD related, maybe we should rename it? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23542 To: ngraham, #vdg, #plasma, drosca, nicolasfella, sitter Cc: wbauer,

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 7 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/7/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Wed, 04 Sep 2019 11:32:08 + Build duration: 7 min 43 sec and counting CONSOLE OUTPUT [...tru

D23651: WIP: Add support for a theming in Kicker Dashboard

filipf added a comment. I would also think a bit more about using Kirigami.SearchField -> it's not used in Kickoff and it's not properly themable (the same way PlasmaComponents.TextField is). It also looks too small. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricato

D23651: WIP: Add support for a theming in Kicker Dashboard

filipf added a comment. What I'm seeing is that this could result in poor visibility of action buttons. F7317401: image.png They should use text color. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23651 To:

D23714: Manipulate Document prototype for createElement

This revision was automatically updated to reflect the committed changes. Closed by commit R856:a83d9300a7a1: Manipulate Document prototype for createElement (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23714?vs=6535

D23714: Manipulate Document prototype for createElement

ognarb accepted this revision. ognarb added a comment. Tested in a modern browser and it still works REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D23714 To: broulik, #plasma, fvogt, ognarb Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23714: Manipulate Document prototype for createElement

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. The same approach should probably be used for other overrides as well, like `navigator.mediaSession.setActionHandler` and `window.Audio`. That's unrelated to the bug though. REPOSITORY R85

D23714: Manipulate Document prototype for createElement

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This fixes Shadydom SHIM breaking because we overrode `createElement` and then the