D23198: Skip mime type check only for files on network mounts

meven added a comment. In D23198#523708 , @broulik wrote: > So I guess we can use the `KFileItem::isSlow()` here now, too? No because isSlow is a member function but the purpose here is to choose a constructor for KFileItem in the first p

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

https://bugs.kde.org/show_bug.cgi?id=304696 Kai Uwe Broulik changed: What|Removed |Added CC||certainlya...@gmail.com --- Comment #16 from

D23392: [energy KCM] Add battery Technology

meven updated this revision to Diff 65189. meven added a comment. fix REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23392?vs=65188&id=65189 BRANCH arcpatch-D23392 REVISION DETAIL https://phabricator.kde.org/D23392 AFFECTED FILES Modules/energy

D23392: [energy KCM] Add battery Technology

meven added a comment. Please note that the feature needs solid 5.62 installed on system as qml looks in `/usr/include/solid/battery.h` for the battery model header. By chance iIf you know how to set the include path used by qml REPOSITORY R102 KInfoCenter REVISION DETAIL https://p

D23392: [energy KCM] Add battery Technology

meven updated this revision to Diff 65188. meven added a comment. Rebase on master REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23392?vs=64459&id=65188 BRANCH arcpatch-D23392 REVISION DETAIL https://phabricator.kde.org/D23392 AFFECTED FILES M

D23392: [energy KCM] Add battery Technology

ngraham added a comment. Needs a rebase as it no longer applies cleanly: $ arc patch D23392 INFO Base commit is not in local repository; trying to fetch. Created and checked out branch arcpatch-D23392. Branch name arcpatch-D23152 already exists; trying a new name. Creat

D23652: [Kicker/Kickoff] Re-word "Manage ..." menu item for greater clarity

This revision was automatically updated to reflect the committed changes. Closed by commit R119:408f3ebbec9a: [Kicker/Kickoff] Re-word "Manage ..." menu item for greater clarity (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D23640: [kicker/kickoff] Add icon to hide application action

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9359baac9e7d: [kicker/kickoff] Add icon to hide application action (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23640?vs=65116&

D23652: [Kicker/Kickoff] Re-word "Manage ..." menu item for greater clarity

ngraham updated this revision to Diff 65172. ngraham added a comment. Correct Capitalization REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23652?vs=65171&id=65172 BRANCH re-word-manage-item (branched from master) REVISION DETAIL https://phabri

D23652: [Kicker/Kickoff] Re-word "Manage ..." menu item for greater clarity

ngraham created this revision. ngraham added reviewers: VDG, Plasma, hein, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Even with the Discover icon added in D23623

D23622: [kicker/kickoff] Use better icon for edit application

ngraham added a comment. Since this action actually opens the properties window (which just happens to have a tab that allows you to edit the .desktop file), how about just, "Properties". Then we could use the standard `document-properties` icon. REPOSITORY R119 Plasma Desktop REVISION DE

Re: plasma-nm strongswan support for custom proposals

Hi, please submit your patch to Phabricator [1], we don't do reviews over email. [1] - https://phabricator.kde.org Thank you for your contribution. Regards, Jan so 31. 8. 2019 v 3:35 odesílatel Bob Richmond napsal: > This patch brings feature parity with gnome's nm-connection-editor > strong

D23542: Promote KCM to top level and rename accordingly

ngraham added a comment. That's correct. I guess this can be considered an advanced feature. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23542 To: ngraham, #vdg, #plasma, drosca, nicolasfella, sitter Cc: agurenko, ndavis, plasma-devel, LeGast00

D23542: Promote KCM to top level and rename accordingly

agurenko added a comment. In D23542#523723 , @ngraham wrote: > In D23542#523306 , @agurenko wrote: > > > Can you still re-order devices to set priority of input/output devices? > > > That's not

D23651: WIP: Add support for a theming in Kicker Dashboard

ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY - Replace hardcoded color with Kirigami.Theme.* - Replace search bar with Kirigami.Search I tried to use PlasmaCore.Theme but t

D23542: Promote KCM to top level and rename accordingly

ngraham added a comment. In D23542#523306 , @agurenko wrote: > Can you still re-order devices to set priority of input/output devices? That's not relevant to this patch, which only moves the KCM to the top level. No functionality has been

D23198: Skip mime type check only for files on network mounts

broulik added a comment. So I guess we can use the `KFileItem::isSlow()` here now, too? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23198 To: meven, #plasma, dfaure Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23342: Add a per-process network information plugin

meven added a comment. In D23342#523626 , @davidedmundson wrote: > > This could be run on package install by distributions, or we could add an action somewhere to let the user run it on demand. > > It is run automatically in the cmake. >

D23342: Add a per-process network information plugin

davidedmundson added a comment. > This could be run on package install by distributions, or we could add an action somewhere to let the user run it on demand. It is run automatically in the cmake. See plugins/process/network/helper/CMakeLists.txt I think that should be enough

D23387: [Folder view] Scale selection and preview buttons with item size

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d9ea98a61c7f: [Folder view] Scale selection and preview buttons with item size (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23387?vs

D23387: [Folder view] Scale selection and preview buttons with item size

ngraham added a comment. The icons are in the plasma theme. REPOSITORY R119 Plasma Desktop BRANCH folderview-buttons-scale-with-item-size (branched from master) REVISION DETAIL https://phabricator.kde.org/D23387 To: ngraham, hein, #plasma, #vdg, ndavis Cc: ndavis, plasma-devel, LeGast

D23387: [Folder view] Scale selection and preview buttons with item size

ndavis added a comment. That's some nice consistent spacing. Does it get the icons from the desktop theme? If so, I could add some additional sizes so that it doesn't look as blurry. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23387 To: ngraham, hein, #p

D23387: [Folder view] Scale selection and preview buttons with item size

ngraham updated this revision to Diff 65127. ngraham added a comment. Use medium for largest size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23387?vs=64447&id=65127 BRANCH folderview-buttons-scale-with-item-size (branched from master) REVISIO

D23647: XRandR: Generic code cleanup

romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY No functional changes, white space added where sensible, debug messages now without repetition of

D23640: [kicker/kickoff] Add icon to hide application action

nicolasfella created this revision. nicolasfella added reviewers: Plasma, hein, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY The icon name seems a bit weird to me, but it's what Dolphin uses for

D23620: Fix speaker test not showing sinks/buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R115:097879580833: Fix speaker test not showing sinks/buttons (authored by nicolasfella). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23620?vs=6508

D23621: [kicker/kickoff] Add icon to forget recent docs action

This revision was automatically updated to reflect the committed changes. Closed by commit R119:16fdd6493162: [kicker/kickoff] Add icon to forget recent docs action (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23621?vs=6508

D23622: [kicker/kickoff] Use better icon for edit application

nicolasfella added a comment. What do you suggest? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23622 To: nicolasfella, #plasma, hein, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, l

D23623: [kicker/kickoff] Use discover icon for manage application action

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8a9ee0233b07: [kicker/kickoff] Use discover icon for manage application action (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D236

D23387: [Folder view] Scale selection and preview buttons with item size

ndavis added inline comments. INLINE COMMENTS > FolderItemActionButton.qml:38 > +case 4: return units.iconSizes.smallMedium; > +case 5: return units.iconSizes.large; > +default: return units.iconSizes.small; medium would be better because then it won't overlap

D23542: Promote KCM to top level and rename accordingly

agurenko added a comment. Can you still re-order devices to set priority of input/output devices? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23542 To: ngraham, #vdg, #plasma, drosca, nicolasfella, sitter Cc: agurenko, ndavis, plasma-devel, LeG