D23253: [Notifications] Don't allow popup to obscure things in corners

broulik added a comment. Not a fan. F7259717: Screenshot_20190819_085603.png INLINE COMMENTS > Globals.qml:230 > if (popupLocation & Qt.AlignBottom) { > -y += screenRect.height; > +y += screenRect.height - popupEdgeDis

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

GB_2 added a comment. In D23242#514239 , @hein wrote: > Code's fine, but let's discuss the change briefly - disabling grouping in ITM gets you a bunch of identical-looking icons you can't tell apart. I think that's a pretty ugly user experience,

D23250: Try to fix i18n() timing error in version strings

pino added a comment. This looks like a workaround to me: if `installedVersion` is not available (is it known when, actually?), why keep using it anyway, with or without i18n? Also, -1 to string puzzles and to UI strings not translatable. REPOSITORY R134 Discover Software Store REVISION

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

hein added a comment. Code's fine, but let's discuss the change briefly - disabling grouping in ITM gets you a bunch of identical-looking icons you can't tell apart. I think that's a pretty ugly user experience, does it make sense to have an option to configure the applet into an invariably

D23253: [Notifications] Don't allow popup to obscure things in corners

ngraham updated this revision to Diff 64012. ngraham added a comment. Revert unnecessary variable name change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23253?vs=64011&id=64012 BRANCH notification-popups-dont-obscure-things-in-corners0anymor

D23253: [Notifications] Don't allow popup to obscure things in corners

ngraham created this revision. ngraham added reviewers: broulik, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY One thing that has been bugging me a bit with notifications is how close the pop-up

D23241: Show application window icon on AboutPage

hein added a comment. I was looking into this recently and added the component named getter, which does the trick for me and is much nicer to use than setting the program logo. So in some sense this is not strictly necessary, and also it would really be better if the window icon first part o

D23250: Try to fix i18n() timing error in version strings

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Sometimes, `availableVersion` isn't set when the `i18n()` string is built,

D23237: Do not display vendor, Product and capacity in network plasmoid

apol added a comment. LGTM but the title looks wrong, this isn't the network plasmoid. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D23237 To: meven, ngraham, #plasma, broulik, #vdg, filipf Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-D

D23241: Show application window icon on AboutPage

apol added a comment. +1 LGTM, please address the @since bit INLINE COMMENTS > settings.h:81 > + */ > +Q_PROPERTY(QVariant applicationWindowIcon READ applicationWindowIcon > CONSTANT) > It could make sense to include the REVISION part: https://doc.qt.io/qt-5/properties.html REPOS

D23248: Make "Network Disconnected" notification low priority

ngraham created this revision. ngraham added reviewers: jgrulich, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. ngraham requested review of this revision. REVISION SUMMARY This is a quintissential low priority not

D21860: Set a font for gtk applications in the fonts kcm

nicolasfella added inline comments. INLINE COMMENTS > fonts.cpp:613 > +org::kde::gtkConfigd gtkDaemonInterface { > +"org.kde.gtkConfigd", > +"/KdeGtkConfigd", QStringLiteral() around strings > fonts.cpp:618 > +}; > +QString fontAsGtkConfigString = m_generalFont.famil

D21860: Set a font for gtk applications in the fonts kcm

gikari updated this revision to Diff 64002. gikari added a comment. - Delegate gtk fonts configuration to Gtk Daemon REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21860?vs=59956&id=64002 BRANCH set-gtk-font-in-fonts-kcm (branched from master) RE

D20746: Remove disable for showing only minimized tasks on Icons only task manager

cblack abandoned this revision. cblack added a comment. Change made here is being made in D23242 . Abandoning this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20746 To: cblack, #plasma, hein, #vdg Cc: broulik, ngraham,

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

ngraham added subscribers: hein, ngraham. ngraham added a reviewer: hein. ngraham accepted this revision. ngraham added a comment. +1, but wait for @hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23242 To: GB_2, #plasma, #vdg, hein, ngraham Cc: ngraham,

D23241: Show application window icon on AboutPage

ngraham added a reviewer: Kirigami. ngraham added inline comments. INLINE COMMENTS > settings.h:79 > + * @since 5.62 > + * @since org.kde.kirigami 2.9 > + */ 2.10 actually (this is super confusing, I know) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23

D23237: Do not display vendor, Product and capacity in network plasmoid

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, a simplified information display makes sense here IMO. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D23237 To: meven, ngraham, #p

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 368430 Being able to disable grouping for the icons-only taskmanager makes sense, because it ha

D23241: Show application window icon on AboutPage

caspermeijn added a comment. I am not sure about the version numbers and the return type. Did I choose the correct ones? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23241 To: caspermeijn, mart, apol Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, dav

D23241: Show application window icon on AboutPage

caspermeijn created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. caspermeijn requested review of this revision. REVISION SUMMARY With this it is not nessecary to KAboutData::setProgramLogo. If the QApplication::setWindowIcon is set, then the AboutPa

D23188: Fix supported OS attributes for api.kde.org

vkrause added inline comments. INLINE COMMENTS > apol wrote in metainfo.yaml:12 > Isn't it called macOS nowadays? Or is it a keyword we have that we'd need to > change elsewhere? See commit message, yes. We'd need to change it everywhere in order to show up as a single "macOS" entry on api.kde

D23130: [energy kcm] Remove bogus Has power supply property from UI

meven added a comment. Given: 1. this is buggy right now 2. not very informative even with a proper label I am in favor of landing this as is. REPOSITORY R102 KInfoCenter BRANCH dev1 REVISION DETAIL https://phabricator.kde.org/D23130 To: meven, broulik, ngraham Cc: plasma-

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

marten planned changes to this revision. marten added a comment. @GB_2 thanks for testing; a desktop UUID is obviously not friendly to show to the user, so there needs to be some sort of X11/Wayland runtime check here. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 63968. GB_2 added a comment. Add tooltip to menu button REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63872&id=63968 BRANCH arcpatch-D22896 REVISION DETAIL https://phabricator.kde.org/D22896 AFFECT

D23237: Do not display vendor, Product and capacity in network plasmoid

meven created this revision. meven added reviewers: ngraham, Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Those information mostly clutter the plasmoid UI and not very informative. The batter