D23218: Fix compile warning

2019-08-17 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R161:45309604c7c6: Fix compile warning (authored by meven). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23218?vs=63918&id=63964 REVISION DETAIL ht

D23188: Fix supported OS attributes for api.kde.org

2019-08-17 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > metainfo.yaml:12 > - name: Windows > -- name: macOS (maintainer needed) > +- name: MacOSX > + note: maintainer needed Isn't it called macOS nowadays? Or is it a keyword we have that we'd need to change elsewhere? REPOSITORY R169

D23185: [libtaskmanager] Port to lighter KProcessList

2019-08-17 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D23185 To: davidedmundson, #plasma, apol Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-

D23170: Fix colors from KStatefulBrushes not using application colorschemes

2019-08-17 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R31:f803a89e2443: Fix colors from KStatefulBrushes not using application colorschemes (authored by ndavis). REPOSITORY R3

D23170: Fix colors from KStatefulBrushes not using application colorschemes

2019-08-17 Thread Noah Davis
ndavis added a comment. Considering the changes were already agreed upon before I made this diff, it seem safe to land without further review. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D23170 To: ndavis, #vdg, #breeze Cc: hpereiradacosta, mglb, ngraham, plasma-de

Plasma installation clarification requested

2019-08-17 Thread Sahlan
Obtained a Nexus 5X on which to install Plasma OS, for porting software which I am also porting to Sailfish and Tizen devices. All going well except the final step, so I am requesting some advice please. I have successfully followed the instructions to unlock the phone's bootloader I have ch

D23228: Port away from deprecated KWindowSystem API

2019-08-17 Thread David Faure
dfaure created this revision. dfaure added reviewers: zzag, graesslin, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. REVISION SUMMARY Call the all-in-one method (which handles numeric keypad better), then spli

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-08-17 Thread Björn Feber
GB_2 added a comment. I just tried it on Wayland and it looks like for some reason instead of a number it shows some kind of UUID. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22740 To: marten, #plasma Cc: GB_2, ngraham, cfeck, plasma-devel, LeGast00n, T

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-08-17 Thread Nathaniel Graham
ngraham added a comment. Cool, thanks. Once it's verified on Wayland, we can change `CCBUG:` to `BUG:`. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22740 To: marten, #plasma Cc: ngraham, cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampa

D17464: [Timer applet] Minor fixes for the applet

2019-08-17 Thread Alexander Kernozhitsky
gepardo added a comment. Thanks, now I got your point much clearer. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D17464 To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma, ngraham, davidedmundson Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-F

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-08-17 Thread Carson Black
cblack updated this revision to Diff 63936. cblack added a comment. The new highlight style has been yeeted in favor of the current one REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=60379&id=63936 BRANCH arcpatch-D21815 REVISION DETAI

D17464: [Timer applet] Minor fixes for the applet

2019-08-17 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. If it's the exact same code as before, then my opinion will be the same. The digital clock set the text height to 0.7 of the panel and the width is inferred th

D23218: Fix compile warning

2019-08-17 Thread Méven Car
meven created this revision. meven added a reviewer: ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Add a Q_UNUSED to avoid a compile warning TEST PLAN Build REPOSITORY R161 KActivity Manager Service

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-17 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R161:acbc21c15622: Add a event Spy for GtkFileChooser recent files (authored by meven). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63913&i

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-17 Thread Méven Car
meven updated this revision to Diff 63913. meven added a comment. Reduce the amount of included code and linked libraries REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63890&id=63913 BRANCH arcpatch-D23112 REVISION DETAIL h

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-08-17 Thread Jonathan Marten
marten added a comment. In D22740#512556 , @ngraham wrote: > So does this fully fix 410190, or only partially? Fixes it completely for X11. Should really verify on Wayland before considering the bug to be completely fixed. REPOSITORY

D23049: Add Kirigami ListSectionHeader component

2019-08-17 Thread Björn Feber
GB_2 added a comment. @mart is this good now? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23049 To: GB_2, #kirigami, #vdg, mart, ngraham Cc: jbbgameich, ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, dkardarakos, apol, davidedmun