D23112: Add a event Spy for GtkFileChooser recent files

meven updated this revision to Diff 63890. meven added a comment. Ensure the log category is exported, compare only chars, variable naming fix REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63830&id=63890 BRANCH arcpatch-D23112

D12827: Added process details in the process list context menu

chrisx added a comment. In D12827#513118 , @meven wrote: > I quite like this feature @chrisx > I hope you can still push it forward after all this time. I'll definitely update the patch if the maintainers show more interest in merging.

D23112: Add a event Spy for GtkFileChooser recent files

bruns added inline comments. INLINE COMMENTS > ivan wrote in GtkEventSpy.cpp:126 > No need to compare chars with strings: > > if (!exec.isEmpty() && exec[0] == '\'' && exec.back() == '\'') missing `QChar('\'')`, otherwise it breaks with QT_NO_CAST_FROM_ASCII -> `if (exec.startsWith(QChar('\'

D23081: remove references from the icon qrc to missing icons.

This revision was automatically updated to reflect the committed changes. Closed by commit R169:b3ffca1363b1: remove references from the icon qrc to missing icons. (authored by camiloh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23081?vs=63518&id=63889

Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 SUSEQt5.12 - Build # 50 - Still Failing!

Hi all, Please see below - can someone take a look at the below build failure? Thanks, Ben -- Forwarded message - From: CI System Date: Sat, Aug 17, 2019 at 10:05 AM Subject: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 SUSEQt5.12 - Build # 50 - Still Failing!

D23112: Add a event Spy for GtkFileChooser recent files

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Another tiny change, and I think it is ready to land. Unless someone else sees other issues. INLINE COMMENTS > GtkEventSpy.cpp:126 > + > +if (exec.at(0) == QStringLiteral("'"

D23170: Fix colors from KStatefulBrushes not using application colorschemes

ngraham added a subscriber: hpereiradacosta. ngraham added a comment. Looking back at the quality of my last Breeze review, maybe @hpereiradacosta could have a go. :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D23170 To: ndavis, #vdg, #breeze Cc: hpereiradacosta,

D23170: Fix colors from KStatefulBrushes not using application colorschemes

ndavis added a comment. Anyone want to accept this? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D23170 To: ndavis, #vdg, #breeze Cc: mglb, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezha

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

hpereiradacosta added a comment. Thanks ! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D23169 To: ndavis, #vdg, #breeze, ngraham, hpereiradacosta Cc: hpereiradacosta, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, Z

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

ndavis abandoned this revision. ndavis added a comment. Alright, problem fixed. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D23169 To: ndavis, #vdg, #breeze, ngraham, hpereiradacosta Cc: hpereiradacosta, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

ndavis added a comment. In D23169#513046 , @hpereiradacosta wrote: > Hi Noah > Thanks for the patch, however, it is not the right fix to the issue. If you use a light color scheme (like the default breeze), you will see that the shadow below

D23152: [energy kcm] Display Vendor and model

ngraham added a comment. "Manufacturer" is fine IMO. If it needs to be changed, maybe "Vendor" or "Hardware" REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23152 To: meven, broulik, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

ndavis added a comment. In D23169#513071 , @hpereiradacosta wrote: > Zoom showing the issue mentionned above with the "current" patch (or master branch of breeze) > > F7250494: Screenshot_20190816_175237.png

D23152: [energy kcm] Display Vendor and model

meven added a comment. For reference in GNOME, the equivalent feature looks like : https://i.stack.imgur.com/V7Fpk.png I would be in favor of rename the "Manufacturer" section to "Manufacturing" or "Part" or "Component". REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabrica

D23198: Skip mime type check only for files on network mounts

meven added a comment. For reference in GNOME, the equivalent feature looks like : https://i.stack.imgur.com/V7Fpk.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23198 To: meven, #plasma, dfaure Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-O

D12827: Added process details in the process list context menu

meven added a comment. I quite like this feature @chrisx I hope you can still push it forward after all this time. INLINE COMMENTS > DetailsDlg.cpp:1 > +/* > + KSysGuard, the KDE System Guard Personally I would favor a class name with no abbreviation, here DetailsDialog, and here perh

D23198: Skip mime type check only for files on network mounts

meven added a comment. In D23198#512999 , @ngraham wrote: > In D23198#512942 , @broulik wrote: > > > `fileSystemType` calls `statvfs` which might also block, so I don't think this helps. > > >

D22896: Port System Settings sidebar to QQC2

GB_2 updated this revision to Diff 63872. GB_2 added a comment. Address comments REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63827&id=63872 BRANCH arcpatch-D22896 REVISION DETAIL https://phabricator.kde.org/D22896 AFFECTED FILES

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

hpereiradacosta added a comment. Zoom showing the issue mentionned above with the "current" patch (or master branch of breeze) F7250494: Screenshot_20190816_175237.png How it should look: F7250505: Screenshot_20190816_175628.png

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

hpereiradacosta reopened this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. F7250479: patch.diff REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D23169 To: ndavis, #vdg, #breeze, ngraha

D23169: Fix width and separator of ToolButtonComplexControl outline w/ dropdown menu

hpereiradacosta added a comment. Hi Noah Thanks for the patch, however, it is not the right fix to the issue. If you use a light color scheme (like the default breeze), you will see that the shadow below the part of the button that corresponds to the arrow is darker than below the rest of

D23198: Skip mime type check only for files on network mounts

ngraham added a comment. In D23198#512942 , @broulik wrote: > `fileSystemType` calls `statvfs` which might also block, so I don't think this helps. True, but then that implies that `KFileItem::isSlow()` which has the same code is flawed

D23198: Skip mime type check only for files on network mounts

meven updated this revision to Diff 63859. meven added a comment. Use toLocalFile() instead of path() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23198?vs=63855&id=63859 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23198 AFFEC

D22896: Port System Settings sidebar to QQC2

broulik added a comment. Working very nice now! Just some minor nitpicks then this can go in INLINE COMMENTS > SidebarMode.h:54 > Q_PROPERTY(int width READ width NOTIFY widthChanged) > +Q_PROPERTY(bool actionMenuVisible READ actionMenuVisible WRITE > setActionMenuVisible NOTIFY acti

D17464: [Timer applet] Minor fixes for the applet

gepardo added a comment. ping @davidedmundson REPOSITORY R114 Plasma Addons BRANCH arcpatch-D17464 REVISION DETAIL https://phabricator.kde.org/D17464 To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma, ngraham Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D23198: Skip mime type check only for files on network mounts

broulik added a comment. `fileSystemType` calls `statvfs` which might also block, so I don't think this helps. INLINE COMMENTS > recentusagemodel.cpp:252 > +// taken from kfileitem::isSlow > +const KFileSystemType::Type fsType = > KFileSystemType::fileSystemType(url.path());

D23198: Skip mime type check only for files on network mounts

meven created this revision. meven added reviewers: Plasma, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Related diff D19784 BUG: 401579 REPOSITORY R119 Plas

KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.13/10/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 16 Aug 2019 10:23:40 + Build duration: 2 min 16 sec and counting

D23125: fix bridge master:slave mapping by-name

jgrulich added a comment. The parent knows the connection id, if you look into ConnectionEditorBase::initialize(), then you can get the id using "m_connection->id()" You can add additional **masterId** parameter so you don't need to go through the whole connection list to get the

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

luc4 added a comment. Ping. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22774 To: luc4, davidedmundson, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

GB_2 added a comment. Ping. REPOSITORY R120 Plasma Workspace BRANCH distro-logo-slot (branched from master) REVISION DETAIL https://phabricator.kde.org/D22458 To: cblack, #vdg, #plasma, filipf, ngraham Cc: GB_2, Codezela, filipf, davidedmundson, broulik, ngraham, plasma-devel, LeGast

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. Visually +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23158 To: ngraham, #vdg, #plasma, davidedmundson, GB_2 Cc: GB_2, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,