KDE CI: Plasma » plymouth-kcm » stable-kf5-qt5 SUSEQt5.12 - Build # 21 - Failure!

2019-08-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plymouth-kcm/job/stable-kf5-qt5%20SUSEQt5.12/21/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sun, 11 Aug 2019 06:16:41 + Build duration: 5 min 44 sec and counting CONSOLE OUTPUT [

D23082: Allow to set maximum volume < 100%

2019-08-10 Thread Kishore Gopalakrishnan
kishoreg created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kishoreg requested review of this revision. REVISION SUMMARY Currently one cannot set the maximum volume < 100%. This feature is required because some earphones / speakers are more sensitive

D23081: remove references from the icon qrc to missing icons.

2019-08-10 Thread Camilo Higuita
camiloh created this revision. camiloh added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. camiloh requested review of this revision. REVISION SUMMARY this issue was affecting the building of app when using kirigami static linked REPOSITORY R

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-10 Thread Nathaniel Graham
ngraham added a comment. TBH I don't like it with the standard Breeze color scheme--or any color scheme where the titlebar is a bold or highly contrasting color. The top part of the window starts to feel overwhelming IMO. I think it looks out of place with other windows where that area of co

KDE CI: Plasma » plymouth-kcm » kf5-qt5 SUSEQt5.12 - Build # 26 - Failure!

2019-08-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plymouth-kcm/job/kf5-qt5%20SUSEQt5.12/26/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 11 Aug 2019 02:58:41 + Build duration: 2 min 48 sec and counting CONSOLE OUTPUT [...truncated 2

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-10 Thread Carson Black
cblack created this revision. cblack added reviewers: Breeze, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Tabs have had their colors changed to make it easier to tell which is active. REPOSITORY R98 B

D17464: [Timer applet] Minor fixes for the applet

2019-08-10 Thread Alexander Kernozhitsky
gepardo added a comment. Still waiting for the feedback. REPOSITORY R114 Plasma Addons BRANCH arcpatch-D17464 REVISION DETAIL https://phabricator.kde.org/D17464 To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma, ngraham Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jralei

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This also happens with Thunderbird too. I think we need to go back to the earlier version, come up with something different or fix Firefox itself. :/ REPOSITORY R98 Breeze for

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Nathaniel Graham
ngraham added a comment. And it really really really doesn't work with Wonton soup at all: F7203531: Screenshot_20190810_171455.png REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D23079 To: cblack, #vdg, #breeze Cc:

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Nathaniel Graham
ngraham added a comment. With certain color schemes, this new style looks... special. :) Oxygen: F7203525: Oxygen.png Honeycomb: F7203526: Honeycomb.png REPOSITORY R98 Breeze for Gtk REVISION DETAIL ht

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Nathaniel Graham
ngraham added a comment. Hmm, now the rest of the tab bar and menubar backgrounds have started to use the titlebar color: F7203516: Screenshot_20190810_170538.png It's not a terrible look, but I'm not sure it's intended... REPOSITORY R98 Bre

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Nathaniel Graham
ngraham added a comment. Hmm, definitely looks better with CSDs, but with SSDs, this happens: F7203504: Screenshot_20190810_170312.png I could live with the inactive tab titles getting lighter, but not the menubar. REPOSITORY R98 Breeze for

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Carson Black
cblack updated this revision to Diff 63515. cblack added a comment. Add background color to make SSD decorations more legible with patch REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23079?vs=63514&id=63515 BRANCH firefox-csd-fix (branched from ma

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Vlad Zagorodniy
zzag added a comment. How does it look when Firefox has a server side-decoration? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D23079 To: cblack, #vdg, #breeze Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf

D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Carson Black
cblack created this revision. cblack added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This fixes the CSD colors of Firefox to be more legible, but not without some caveats due to upstream i

D23078: Remove persistence from the kauth helper

2019-08-10 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R123:2ce7ccd2dff8: Remove persistence from the kauth helper (authored by fvogt). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23078?vs=63511&id=

D22535: Make kimpanel a system tray applet

2019-08-10 Thread Yunhe Guo
guoyunhe added a comment. Making the layout of status panel: F7203378: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22535 To: guoyunhe, ngraham, #vdg, #plasma Cc: xuetianweng, gpark, hein, mart, ngraham,

D23078: Remove persistence from the kauth helper

2019-08-10 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. fvogt requested review of this revision. REVISION SUMMARY The way the helper works allows everyone with access to elevate to root trivially, so persistence need

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

2019-08-10 Thread Björn Feber
GB_2 added a comment. In D22896#509989 , @ngraham wrote: > Maybe the show most used action should go in a separate patch. This one feels like it's getting overloaded with too many different changes. Yeah, we that feature is also not ready

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

2019-08-10 Thread Nathaniel Graham
ngraham added a comment. Maybe the show most used action should go in a separate patch. This one feels like it's getting overloaded with too many different changes. REPOSITORY R124 System Settings BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

2019-08-10 Thread Marco Martin
mart accepted this revision. mart added a comment. Cool, tough I'm a bit hesitant on using qt.labs.platform as it may break any moment in any future release REPOSITORY R124 System Settings BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from master)

D22981: Minor code improvements

2019-08-10 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R123:c1c4e03b0003: Minor code improvements (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22981?vs=63250&id=63503 REVISION

D23063: [lockscreen] Fit album art to defined geometry

2019-08-10 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R120:953f72e42f6c: [lockscreen] Fit album art to defined geometry (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23063?vs=63453&id=63502

D22535: Make kimpanel a system tray applet

2019-08-10 Thread Yunhe Guo
guoyunhe added a comment. In D22535#509917 , @ngraham wrote: > Did you delete the old KCM first? If not, it will take precedence and you won't see the new one. The old one is located in the following location: > > - Ubuntu-based distros: `[in

D22535: Make kimpanel a system tray applet

2019-08-10 Thread Nathaniel Graham
ngraham added a comment. Did you delete the old KCM first? If not, it will take precedence and you won't see the new one. The old one is located in the following location: - Ubuntu-based distros: `[install prefix]/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_keyboard.so` - Other distros: `

D23064: Fix duplicate results when a 2nd unit is partially written in krunner

2019-08-10 Thread Nathaniel Graham
ngraham added a comment. Great job, @iasensio! May it be the first of many. :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D23064 To: iasensio, ngraham, broulik Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, le

D23043: Include xkb.h

2019-08-10 Thread Frederik Gladhorn
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:5ea41a794f68: Include xkb.h (authored by gladhorn). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https

D23042: When implementing assignment, also implement copy ctor

2019-08-10 Thread Frederik Gladhorn
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:937a0cedf227: When implementing assignment, also implement copy ctor (authored by gladhorn). REPOSITORY R119 Plasma

Re: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 SUSEQt5.12 - Build # 46 - Still Failing!

2019-08-10 Thread Ben Cooksley
On Sat, Aug 10, 2019 at 4:36 PM Ömer Fadıl USTA wrote: > https://phabricator.kde.org/D22976 > While that does appear to be the fix, please note that this build was for the stable branch, and that fix is only in the master branch at the moment. I guess it needs to be cherry-picked across? Cheers

Re: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 SUSEQt5.12 - Build # 46 - Still Failing!

2019-08-10 Thread Ömer Fadıl USTA
https://phabricator.kde.org/D22976 On Fri, Aug 9, 2019, 23:21 Ben Cooksley wrote: > Hi folks, > > Could someone please look into the below QMutex include problem within > plasma-workspace? > > Thanks, > Ben > > -- Forwarded message - > From: CI System > Date: Sat, Aug 10, 2019 a

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 SUSEQt5.12 - Build # 149 - Unstable!

2019-08-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.12/149/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sat, 10 Aug 2019 14:04:41 + Build duration: 9 min 32 sec and counting BUILD ARTIFACTS

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 SUSEQt5.12 - Build # 46 - Still Failing!

2019-08-10 Thread Nate Graham
Done and fixed. Nate On 8/9/19 2:20 PM, Ben Cooksley wrote: Hi folks, Could someone please look into the below QMutex include problem within plasma-workspace? Thanks, Ben -- Forwarded message - From: *CI System* mailto:nore...@kde.org>> Date: Sat, Aug 10, 2019 at 8:18 AM S

KDE CI: Plasma » kdeplasma-addons » stable-kf5-qt5 SUSEQt5.12 - Build # 52 - Fixed!

2019-08-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/stable-kf5-qt5%20SUSEQt5.12/52/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sat, 10 Aug 2019 15:56:15 + Build duration: 5 min 18 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » kdeplasma-addons » stable-kf5-qt5 SUSEQt5.12 - Build # 51 - Failure!

2019-08-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/stable-kf5-qt5%20SUSEQt5.12/51/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sat, 10 Aug 2019 15:48:46 + Build duration: 7 min 27 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kdeplasma-addons » stable-kf5-qt5 FreeBSDQt5.13 - Build # 15 - Fixed!

2019-08-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/stable-kf5-qt5%20FreeBSDQt5.13/15/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 10 Aug 2019 15:53:06 + Build duration: 1 min 19 sec and counting

KDE CI: Plasma » kdeplasma-addons » stable-kf5-qt5 FreeBSDQt5.13 - Build # 14 - Failure!

2019-08-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/stable-kf5-qt5%20FreeBSDQt5.13/14/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 10 Aug 2019 15:48:46 + Build duration: 1 min 4 sec and counting CONSOLE OUTPU

D23064: Fix duplicate results when a 2nd unit is partially written in krunner

2019-08-10 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R114:239f574c5b2f: Fix #410744: Duplicate results when a 2nd unit is partially written in krunner (authored by iasensio, committed by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D23064: Fix duplicate results when a 2nd unit is partially written in krunner

2019-08-10 Thread Ismael Asensio
iasensio added a comment. Sure about the email. Thanks! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D23064 To: iasensio, ngraham, broulik Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D23064: Fix #410744: Duplicate results when a 2nd unit is partially written in krunner

2019-08-10 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. I'll do it :) Very nice job indeed! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D23064 To: iasensio, ngraham, broulik Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, Zr

D22976: Fix compilation

2019-08-10 Thread Ömer Fadıl Usta
usta added a comment. In D22976#509675 , @aacid wrote: > And what are you or ben waiting for? You've both got commit access :) @aacid: ;) in here we are in sacrifice feast , and i dont have my laptop with me ( sorry about that ) A

D23064: Fix #410744: Duplicate results when a 2nd unit is partially written in krunner

2019-08-10 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Well done! :) I'll land this (or Nate is probably quicker) once I find the time to do it. Can I use the email address you used in the bugreport for this? REPOSITORY R114 Plasma Addons

D22976: Fix compilation

2019-08-10 Thread Nathaniel Graham
ngraham added a comment. Done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22976 To: ngraham, #plasma, aacid Cc: usta, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abe

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still unstable!

2019-08-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20FreeBSDQt5.13/22/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 10 Aug 2019 14:04:41 + Build duration: 4 min 51 sec and counting JUnit Tests

D23028: Wayland: set KWayland outputs data in output class

2019-08-10 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:137ec11fe2a6: Wayland: set KWayland outputs data in output class (authored by romangg). REPOSITORY R110 KScreen Libr

D23026: Wayland: unfriend config and output classes

2019-08-10 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:4d698bd16d41: Wayland: unfriend config and output classes (authored by romangg). REPOSITORY R110 KScreen Library CH

D23025: Wayland: output device name as create function argument only

2019-08-10 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:6a1aef331f7e: Wayland: output device name as create function argument only (authored by romangg). REPOSITORY R110 KS

D23024: Wayland: save pointers in initializing list

2019-08-10 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:e4bb0192df42: Wayland: save pointers in initializing list (authored by romangg). REPOSITORY R110 KScreen Library CH

D22535: Make kimpanel a system tray applet

2019-08-10 Thread Yunhe Guo
guoyunhe added a comment. I tried to merge @gpark 's branch. It is compiled but I cannot reproduce the UI as shown in demo video. I am not sure how it is connected. So I leave that part untouched for now. I hope I can get in touch with @gpark to understand how the code works. Then we can mak

D22976: Fix compilation

2019-08-10 Thread Albert Astals Cid
aacid added a comment. And what are you or ben waiting for? You've both got commit access :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22976 To: ngraham, #plasma, aacid Cc: usta, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, Z

D23064: Fix #410744: Duplicate results when a 2nd unit is partially written in krunner

2019-08-10 Thread Ismael Asensio
iasensio created this revision. iasensio added reviewers: ngraham, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. iasensio requested review of this revision. REVISION SUMMARY When typing a conversion, and the second unit is partially written (i.e. "10€ to ru..

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

2019-08-10 Thread Björn Feber
GB_2 updated this revision to Diff 63460. GB_2 added a comment. "Configure" -> "Configure..." REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63458&id=63460 BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (bra

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

2019-08-10 Thread Björn Feber
GB_2 added a subscriber: mart. GB_2 added a comment. Ping @mart, can you please help here? REPOSITORY R124 System Settings BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from master) REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2, #

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

2019-08-10 Thread Björn Feber
GB_2 updated this revision to Diff 63458. GB_2 added a comment. Add a "Show Most Used Page" button REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63404&id=63458 BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent