D22634: Sync NumLock preference

filipf added a comment. Numlock in SDDM config files is documented here: https://github.com/sddm/sddm/blob/develop/data/man/sddm.conf.rst.in REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D22634 To: filipf, #plasma, ngraham, davidedmundson Cc:

D22634: Sync NumLock preference

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY SDDM currently doesn't respect the user's choice on whether or not NumLock should be on or off by default. Fortunately there is a con

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

broulik added a comment. I'm confused - what does this change? There's no context, so I can't tell where it's being moved to. Soundcloud works fine here. You might want to enable "Enhanced Media Controls" in settings. REVISION DETAIL https://phabricator.kde.org/D22631 To: rgeorgiev Cc: br

D22632: Implement support for the "next" and "previous" actions in SoundCloud

broulik added a comment. -1 Site-specific workarounds are not in scope for this extension. REVISION DETAIL https://phabricator.kde.org/D22632 To: rgeorgiev Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jens

D22630: Slow down the busy indicator's rotation speed

broulik added a comment. Also, Plasma's `BusyIndicator` should maybe get the same treatment? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D22630 To: ngraham, #vdg, filipf, cullmann Cc: broulik, cfeck, filipf, plasma-devel, cullmann, LeGas

D22627: Add a GUI option for choosing the input method

filipf added a comment. In D22627#499699 , @ngraham wrote: > Why is there a blank entry? The blank entry is sort of the whole point of the option. The way to fix the virtual keyboard popping up on its own with some themes is to leave Inpu

D19440: Exclude non-managed devices from plasma-nm

jgrulich added a comment. It looks that the patch needs to be rebased. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D19440 To: afiestas, #plasma, jgrulich Cc: aacid, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, Zr

D19440: Exclude non-managed devices from plasma-nm

This revision was automatically updated to reflect the committed changes. Closed by commit R116:a6bce5fccc14: Exclude non-managed devices from plasma-nm (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19440?vs=52

D19440: Exclude non-managed devices from plasma-nm

jgrulich added a comment. In D19440#499168 , @aacid wrote: > @jgrulich should we land this? Yes. > Alex is unsure you're convinced it's good I wasn't sure if this patch is needed, but it makes sense. REPOSITORY R116 Plasma Net

D22630: Slow down the busy indicator's rotation speed

cfeck added a comment. Do we need a matching commit in KWidgetsAddons? See https://commits.kde.org/kwidgetsaddons/2631be903f947872f67c9e2063950345dda9033e REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D22630 To: ngraham, #vdg, filipf, cul

D22589: Embrace X-KDE-Wayland-Interfaces

mvourlakos added a comment. In D22589#499203 , @davidedmundson wrote: > > Thanks I will add it! > > And make sure your exec line is an absolute path OH!!! I would had missed that one REPOSITORY R120 Plasma Workspace BRANCH maste

D22632: Implement support for the "next" and "previous" actions in SoundCloud

rgeorgiev updated this revision to Diff 62251. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22632?vs=62244&id=62251 REVISION DETAIL https://phabricator.kde.org/D22632 AFFECTED FILES extension/content-script.js To: rgeorgiev Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

rgeorgiev updated this revision to Diff 62249. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22631?vs=62241&id=62249 REVISION DETAIL https://phabricator.kde.org/D22631 AFFECTED FILES extension/content-script.js To: rgeorgiev Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB

D22627: Add a GUI option for choosing the input method

ngraham added a comment. Why is there a blank entry? Also these hardcoded values make me feel a little leery. Is there a way we can programmatically generate them or get them from SDDM or something? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.o

D21950: [Night Color KCM] Add "Constant" mode

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f254f9be8457: [Night Color KCM] Add "Constant" mode (authored by zzag). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21950?vs=60189&id=62246#toc REPOSITORY R119 Plasma Desktop CHANGES SIN

D21949: [libcolorcorrect] Add "Constant" mode

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a6b1c0e543cc: [libcolorcorrect] Add "Constant" mode (authored by zzag). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21949?vs=60188&id=62245 REVISION DE

D22632: Implement support for the "next" and "previous" actions in SoundCloud

rgeorgiev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rgeorgiev requested review of this revision. REVISION SUMMARY Implement support for the "next" and "previous" actions in SoundCloud. REPOSITORY R856 Plasma Browser Integration REVISION D

D22363: Remove cursor theme option

This revision was automatically updated to reflect the committed changes. Closed by commit R123:34fc153b2593: Remove cursor theme option (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22363?vs=62174&id=62242 REVISI

D22631: Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud support work

rgeorgiev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rgeorgiev requested review of this revision. REVISION SUMMARY Perform registering of dynamically-added players in all cases when media controls are enabled, thereby making basic SoundCloud

D22630: Slow down the busy indicator's rotation speed

This revision was automatically updated to reflect the committed changes. Closed by commit R858:217fc7530b75: Slow down the busy indicator's rotation speed (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22630?vs=62239&id=62240#toc REPOSITORY R858 Qt Quick Control

D22630: Slow down the busy indicator's rotation speed

ngraham added a comment. *sigh* Nothing's ever easy with you, is it, arc? REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH slower-busy-indicator REVISION DETAIL https://phabricator.kde.org/D22630 To: ngraham, #vdg, filipf, cullmann Cc: filipf, plasma-devel, cullmann, LeG

D22630: Slow down the busy indicator's rotation speed

ngraham updated this revision to Diff 62239. ngraham added a comment. Rebase REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22630?vs=62236&id=62239 BRANCH slower-busy-indicator REVISION DETAIL https://phabricator.kde.org/D22

D22630: Slow down the busy indicator's rotation speed

cullmann accepted this revision. cullmann added a comment. Jup, looks less iritating. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH slower-busy-indicator REVISION DETAIL https://phabricator.kde.org/D22630 To: ngraham, #vdg, filipf, cullmann Cc: filipf, plasma-devel, cullma

D22363: Remove cursor theme option

ngraham accepted this revision. ngraham added a comment. So much removed code. 👍 Shipit! REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH remove-cursor-theme-option (branched from master) REVISION DETAIL https://phabricator.kde.org/D22363 To: filipf, ngraham, davidedmundson Cc:

D22494: Attempt to support different collections of Unsplash

guoyunhe added a comment. In D22494#499592 , @ngraham wrote: > In D22494#499587 , @filipf wrote: > > > Could we only have Unsplash as the provider and the an additional combobox that would allow choo

D22630: Slow down the busy indicator's rotation speed

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. The FPS before was a little bit gamer-esque. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH slower-busy-indicator REVISION DETAIL https://phabricator.kde.org/D22630 To: n

D22630: Slow down the busy indicator's rotation speed

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The busy indicator spins really fast and it's kind of disorienting. Let's slow it down. TEST PLAN

D22627: Add a GUI option for choosing the input method

filipf updated this revision to Diff 62233. filipf added a comment. combobox strings shouldn't be translatable REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22627?vs=62226&id=62233 BRANCH add-input-method-combobox (branched from m

D22494: Attempt to support different collections of Unsplash

ngraham added a comment. In D22494#499587 , @filipf wrote: > Could we only have Unsplash as the provider and the an additional combobox that would allow choosing the category? +1, this should be a single Unsplash plugin whose user-facing

D22494: Attempt to support different collections of Unsplash

filipf added a comment. Could we only have Unsplash as the provider and the an additional combobox that would allow choosing the category? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22494 To: guoyunhe, #plasma Cc: filipf, plasma-devel, LeGast00n, jraleigh

[Powerdevil] [Bug 377357] configurable timer setting to turn off the keyboard's backlight

https://bugs.kde.org/show_bug.cgi?id=377357 --- Comment #6 from Jan Przybylak --- Yes, the purpose is saving energy. I always just assumed it was using a lot of power, but now that you mention it, I'm not so sure anymore. I will report back when I find concrete data. -- You are receiving this m

D22627: Add a GUI option for choosing the input method

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This exposes an existing SDDM InputMethod option and can function as a workaround for: https://github.com/sddm/sddm/issues/952 REPOS

D22616: Remove phonon KCM

pino added a comment. In D22616#499453 , @nicolasfella wrote: > > @sitter said he has a version of the settings to be integtated into phonon so the remaining three users can still access them > > this ... doesn't say anything. Before

D22623: Bind SQL parameters in firefox bookmarksrunner support

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. fvogt requested review of this revision. REVISION SUMMARY Previously (accidental) SQL injection was easily possible. TEST PLAN Could still list bookmarks. REP

D22616: Remove phonon KCM

nicolasfella added a comment. > @sitter said he has a version of the settings to be integtated into phonon so the remaining three users can still access them this REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22616 To: nicolasfella, sitter Cc: pino, pl

D22619: Remove duplicate occurence of Qt5::DBus in CMakeLists.txt

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5a79ff3db16f: Remove duplicate occurence of Qt5::DBus in CMakeLists.txt (authored by shubham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22619?vs=62213&

D22588: [Pager] Don't link kdelibs4support

shubham added a comment. I have put up a patch to remove duplicate occurrence of DBus here. https://phabricator.kde.org/D22619 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22588 To: broulik, #plasma, hein, davidedmundson Cc: pino, shubham, plasma-devel, L

D22619: Remove duplicate occurence of Qt5::DBus in CMakeLists.txt

shubham created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. shubham requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D22619 AFFECTED FILES applets/pager/CMakeLists.txt

D19865: Linux softraid: Define _GNU_SOURCE for pipe2

aacid closed this revision. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D19865 To: awilcox, #plasma, davidedmundson, broulik Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abett

D17552: Fix 2 typos

aacid closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17552 To: lepagevalleeemmanuel, ngraham, bshah Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein

D4775: Suggestion - newline ending after password to output

aacid closed this revision. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D4775 To: martinkostolny, cfeck, davidedmundson Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterbe

D22616: Remove phonon KCM

pino added a comment. Erm, so what if you do **not** use plasma-pa? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22616 To: nicolasfella, sitter Cc: pino, plasma-devel, sitter, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesl

D22616: Remove phonon KCM

nicolasfella created this revision. nicolasfella added a reviewer: sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Most of the Phonon KCM settings have been moved to plasma-pa. The remaining settin

D22613: kstart: Prevent crash when running without args

apol added a comment. LGTM otherwise INLINE COMMENTS > kstart.cpp:355 >} else { > - if ( parser.positionalArguments().count() == 0 ) > + if ( parser.positionalArguments().count() == 0 ) { >qCritical() << i18n("No command specified"); if ( parser.positionalArguments(

D22612: Fix assert when pressing enter really quickly

This revision was automatically updated to reflect the committed changes. Closed by commit R112:21a7ef11ba70: Fix assert when pressing enter really quickly (authored by davidedmundson). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22612?vs=62194&id=62195 REVI

D22613: kstart: Prevent crash when running without args

tasossahanidis created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tasossahanidis requested review of this revision. REVISION SUMMARY Despite an error being thrown, kstart would continue, trying to access an item that didn't exist in parser's argumen

D22612: Fix assert when pressing enter really quickly

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY runCurrentIndex checks if "currentItem" is valid. currentItem relies on the

D21950: [Night Color KCM] Add "Constant" mode

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main.qml:151 > +i18n("Times"), > +i18n("Always on") > +] Maybe "Manual" rather than "always on"

D22589: Embrace X-KDE-Wayland-Interfaces

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > Thanks I will add it! And make sure your exec line is an absolute path REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.o

D19440: Exclude non-managed devices from plasma-nm

aacid added a comment. @jgrulich should we land this? Alex is unsure you're convinced it's good REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D19440 To: afiestas, #plasma, jgrulich Cc: aacid, plasma-devel, LeGast00n, jraleigh, fbampalou

D22589: Embrace X-KDE-Wayland-Interfaces

mvourlakos added a comment. In D22589#499012 , @zzag wrote: > @mvourlakos Perhaps Latte-Dock will need to set X-KDE-Wayland-Interfaces too (I assume that Latte-Dock uses libtaskmanager). Thanks I will add it! REPOSITORY R120 Plasma Wor

D22493: [Notifications] Move history items' icons over to the left a bit

alexde added a comment. In D22493#496764 , @ngraham wrote: > Yeah, this patch touches only the history items, not the popups. I can do that too, if you'd like. Are you sure? When I applied this patch (+ units.iconSizes.medium) it looked

D20830: Add hack to unbreak audio playback through pure JS via new Audio()

This revision was automatically updated to reflect the committed changes. Closed by commit R856:d637f92040c3: Add hack to unbreak audio playback through pure JS via new Audio() (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde

D21112: Support message response and reply callbacks

This revision was automatically updated to reflect the committed changes. Closed by commit R856:59fa1853817b: Support message response and reply callbacks (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21112?vs=62129&i

D21112: Support message response and reply callbacks

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. In D21112#498669 , @fvogt wrote: > Code looks good and seems to work fine in vivaldi, but I get an error in firefox: > > Promise resolved

D22605: Set notifications entry icon size to medium

alexde added a comment. > For pictures (like people's faces in messenger notifications) I would still prefer the lager icons, though. I have to admit, that I'm not very much satisfied myself with the size. It could be a bit larger, something between medium and large. Maby we should disc

D22605: Set notifications entry icon size to medium

broulik added a comment. For pictures (like people's faces in messenger notifications) I would still prefer the lager icons, though. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22605 To: alexde, #vdg Cc: broulik, pino, plasma-devel, LeGast00n, jraleigh,

D22605: Set notifications entry icon size to medium

alexde added a comment. > You must run cmake for the whole repository; once done that, you can cd to the applets/notifications/ subdirectory of the builddir, and build only that part. What I also needed to install is kdesignerplugin then So the procedure is as follows:

D22607: Fix compile warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R856:8a254b2ec2e0: Fix compile warnings (authored by fvogt). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22607?vs=62176&id=62178 REVISION DETAIL

D22607: Fix compile warnings

fvogt updated this revision to Diff 62176. fvogt added a comment. Do it differently. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22607?vs=62175&id=62176 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22607 AFFECTED F

D22607: Fix compile warnings

fvogt created this revision. fvogt added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. fvogt requested review of this revision. REVISION SUMMARY Fix warnings printed during build. TEST PLAN Built it, no warnings anymore. REPOSITORY R85

D22363: Remove cursor theme option

filipf updated this revision to Diff 62174. filipf added a comment. address review comments REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22363?vs=62101&id=62174 BRANCH remove-cursor-theme-option (branched from master) REVISION D

D22605: Set notifications entry icon size to medium

pino added a comment. In D22605#499051 , @alexde wrote: > I would like to test it and post a screenshot, however I am not able to compile it: > > 1. I cloned the source from the git repository > 2. mkdir plasma-workspace/applets/notificatio

D22605: Set notifications entry icon size to medium

alexde added a comment. I would like to test it and post a screenshot, however I am not able to compile it: 1. I cloned the source from the git repository 2. mkdir plasma-workspace/applets/notifications/build 3. cd plasma-workspace/applets/notifications/build 4. cmake .. This r

D22605: Set plasma-nm history entry icon size to medium

alexde created this revision. alexde added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexde requested review of this revision. REVISION SUMMARY The current history entry icon is rather large and therefore hits the bottom of the entry in the list.

D22589: Embrace X-KDE-Wayland-Interfaces

zzag added subscribers: mvourlakos, zzag. zzag added a comment. @mvourlakos Perhaps Latte-Dock will need to set X-KDE-Wayland-Interfaces too (I assume that Latte-Dock uses libtaskmanager). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22589 To: apol, #pla

D22306: Do not skip code launching application in application dashboard

luc4 updated this revision to Diff 62170. luc4 added a comment. This is another implementation that follows the same principale of the previous ones, but moves the responsibility of maintaining the state to the `dragHelper` object. This requires to postpone the reset of the state after the o

D9388: Fix queued connection error

aacid closed this revision. aacid added a comment. There's no minimizeall applet anymore REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9388 To: iromanov, graesslin, mart Cc: aacid, davidedmundson, anthonyfieroni, plasma-devel, LeGast00n, jraleigh, fbampalouk

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

pino added a comment. In D22210#498929 , @asturmlechner wrote: > drop translations No need to do that, scripty will take care of it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlech

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

fvogt added a comment. In D22210#498929 , @asturmlechner wrote: > drop translations, rename to 'Plasma on Xorg' That would not be symmetric to "Plasma (Wayland)" though as produced by sddm. REPOSITORY R120 Plasma Workspace REVISION DE

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner updated this revision to Diff 62165. asturmlechner added a comment. drop translations, rename to 'Plasma on Xorg' REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22210?vs=60995&id=62165 BRANCH session-rename REVISION DETAIL https