D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

This revision was automatically updated to reflect the committed changes. Closed by commit R31:d6b2a3a36a1c: Remove unneeded 1 pixel margin around side panels (authored by hpereiradacosta). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22138?vs=61228&id=61236

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

ndavis added a comment. Works for me. Tested RTL with `kate --reverse`. REVISION DETAIL https://phabricator.kde.org/D22138 To: hpereiradacosta, mart, #vdg, ndavis, filipf Cc: ngraham, ndavis, filipf, mart, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himc

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

hpereiradacosta updated this revision to Diff 61228. hpereiradacosta added a comment. Simplified the patch: special case in ::pixelMetrics is in fact not needed, because it is overridden in ::frameContentsRect anyway CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22138?vs=61227&id=6

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

hpereiradacosta updated this revision to Diff 61227. hpereiradacosta added a comment. New patch, adding proper margin to avoid overlap with viewport CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22138?vs=60773&id=61227 REVISION DETAIL https://phabricator.kde.org/D22138 AFFECTED

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

hpereiradacosta added a comment. In D22138#491285 , @mart wrote: > In D22138#491173 , @hpereiradacosta wrote: > > > Indeed. This is a problem. As soon as treeviews are animated Qt makes a pixmap cop

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 51 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/51/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 05 Jul 2019 14:50:56 + Build duration: 2 min 34 sec and counting CONSOLE OUTPUT [...tr

D22288: force a token refresh before submitting the report

This revision was automatically updated to reflect the committed changes. Closed by commit R871:824efbe6aa17: force a token refresh before submitting the report (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22288?vs=61204&id=61222 REVIS

D22289: hijack nextbutton on preview page and rename it to Submit!

This revision was automatically updated to reflect the committed changes. Closed by commit R871:470549de27d8: hijack nextbutton on preview page and rename it to Submit! (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22289?vs=61205&id=61223#toc REPOSITORY R871 DrKo

D22268: Port containmentActions to use KPlugin instead of KService

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7e2c5231114e: Port containmentActions to use KPlugin instead of KService (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22268?vs=61137&

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidedmundson added inline comments. INLINE COMMENTS > image.cpp:600 > +m_slideshowModel->addBackground(path); > +m_currentSlide = m_slideFilterModel->indexOf(path) - 1; > nextSlide(); what will happen if you add a background that the slideFilterModel then filters out?

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

ngraham added a comment. Huh, in a VM everything works for me too. I wonder if there's some subtle issue with the fact that I'm running a custom-compiled Plasma at a different path on bare metal. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22121 To: da

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 131 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/131/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Jul 2019 13:32:21 + Build duration: 4 min 22 sec and counting BUILD ARTIFACTS abi-compa

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.12 - Build # 139 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.12/139/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 05 Jul 2019 11:57:43 + Build duration: 42 min and counting JUnit Tests

KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 139 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/139/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 05 Jul 2019 11:57:43 + Build duration: 40 min and counting JUnit Tests Name: projec

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 128 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/128/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Jul 2019 11:57:43 + Build duration: 8 min 34 sec and counting BUILD ARTIFACTS

D15875: [Media Controller] Disallow seeking beyond end of track

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. In D15875#334752 , @anthonyfieroni wrote: > 1s file is a corner case as well as 0, cause you have always 2 positions - start and stop

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 130 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/130/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Jul 2019 11:57:43 + Build duration: 4 min 50 sec and counting CONSOLE OUTPUT [...trunca

D22285: [ActionTextField] Make action glow on press

This revision was automatically updated to reflect the committed changes. Closed by commit R169:4384fa0c8162: [ActionTextField] Make action glow on press (authored by broulik). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22285?vs=61195&id=61214 REVISION D

D22229: Ignore Next/Previous call if CanGoNext/CanGoPrevious are false

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R856:0c1b8d57b0ea: Ignore Next/Previous call if CanGoNext/CanGoPrevious are false (authored by broulik). REPOSITORY R856

D22065: Introduce PluginManager

This revision was automatically updated to reflect the committed changes. Closed by commit R856:cc4436cf491c: Introduce PluginManager (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22065?vs=60997&id=61211 REVISION DET

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 149 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/149/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Jul 2019 11:43:13 + Build duration: 2 min 0 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 148 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/148/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Jul 2019 11:35:43 + Build duration: 7 min 29 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 289 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/289/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Jul 2019 11:37:03 + Build duration: 1 min 54 sec and counting CONSOLE OUTPUT [...truncate

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 288 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/288/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Jul 2019 11:35:43 + Build duration: 1 min 18 sec and counting CONSOLE OUTPUT [...truncate

D22284: Add missing libinput include

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ebc5bc9e1df2: Add missing libinput include (authored by bkchr, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22284?vs=61194&id=61209

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 129 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/129/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Jul 2019 11:09:11 + Build duration: 1 min 15 sec and counting CONSOLE OUTPUT [...trunca

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

mart added a comment. In D22138#491173 , @hpereiradacosta wrote: > Indeed. This is a problem. As soon as treeviews are animated Qt makes a pixmap copy of the treeview viewport. This does not include the blue line on the side, which is painted i

D22289: hijack nextbutton on preview page and rename it to Submit!

sitter created this revision. sitter added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY it's very awkward when you don't know when a change happens or not, so suitably label the next

D22289: hijack nextbutton on preview page and rename it to Submit!

sitter added a comment. Looks comme ca: F6973746: Screenshot_20190705_125955.png REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D22289 To: sitter, #plasma, #vdg Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragre

D22288: force a token refresh before submitting the report

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY when the user takes a very long time to prepare the bug report the original login session may have timed out and prevent submitting

D22285: [ActionTextField] Make action glow on press

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, much better REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22285 To: broulik, #plasma, mart, ngraham Cc: ngraham, plasma-devel, fbampaloukas, domson, dkard

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

msdobrescu updated this revision to Diff 61201. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22256?vs=61191&id=61201 REVISION DETAIL https://phabricator.kde.org/D22256 AFFECTED FILES wallpapers/image/backgroundlistmodel.cpp wallpapers/image/backgroundlistmodel.h wallpapers/im

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 128 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/128/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Jul 2019 10:22:33 + Build duration: 3 min 57 sec and counting CONSOLE OUTPUT [...trunca

D21510: Filter KNewStuff Plasma Themes by Download Tag

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e93b567ecb7f: Filter KNewStuff Plasma Themes by Download Tag (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21510?vs=61120&id=61196#toc REPOSITORY R119 Plasma Desktop

D22285: [ActionTextField] Make action glow on press

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This matches `QLineEdit` behavior REPOSITORY R169 Kirigami REVISION DETAIL https://ph

D22284: Add missing libinput include

bkchr created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bkchr requested review of this revision. REVISION SUMMARY The libinput include path was missing for the x11 touchpad kcm. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 28 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/28/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 05 Jul 2019 07:35:15 + Build duration: 2 min 29 sec and counting JUnit Tests

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 26 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/26/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Jul 2019 07:35:14 + Build duration: 2 min 37 sec and counting JUnit Tests Na

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

hpereiradacosta added a comment. Indeed. This is a problem. As soon as treeviews are animated Qt makes a pixmap copy of the treeview viewport. This does not include the blue line on the side, which is painted in the frame, below the (transparent) viewport. Will investigate further. REPOSITO

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

msdobrescu updated this revision to Diff 61191. msdobrescu edited the summary of this revision. msdobrescu added a comment. Added Reversed, DirsFirst/DirsLast, IgnoreCase, LocaleAware options. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22256?vs=6&id=61191 REVISION DETAIL h