D22084: Span wayland objects to lifespan of the QApplication

davidedmundson updated this revision to Diff 60705. davidedmundson added a comment. update REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22084?vs=60604&id=60705 BRANCH master REVISION DETAIL https://phabricator.kd

D22084: Span wayland objects to lifespan of the QApplication

davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in waylandintegration.cpp:125 > Is it okay to access waylandBlurManager() right after it's been deleted (or > rather scheduled for removal)? There's two questions here. I'll answer both. --- Is it safe to call a method on Blur

D18571: Add "apply on double-click" feature to most other recent ported KCMs

pino added a comment. In D18571#486708 , @ngraham wrote: > I think we need to implement this everywhere, or remove it from the Colors KCM. Indeed, this misfeature ought to be removed from the colors kcm for the reasons stated above. REP

D22053: [libtaskmanager] Track stacking order and window activation (on X11)

pino added inline comments. INLINE COMMENTS > anthonyfieroni wrote in xwindowtasksmodel.cpp:673-675 > That's double lookup in intensive called function, what about > > int idx = d->lastActivated.indexOf(window); > if (idx >= 0) >return d->lastActivated.at(idx); @anthonyfieroni `d->l

D22053: [libtaskmanager] Track stacking order and window activation (on X11)

anthonyfieroni added inline comments. INLINE COMMENTS > xwindowtasksmodel.cpp:673-675 > +if (d->lastActivated.contains(window)) { > +return d->lastActivated.value(window); > +} That's double lookup in intensive called function, what about int idx = d->lastActivated

D22106: [Separator] Match Breeze borders' color

filipf added a comment. Although testing with other color schemes there is clearly an underlying difference in the code between how the Kirigami separator determines the color and Breeze: F6935969: image.png If someone could point me to the pla

D22106: [Separator] Match Breeze borders' color

filipf created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Kirigami separators are currently stronger than Breeze style borders used with controls. With this patch the difference betwee

[Powerdevil] [Bug 345618] Powerdevil crash from idle desktop.

https://bugs.kde.org/show_bug.cgi?id=345618 --- Comment #18 from mthw0 --- Is this bug still present? -- You are receiving this mail because: You are the assignee for the bug.

D22084: Span wayland objects to lifespan of the QApplication

zzag added inline comments. INLINE COMMENTS > apol wrote in waylandintegration.cpp:125 > Yes, note it's a QPointer now. Is it okay to access waylandBlurManager() right after it's been deleted (or rather scheduled for removal)? REPOSITORY R130 Frameworks integration plugin using KWayland REV

D18571: Add "apply on double-click" feature to most other recent ported KCMs

ngraham abandoned this revision. ngraham added a comment. Per @mart's suggestion, I've implemented this in the base item itself so it doesn't need to be done individually for every KCM. See D22102 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https

D22098: Don't keep requesting scans when wifi is disabled

This revision was automatically updated to reflect the committed changes. Closed by commit R116:aad8d8173266: Don't keep requesting scans when wifi is disabled (authored by apol). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22098?vs