D21979: [System Load Viewer] Add a tooltip about the "CPUs separately" option

nhiga added a comment. In D21979#484281 , @ngraham wrote: > Sorry, my mistake. I missed that this tooltip is set on the wrong checkbox. It needs to be set on the "CPUs separately" checkbox This is intentional - if we set this on the "CPUs

D22011: Add MenuSeparator

filipf added a comment. In the after picture I'm noticing that the separator is 1px outside the frame when the menus is over a dark bg. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D22011 To: astippich, mart, apol, ngraham Cc: filipf, pl

D22011: Add MenuSeparator

ngraham added inline comments. INLINE COMMENTS > MenuSeparator.qml:37 > +width: controlRoot.width > +height: 1 > +} @mart does this need to be multiplied by the device pixel ratio to account for fractional scale factors? I forget. REPOSITORY R858 Qt Quick Controls 2: Desk

D22012: Clean up old bug workaround in KCMFileIndexer

ngraham added subscribers: mart, ngraham. ngraham added reviewers: mart, Plasma. ngraham added a comment. @mart do you know the history of this? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D22012 To: meven, mart, #plasma Cc: ngraham, mart, plasma-devel, LeGast

D22012: Clean up old bug workarount in KCMFileIndexer

meven created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D22012 AFFECTED FILES Modules/fileindexermonitor/kcm.cpp

D22011: Add MenuSeparator

astippich added a comment. Related to D21944 Menu now looks like F6924938: menu_separator.png before: F6924945: menu_before.png REPOSITORY R858 Qt Quick Controls 2: D

D22011: Add MenuSeparator

astippich created this revision. astippich added reviewers: mart, apol, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. astippich requested review of this revision. REVISION SUMMARY Make the MenuSeparator span the full width of the menu like in QWidget-based m

D21993: [Klipper] Always restore the last clipbboard item

ngraham closed this revision. ngraham added a comment. Arc didn't automatically close this because for some reason the commit message of what got committed lacked the Phab revision ID and the `BUG:` keyword. Not sure why. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabrica

D21815: [sddm-theme] Start moving from QQC1 to QQC2

cblack updated this revision to Diff 60379. cblack added a comment. - Change toolBtn to be more descriptive based on file the id was in - Styling changes on menus (they now have shadows) - Menu item highlight is tweaked as per T11124 (can revert if shou

D22004: Increment iterator before any potential continue

This revision was automatically updated to reflect the committed changes. Closed by commit R119:51d16037ee16: Increment iterator before any potential continue (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22004?vs=60370&id=60376#toc REPOSITORY R119 Plasma Deskto

D21983: [Kickoff/Dash] Show Calculator and Unit Converter runners

This revision was automatically updated to reflect the committed changes. Closed by commit R119:16eddf0503ba: [Kickoff/Dash] Show Calculator and Unit Converter runners (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21983?vs=60375&

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

ngraham updated this revision to Diff 60375. ngraham added a comment. Do do it for Dash REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21983?vs=60374&id=60375 BRANCH add-more-runners (branched from Plasma/5.16) REVISION DETAIL https://phabricat

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

hein added a comment. You can do it for Dash, though -- check that `isDash` check where it already adds some runners to the Dash it doesn't add to App Menu. I'm fine with doing it for Kicker later, but we need to resolve the design issue first so we don't create a new bug. REPOSITORY

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

ngraham updated this revision to Diff 60374. ngraham added a comment. Don't do it for Kicker REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21983?vs=60289&id=60374 BRANCH add-more-runners (branched from Plasma/5.16) REVISION DETAIL https://phab

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

hein added a comment. Let's only do it for Kickoff and the Dash? The Kicker UI is really not made for arbitrary runners. REPOSITORY R119 Plasma Desktop BRANCH add-more-runners (branched from Plasma/5.16) REVISION DETAIL https://phabricator.kde.org/D21983 To: ngraham, #vdg, #plasma, h

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 215 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/215/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 14 Jun 2019 15:00:42 + Build duration: 10 min and counting BUILD ARTIFACTS abi-compatibili

Re: KInit - Current state and benchmarks

Hi, On 2019-06-17 11:56, David Edmundson wrote: From API.kde.org: Using kdeinit to launch KDE applications makes starting a typical KDE applications 2.5 times faster (100ms instead of 250ms on a P-III 500) Certainly sounds like a good thing. ===The current State=== ==Plasma== * Apps launche

Re: user-manager avatars

Those are just existing avatars which have been upscaled and have had more contrast added to them. But FWIW I don't like the female avatar either. If we manage to get our hands on better avatars we might even up removing these plain circular ones too. (And those better ones would be shifted towar

D22004: Increment iterator before any potential continue

hein added a comment. I'm not super happy with hardcoding directory separators and schemas, judicious use of `QUrl::fromLocalFile` or `QUrl::fromUserInput` would probably be better to norm behavior. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22004 To: b

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 180 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/180/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 21 Jun 2019 03:36:05 + Build duration: 54 min and counting JUnit Tests Name: (root) Failed: 0 test(s)

D21815: [sddm-theme] Start moving from QQC1 to QQC2

cblack added a comment. In D21815#482624 , @filipf wrote: > For positioning the menu maybe you could have a look at how it was done in Kickoff config window: https://github.com/KDE/plasma-desktop/blob/master/applets/kickoff/package/contents/ui/C

D22005: Accept local paths

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Alternate approach to D16087 TEST PLAN 5.12 No long

Re: user-manager avatars

I agree. Note that the existing female avatar was already like that before Filip's patch. The only change was simply to add more contrast to the shade of gray used for the background in these avatars. That said: yeah, we should definitely have a more appropriate female avatar and a gender-neut

D22004: Increment iterator before any potential continue

broulik updated this revision to Diff 60370. broulik retitled this revision from "[Task Manager] Increment iterator before any potential continue" to "Increment iterator before any potential continue". REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2200

D22000: [colors/Breeze] Change selected text color to black

ndavis added a comment. In D22000#484409 , @IlyaBizyaev wrote: > Looks fine in the menu, but black on bright blue in the list model below is just wrong now. I don't actually have all the necessary patches right now, so pretend you don't

D22004: [Task Manager] Increase iterator before any potential continue

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise if none of the results are viable, we could end up in an infinite loop because we

D22000: [colors/Breeze] Change selected text color to black

filipf added a comment. In D22000#484409 , @IlyaBizyaev wrote: > Looks fine in the menu, but black on bright blue in the list model below is just wrong now. There would be no black on bright blue once the task is finished; that's one of

user-manager avatars

Looking at the new avatars in user-manager https://phabricator.kde.org/D21926 The Female one is much more genderised and almost sexualied compared to the male one. It's fine to emphasise gendered aspects if that's the desire but they should be balanced between the male and female one. It's prob

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 60366. romangg added a comment. - Minor style changes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=60364&id=60366 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10747 AFFECTED FILES src/

D22000: [colors/Breeze] Change selected text color to black

IlyaBizyaev added a comment. Looks fine in the menu, but black on bright blue in the list model below is just wrong now. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D22000 To: ndavis, #vdg, #breeze, #plasma, ngraham Cc: IlyaBizyaev, ngraham, cfeck, zzag, plasma-dev

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 60364. romangg added a comment. - Revert drm_fourcc.h whitespace changes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=60360&id=60364 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10747 AF

D22002: [Look and Feel KCM] Use view-preview for preview button

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ea079d0e5906: [Look and Feel KCM] Use view-preview for preview button (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22002?vs=60357&id

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 60360. romangg added a comment. Rebase on master. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=28986&id=60360 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10747 AFFECTED FILES src/clie

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

filipf added a comment. Users shouldn't be creating random files in this directory. But if considering the possibility, according to tests configs are ordered alphabetically so we'd need to have a z_kde_settings.conf (if not intervening in SDDM). REPOSITORY R123 SDDM Configuration Pan

D10747: Implement zwp_linux_dmabuf_v1

romangg commandeered this revision. romangg added a reviewer: fredrik. romangg added a comment. Thanks @fredrik for initiating this. I'll try to finish the patches up. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10747 To: romangg, #kwin, #plasma, graesslin, davi

D22000: [colors/Breeze] Change selected text color to black

ngraham added subscribers: cfeck, ngraham. ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This also needs to be changed in the Default theme here in the same repo, in the Kirigami repo (which has a duplicate of it) and in som

D22000: [colors/Breeze] Change selected text color to black

zzag added a comment. Can you attach before & after screenshots? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D22000 To: ndavis, #vdg, #breeze, #plasma Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, al

D22002: [Look and Feel KCM] Use view-preview for preview button

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It makes sense for the splash screen preview to use a "play" icon since it's effectively an a

D22000: Change selected text color to black

ndavis created this revision. ndavis added reviewers: VDG, Breeze, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Also make black text color match the Shade Black color: https://hig.kde.org/style/co

D21992: Provide a way for developers to easily set up plasma sessions for their development environment

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9d9c1fc3b378: Provide a way for developers to easily set up plasma sessions for their… (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21992?vs=60342&id=60354#toc REPOSITORY

D21999: [WIP] Make context menu highlight similar to Kickoff highlight

ndavis updated this revision to Diff 60353. ndavis added a comment. Remove unnecessary if statement REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21999?vs=60349&id=60353 BRANCH highlight (branched from master) REVISION DETAIL https://phabricator.kde.or

D21998: Batch MPRIS DBus property changes

broulik updated this revision to Diff 60352. broulik added a comment. Timer on stack REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21998?vs=60347&id=60352 REVISION DETAIL https://phabricator.kde.org/D21998 AFFECTED FILES host/mpris

D21979: [System Load Viewer] Add a tooltip about the "CPUs separately" option

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Sorry, my mistake. I missed that this tooltip is set on the wrong checkbox. It needs to be set on the "CPUs separately" checkbox REVISION DETAIL https://phabricator.kde.org/D2

D21998: Batch MPRIS DBus property changes

broulik added inline comments. INLINE COMMENTS > fvogt wrote in mprisplugin.h:153 > Why a pointer? No particular reason, just that we usually do that.. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D21998 To: broulik, #plasma, fvogt Cc: plasma-deve

D21999: [WIP] Make context menu highlight similar to Kickoff highlight

filipf added a comment. Visually +100, obviously we can only merge it until we have changed it all places (+gtk theme). REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D21999 To: ndavis, #breeze, #vdg, #plasma Cc: filipf, ngraham, plasma-devel, LeGast00n, jraleigh, fba

D21999: [WIP] Make context menu highlight similar to Kickoff highlight

ngraham added a comment. Looks amazing! But I think we need to do all the highlight effects at once. At least, all the ones that need to be done in this repo. Kirigami and qqc2-desktop-style will need their own patches, of course. REPOSITORY R31 Breeze REVISION DETAIL https://phabricato

D21998: Batch MPRIS DBus property changes

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. There should be a comment somewhere to explain what's happening and why. INLINE COMMENTS > mprisplugin.h:153 > > +QTimer *m_propertyChangeSignalTimer; > +// interface -

D21987: Extend KDE Connect to images, video, audio, selection

broulik planned changes to this revision. broulik added a comment. Will add a separate `shareText` method. Will re-introduce some subsystem status query thing and then set kdeconnect plugin to version 2 and then only show the "copy" entry if host host has version >= 2 REPOSITORY R856 Pla

D21999: Make context menu highlight similar to Kickoff highlight

ndavis created this revision. ndavis added reviewers: Breeze, VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Part of T11124 REPOSITORY R31 Breeze BRANCH hi

D21995: Split ksmserver into a small application that handles startup and ksmserver

davidedmundson added inline comments. INLINE COMMENTS > shutdown.cpp:66 > runShutdownScripts(); > -KDisplayManager().shutdown( m_shutdownType, > KWorkSpace::ShutdownModeDefault); > +// if (m_shutdownType == KWorkSpace::ShutdownTypeHalt) { > +// SessionBackend::self()->sh

D21992: Provide a way for developers to easily set up plasma sessions for their development environment

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This is fantastic. I think it'll be a real improvement over the current set of manual steps. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde

D21998: Batch MPRIS DBus property changes

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN Didn't rename the `emitPropertyChange` method to `queuePropertyChange` to keep the changes to a mi

D21987: Extend KDE Connect to images, video, audio, selection

fvogt added inline comments. INLINE COMMENTS > kdeconnectplugin.cpp:188 > > QStringLiteral("org.kde.kdeconnect.device.share"), > - > QStringLiteral("shareUrl")); > -ms

D21995: Split ksmserver into a small application that handles startup and ksmserver

davidedmundson updated this revision to Diff 60345. davidedmundson marked an inline comment as done. davidedmundson added a comment. Update merge issue REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21995?vs=60340&id=60345 BRANCH davidedmundson/

D21995: Split ksmserver into a small application that handles startup and ksmserver

bshah added inline comments. INLINE COMMENTS > CMakeLists.txt:8 > ecm_qt_declare_logging_category(plasma_waitforname_SRCS HEADER debug_p.h > IDENTIFIER LOG_PLASMA CATEGORY_NAME org.kde.knotifications) > -ecm_mark_nongui_executable(ksyncdbusenv) > ? REPOSITORY R120 Plasma Workspace REVISI

D21992: Provide a way for developers to easily set up plasma sessions for their development environment

apol updated this revision to Diff 60342. apol added a comment. Make executables executable REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21992?vs=60330&id=60342 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21992 AFFECTED FILE

D20830: Add hack to unbreak audio playback through pure JS via new Audio()

apol added a comment. Works for me. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D20830 To: broulik, #plasma, fvogt Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jens

D21995: Split ksmserver into a small application that handles startup and ksmserver

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This allows new startup procedures to use a session manager and also allows

D21991: Add X-KDE-ParentApp entries in metadata.desktop

This revision was automatically updated to reflect the committed changes. Closed by commit R120:53d45a126e5d: Add X-KDE-ParentApp entries in metadata.desktop (authored by bshah). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21991?vs=60323&id=60338

D21979: [System Load Viewer] Add a tooltip about the "CPUs separately" option

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thank you! The email address I have on file for you is `c822c4f23bca1ea6faac7...@mail.xn--3ds443g`. Is there any chance you can provide a different, more human-readable email address

D21993: [Klipper] Always restore the last clipbboard item

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch please! REPOSITORY R120 Plasma Workspace BRANCH unify REVISION DETAIL https://phabricator.kde.org/D21993 To: davidre, ngraham, davidedmundson, #plasma Cc: plasma-dev

D21935: [devicenotifier] Hide plasmoid if no device is available

broulik added a comment. Yes but you can only do that once it shows up because of a removable device then REPOSITORY R120 Plasma Workspace BRANCH hideit REVISION DETAIL https://phabricator.kde.org/D21935 To: nicolasfella, #plasma, ngraham, broulik Cc: plasma-devel, LeGast00n, jraleig

D21944: Show shortcut in menu item when specified

astippich added a comment. Unfortunately, even with this reverted change I know get a wrong menu separator. I don't know what was different before... Since it was also there without this patch (see screenshot), it is probably a different issue which needs investigation REPOSITORY R858

D21944: Show shortcut in menu item when specified

astippich updated this revision to Diff 60332. astippich added a comment. - use item for margin again REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21944?vs=60300&id=60332 BRANCH menu_item REVISION DETAIL https://phabricato

D21993: [Klipper] Always restore the last clipbboard item

davidre created this revision. davidre added reviewers: ngraham, davidedmundson, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY D19852 intrdouced x-kde-force-image-c

D21992: Provide a way for developers to easily set up plasma sessions for their development environment

apol updated this revision to Diff 60330. apol added a comment. Duplicated line REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21992?vs=60328&id=60330 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21992 AFFECTED FILES CMakeLis

D21992: Provide a way for developers to easily set up plasma sessions for their development environment

apol updated this revision to Diff 60328. apol added a comment. Forgot to install the prefix.sh file REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21992?vs=60327&id=60328 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21992 AFFE

D21979: [System Load Viewer] Add a tooltip about the "CPUs separately" option

nhiga updated this revision to Diff 60326. nhiga added a comment. Rephrased the tooltip message according to ngraham's suggestion. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21979?vs=60279&id=60326 REVISION DETAIL https://phabricator.kde.org/D21979 AFFECTED FILES applets/sy

D21992: Provide a way for developers to easily set up plasma sessions for their development environment

apol created this revision. apol added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Creates the necessary files in the build directory as well as provide a script that will install them to

D21987: Extend KDE Connect to images, video, audio, selection

broulik updated this revision to Diff 60324. broulik added a comment. - Fix id mismatch REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21987?vs=60315&id=60324 REVISION DETAIL https://phabricator.kde.org/D21987 AFFECTED FILES extensi

D21991: Add X-KDE-ParentApp entries in metadata.desktop

bshah created this revision. bshah added reviewers: apol, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY If this entry is not added, kpackagetool5 tries to load the specific packagestructure plugin, fa

D21990: Don't propagate a title change if it didn't actually change

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Ironically quite similar to a DDoS vector on the Task Manager. Apps suck :) REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D21990 To: broulik, #plas

D21990: Don't propagate a title change if it didn't actually change

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Noticed Telegram continuously touched the window title. The host didn't actually send a cha

D21988: Reject duplicate events with identical coordinates

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0628dab8f42b: Reject duplicate events with identical coordinates (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21988?vs=60316&id=60319

D21988: Reject duplicate events with identical coordinates

ngraham added a comment. Stable branch would be nice REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D21988 To: hein, #plasma, ngraham Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesli

D21988: Reject duplicate events with identical coordinates

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes perfect sense and fixes the bug. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D21988 To: hein, #plasma, ngraham Cc: ngraham, plas

D20442: Provide a KModifierKeyInfoProvider implementation

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R130:1a54c53bca82: Provide a KModifierKeyInfoProvider implementation (authored by apol). REPOSITORY R130 Frameworks integ

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

hein added a comment. In D21978#483972 , @hein wrote: > That's wrong, sorry - I'm uploading a different patch that fixes the underlying cause. D21988 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D21988: Reject duplicate events with identical coordinates

hein created this revision. hein added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY BUG:401861 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.or

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

hein added a comment. That's wrong, sorry - I'm uploading a different patch that fixes the underlying cause. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21978 To: filipf, hein, #plasma, ngraham Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ra

D21987: Extend KDE Connect to images, video, audio, selection

broulik updated this revision to Diff 60315. broulik added a comment. - Simplify REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21987?vs=60314&id=60315 REVISION DETAIL https://phabricator.kde.org/D21987 AFFECTED FILES extension/_loc

D21987: Extend KDE Connect to images, video, audio, selection

broulik created this revision. broulik added reviewers: Plasma, fvogt, davidedmundson, nicolasfella. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This lets it share image, video, and audio URLs as well as tex

KDE CI: Plasma » kwayland-integration » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20FreeBSDQt5.12/15/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 22 Jun 2019 10:32:31 + Build duration: 12 min and counting CONSOLE OUTPUT [...tru

D21811: [Calculator] Fix popup size and minimum size for expanded version

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:ba5d35dfe829: [Calculator] Fix popup size and minimum size for expanded version (authored by ngraham). REPOSITORY R1

D21811: [Calculator] Fix popup size and minimum size for expanded version

ngraham updated this revision to Diff 60312. ngraham added a comment. Just use a reasonable hardcoded size, per @davidedmundson's suggestion REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21811?vs=59830&id=60312 BRANCH fix-calculator-popup (branche

KDE CI: Plasma » kwayland-integration » kf5-qt5 SUSEQt5.12 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwayland-integration/job/kf5-qt5%20SUSEQt5.12/13/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 22 Jun 2019 10:32:30 + Build duration: 2 min 9 sec and counting CONSOLE OUTPUT [...trun

D21981: Set SwipeListItem implicitHeight to be the maximum of content and actions

This revision was automatically updated to reflect the committed changes. Closed by commit R169:43eb5fae5784: Set SwipeListItem implicitHeight to be the maximum of content and actions (authored by davidre). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21981

D21944: Show shortcut in menu item when specified

ngraham added inline comments. INLINE COMMENTS > apol wrote in MenuItem.qml:103 > Use Layout.rightMargin on the shortcut object. > https://doc.qt.io/qt-5/qml-qtquick-layouts-layout.html#rightMargin-attached-prop I think the original approach to use an Item was correct, both because now it looks

D21944: Show shortcut in menu item when specified

astippich added a comment. The menu separator now does not look correct: F6923245: menu_after2.png I don't know why REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D21944 To: astippich, mart, ngraha

D21944: Show shortcut in menu item when specified

astippich updated this revision to Diff 60300. astippich added a comment. - simplify REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21944?vs=60162&id=60300 BRANCH menu_item REVISION DETAIL https://phabricator.kde.org/D21944

D21981: Set SwipeListItem implicitHeight to be the maximum of content and actions

ngraham added a comment. Now that I look at it, the right-most button's right padding is also too high; it should be much closer to the right edge of the list item. Maybe good material for another patch. REPOSITORY R169 Kirigami BRANCH height (branched from master) REVISION DETAIL ht

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

ngraham added a comment. This works for me, and doesn't seem to break the triangle filter, but I'd like @hein to take a look since he wrote this code. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21978 To: filipf, hein, #plasma, ngraham Cc: plasma-devel, L

D21979: [System Load Viewer] Add a tooltip about the "CPUs separately" option

ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > GeneralSettings.qml:54 > +visible: parent.hovered > +text: i18n("CPUs can be shown separately when using compact bar > monitor") > +

D21934: Ensure no one but us writes to stdout

This revision was automatically updated to reflect the committed changes. Closed by commit R856:ee36561ca66f: Ensure no one but us writes to stdout (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21934?vs=60182&id=60290

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

ngraham created this revision. ngraham added reviewers: VDG, Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Calculator and Unit Converter runners are some of the most useful and productivity

D21959: Fix selectedNameFilter() multiple matches

hoffmannrobert updated this revision to Diff 60286. hoffmannrobert added a comment. - Remove redundant condition REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21959?vs=60217&id=60286 BRANCH fix_selectedNameFilter REVIS

D21980: Fix ocasional crash on the touchpad kded

This revision was automatically updated to reflect the committed changes. Closed by commit R119:920e39c2e5cc: Fix ocasional crash on the touchpad kded (authored by aacid). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21980?vs=60283&id=60285 REVISION

D21980: Fix ocasional crash on the touchpad kded

atulbi accepted this revision. atulbi added a comment. Me too REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D21980 To: aacid, atulbi, ngraham Cc: ngraham, knambiar, atulbi, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen,

D21981: Set SwipeListItem implicitHeight to be the maximum of content and actions

ngraham added subscribers: mart, ngraham. ngraham added reviewers: Kirigami, mart. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. @mart? REPOSITORY R169 Kirigami BRANCH height (branched from master) REVISION DETAIL https:

D21980: Fix ocasional crash on the touchpad kded

ngraham added a reviewer: atulbi. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. @atulbi? REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D21980 To: aacid, atulbi, ngraham Cc

  1   2   >