D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

2019-06-20 Thread Noah Davis
ndavis added a comment. I feel like these names should be localized, but the gallery gets the sames from the file names. No translations unless that gets fixed. REPOSITORY R128 User Manager BRANCH user-pictures (branched from master) REVISION DETAIL https://phabricator.kde.org/D21939

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

2019-06-20 Thread Noah Davis
ndavis added a comment. In D21939#482934 , @filipf wrote: > Agreed with all the removals. > > New ones should be sufficient for just about any screen and they look great. I'm okay with the namings. Good work! > > If it's doable, I would o

D20867: Add Property to disable drawing of menu arrow indicators

2019-06-20 Thread David Hallas
hallas added a comment. In D20867#482950 , @ngraham wrote: > Actually maybe it just needs a rebase on master... Let me give it a rebase then :D REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D20867 To: hallas, ngr

D21944: Show shortcut in menu item when specified

2019-06-20 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > MenuItem.qml:98 > +font: controlRoot.font > +color: (controlRoot.highlighted || controlRoot.hovered) ? > Kirigami.Theme.highlightedTextColor : Kirigami.Theme.textColor > +horizontalAlignment: Text.AlignRight label

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-06-20 Thread Filip Fila
filipf added a comment. That's what I thought, but it doesn't work :/ What we know is the gap was there before. Since we've now got a Kirigami.ScrollablePage, we can scroll all the content up by holding the mouse. And we can also just make the ScrollablePage the top item. Regardless of t

Re: Vision on web page

2019-06-20 Thread Nate Graham
Personally I like the faux window, but if so, it should be centered. Maybe it could be in a sticky note widget! On 6/20/19 3:37 PM, David Edmundson wrote: At the bottom, not as a faux window. David

D20867: Add Property to disable drawing of menu arrow indicators

2019-06-20 Thread Nathaniel Graham
ngraham added a comment. Actually maybe it just needs a rebase on master... REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D20867 To: hallas, ngraham Cc: mart, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, le

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-06-20 Thread Nathaniel Graham
ngraham added a comment. Hey that looks pretty good! To fix the top gap, I wonder if it would suffice to add `anchors.fill: parent` or some other positioning mechanism to the top-most `ColumnLayout` inside the `Kirigami.ScrollablePage`. REPOSITORY R102 KInfoCenter REVISION DETAIL h

D21942: Add gitignore

2019-06-20 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah ok, makes sense. REPOSITORY R134 Discover Software Store BRANCH gitignore REVISION DETAIL https://phabricator.kde.org/D21942 To: nicolasfella, apol, ngraham Cc: plasma-devel, L

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

2019-06-20 Thread Filip Fila
filipf added a comment. What I've got right now is: F6918999: image.png F6919002: main.qml The most notable UI change is probably the fact that I added an inline message to waste less space. So we

D21926: Have more contrast in circle-style user avatars

2019-06-20 Thread Filip Fila
filipf planned changes to this revision. filipf added a comment. Good catch. I'll need a bit of help with that but should be doable. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D21926 To: filipf, #vdg, ngraham, ndavis Cc: ngraham, plasma-devel, LeGast00n, jra

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

2019-06-20 Thread Filip Fila
filipf accepted this revision. filipf added a comment. Agreed with all the removals. New ones should be sufficient for just about any screen and they look great. I'm okay with the namings. Good work! If it's doable, I would only possibly consider replacing PC Builder Konqi with Guit

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

2019-06-20 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I might prefer "Business Konqi", but "Boss" is probably fine. Let's make sure to add some new avatars too, or else most of what we have will be Konqis. :) Also we need to make the ava

D21944: Show shortcut in menu item when specified

2019-06-20 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Excellent. Looks like a sane way to do it. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH menu_item REVISION DETAIL https://phabricator.kde.org/D21944 To: astippich, ma

D20867: Add Property to disable drawing of menu arrow indicators

2019-06-20 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This patch doesn't seem to make the back and forward buttons lose their arrows once I've applied D19311 , and it also makes all KDE apps cras

Re: Vision on web page

2019-06-20 Thread David Edmundson
At the bottom, not as a faux window. David

Vision on web page

2019-06-20 Thread Jonathan Riddell
How's this for the plasma vision on web page? Which of the two positions do you prefer? http://apps.kde.org.uk/plasma-desktop Jonathan

D21860: Set a font for gtk applications in the fonts kcm

2019-06-20 Thread Mikhail Zolotukhin
gikari added a comment. In D21860#481370 , @broulik wrote: > Actually, for most appearance settings (color scheme, widget style, icon settings) it should already be signalled automatically via DBus through plasma-integration with no config readi

D21926: Have more contrast in circle-style user avatars

2019-06-20 Thread Noah Davis
ndavis added a comment. Unless you want to get rid of the SVG these avatars were created from, you should also update `pics_sources/avatar.svg`. REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D21926 To: filipf, #vdg, ngraham, ndavis Cc: ngraham

D21915: Fix crash in the touchpad kded

2019-06-20 Thread Albert Astals Cid
aacid added a subscriber: atulbi. aacid added a comment. In D21915#482182 , @knambiar wrote: > In D21915#482145 , @aacid wrote: > > > The other question is if "enabled" was ever the correct atom to ch

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

2019-06-20 Thread Noah Davis
ndavis added a comment. In D21939#482800 , @GB_2 wrote: > Great! I'd only change the name of these avatars: > Boss Konqi -> Banker Konqi > Hacker Konqi -> Developer Konqi / Programmer Konqi I chose boss and hacker because I want the

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

2019-06-20 Thread Noah Davis
ndavis updated this revision to Diff 60165. ndavis added a comment. Rename duelist to card shark REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21939?vs=60164&id=60165 BRANCH user-pictures (branched from master) REVISION DETAIL https://phabricato

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

2019-06-20 Thread Noah Davis
ndavis added a comment. Saying i In D21939#482861 , @ngraham wrote: > Hmm, I don't think "duelist" is the right word. That one makes me think "card shark". Yeah, it was just a dumb Yu-Gi-Oh reference that doesn't really make sense in

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

2019-06-20 Thread Nathaniel Graham
ngraham added a comment. Hmm, I don't think "duelist" is the right word. That one makes me think "card shark". REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D21939 To: ndavis, #vdg, #plasma Cc: GB_2, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ra

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

2019-06-20 Thread Noah Davis
ndavis updated this revision to Diff 60164. ndavis added a comment. Fix spelling of dualist REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21939?vs=60163&id=60164 BRANCH user-pictures (branched from master) REVISION DETAIL https://phabricator.kde

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

2019-06-20 Thread Felix Ernst
felixernst added a comment. I don't think Konqi should be called a banker when wearing a suit. It doesn't fit the collaborative non-profit nature of KDE. I think Boss Konqi is alright. Business Konqi can work too. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

2019-06-20 Thread Noah Davis
ndavis updated this revision to Diff 60163. ndavis removed a subscriber: felixernst. ndavis added a comment. Change names of Bugcatcher and Officeworker to be more grammatically correct REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21939?vs=60153&id=6

D21944: Show shortcut in menu item when specified

2019-06-20 Thread Alexander Stippich
astippich added a comment. This is required to port the menu of Elisa to qqc2 (D21943 ) qqc1 version F6918483: menu_qqc1.png qqc2 version without this patch F6918485: menu_before.png

D21944: Show shortcut in menu item when specified

2019-06-20 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: mart, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. astippich requested review of this revision. REVISION SUMMARY Show the shortcut as text for menu items when they are given via an action REPOSIT

D21927: Use window.postMessage instead of creating a wrapper item

2019-06-20 Thread Fabian Vogt
fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. > Also do some more sanity checks on the input data. Are those even necessary at that point? Considering that the referenced payload properties can still be literally anything

D21934: Ensure no one but us writes to stdout

2019-06-20 Thread Fabian Vogt
fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > connection.cpp:39 > +int newStdout = dup(STDOUT_FILENO); > +close(STDOUT_FILENO); > +m_stdOut.open(newStdout, QIODevice::WriteOnly); I'd `dup2(STDER

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

2019-06-20 Thread Björn Feber
GB_2 added a comment. Great! I'd only change the name of these avatars: Boss Konqi -> Banker Konqi Hacker Konqi -> Developer Konqi / Programmer Konqi REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D21939 To: ndavis, #vdg, #plasma Cc: GB_2, ngraham, plasma-de

D21942: Add gitignore

2019-06-20 Thread Nicolas Fella
nicolasfella added a comment. In D21942#482796 , @ngraham wrote: > Where do `*.kdev4` files come from? Those are KDevelop project files REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D21942 To: n

D21942: Add gitignore

2019-06-20 Thread Nathaniel Graham
ngraham added a comment. Where do `*.kdev4` files come from? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D21942 To: nicolasfella, apol, ngraham Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezha

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

2019-06-20 Thread Nathaniel Graham
ngraham added a comment. Very nice! What happens to a user who was using one of the old images though? Is it preserved, or does their user avatar suddenly become blank? REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D21939 To: ndavis, #vdg, #plasma Cc: ngraham,

D21942: Add gitignore

2019-06-20 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: apol, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R134 Discover Software Store BRANCH gitignore REVISION DETAIL https://phabric

D21935: [devicenotifier] Hide plasmoid if no device is available

2019-06-20 Thread Nathaniel Graham
ngraham added a comment. In D21935#482746 , @broulik wrote: > Not sure how useful it actually is to show non removable drives there. I only use that for testing, if ever. +/-0 from my side If you opt to make it show all drives, then it wo

D21941: Hide update notifier completely when no updates are available

2019-06-20 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R134:f6ac17b54b8d: Hide update notifier completely when no updates are available (authored by nicolasfella). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D21941: Hide update notifier completely when no updates are available

2019-06-20 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: ngraham, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY The applet isn't particularly useful when no updates are available. Hide it

D21939: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars

2019-06-20 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY The Konqi mascots are so good, we might as well use them. Our existing avatars are not so good,

D21935: [devicenotifier] Hide plasmoid if no device is available

2019-06-20 Thread Kai Uwe Broulik
broulik added a comment. Not sure how useful it actually is to show non removable drives there. I only use that for testing, if ever. +/-0 from my side REPOSITORY R120 Plasma Workspace BRANCH hideit REVISION DETAIL https://phabricator.kde.org/D21935 To: nicolasfella, #plasma, ngraham

D21935: [devicenotifier] Hide plasmoid if no device is available

2019-06-20 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, it's pointless to show something that can't be interacted with. I suppose technically you could right-click on it and configure it, but that seems like a niche use case (I doubt more

D21935: [devicenotifier] Hide plasmoid if no device is available

2019-06-20 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY When no device is present the plasmoid doesn't do anything interactive. It

D21934: Ensure no one but us writes to stdout

2019-06-20 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I originally didn't consider this neccessary because we have a `qMessageHan

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-20 Thread Filip Fila
filipf added a comment. For positioning the menu maybe you could have a look at how it was done in Kickoff config window: https://github.com/KDE/plasma-desktop/blob/master/applets/kickoff/package/contents/ui/ConfigGeneral.qml REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phab

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-20 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > KeyboardButton.qml:10 > PlasmaComponents.ToolButton { > -id: keyboardButton > +id: toolBtn > Prefer descriptive variable names; `toolButton` is better than `toolBtn`, but even better would be a description of what this button is actual

D21927: Use window.postMessage instead of creating a wrapper item

2019-06-20 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > content-script.js:642 > +if (!["none", "paused", "playing"].includes(payload)) { > +console.log("shit playback state", payload); > +return; Oops :) REPOSITORY R856 Plasma Browser Integrati

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-20 Thread Carson Black
cblack updated this revision to Diff 60136. cblack added a comment. - Remove Item {} root and embed QQC2.Menu {} in PlasmaComponents.ToolButton{} - If toolbutton is larger than largest menu item, resize menu to size of toolbutton - Other minor things REPOSITORY R120 Plasma Workspace CH

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-20 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > filipf wrote in SessionButton.qml:47 > While we're doing this, can you perhaps make the menu pop up *above* the > button? It seems that changing the `y` value doesn't affect its y position for whatever reason. REPOSITORY R120 Plasma Workspace

D21784: Remove accidentally slipped back traces of cmake code for Plasma style

2019-06-20 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R169:89b9f8768ee4: Remove accidentally slipped back traces of cmake code for Plasma style (authored by kossebau). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21784?v

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 26 - Fixed!

2019-06-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/26/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 20 Jun 2019 14:11:59 + Build duration: 6 min 7 sec and counting JUnit Tests Name: (

D21918: [powerdevil] Connect to battery source events

2019-06-20 Thread Anthony Fieroni
This revision was automatically updated to reflect the committed changes. Closed by commit R122:a1f9e365a5b4: [powerdevil] Return battery source monitoring (authored by anthonyfieroni). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21918?vs=60098&id=60131

D21895: print a warning when invoking the scripting API's sleep()

2019-06-20 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. we could make it a no op even? REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D21895 To: sitter, mart Cc: davidedmundson, plasma-devel,

D21918: [powerdevil] Connect to battery source events

2019-06-20 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Oh, shit. Thanks! 5.16 branch please REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D21918 To: anthonyfieroni, broulik, #plasma, davidedmundson Cc: plasma-dev

D21926: Have more contrast in circle-style user avatars

2019-06-20 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. There we go, much better. Thanks! REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D21926 To: filipf, #vdg, ngraham, ndavis Cc: ngraham, plas

D21926: Have more contrast in circle-style user avatars

2019-06-20 Thread Filip Fila
filipf updated this revision to Diff 60122. filipf added a comment. fix permissions, take 2 REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21926?vs=60120&id=60122 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21926 AFFECTED FILES

D21927: Use window.postMessage instead of creating a wrapper item

2019-06-20 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This should make it less invasive by not messing with the website DOM. Als

D21926: Have more contrast in circle-style user avatars

2019-06-20 Thread Filip Fila
filipf updated this revision to Diff 60120. filipf edited the test plan for this revision. filipf added a comment. fix permissions REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21926?vs=60118&id=60120 BRANCH circle-avatars-better-contrast (branched

D21926: Have more contrast in circle-style user avatars

2019-06-20 Thread Nathaniel Graham
ngraham added a comment. Looks like the permissions have changed too? REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D21926 To: filipf Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed

D21926: Have more contrast in circle-style user avatars

2019-06-20 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Our circular avatar currently don't have the best contrast between their background and main element, which is especially evident whe

D20908: RFC: Redesign QML applet configuration windows

2019-06-20 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. There we go, much better. F6917696: Screenshot_20190620_151607.png This is so nice. Let's not commit it until @mart's companion patch for B

D21925: Update joystick kcm documentation for game controllers

2019-06-20 Thread Yuri Chornoivan
yurchor accepted this revision. yurchor added a comment. This revision is now accepted and ready to land. Thanks. Please answer the comment then push if you want to. REPOSITORY R119 Plasma Desktop BRANCH joystick-settings (branched from master) REVISION DETAIL https://phabricator.kde.o

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-20 Thread Filip Fila
filipf added a comment. Added some comments that apply to both button files. On a final note, watch out for whitespace because there's lots of it that's been added. You can turn on whitespace displaying in Kate: F6894460: image.png INLINE COMME

D21925: Update joystick kcm documentation for game controllers

2019-06-20 Thread Nathaniel Graham
ngraham added a reviewer: Documentation. ngraham added inline comments. INLINE COMMENTS > index.docbook:71 > > The plotted location of the X and Y axes of the joystick. Enable > Show trace > to plot the path of the joystick from one point to another. `of the joystick` -> `of the game contro

D21922: Rename Joystick KCM to Game Controller

2019-06-20 Thread Nathaniel Graham
ngraham added a comment. Looks like that's in D21925 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21922 To: ndavis, #plasma, #vdg, ngraham Cc: ltoscano, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ra

D21872: Translate keyboard layouts in sddm

2019-06-20 Thread Nathaniel Graham
ngraham added a comment. So is this unnecessary, and the string should be translated somewhere over in FreeDesktop-land? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21872 To: McPain, ngraham, #plasma Cc: pshinjo, davidedmundson, plasma-devel, LeGast00n,

D13930: [KdePlasma-addons][POTD]{SIOD} Added new provider SIOD to handle Images from Space.com

2019-06-20 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks, now the name shows up in the combobox. However I'm not sure the images are fetched properly. I get a black background, rather than an image. REPOSITORY R114 Plasma Add

D21925: Update joystick kcm documentation

2019-06-20 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: Plasma. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. ndavis requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH joystick-settings (branched from master) REVIS

D20908: RFC: Redesign QML applet configuration windows

2019-06-20 Thread Filip Fila
filipf updated this revision to Diff 60115. filipf added a comment. fix wrong sidebar width REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=60101&id=60115 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20908 AFFECTED FILES

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

2019-06-20 Thread Nathaniel Graham
ngraham added a comment. Instead of adding another tab, how about putting the shortcuts editor below the plugins list? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D15341 To: smithjd, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fb

D20908: RFC: Redesign QML applet configuration windows

2019-06-20 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, something's not right anymore: F6917589: Screenshot_20190620_143140.png REPOSITORY R119 Plasma Desktop REVISION DETAIL http

D21909: [Colors KCM] Assign properties in a binding

2019-06-20 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:0b72df235a0a: [Colors KCM] Assign properties in a binding (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21909?vs=60075&id=60114 REVI

D21922: Rename Joystick KCM to Game Controller

2019-06-20 Thread Luigi Toscano
ltoscano added a comment. The documentation should have been changed as well. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21922 To: ndavis, #plasma, #vdg, ngraham Cc: ltoscano, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel

D21922: Rename Joystick KCM to Game Controller

2019-06-20 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R119:1c24138b481a: Rename Joystick KCM to Game Controller (authored by ndavis). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21922?vs=60106&id=60110 REVISION D

D21922: Rename Joystick KCM to Game Controller

2019-06-20 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks great! REPOSITORY R119 Plasma Desktop BRANCH joystick-settings (branched from master) REVISION DETAIL https://phabricator.kde.org/D21922 To: ndavis, #plasma, #vdg, ngraham C

D14490: [System Monitor] Enable high dpi pixmaps

2019-06-20 Thread Nathaniel Graham
ngraham added a comment. @broulik can this land? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14490 To: broulik, #plasma, davidedmundson, ngraham Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, al

D21922: Rename Joystick KCM to Game Controller

2019-06-20 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Most people will use it for calibrating game controllers and the icon was recently changed to a

D19612: RFC port to bugzilla REST API

2019-06-20 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good! REPOSITORY R871 DrKonqi BRANCH webservice REVISION DETAIL https://phabricator.kde.org/D19612 To: sitter, apol Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2

D21918: [powerdevil] Connect to battery source events

2019-06-20 Thread Anthony Fieroni
anthonyfieroni added a reviewer: davidedmundson. anthonyfieroni added a comment. it's removed in D20157 REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D21918 To: anthonyfieroni, broulik, #plasma, davidedmundson Cc: plasma-devel

D20908: RFC: Redesign QML applet configuration windows

2019-06-20 Thread Filip Fila
filipf updated this revision to Diff 60101. filipf added a comment. line 218: width -> implicitWidth REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=60100&id=60101 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20908 AFFECT

D20908: RFC: Redesign QML applet configuration windows

2019-06-20 Thread Filip Fila
filipf updated this revision to Diff 60100. filipf added a comment. rebase on master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=57680&id=60100 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20908 AFFECTED FILES deskt

Technical Advise for PlasmaQuick::ContainmentView [Latte]

2019-06-20 Thread Michail Vourlakos
Hello everyone, I need some help, Latte::Indicators (https://store.kde.org/browse/cat/563/) are standalone qml only packages like plasma applets which are loaded in order to show Tasks indication/information My issue is that when an indicator's qml code is updated I would like the user to notice

D21918: [powerdevil] Connect to battery source events

2019-06-20 Thread Anthony Fieroni
anthonyfieroni created this revision. anthonyfieroni added reviewers: broulik, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY I don't know how this works till now, but without monitor battery per

D21915: Fix crash in the touchpad kded

2019-06-20 Thread Rajeesh K Nambiar
knambiar added a comment. In D21915#482145 , @aacid wrote: > The other question is if "enabled" was ever the correct atom to check for > > libinput Tapping Enabled I'm fairly sure we were checking for `libinput Tapping Enabled` atom in