D21828: Invert controls direction for process priority slider

2019-06-15 Thread Christoph Feck
cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D21828 To: kishoreg, cfeck Cc: cfeck, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenB

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

2019-06-15 Thread Björn Feber
GB_2 added a comment. I think `plasma-sddm.conf` is a better filename. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH new-config-location (branched from master) REVISION DETAIL https://phabricator.kde.org/D21832 To: filipf, davidedmundson, ngraham, #plasma Cc: GB_2, plasma-deve

D21832: [sddm-kcm] Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

2019-06-15 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Good stuff, thanks REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH new-config-location (branched from master) REVISION DETAIL https://phabricator.kde.org/D21832

D21832: [sddm-kcm] WIP: Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

2019-06-15 Thread Filip Fila
filipf marked 3 inline comments as done. filipf added inline comments. INLINE COMMENTS > davidedmundson wrote in sddmauthhelper.cpp:86 > if something is going into the file "kde_settings.conf" then we want to > remove it from sddmOldConfig > > Nothing in args is sent with this filename Thanks!

D21832: [sddm-kcm] WIP: Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

2019-06-15 Thread Filip Fila
filipf updated this revision to Diff 59890. filipf added a comment. - revert 2 unecessary changes to file location - actually delete duplicate entries from sddm.conf - tidy up comment REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 33 - Still Failing!

2019-06-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/33/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 15 Jun 2019 18:12:34 + Build duration: 1 hr 46 min and counting CONSOLE OUTPUT [...tru

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 32 - Still Failing!

2019-06-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/32/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 14 Jun 2019 13:07:03 + Build duration: 1 day 5 hr and counting CONSOLE OUTPUT [...trun

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 9 - Still Failing!

2019-06-15 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/9/ Project: stable-kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 14 Jun 2019 13:07:03 + Build duration: 1 day 5 hr and counting CONSOLE OUTPUT

D21832: [sddm-kcm] WIP: Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

2019-06-15 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > sddmauthhelper.cpp:86 > +// see: > https://github.com/sddm/sddm/blob/develop/src/common/ConfigReader.cpp#L144 > +if (f

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black
cblack updated this revision to Diff 59884. cblack added a comment. Use PC3 components in the kb & session buttons instead of PC2 components REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=59880&id=59884 BRANCH sddm-qqc2-port (branched f

D21832: [sddm-kcm] WIP: Write settings to /etc/sddm.conf.d instead of etc/sddm.conf

2019-06-15 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY As of SDDM release 0.16.0 it advised to use /etc/sddm.conf.d/ as the directory for user settings. This patch aims to achieve it

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > cblack wrote in SessionButton.qml:23 > The `menu` property seems to be removed in PC3 Additionally, `ToolButton` still seems to use QQC1 even in PC3. REPOSIT

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > davidedmundson wrote in SessionButton.qml:23 > Note that (confusingly) Plasma components 2 is QQC1 > Plasma components3 is QQC2 > > It might fix the menu issue The `menu` property seems to be removed in PC3 REPOSITORY R120 Plasma Workspace REV

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > SessionButton.qml:23 > import org.kde.plasma.core 2.0 as PlasmaCore > import org.kde.plasma.components 2.0 as PlasmaComponents > Note that (confusingly) Plasma components 2 is QQC1 Plasma components3 is QQC2 It might fix the menu issue

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Filip Fila
filipf added a comment. Seems like you have all the QQC1 imports covered. I'm seeing a couple more in other files that are unused so it would be perfectly fine to remove them as a part of this diff. I'll give the new code a spin soon and then I can add more detailed comments. REPOSITORY

D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips

2019-06-15 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f65a0eee09da: PanelView: align setting of masks with how it's done for dialogs/tooltips (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.o

Re: 5.17 Kickoff Meeting

2019-06-15 Thread Nate Graham
On 6/15/19 2:00 AM, Jonathan Riddell wrote: Great, I added it to the meeting etherpad, please go over the phab tasks and triage them. Please also decide on a version of Qt to be the minimum, possibly Qt 5.13 will be out by then. And review the schedule we agreed on, release is currently penc

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black
cblack added inline comments. INLINE COMMENTS > davidedmundson wrote in SessionButton.qml:27 > Why the wrapper? QML files can only have one root, and the ToolButton's `menu` property doesn't accept QQC2 menus, meaning they have to be separated. REPOSITORY R120 Plasma Workspace REVISION DETA

D21815: [sddm-theme] Start moving from QQC1 to QQC2

2019-06-15 Thread Carson Black
cblack updated this revision to Diff 59880. cblack added a comment. Updates based off of feedback, and adding the standard menu fade animation to the QQC2 menus. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21815?vs=59842&id=59880 BRANCH sddm

D21690: Only show system total cpu usage by default on high core count machines

2019-06-15 Thread Robin Appelman
rappelman added a comment. ro...@icewind.nl REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21690 To: rappelman, #plasma, #vdg, davidedmundson Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezha

D21829: Improved Touch support for Kickoff

2019-06-15 Thread Steffen Hartleib
steffenh created this revision. steffenh added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. steffenh requested review of this revision. REVISION SUMMARY - enabled touch scrolling in Kickoff - open the correct category in the application tab - o

D21828: Invert controls direction for process priority slider

2019-06-15 Thread Kishore Gopalakrishnan
kishoreg updated this revision to Diff 59864. kishoreg added a comment. Do the same for the ionice slider too. REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21828?vs=59862&id=59864 REVISION DETAIL https://phabricator.kde.org/D21828 AFFECTED F

D21828: Invert controls direction for process priority slider

2019-06-15 Thread Kishore Gopalakrishnan
kishoreg created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kishoreg requested review of this revision. REVISION SUMMARY Since low 'nice' values correspond to high priority, the slider labels are inverted so that 'higher' corresponds to a lower nice

Re: 5.17 Kickoff Meeting

2019-06-15 Thread Jonathan Riddell
On Fri, 14 Jun 2019 at 19:36, Aleix Pol wrote: > On Fri, Jun 14, 2019 at 7:08 PM Jonathan Riddell wrote: > > > > We would typically have a start of cycle Kickoff meeting sometime in the > coming week. But there is a Sprint happening next Wednesday to the > following Wednesday. I'm also aware t