D21725: Use a native application for starting plasma

broulik added inline comments. INLINE COMMENTS > fvogt wrote in startplasma-wayland.cpp:41 > AFAICT this won't work as expected: localed is only launched on demand, which > `isServiceRegistered` does not care about. Indeed. When it's not registered, query "org.freedesktop.DBus", "/org/free

D21273: Add support for newer linux kernel power_supply API

meven added a comment. Friendly ping to our dear reviewers @broulik @davidedmundson @hein REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D21273 To: luc4, davidedmundson, broulik, hein Cc: meven, alexeymin, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragree

Re: Plasma dialogs (and others?) disappearing on wayland + Qt 5.13

On Mon, Jun 10, 2019 at 8:06 PM David Edmundson wrote: > > I have krunner sometimes reposition itself wrongly but that's all. > > If you can get a log with > WAYLAND_DEBUG=1 krunner that would be great. > > kwin also has a debug console to list windows it knows of which would > be useful to check

Re: Plasma dialogs (and others?) disappearing on wayland + Qt 5.13

[1] this occurs in my system since always (even back to Qt 5.11) but I always thought that it might be a drivers issue (I have an optimus laptop so I can not trust it) probably with Qt 5.13 might hit more users. [2] in the same category one more major issue under wayland in my system is that the

D21701: [kcm-colors] Do not ship any additional color schemes

ngraham added a comment. In D21701#477658 , @filipf wrote: > No, that definitely sounds like the right approach. It would also allow us to have an official channel through which we could offer bleeding edge design experimentation. > > I don'

D21701: [kcm-colors] Do not ship any additional color schemes

filipf added a comment. No, that definitely sounds like the right approach. It would also allow us to have an official channel through which we could offer bleeding edge design experimentation. I don't know how to go about setting a new repo, but with this being targeted for 5.17 we hav

D21701: [kcm-colors] Do not ship any additional color schemes

ngraham added a comment. It's good that the active color scheme is saved on disk somewhere (unlike the wallpaper, see https://bugs.kde.org/show_bug.cgi?id=408223), and it's also nice that the KCM is smart enough to handle this case. The wording on that error message could maybe be improved,

Plasma dialogs (and others?) disappearing on wayland + Qt 5.13

Hey, Since I switched to a Qt 5.13 build, I'm seeing that some dialogs eventually stop showing up. It happens randomly and I'm not even sure that it's Qt's fault anymore, but I wouldn't discard it either. Initially I thought it would be [1] but it got fixed and I still get it. An easy way to trig

D21725: Use a native application for starting plasma

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > startplasma-wayland.cpp:41 > +// set XKB_DEFAULT_{MODEL,LAYOUT,VARIANT,OPTIONS} accordingly. > +if > (QDBusConnection::systemBus().interface()->isServic

D21701: [kcm-colors] Do not ship any additional color schemes

filipf added a comment. Then they'll be removed it seems. Kdeglobals does save the color scheme in use, and updating wouldn't change it to something else. It wouldn't, however, leave the color scheme in the KCM: F6882212: image.png REPOSITORY

D21725: Use a native application for starting plasma

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in startplasma.cpp:142 > Don't yet. > > This being here is (I think) the result of a lazy hack due to env vars not > getting synced properly from kcminit. I hope to address that. > > Obviously your port being a 1:1 clone is fin

D21725: Use a native application for starting plasma

apol updated this revision to Diff 59529. apol added a comment. braces REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21725?vs=59528&id=59529 BRANCH apol/startkde REVISION DETAIL https://phabricator.kde.org/D21725 AFFECTED FILES plasma.des

D21701: [kcm-colors] Do not ship any additional color schemes

ngraham added a comment. Just recompiling from source doesn't delete files on disk. However distro package managers do. So to test a change that removes files, you need to remove them on disk yourself to simulate what will happen when users update their systems. REPOSITORY R119 Plasma Des

D21725: Use a native application for starting plasma

apol updated this revision to Diff 59528. apol added a comment. Clean debug REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21725?vs=59525&id=59528 BRANCH apol/startkde REVISION DETAIL https://phabricator.kde.org/D21725 AFFECTED FILES plasm

D21725: Use a native application for starting plasma

apol updated this revision to Diff 59525. apol added a comment. Make sure plasma-localerc is created REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21725?vs=59519&id=59525 BRANCH apol/startkde REVISION DETAIL https://phabricator.kde.org/D2172

D21701: [kcm-colors] Do not ship any additional color schemes

filipf added a subscriber: broulik. filipf added a comment. I ran this test: - compiled plasma-desktop, master version - applied this patch and compiled again - // color schemes were not deleted - compiled breeze - // same result Let me know if this isn't the best of methodolo

D21725: Use a native application for starting plasma

davidedmundson added a comment. Concept ++ > Started different systems on different distros, on wayland and x11. Given this is a huge change, please expand on this and confirm we've covered all paths. Debug needs cleaning (or QCDebug) before merge. > #preload the

D21725: Use a native application for starting plasma

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY At the moment we had several scripts to start the different processes. With this we unify this code into a

D21701: [kcm-colors] Do not ship any additional color schemes

filipf added a comment. The first time I compiled this I actually forgot to clean up the `color-schemes` folder and nothing happened, the patch didn't delete the old schemes. That's why I concluded it would only be relevant for new installs. I will check again though. In D21701#477368 <

D21493: Port away from foreach()

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b2a869fa9c93: Port away from foreach() (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21493?vs=58878&id=59515#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDA

D21701: [kcm-colors] Do not ship any additional color schemes

abetts added a comment. +1 on principle. Many of these color themes are old and unmaintained. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21701 To: filipf, #plasma, #vdg, ngraham Cc: abetts, davidedmundson, nicolasfella, plasma-devel, LeGast00n, ericadams,

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. > Firefox's scrollbar still does not have the correct appearance... Do you mean Firefox having blue scroollbar now, instead of grey it had before? Is that a real problem? I mean, couldn't it stay like this? The problem roots from default color now being blue instead

D21667: Optionally display threads as if they were processes

topimiettinen added a comment. In D21667#477393 , @davidedmundson wrote: > What information would an end user gain from doing this? They get to see how programs uses threads, for example to help develop programs. It's probably not very u

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. Thanks! However Firefox's scrollbar still does not have the correct appearance when not hovered; compare it to GIMP or Inkscape. This is a regression from the status quo. Everything else looks good to me now, but that regression needs to be fixed before we can land t

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. @ngraham Can you please review this? It's as good as I can make it. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: filipf, ngraham, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh,

D21667: Optionally display threads as if they were processes

davidedmundson added a comment. What information would an end user gain from doing this? REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D21667 To: topimiettinen Cc: davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot

D21701: [kcm-colors] Do not ship any additional color schemes

davidedmundson added a comment. Have you tested what happens when a user is using this theme and we remove it? We /might/ be ok in this case, as it copies data to kdeglobals. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21701 To: filipf, #plasma, #vdg,

D21702: Ship color schemes with Oxygen

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense for the theme's repo to provide its own color scheme rather than having it there. REPOSITORY R113 Oxygen Theme BRANCH add-oxygen-color-schemes (branched from master) REV

D21701: [kcm-colors] Do not ship any additional color schemes

ngraham added a comment. That was actually going to be my next question. :) Yes, we'll need to gracefully handle that case too so people don't just get their color scheme changed from under them. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21701 To: fili

D21701: [kcm-colors] Do not ship any additional color schemes

nicolasfella added a comment. What will happen if the user has one of those color schemes installed and upgrades Plasma? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21701 To: filipf, #plasma, #vdg, ngraham Cc: nicolasfella, plasma-devel, LeGast00n, ericad

D21701: [kcm-colors] Do not ship any additional color schemes

ngraham added a comment. +1 in principle. I think two things need to happen before we do this: 1. We need to upload the old ones to store.kde.org, preferably under a shared VDG account so that they can't just randomly go away if whoever uploads it leaves KDE or deletes their account

D21493: Port away from foreach()

apol added a comment. ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21493 To: apol, #plasma Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mar

D21670: Enforce use of the reset timer for clearing the model

This revision was automatically updated to reflect the committed changes. Closed by commit R112:9d5921fb21c7: Enforce use of the reset timer for clearing the model (authored by fvogt). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21670?vs=59407&id=59490 REVIS

D21685: [minimzeall] Actually change max panel icon size to smallMedium

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:5de082c39b91: [minimzeall] Actually change max panel icon size to smallMedium (authored by ndavis). REPOSITORY R119