D21591: Panel: Use bitwise operators on flags

2019-06-04 Thread David Edmundson
davidedmundson abandoned this revision. davidedmundson added a comment. heh, thanks REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21591 To: davidedmundson, #plasma Cc: broulik, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, h

D21591: Panel: Use bitwise operators on flags

2019-06-04 Thread Kai Uwe Broulik
broulik added a comment. `git pull` https://cgit.kde.org/plasma-workspace.git/commit/?id=f6258fa4ec69243fd638251eafeeb10af5e8c66e :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21591 To: davidedmundson, #plasma Cc: broulik, plasma-devel, LeGast00n, eri

D21591: Panel: Use bitwise operators on flags

2019-06-04 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY ! is only for booleans REPOSITORY R120 Plasma Workspace REVISION DETAIL

D16425: Added new Suspend then Hibernate option

2019-06-04 Thread Ambareesh Balaji
abalaji added inline comments. INLINE COMMENTS > suspendsessionconfig.cpp:45 > { > - > +m_suspendThenHibernateEnabled = nullptr; > } Move this to the initializer REPOSITORY R122 Powerdevil BRANCH arcpatch-D16425_1 REVISION DETAIL https://phabricator.kde.org/D16425 To: avaldes, br

D16425: Added new Suspend then Hibernate option

2019-06-04 Thread Alejandro Valdes
avaldes marked 5 inline comments as done. avaldes added a comment. Sorry for the constant spam of the original commit message, I cannot make arcanist to pick up a new commit for this differential without deleting the old one. Added changes based on code review comments REPOSITORY R122

D16425: Added new Suspend then Hibernate option

2019-06-04 Thread Alejandro Valdes
avaldes updated this revision to Diff 59170. avaldes marked 2 inline comments as done. avaldes added a comment. Added new Suspend then Hibernate option Summary: See bug 399727 for a good description of what this code is for. The new ui

KDE CI: Plasma » breeze » stable-kf5-qt5 FreeBSDQt5.12 - Build # 42 - Fixed!

2019-06-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze/job/stable-kf5-qt5%20FreeBSDQt5.12/42/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 05 Jun 2019 00:26:14 + Build duration: 14 min and counting

KDE CI: Plasma » breeze » stable-kf5-qt5 FreeBSDQt5.12 - Build # 41 - Failure!

2019-06-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze/job/stable-kf5-qt5%20FreeBSDQt5.12/41/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 04 Jun 2019 22:22:31 + Build duration: 2 hr 2 min and counting CONSOLE OUTPUT [..

D18007: [SDDM theme] Use the biggest wallpaper resolution

2019-06-04 Thread Filip Fila
filipf added a subscriber: davidedmundson. filipf added a comment. @davidedmundson was there a reason why we used the very specific 3200x2000 resolution before? Also is this okay? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18007 To: filipf, #vdg, #plas

D18007: [SDDM theme] Use the biggest wallpaper resolution

2019-06-04 Thread Nathaniel Graham
ngraham added a comment. Yes, 5.16 and then merge to master REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18007 To: filipf, #vdg, #plasma, ngraham Cc: ngraham, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezh

D18007: [SDDM theme] Use the biggest wallpaper resolution

2019-06-04 Thread Filip Fila
filipf updated this revision to Diff 59159. filipf added a comment. rebase on master REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18007?vs=59153&id=59159 REVISION DETAIL https://phabricator.kde.org/D18007 AFFECTED FILES sddm-theme/theme.con

D18007: [SDDM theme] Use the biggest wallpaper resolution

2019-06-04 Thread Filip Fila
filipf added a comment. Should we land this in 5.16 as well? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18007 To: filipf, #vdg, #plasma, ngraham Cc: ngraham, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliez

D18007: [SDDM theme] Use the biggest wallpaper resolution

2019-06-04 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Needs a rebase on master before landing as there is a minor merge conflict in the CMake file due to the addition of `fontSize=10` in the meantime. REPOSITORY R120 Plasma Workspace BRAN

D18007: [SDDM theme] Use the biggest wallpaper resolution

2019-06-04 Thread Filip Fila
filipf updated this revision to Diff 59153. filipf added a comment. use 5K instead of 4K REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18007?vs=48785&id=59153 BRANCH arcpatch-D18007 REVISION DETAIL https://phabricator.kde.org/D18007 AFFECTE

D18007: [SDDM theme] Use the biggest wallpaper resolution

2019-06-04 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Now we have an even bigger one! Let's use that. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18007 To: filipf, #vdg, #plasma, ngraham Cc: n

D21497: fill layouts from X server when there are no layouts in config

2019-06-04 Thread Oleg Solovyov
This revision was automatically updated to reflect the committed changes. Closed by commit R119:a14258a0cd60: fill layouts from X server when there are no layouts in config (authored by McPain). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21497?vs=58

D13095: Scren brightness follow a quatratic progression

2019-06-04 Thread Roman Gilg
romangg added a comment. Please create a table with what would happen when. To me it sounds like something would not work out in the end, but I can be wrong. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D13095 To: thsurrel, #plasma, broulik, ngraham Cc: kjslag,

D13095: Scren brightness follow a quatratic progression

2019-06-04 Thread Nathaniel Graham
ngraham added a comment. In D13095#473975 , @kjslag wrote: > > Well it's not me that matters; it's all the other people with weird screens like mine, as well as the prople whose screens don't do this. We need to wither come up with a solution th

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

2019-06-04 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in calculator.qml:39 > This will change with the font size, surely breaking it? I didn't see any regressions in testing... REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D21503 To: ngraham, #p

D21561: [Notifier] Delay creating QNetworkConfigurationManager

2019-06-04 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R134:89681ad47084: [Notifier] Delay creating QNetworkConfigurationManager (authored by broulik). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21561?vs=

D21569: [Notifications] Don't alter top margin of ThumbnailStrip

2019-06-04 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This edge touches the notification text and as such shouldn't "bleed in" as with the other ed

D13095: Scren brightness follow a quatratic progression

2019-06-04 Thread Kevin Slagle
kjslag added a comment. > Well it's not me that matters; it's all the other people with weird screens like mine, as well as the prople whose screens don't do this. We need to wither come up with a solution that works for everyone, or else mark some class of screen as misconfigured so we can