D21470: Properly read stderr when data is ready from the daemon.

luc4 created this revision. luc4 added reviewers: davidedmundson, mlaurent. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. luc4 requested review of this revision. REVISION SUMMARY When stderr data is sent from the daemon, it seems that libksysguard was actually reading

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

ngraham added a comment. In D21414#471289 , @kishoreg wrote: > BTW, if I open the window standalone (from krunner), it allows me to resize it vertically so that the entire window gets scrollbars. F6856837: Screenshot_20190528_220702.png

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

ngraham added a comment. In D21414#471286 , @GB_2 wrote: > In D21414#471285 , @ngraham wrote: > > > Actually now that I think about it, this should probably go into Plasma 5.16. However since I aske

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg added a comment. BTW, if I open the window standalone (from krunner), it allows me to resize it vertically so that the entire window gets scrollbars. F6856837: Screenshot_20190528_220702.png I can't do this horizontally. Is there some vertical

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

GB_2 added a comment. In D21414#471285 , @ngraham wrote: > Actually now that I think about it, this should probably go into Plasma 5.16. However since I asked you to add a colon to the end of a string, technically that's a string change and thos

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

ngraham added a comment. Actually now that I think about it, this should probably go into Plasma 5.16. However since I asked you to add a colon to the end of a string, technically that's a string change and those aren't allowed so close to the release, so it would have to go into Plasma 5.17

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

ngraham added a comment. Nope, that looks perfect to me! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21414 To: kishoreg, #baloo, #vdg, ngraham Cc: abetts, bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jen

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg updated this revision to Diff 58797. kishoreg added a comment. Screenshot as of this diff: F6856823: Screenshot_20190528_220210.png Are there any other changes that need to be made? REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDAT

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21414 To: kishoreg, #baloo, #vdg, ngraham Cc: abetts, bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21436: Use onClicked for Home button

This revision was automatically updated to reflect the committed changes. Closed by commit R134:66f3bec02825: Use onClicked for Home button (authored by GB_2). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21436?vs=58739&id=58791 REVISION DET

D21451: [System Tray] Ignore services that start with a colon (:)

This revision was automatically updated to reflect the committed changes. Closed by commit R120:143969f24fbe: [System Tray] Ignore services that start with a colon (:) (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21451?vs=5876

D21460: [Notifications] Group applications with same display name but no desktop entry

This revision was automatically updated to reflect the committed changes. Closed by commit R120:08b027f1124b: [Notifications] Group applications with same display name but no desktop entry (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.k

D21439: [Touchpad KCM] Revoke touchpad enabled/disabled notification before sending a new one

This revision was automatically updated to reflect the committed changes. Closed by commit R119:999b619bc5c8: [Touchpad KCM] Revoke touchpad enabled/disabled notification before sending a… (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

ngraham added a comment. I think I confused you, sorry. My desire was for some spacing above the listview's label, like this: F6856571: edited.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21414 To: kishoreg,

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg updated this revision to Diff 58786. kishoreg added a comment. This is awkward. I hadn't realized that I was supposed to use one space for indentation. Fixed as per the preexisting convention. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg updated this revision to Diff 58784. kishoreg added a comment. I seem to have messed up the indentation in my previous diff. Here it is with the indentation fixed. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21414?vs=58781&id=58784 REVI

D21460: [Notifications] Group applications with same display name but no desktop entry

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The specification says `appName` should be the display name of the application. An applica

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg marked an inline comment as done. kishoreg added a comment. BTW, checkboxes in other KCMs also seem to have the same spacing as this one had before this change. Is there a way to globally apply this spacing / padding consistently to QCheckBoxes in all KCMs for the sake of consistency

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

kishoreg updated this revision to Diff 58781. kishoreg added a comment. I've added a colon after the 'Do not search in these locations' text. I've also added spacing between the checkboxes and their text. I've put in 10 px for now. Is there a better way to do this? Without additional spa

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven added a comment. In D20598#471149 , @filipf wrote: > In D20598#455424 , @ngraham wrote: > > > This doesn't actually work for me. Upon opening, the following is printed to the console: > >

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

filipf added a comment. In D20598#455424 , @ngraham wrote: > This doesn't actually work for me. Upon opening, the following is printed to the console: > > org.kde.kcoreaddons: Error loading plugin "kcm_energyinfo" "The shared library was n

D21438: [plasmashell] Don't talk to ksmserver

apol added a comment. Maybe we can just get this in https://codereview.qt-project.org/c/qt/qtbase/+/254679. Tampering with env vars is scary. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21438 To: broulik, #plasma, davidedmundson Cc: apol, plasma-de

D21451: [System Tray] Ignore services that start with a colon (:)

broulik created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21451 AFFECTED FILES applets/systemtray/systemtray.cpp To: broul

D21441: Start krunner later

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5bb4680bcffc: Start krunner later (authored by broulik). Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://

D21439: [Touchpad KCM] Revoke touchpad enabled/disabled notification before sending a new one

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 387590 FIXED-IN: 5.16.0 TEST PLAN Enabled automatic touchpad disabling when plugging in

D21423: [Notifications] Don't show blue icon when a notification is active

This revision was automatically updated to reflect the committed changes. Closed by commit R120:100075ab4413: [Notifications] Don't show blue icon when a notification is active (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2142

D21147: Null pointer dereference at ksysguard

This revision was automatically updated to reflect the committed changes. Closed by commit R106:c5bc3a6c5d31: Null pointer dereference at ksysguard (authored by gkaragiannidis, committed by davidedmundson). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2114

D21431: [kaccess] Don't talk to ksmserver

This revision was automatically updated to reflect the committed changes. Closed by commit R119:43b8cab44b6c: [kaccess] Don't talk to ksmserver (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21431?vs=58729&id=58748 REVISION DETAI

D21434: [Notifications KCM] Try both model indices

This revision was automatically updated to reflect the committed changes. Closed by commit R119:85359e1d4b22: [Notifications KCM] Try both model indices (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21434?vs=58737&id=58749 REVIS

D21438: [plasmashell] Don't talk to ksmserver

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We don't need any of its session restoration capabilities but it still talks to ks

D21431: [kaccess] Don't talk to ksmserver

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. kaccess is invoked by kcminit which currently happens before ksmserver...at best it was racy. May as well make is explicit. REPOSITORY R119 Plasma Desktop REVISION DETA