D21326: Make limtedrowcountproxymodel usable from QML

davidedmundson updated this revision to Diff 58451. davidedmundson added a comment. update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21326?vs=58442&id=58451 BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D21326 AFFECTED

D21274: Don't assign a QtObject to a model

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a282bc9d612a: Don't assign a QtObject to a model (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21274?vs=58261&id=58450#toc REPOSITORY R120 Plasma Workspace CH

D21326: Make limtedrowcountproxymodel usable from QML

apol added inline comments. INLINE COMMENTS > limitedrowcountproxymodel.cpp:37 > { > if (this->sourceModel()) { > disconnect(this->sourceModel(), nullptr, this, nullptr); it could make sense to check if it's different to the current one. REPOSITORY R120 Plasma Workspace REVISI

D20585: [FormLayout] Use even top and bottom spacing for separator

filipf added a comment. In D20585#465924 , @mart wrote: > I don't like adding a new property to separator for doing duck typing... > > even is really ugly and errorprone as well, but i would prefer > Layout.topMargin: item.toString().index

D20585: [FormLayout] Use even top and bottom spacing for separator

filipf updated this revision to Diff 58444. filipf added a comment. minor fix REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20585?vs=58443&id=58444 BRANCH even-separator-spacing (branched from master) REVISION DETAIL https://phabricator.kde.org/D205

D20585: [FormLayout] Use even top and bottom spacing for separator

filipf updated this revision to Diff 58443. filipf added a comment. use mart's solution REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20585?vs=57065&id=58443 BRANCH even-separator-spacing (branched from master) REVISION DETAIL https://phabricator.kd

D20972: [sidebar] Make search field not glued to the separator

filipf added a comment. In D20972#465912 , @davidedmundson wrote: > > When anchors.margins is removed we see that the ToolButton still has 1px of its own margin around it > > From what? Should they be there? I believe it's inherent t

D21326: Make limtedrowcountproxymodel usable from QML

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY For intended moving into KItemModels REPOSITORY R120 Plasma Workspace BRA

D21322: [sddm-theme] Revert bad hack for spacing in action buttons and use a proper solution

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:e31d37ac721f: update (authored by filipf). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21322?vs=58429&id=584

D21322: update

filipf updated this revision to Diff 58429. filipf added a comment. fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21322?vs=58428&id=58429 BRANCH fix-bad-sddm-action-button-spacing-commit (branched from master) REVISION DETAIL https://pha

D21322: update

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH fix-bad-sddm-action-button-spacing-commit (branched from master) REVISION DETAIL https://phabricator.kde.

D21321: [sddm-theme] Revert bad hack for spacing in action buttons and use a proper solution

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Merge remote-tracking branch 'origin/Plasma/5.16' REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.16 REVISION DETAIL https:/

D21279: [sddm-theme] Add spacing between action buttons' labels

filipf added a comment. In D21279#468029 , @davidedmundson wrote: > This is an ugly hack. > > ActionItems ultimately end up in > SessionManagementScreen.qml:113 > > Row { > id: actionItemsLayout > } > > A Row has a spacing pr

D21279: [sddm-theme] Add spacing between action buttons' labels

davidedmundson added a comment. This is an ugly hack. ActionItems ultimately end up in SessionManagementScreen.qml:113 Row { id: actionItemsLayout } A Row has a spacing property. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21279 To:

D21279: [sddm-theme] Add spacing between action buttons' labels

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c92a33c20c53: [sddm-theme] Add spacing between action buttons' labels (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21279?vs=58269&i

D13095: Scren brightness follow a quatratic progression

ngraham added a comment. In D13095#467779 , @romangg wrote: > In D13095#279659 , @thsurrel wrote: > > > - accept to break some systems (but who wants that ?) > > > If these systems' breakage is

D13095: Scren brightness follow a quatratic progression

ngraham added a comment. Moving the brightness to zero is supposed to turn the //backlight// off, not the //screen// right? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D13095 To: thsurrel, #plasma, broulik, ngraham Cc: kjslag, sharvey, zzag, ngraham, romangg,

D21319: make AcceptingInputStatus work

This revision was automatically updated to reflect the committed changes. Closed by commit R120:60ef118c92e4: make AcceptingInputStatus work (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21319?vs=58418&id=58419 REVISION DETAIL

D21319: make AcceptingInputStatus work

mart updated this revision to Diff 58418. mart added a comment. - use platformheaders REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21319?vs=58416&id=58418 BRANCH focusworkaround REVISION DETAIL https://phabricator.kde.org/D21319 AFFECTED F

D21319: make AcceptingInputStatus work

mart created this revision. mart added reviewers: Plasma, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY the culript seems the Qt::WindowDoesNotAcceptFocus flag, removing it makes it possible to have back

D21274: Don't assign a QtObject to a model

fvogt added a comment. Yes, but the workaround here has no actual downsides, and the upside is avoiding a guaranteed crash with the still latest non-development release of Qt. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D21274 To: davide

D21274: Don't assign a QtObject to a model

davidedmundson added a comment. FWIW, the relevant Qt bug is fixed. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D21274 To: davidedmundson, #plasma, fvogt Cc: fvogt, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, l

D21274: Don't assign a QtObject to a model

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Tested on top of the 5.16 beta, works fine. Please add a comment referencing the QTBUG though, so that this doesn't get reintroduced by accident. REPOSITORY R120 Plasma Workspace BRANCH

D13095: Scren brightness follow a quatratic progression

kjslag added a comment. @romangg The current code selects from a discrete set of brightness levels which starts at zero. I was suggesting just removing the zero brightness level and using the next level as the minimum brightness level. I didn't realize turning off the screen at the lowes

Re: Review Request: plasma-thunderbolt

On Wed, May 15, 2019 at 03:27:07PM +0200, Daniel Vrátil wrote: > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM > for Plasma. I initially submitted the code as a patch against plasma-desktop > [0], where it got reviewed, but it was ultimately decided to better put it

D13095: Scren brightness follow a quatratic progression

romangg added a comment. In D13095#279659 , @thsurrel wrote: > - accept to break some systems (but who wants that ?) If these systems' breakage is because of an erroneous kernel driver, we can accept it. My system goes with brightness fro