D13095: Scren brightness follow a quatratic progression

2019-05-20 Thread Kevin Slagle
kjslag added a comment. I like the idea of this patch. I just reassigned my brightness hotkeys to a small script that does almost exactly what this patch does before I discovered this patch. In order to deal with Nate's problem, perhaps instead of starting with brightness=0, we could ju

D21307: Optimise the NetworkModel

2019-05-20 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R116:7e1d06d0c0aa: Optimise the NetworkModel (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21307?vs=58366&id=58388#toc REPOSITORY R116 Plasma Network Management Applet CHANG

D21181: [Notifications] Ensure "Open" and "More Options" button have the same height

2019-05-20 Thread Nathaniel Graham
ngraham added a comment. @davidedmundson Given your comments in https://bugs.kde.org/show_bug.cgi?id=407460, can this go in? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21181 To: broulik, #plasma, davidedmundson Cc: ngraham, davidedmundson, plasma-devel

D21234: Use a more conventional sidebar header apparance in desktop view

2019-05-20 Thread Nathaniel Graham
ngraham added a comment. That's exactly why manually setting the DPI isn't the correct way to enable high DPI mode. It only changes the fonts, so UI elements that aren't textual (like icon-only buttons, and icons in buttons) don't get scaled. You should use the scale factor slider in System

D21307: Optimise the NetworkModel

2019-05-20 Thread Jan Grulich
jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good. INLINE COMMENTS > networkmodelitem.cpp:561 > if (m_mode == NetworkManager::WirelessSetting::Infrastructure) { > -m_details << i18n("Signal strength") <<

D20222: Plasma-Workspace. The last checkbox in the widget settings

2019-05-20 Thread Nathaniel Graham
ngraham added a comment. This doesn't apply to master anymore: INFO Base commit is not in local repository; trying to fetch. Created and checked out branch arcpatch-D20222. Checking patch applets/systemmonitor/common/contents/ui/ConfigGeneral.qml... error: while searching f

D19745: Fix system tray UI/UX & refactor

2019-05-20 Thread Nathaniel Graham
ngraham added a comment. Thanks again. Very nice patch. May it be the first of many! :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19745 To: ratijastk, #vdg, #plasma, broulik, mart, hein, davidedmundson Cc: aacid, davidre, davidedmundson, ngraham, ndavi

D19745: Fix system tray UI/UX & refactor

2019-05-20 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:a73aa33028ef: Fix system tray UI/UX & refactor (authored by ratijastk, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19745?vs=58123

D20853: ksysguardd: show Mandatory Access Control (SELinux/AppArmor) context

2019-05-20 Thread Topi Miettinen
This revision was automatically updated to reflect the committed changes. Closed by commit R106:446a3b368813: ksysguardd: show Mandatory Access Control (SELinux/AppArmor) context (authored by topimiettinen). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D208

D20854: libksysguard: show Mandatory Access Control (SELinux/AppArmor) context

2019-05-20 Thread Topi Miettinen
This revision was automatically updated to reflect the committed changes. Closed by commit R111:e3894f9408cc: libksysguard: show Mandatory Access Control (SELinux/AppArmor) context (authored by topimiettinen). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kd

D20854: process: show SELinux context

2019-05-20 Thread Topi Miettinen
topimiettinen updated this revision to Diff 58372. topimiettinen added a comment. update to reflect that this also shows AppArmor context REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20854?vs=57197&id=58372 BRANCH process-cgroup-selinux REVI

D16425: Added new Suspend then Hibernate option

2019-05-20 Thread Nathaniel Graham
ngraham added a comment. Thanks. Let's wait for @broulik's review once he gets back from vacation (a few days, I think). REPOSITORY R122 Powerdevil BRANCH arcpatch-D16425_1 REVISION DETAIL https://phabricator.kde.org/D16425 To: avaldes, broulik, ngraham Cc: reverendhomer, meven, sori

D21274: Don't assign a QtObject to a model

2019-05-20 Thread David Edmundson
davidedmundson added a comment. That would still hit the Qt crash unless I declare all used properties, which is the part I wanted to avoid. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21274 To: davidedmundson, #plasma Cc: apol, plasma-devel, jraleigh,

D21307: Optimise the NetworkModel

2019-05-20 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. apol requested review of this revision. REVISION SUMMARY Only notify changes about the bits that actually changed. This is espe

D21279: [sddm-theme] Add spacing between action buttons' labels

2019-05-20 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch please! REPOSITORY R120 Plasma Workspace BRANCH add-spacing-action-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D21279 To: filipf, #vdg

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-05-20 Thread Nathaniel Graham
ngraham added a comment. In D19631#467171 , @filipf wrote: > We could also increase the width of each of the button's container, basically what this shows I guess is the Shut Down button barely fits in one row. I'll look into it. +1. I d

D21303: Set application name to org_kde_powerdevil

2019-05-20 Thread Bhushan Shah
This revision was automatically updated to reflect the committed changes. Closed by commit R122:90839c802ebc: Set application name to org_kde_powerdevil (authored by bshah). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21303?vs=58355&id=58356 REVISION DE

D21303: Set application name to org_kde_powerdevil

2019-05-20 Thread Bhushan Shah
bshah updated this revision to Diff 58355. bshah added a comment. setProductName REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21303?vs=58350&id=58355 BRANCH bshah-rename-component REVISION DETAIL https://phabricator.kde.org/D21303 AFFECTED FILES

D21303: Set application name to org_kde_powerdevil

2019-05-20 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Probably needs a matching KAboutData::setProductName to "powerdevil" REPOSITORY R122 Powerdevil BRANCH bshah-rename-component REVISION DETAIL https://phabricator.k

D21303: Set application name to org_kde_powerdevil

2019-05-20 Thread Bhushan Shah
bshah created this revision. bshah added reviewers: davidedmundson, romangg. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY Previously application component name without any KAboutData was org_kde_powerdevil (e

plasma-desktop 5.15.90.1 update

2019-05-20 Thread Jonathan Riddell
I've updated plasma-desktop tar for 5.16 beta due to a crasher it caused in kded

Plasma 5.16 beta

2019-05-20 Thread Jonathan Riddell
Plasma 5.16 beta is out now for testing before a final release due on June 11 https://kde.org/announcements/plasma-5.15.90.php

Notes from Monday meeting of 20/5/2019

2019-05-20 Thread Marco Martin
Eike: * Nothing to report, $dayjob still has me in its throes :( However in $dayjob I've been working a lot with Qt Quick's new TableView + DelegateChooser + pointer handlers lately, which has given me a lot of ideas for how to overhaul the Folder View presentation layer. I'll likely make that m

D21278: [Touchpad KCM] Fix kded crashing at startup

2019-05-20 Thread Atul Bisht
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:ecea8b93d997: [Touchpad KCM] Fix kded crashing at startup (authored by atulbi). REPOSITORY R119 Plasma Desktop CHAN

D21278: [Touchpad KCM] Fix kded crashing at startup

2019-05-20 Thread Roman Gilg
romangg accepted this revision. romangg added a comment. Feedback positive in bug report. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21278 To: atulbi, romangg, davidedmundson Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himc