D19745: Fix system tray UI/UX & refactor

ngraham added a subscriber: aacid. ngraham added a comment. In D19745#466760 , @davidedmundson wrote: > > Please, check whether 'LayoutMirroring' works properly. > > To test layout mirroring run "plasmashell --reverse" > Layouts will auto

D16425: Added new Suspend then Hibernate option

avaldes marked 3 inline comments as done. avaldes added a comment. Updated with latest comments. Please land, I don't have permissions. REPOSITORY R122 Powerdevil BRANCH arcpatch-D16425_1 REVISION DETAIL https://phabricator.kde.org/D16425 To: avaldes, broulik, ngraham Cc: reveren

D16425: Added new Suspend then Hibernate option

avaldes updated this revision to Diff 58273. avaldes added a comment. Added new Suspend then Hibernate option Summary: See bug 399727 for a good description of what this code is for. The new ui will show a new option like th

D21274: Don't assign a QtObject to a model

apol added a comment. To do this in the past I've used an object array which would read a bit less hacky. userListModel: [ QtObject { /*...*/} ] REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21274 To: davidedmundson, #plasma Cc: apol, plasma-devel,

D21268: Add missing includes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R116:fbf0fc710cfb: Add missing includes (authored by palimaka). REPOSITORY R116 Plasma Network Management Applet CHANGES

D21279: [sddm-theme] Add spacing between action buttons' labels

filipf updated this revision to Diff 58269. filipf added a comment. height=width REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21279?vs=58267&id=58269 BRANCH add-spacing-action-buttons (branched from master) REVISION DETAIL https://phabricat

D21279: [sddm-theme] Add spacing between action buttons' labels

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Currently there is no spacing between the labels of action buttons, leading to crammed text with longer translations which are not sp

D21278: [Touchpad KCM] Fix kded crashing at startup

romangg added a comment. I believe we don't call the `XcbAtom::intern` function in the X libinput backend, what we do in the evdev/synaptics constructor part. Question is if we just don't want to not send the relevant call on keypress after all in X libinput. Because libinput does the disabl

D21278: [Touchpad KCM] Fix kded crashing at startup

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > m_connection seems to be having null or 0x0 value. Which means we're calling XcbAtom::atom after being constructed from the default constructor not the prope

D21278: [Touchpad KCM] Fix kded crashing at startup

atulbi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. atulbi requested review of this revision. REVISION SUMMARY When XcbAtom::atom() is called (by kded on key press other than Kded Keyboard shortcuts), m_connection seems to be having null or 0x0

D19745: Fix system tray UI/UX & refactor

davidedmundson added a comment. > Please, check whether 'LayoutMirroring' works properly. To test layout mirroring run "plasmashell --reverse" Layouts will auto handle most things, so things should be fine. Do you have commit access? REPOSITORY R120 Plasma Workspace BRANCH fix

D19745: Fix system tray UI/UX & refactor

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ratijastk wrote in CompactApplet.qml:34 > As far as I remember, one of the branches never got executed in my > environment. Could you point to specific

D21274: Don't assign a QtObject to a model

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It's a weird thing to do, and that's causing us to hit https://bugreports.q

D21269: [Touchpad KCM] Fixed loading of wrong qml file

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3e0fd10ddc27: [Touchpad KCM] Fixed loading of wrong qml file (authored by atulbi). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21269?vs=58248&id=58260#toc REPOSITORY R119 Plasma Desktop

D21273: Add support for newer linux kernel power_supply API. Keep backwardcompatibility with older procfs API.

alexeymin added a comment. Hm, looks ideologically similar to how it was done in SDL2... https://hg.libsdl.org/SDL/file/792c26401463/src/power/linux/SDL_syspower.c REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D21273 To: luc4, davidedmundson Cc: alexeymin, plasm

D21273: Add support for newer linux kernel power_supply API. Keep backwardcompatibility with older procfs API.

luc4 created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. luc4 requested review of this revision. REPOSITORY R106 KSysguard BRANCH batt REVISION DETAIL https://phabricator.kde.org/D21273 AFFECTED FILES ksysguardd/Linux/acpi.c To: luc4 Cc: plas

D20853: ProcessList: show SELinux context

topimiettinen updated this revision to Diff 58257. topimiettinen added a comment. Updated to reflect that this is also useful for AppArmor REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20853?vs=57094&id=58257 BRANCH processlist-add-cgroup REVISION DE

D21269: [Touchpad KCM] Fixed loading of wrong qml file

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Good find. Also backport to beta branch. REPOSITORY R119 Plasma Desktop BRANCH touchpad-mouse REVISION DETAIL https://phabricator.kde.org/D21269 To: atulbi, romangg, ngraham Cc: p

D21269: [Touchpad KCM] Fixed loading of wrong qml file

atulbi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. atulbi requested review of this revision. REVISION SUMMARY On system settings, If Mouse KCM is opened first, then touchpad KCM loads the same Mouse QML file (qrc::/libinput/main.qml) instead o

D20787: process: add support for cgroups

This revision was automatically updated to reflect the committed changes. Closed by commit R111:3eb5e842ae64: process: add support for cgroups (authored by topimiettinen). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20787?vs=57196&id=58245 REVISI

D20786: ProcessList: add support for cgroups

This revision was automatically updated to reflect the committed changes. Closed by commit R106:11af9d11a457: ProcessList: add support for cgroups (authored by topimiettinen). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20786?vs=57093&id=58244 REVISION D

D20584: ProcessList: add NoNewPrivileges

This revision was automatically updated to reflect the committed changes. Closed by commit R106:892c895bda83: ProcessList: add NoNewPrivileges (authored by topimiettinen). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20584?vs=56322&id=58243 REVISION DETAI

D20853: ProcessList: show SELinux context

topimiettinen added a comment. Like D20854 , this should be also applicable to AppArmor. REPOSITORY R106 KSysguard BRANCH processlist-add-cgroup REVISION DETAIL https://phabricator.kde.org/D20853 To: topimiettinen, davidedmundson Cc: davidedmundson

D20854: process: show SELinux context

topimiettinen added a comment. I noticed that when the system uses AppArmor instead of SELinux, this also happens to show AppArmor profile and status. Then at least user facing bits should not be so SELinux oriented to avoid confusion. I suppose AppArmor is more widely used than SELinux. RE