D20859: Crash in sddmthemeinstaller invalid use of errorString

johngehrig added a comment. Sorry for the delay... I was finally able to get the crashing machine set up again. Yes, it looks like the descuctor for `job` was called while the KMessageBox was in the process of being painted onscreen (breakpoint in kauthexecutejob.cpp). I tried maki

D20859: Crash in sddmthemeinstaller invalid use of errorString

johngehrig updated this revision to Diff 57581. johngehrig edited the summary of this revision. johngehrig edited the test plan for this revision. johngehrig added a comment. Ordering changed, qWarning first. job->errorString() displayed for all values of job->error(). A QString object was

D21027: [Notes] Fix icons being almost invisible with light backgrounds

ngraham added a comment. I don't like hardcoding the things we're comparing against. If we ever add more colors besides "black" or "translucent-light", or of the actual color values of those change (unlikely, but possible), all these buttons will need their code to be adjusted and that'll be

D21027: [Notes] Fix icons being almost invisible with light backgrounds

filipf updated this revision to Diff 57578. filipf added a comment. move accessibleName back into ToolButton, but still refer to the Tooltip's text REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21027?vs=57577&id=57578 BRANCH background-appropriat

D21027: [Notes] Fix icons being almost invisible with light backgrounds

filipf updated this revision to Diff 57577. filipf added a comment. move accessibleName into tooltip and refer to the tooltip's text REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21027?vs=57576&id=57577 BRANCH background-appropriate-icon-colors (b

D21027: [Notes] Fix icons being almost invisible with light backgrounds

filipf added a comment. In D21027#460966 , @davidedmundson wrote: > Plasma has this "ColorScope" thing. Does this work as a solution? Will fix the frame Seems like that could be one of the solutions: https://bugs.kde.org/show_bug.cgi?id

D21027: [Notes] Fix icons being almost invisible with light backgrounds

davidedmundson added a comment. Plasma has this "ColorScope" thing. Does this work as a solution? Will fix the frame REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D21027 To: filipf, #plasma, #vdg, ngraham Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragr

D21027: [Notes] Fix icons being almost invisible with light backgrounds

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Old code had no way to adapt icon colors based on background so this patch uses different components to color the icons black with li

D21026: Fix ToolButton remaining in a pressed state after press

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY If you click on a QQC2 ToolButton it will remain it's pressed state, meaning it gets a background in the form of highlight color. The

D20969: [potd] Modernize configuration settings

filipf added a comment. In D20969#460470 , @ngraham wrote: > Hmm, setting a maximum width is kind of lousy for really long strings though, because they get elided. I think it might make more sense to make sure that the window expands to accomoda

D20969: [potd] Modernize configuration settings

filipf updated this revision to Diff 57557. filipf added a comment. change string "Providers:" to "Provider:" REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20969?vs=57499&id=57557 BRANCH modernize-potd-config (branched from master) REVISION DETAI

D20797: [dict] Modernize configuration window

filipf updated this revision to Diff 57556. filipf added a comment. wrong diff, revert REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20797?vs=57555&id=57556 BRANCH modernize-dictionary-configuration-window (branched from master) REVISION DETAIL

D20797: [dict] Modernize configuration window

filipf updated this revision to Diff 57555. filipf added a comment. change string "Providers:" to "Provider:" REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20797?vs=57121&id=57555 BRANCH modernize-dictionary-configuration-window (branched from mas

D20972: [sidebar] Make search field not glued to the separator

filipf added a comment. Two sane solutions I see, but which don't end up working: - the vertical separator becomes invisible if left anchored to parent.right instead of right anchored - the `searchLayout` RowLayout has too big of a right margin if right anchored to separator.left

D21013: [PanelView] remove outdated hack to support mask without compositing

kossebau added a comment. In D21013#460774 , @mvourlakos wrote: > > This really needs a proper solution with well defined concepts. > > yep, I agree... > > This is why I left the assumption only in one place and I didnt merge more commit

D21013: [PanelView] remove outdated hack to support mask without compositing

mvourlakos added a comment. In D21013#460765 , @kossebau wrote: > Eek, sorry for breaking things. Will have some thoughts about it. > Though, hm, `item->window()->mask().isNull()` is really a random heuristic asking to break sooner or later,

D21012: [PanelView] Update mask as last on resize event (& move one for consistency)

apol added a comment. That makes a lot of sense. +1 I'm not sure how to reproduce the issue but I've seen it happen many times. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21012 To: kossebau, #plasma, broulik Cc: apol, plasma-devel, jraleigh, GB_2, ra

D21013: [PanelView] remove outdated hack to support mask without compositing

kossebau added a comment. Eek, sorry for breaking things. Will have some thoughts about it. Though, hm, `item->window()->mask().isNull()` is really a random heuristic asking to break sooner or later, given we have seen all kind of panel/dock styles by the time :) Well, actually it was alr

D21013: [PanelView] remove outdated hack to support mask without compositing

mvourlakos added a subscriber: davidedmundson. mvourlakos added a comment. In D21013#460745 , @kossebau wrote: > In D21013#460743 , @mvourlakos wrote: > > > @kossebau one information please, with thi

D21013: [PanelView] remove outdated hack to support mask without compositing

kossebau added a comment. In D21013#460743 , @mvourlakos wrote: > @kossebau one information please, with this set of paches the svg mask is also applied and in COMPOSITING state for the panels? Yes. As in: at least most of the time as th

D21013: [PanelView] remove outdated hack to support mask without compositing

mvourlakos added a comment. @kossebau one information please, with this set of paches the svg mask is also applied and in COMPOSITING state for the panels? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21013 To: kossebau, #plasma Cc: mvourlakos, plasma-de

D21013: [PanelView] remove outdated hack to support mask without compositing

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY The actual mask is now queried from the panel, there is no more need for this. REPOSITORY

D21012: [PanelView] Update mask as last on resize event (& move one for consistency)

kossebau added a comment. @broulik Could you tell if this improves the bug you found about "change resolution in plasma, the panel mask stays incorrect"? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21012 To: kossebau, #plasma, broulik Cc: plasma-devel,

D21012: [PanelView] Update mask as last on resize event (& move one for consistency)

kossebau created this revision. kossebau added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY The mask of a panel depends on things like borders set or window size, but nothing el

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 87 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/87/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sat, 04 May 2019 10:19:04 + Build duration: 11 min and counting BUILD ARTIFACTS ac