D19014: [plasma-pa] Add command to switch all applications to the selected device

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, let's get it in even if we don't have a new icon quite yet. That can be added via a frameworks update anyway. REPOSITORY R115 Plasma Audio Volume Applet BRANCH vpilo/switchStream

D20930: Update WireGuard to match NetworkManager 1.16 interface

andersonbruce created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. andersonbruce requested review of this revision. REVISION SUMMARY In NetworkManager 1.16 handling of WireGuard interfaces was changed from a VPN add-

D19014: [plasma-pa] Add command to switch all applications to the selected device

filipf added a comment. Ping, would be nice to have in 5.16. If there's an issue with getting an icon made, it would be okay I think to have a generic one and then fix it later. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D19014 To: vpilo, #pla

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 57294. enriquem added a comment. I believe I addressed all of your comments. Please check your email for testing options. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=55714&id=57294 REVISION DETAIL https://phabricator.kde.org/D183

D20906: [kimpanel] Port settings page to QQC2+Kirigami FormLayout and modernize UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9dcc29663bd7: [kimpanel] Port settings page to QQC2+Kirigami FormLayout and modernize UI (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D20925: Also handle muted property on player

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. In D20925#458775 , @nicolasfella wrote: > What do you think about adding a x-kde-muted prop and support for it in KDE Connect and the media con

D20925: Also handle muted property on player

nicolasfella added a comment. What do you think about adding a x-kde-muted prop and support for it in KDE Connect and the media control applet? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D20925 To: broulik, #plasma, fvogt Cc: nicolasfella, pla

D20925: Also handle muted property on player

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Report a `Volume` of `0.0` for a muted player and set its `muted` property to whether `volu

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. Wonderful! I'll stop bugging you now. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson, #plasma Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, leslie

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#458259 , @ngraham wrote: > @atulbi were you able to get in touch with @romangg? Can I help in any way? > > The feature freeze for Plasma 5.16 is in a little over two weeks (https://community.kde.org/Schedules

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham added a comment. Thanks, can confirm the fix! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D20896 To: ngraham, #vdg, #plasma, kossebau, filipf Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

kossebau added a comment. In D20896#458668 , @kossebau wrote: > @ngraham @filipf For the Visibility combobox, could you test if changing "ml" to "mi" in https://phabricator.kde.org/source/kdeplasma-addons/browse/master/applets/weather/weatherapp

D20923: Rank Kickoff desktopsessions search results over services

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5f5b21c562a8: Rank Kickoff desktopsessions search results over services (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20923?vs=57277&id=

D20923: Rank Kickoff desktopsessions search results over services

davidedmundson added a comment. How will this change the sorting? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20923 To: GB_2, #plasma, #vdg Cc: davidedmundson, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19011: Thunderbolt KCM and KDED module

dvratil added a comment. @broulik I asked on plasma-devel where to put this and got no definitive answer, so I put it here. Separate repo is fine with me, too. What name for the repo would you prefer? plasma-thunderbolt? I already have kcm_bolt scratch repo, so I can just "backport" the chan

D20923: Rank Kickoff desktopsessions search results over services

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 405268 Users more frequently want to log out rather than change desktop session settings. Al

D20906: [kimpanel] Port settings page to QQC2+Kirigami FormLayout and modernize UI

GB_2 updated this revision to Diff 57274. GB_2 added a comment. Invert checkbox in UI logic instead, fix font preview REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20906?vs=57216&id=57274 BRANCH kimpanel-port-settings-page-to-qqc2-plus-kirigami-f

D20896: [Weather] Port settings window to QQC2+Kirigami FormLayout and modernize UI

kossebau added a comment. @ngraham @filipf For the Visibility combobox, could you test if changing "ml" to "mi" in https://phabricator.kde.org/source/kdeplasma-addons/browse/master/applets/weather/weatherapplet.cpp$97 fixes things for you? Rather sure it does, but cannot create a diff curren

D20919: Add DesktopEntry to notifyrc

This revision was automatically updated to reflect the committed changes. Closed by commit R134:b2a35f5abcc2: Add DesktopEntry to notifyrc (authored by broulik). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20919?vs=57261&id=57271 REVISION D

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 27 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/27/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 30 Apr 2019 14:08:29 + Build duration: 1 min 8 sec and counting CONSOLE OUTPUT [...truncated

D20915: Don't abort when org.freedesktop.pulseaudio.module-group schema isn't installed

This revision was automatically updated to reflect the committed changes. Closed by commit R115:25de7eb8c0dc: Don't abort when org.freedesktop.pulseaudio.module-group schema isn't installed (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://p

D20915: Don't abort when org.freedesktop.pulseaudio.module-group schema isn't installed

nicolasfella added a comment. > Makes me wonder why neon uses gsettings, though, when its PA version is too old to be affected by the gconf→gsettings change plasma-pa is built with GSettings by default. To use GConf one needs to build with -DUSE_GCONF REPOSITORY R115 Plasma Audio Volu

D20908: RFC: Redesign QML applet configuration windows

ngraham added a comment. I'm so in love with this new style. it's just astonishingly good-looking. F6801451: Screenshot_20190430_065515.png Once this is in users' hands (in conjunction with no borders by default for Breeze), I predict that we g

D20222: Plasma-Workspace. The last checkbox in the widget settings

ngraham added a comment. Oops, sorry for losing track of this. Is it replaced by something else? If you don't think it's needed anymore you can Abandon it from the Add Action... menu. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20222 To: pavelmos, brou

D20223: Make disk monitor widget only show real devices by default

ngraham added a comment. Oops, sorry for losing track of this. Is it replaced by something else? If you don't think it's needed anymore you can Abandon it from the Add Action... menu. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20223 To: pavelmos, brou

D20900: Reject invalid keys

This revision was automatically updated to reflect the committed changes. Closed by commit R116:257b03b185d3: Reject invalid keys (authored by McPain). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20900?vs=57249&id=57266 REVISION DET

D20788: Reset model when there are new available connections

This revision was automatically updated to reflect the committed changes. Closed by commit R116:4cb1e69c1a61: Reset model when there are new available connections (authored by McPain). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D207

D20223: Make disk monitor widget only show real devices by default

pavelmos added a comment. Please skip this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20223 To: pavelmos, broulik, #plasma, davidre, ngraham, mart Cc: ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-moha

D20222: Plasma-Workspace. The last checkbox in the widget settings

pavelmos added a comment. Please skip this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20222 To: pavelmos, broulik, #plasma, davidre, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, se

D20919: Add DesktopEntry to notifyrc

broulik created this revision. broulik added reviewers: Plasma, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This allows the new notification KCM to identify Discover as an application. While technica

D20851: [Pager] Improve label legibility

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d09d4d52e161: [Pager] Improve label legibility (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20851?vs=57220&id=57258 REVISION DETAIL

D20804: RFC: Try getting the X keyboard grab multiple times

davidedmundson added a comment. > Arguably it won't help us with all cases because the clients would have to voluntarily participate in the protocol. Yes. I'm not pretending it will. --- > I wonder whether it's worth fixing this bug on X11 at all. There is a way to forceful

D20908: RFC: Redesign QML applet configuration windows

filipf added a comment. Fixed. Not sure if the top separator should stay, but I guess it makes more sense if it does: F6801409: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20908 To: filipf, #vdg, #plas

D20908: RFC: Redesign QML applet configuration windows

filipf updated this revision to Diff 57255. filipf added a comment. Don't draw sidebar and its separator when there is only 1 category, also add left margin REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20908?vs=57227&id=57255 BRANCH master REV

D18394: Add OTP support for openconnect VPN

jgrulich added a comment. Sorry for the delay, I promise that I will start reviewing this more frequently so it gets merged just in time for Plasma 5.16 (we have 2 weeks). One more thing: When I open the "Token authentication" dialog, the "Token secret" label is not aligned with the tex

D20908: RFC: Redesign QML applet configuration windows

ngraham added a comment. Yeah I think keeping the icons on top is nice here since it makes for large click areas. Putting the icon beside the text makes more sense when the number of categories is very large, which isn't normally the case for settings windows. In D20908#458428

D20900: Reject invalid keys

McPain updated this revision to Diff 57249. McPain marked an inline comment as done. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20900?vs=57245&id=57249 BRANCH D20900 REVISION DETAIL https://phabricator.kde.org/D20900 AFFECTED

D20900: Reject invalid keys

jgrulich added inline comments. INLINE COMMENTS > passworddialog.cpp:76 > + > m_connectionSettings->setting(NetworkManager::Setting::WirelessSecurity).staticCast(); > +if (m_connectionSettings->connectionType() == > NetworkManager::ConnectionSettings::Wireless > +

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/26/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 30 Apr 2019 09:54:12 + Build duration: 40 min and counting CONSOLE OUTPUT [...truncated 374

D20804: RFC: Try getting the X keyboard grab multiple times

zzag added a comment. Arguably it won't help us with all cases because the clients would have to voluntarily participate in the protocol. I wonder whether it's worth fixing this bug on X11 at all. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D20804 To:

D20900: Reject invalid keys

McPain updated this revision to Diff 57245. McPain edited the summary of this revision. McPain removed 1 blocking reviewer(s): jgrulich. Herald added 1 blocking reviewer(s): jgrulich. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20900

KDE CI: Plasma » plasma-pa » kf5-qt5 SUSEQt5.12 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20SUSEQt5.12/17/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 30 Apr 2019 09:54:15 + Build duration: 5 min 46 sec and counting JUnit Tests Name: (root) Failed:

D20915: Don't abort when org.freedesktop.pulseaudio.module-group schema isn't installed

broulik created this revision. broulik added reviewers: Plasma, nicolasfella, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Calling `g_settings_new_with_path` with a schema that isn't installed raises

KDE CI: Plasma » plasma-pa » kf5-qt5 SUSEQt5.12 - Build # 16 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20SUSEQt5.12/16/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 30 Apr 2019 09:16:32 + Build duration: 54 sec and counting CONSOLE OUTPUT [...truncated 522 lines.

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/25/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 30 Apr 2019 09:16:32 + Build duration: 32 sec and counting CONSOLE OUTPUT [...truncated 372

D20900: Reject invalid keys

jgrulich added inline comments. INLINE COMMENTS > passworddialog.cpp:93 > +if (!valid) { > + > m_ui->buttonBox->setStandardButtons(QDialogButtonBox::Cancel); > +} else { It shouldn't definitely be hiding buttons, you can make the "OK" button just disabled

D20900: Reject invalid keys

McPain updated this revision to Diff 57239. McPain retitled this revision from "Reject short PSK passwords" to "Reject invalid keys". McPain edited the summary of this revision. McPain added a comment. validate WPA-PSK and WEP keys REPOSITORY R116 Plasma Network Management Applet CHANGES S

D20828: Correctly show memory sizes > 4 GiB on 32 bit Linux

fvogt added a comment. What about Plasma/5.12 and Plasma/5.15? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D20828 To: cfeck, #plasma, davidedmundson Cc: fvogt, sitter, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, je

D20900: Reject short PSK passwords

jgrulich added a comment. Use NetworkManagerQt::Utils::wpaPskIsValid() and NetworkManagerQt::Utils:wepKeyIsValid(). It doesn't make sense to have only validation for WPA. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D20900 To: McPain, jgr

D20900: Reject short PSK passwords

McPain updated this revision to Diff 57237. McPain added a comment. Use validation REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20900?vs=57189&id=57237 REVISION DETAIL https://phabricator.kde.org/D20900 AFFECTED FILES kded/p

D20908: RFC: Redesign QML applet configuration windows

filipf added a comment. In D20908#458426 , @broulik wrote: > I was wondering, wouldn't it also make sense to change the layout to be Icon left of text to make it even more consistent with System Settings? Or will that eat too much horizontal spa

D20908: RFC: Redesign QML applet configuration windows

broulik added a comment. I was wondering, wouldn't it also make sense to change the layout to be Icon left of text to make it even more consistent with System Settings? Or will that eat too much horizontal space? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org

KDE CI: Plasma » plasma-pa » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/24/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 30 Apr 2019 07:31:16 + Build duration: 50 sec and counting CONSOLE OUTPUT [...truncated 372

KDE CI: Plasma » plasma-pa » kf5-qt5 SUSEQt5.12 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-pa/job/kf5-qt5%20SUSEQt5.12/15/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 30 Apr 2019 07:31:16 + Build duration: 51 sec and counting CONSOLE OUTPUT [...truncated 522 lines.

D19994: Add microphone indicator

This revision was automatically updated to reflect the committed changes. Closed by commit R115:2d82429e5299: Add microphone indicator (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19994?vs=57158&id=57234 REVISION DE