D20797: [dict] Modernize configuration window

2019-04-27 Thread Filip Fila
filipf updated this revision to Diff 57121. filipf added a comment. remove binding loop REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20797?vs=57114&id=57121 BRANCH modernize-dictionary-configuration-window (branched from master) REVISION DETAIL

D20797: [dict] Modernize configuration window

2019-04-27 Thread Filip Fila
filipf planned changes to this revision. filipf added a comment. Err sorry, this is a binding loop monstrosity, I cannot be defining the parent with the children and vice versa at the same time. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D20797 To: filipf,

D20797: [dict] Modernize configuration window

2019-04-27 Thread Filip Fila
filipf updated this revision to Diff 57114. filipf added a comment. make it work with ScrollView and make ScrollView not buggy by using ContentWidth and ContentHeight to allow mouse scrolling, as well as setting clip to true so the scrollbar is actually contained within the view REPOSITORY

D20872: Use override

2019-04-27 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R994 Pulseaudio Qt Bindings BRANCH override REVISION DETAIL https://phabricator.kde

D20871: Don't delete profiles and ports on update

2019-04-27 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY When a profile/port is updated the old code deletes all objects and creates new on

D20867: Add Property to disable drawing of menu arrow indicators

2019-04-27 Thread David Hallas
hallas created this revision. hallas added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hallas requested review of this revision. REVISION SUMMARY Add Property to disable drawing of menu arrow indicators. This is useful for navigation type Tool

D20853: ProcessList: show SELinux context

2019-04-27 Thread Topi Miettinen
topimiettinen added a comment. Example output: ksysguardd> ps? NamePID PPIDUID GID Status User Time System Time NiceVmSize VmRss VmURss Login TracerPID TTY Command IO Priority Class IO Priority NNP CGroup SELinux

D20853: ProcessList: show SELinux context

2019-04-27 Thread Topi Miettinen
topimiettinen updated this revision to Diff 57094. topimiettinen added a comment. avoid memory allocations and reuse existing validation function REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20853?vs=57085&id=57094 BRANCH processlist-add-cgroup REVI

D20786: ProcessList: add support for cgroups

2019-04-27 Thread Topi Miettinen
topimiettinen updated this revision to Diff 57093. topimiettinen added a comment. avoid memory allocations and reuse existing validation function REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20786?vs=57091&id=57093 BRANCH processlist-add-cgroup REVI

D20863: Allow folder view elements to be be dropped using other Action than Copy

2019-04-27 Thread Méven Car
meven created this revision. meven added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Relates to D20838 REPOSITORY R119 Plasma Desktop BRANCH mast

D20786: ProcessList: add support for cgroups

2019-04-27 Thread Topi Miettinen
topimiettinen added inline comments. INLINE COMMENTS > anthonyfieroni wrote in ProcessList.c:420-421 > I made mistake i mean `i--` we start from last. I also added a check for i not being negative. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D20786 To: topimietti

D20786: ProcessList: add support for cgroups

2019-04-27 Thread Topi Miettinen
topimiettinen updated this revision to Diff 57091. topimiettinen added a comment. more trimming logic fixes REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20786?vs=57088&id=57091 BRANCH processlist-add-cgroup REVISION DETAIL https://phabricator.kde.

D20786: ProcessList: add support for cgroups

2019-04-27 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > anthonyfieroni wrote in ProcessList.c:420-421 > for (int i = strlen(buf) - 1; buf[i] == '\n'; i++) > buf[i] = '\0'; I made mistake i mean `i--` we start from last. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.

D20786: ProcessList: add support for cgroups

2019-04-27 Thread Topi Miettinen
topimiettinen updated this revision to Diff 57088. topimiettinen added a comment. improve trimming, thanks to @anthonyfieroni REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20786?vs=57086&id=57088 BRANCH processlist-add-cgroup REVISION DETAIL https:

D20786: ProcessList: add support for cgroups

2019-04-27 Thread Topi Miettinen
topimiettinen updated this revision to Diff 57086. topimiettinen added a comment. free strdup'ed string REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20786?vs=57070&id=57086 BRANCH processlist-add-cgroup REVISION DETAIL https://phabricator.kde.org/

D20853: ProcessList: show SELinux context

2019-04-27 Thread Topi Miettinen
topimiettinen updated this revision to Diff 57085. topimiettinen added a comment. free strdup'ed string REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20853?vs=57071&id=57085 BRANCH processlist-add-cgroup REVISION DETAIL https://phabricator.kde.org/