D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Krešimir Čohar
rooty updated this revision to Diff 54168. rooty added a comment. Activity... REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19838?vs=54167&id=54168 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19838 AFFECTED FILES daemon/powerdevi

D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Krešimir Čohar
rooty updated this revision to Diff 54167. rooty added a comment. Remove unnecessary comment REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19838?vs=54166&id=54167 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19838 AFFECTED FILES d

D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Krešimir Čohar
rooty updated this revision to Diff 54166. rooty added a comment. Missed one REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19838?vs=54165&id=54166 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19838 AFFECTED FILES daemon/powerdevil

D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Krešimir Čohar
rooty updated this revision to Diff 54165. rooty marked 9 inline comments as done. rooty added a comment. Implement inline comment suggestions REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19838?vs=54137&id=54165 BRANCH master REVISION DETAIL http

D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Krešimir Čohar
rooty marked 7 inline comments as done. rooty added inline comments. INLINE COMMENTS > ngraham wrote in powerdevilcore.cpp:330 > Remove "the profile" Hmm sure > ngraham wrote in powerdevilcore.cpp:367 > "or the action is not supported" -> "or the action not being supported" "or because the act

D19837: Add support for applications in KNSBackend

2019-03-17 Thread Nathaniel Graham
ngraham added a comment. Can you edit the test plan to indicate the name of an app from the store that now appears in Discover's Applications section? A quick test of this patch didn't reveal ExeQt or Treeline in Discover, which are visible on http://opendesktop.org. INLINE COMMENTS > KNSB

D19842: Port to the new install directory for knsrc files

2019-03-17 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R119:67f0c43a3ad1: Port to the new install directory for knsrc files (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19842?vs=54140&id=54157 R

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

2019-03-17 Thread Nathaniel Graham
ngraham updated this revision to Diff 54155. ngraham marked an inline comment as done. ngraham added a comment. Have the timer off by default so it only fires while resizing REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19550?vs=53310&id=54155 BRANC

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

2019-03-17 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > main.qml:183 > > +// Don't reload the image in the middle of a resize operation to > +// minimize re-reading the file on disk Isn't this doing the opposite of the comment and /always/ reloading an image after 250m

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

2019-03-17 Thread Michail Vourlakos
mvourlakos added a comment. I don't know if this can be of any help but this is supported by Latte dock, including scroll wheel to increase/decrease the specific audio stream volume REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb, #plasma, #v

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

2019-03-17 Thread Nathaniel Graham
ngraham added a comment. In D19822#433103 , @faridb wrote: > - Use a smaller icon for the audio indicator and place it in one of the corners of the task button and not in the centre I would like this, especially if we put it inside an att

D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Mostly good, just a new nitpicks and suggestions: INLINE COMMENTS > powerdevilcore.cpp:256 > QString activity = m_activityConsumer->currentActivity(); > -qCDebug(POWERD

D18357: [applets/mediaframe] Resize combobox to contents

2019-03-17 Thread Nathaniel Graham
ngraham added a comment. While you're in the mood to think about the Media Frame widget (a most scintillating topic, I know), would you like to review D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption ? :) REPOSITORY R

D18357: [applets/mediaframe] Resize combobox to contents

2019-03-17 Thread Nathaniel Graham
ngraham added a comment. Yep, in D19548 . REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D18357 To: davidedmundson, #plasma Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreu

D18438: [Task Manager] When closing apps, resize only when mouse is out.

2019-03-17 Thread Thomas Surrel
This revision was automatically updated to reflect the committed changes. Closed by commit R119:2861ae7cc675: [Task Manager] When closing apps, resize only when mouse is out. (authored by thsurrel). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18438?vs=53394&id=54147#toc REPOSITORY R

D18438: [Task Manager] When closing apps, resize only when mouse is out.

2019-03-17 Thread Thomas Surrel
thsurrel added a comment. I can land this myself. Thank you again for all your help. REPOSITORY R119 Plasma Desktop BRANCH arc_taskmanagerclose (branched from master) REVISION DETAIL https://phabricator.kde.org/D18438 To: thsurrel, #plasma, #vdg, hein Cc: hein, plasma-devel, jraleig

D19821: Fix breeze dialog background with Qt 5.12.2

2019-03-17 Thread Fabian Vogt
fvogt updated this revision to Diff 54143. fvogt added a comment. Keep the style element, but assign id and type. Fix tooltip.svgz as well. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19821?vs=54076&id=54143 BRANCH master REVISION

D19842: Port to the new install directory for knsrc files

2019-03-17 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Ought to do the trick! :) REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D19842 To: apol, #plasma, #knewstuff, leinir Cc: leinir, plasma-de

D18357: [applets/mediaframe] Resize combobox to contents

2019-03-17 Thread David Edmundson
davidedmundson abandoned this revision. davidedmundson added a comment. Sorry, I forgot about this. AFAIK Nate rewrote media frame to QQC2 anyway. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D18357 To: davidedmundson, #plasma Cc: ngraham, plasma-devel, jrale

D19842: Port to the new install directory for knsrc files

2019-03-17 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Plasma, KNewStuff. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY See https://phabricator.kde.org/D19338 REPOSITORY R119 Plasma Desktop BRANCH master REVISI

D19823: Port to the new install directory for knsrc files

2019-03-17 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R120:806a044da1d5: Port to the new install directory for knsrc files (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19823?vs=54079&id=54139#toc REPOSITORY R120 Plasma Workspac

D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Krešimir Čohar
rooty updated this revision to Diff 54137. rooty added a comment. Bring back the posessive pronouns REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19838?vs=54135&id=54137 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19838 AFFECTED FI

D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Krešimir Čohar
rooty updated this revision to Diff 54135. rooty added a comment. Drop unnecessary pronouns REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19838?vs=54132&id=54135 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19838 AFFECTED FILES da

D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Krešimir Čohar
rooty updated this revision to Diff 54132. rooty added a comment. Touch up some more REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19838?vs=54129&id=54132 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19838 AFFECTED FILES daemon/po

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

2019-03-17 Thread Farid Boudedja
faridb added a comment. Yes, you could accidentally mute an application when using Icons-Only Task Manager. As you can see below, the audio indicator is pretty close to the centre of the task button, which is where you would usually click to activate that task: F6698588: Screenshot_201903

D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Krešimir Čohar
rooty updated this revision to Diff 54129. rooty added a comment. Add the verb run (because... why not) REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19838?vs=54123&id=54129 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19838 AFFECTE

D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Krešimir Čohar
rooty added a comment. > Looks good. I'd avoid using pronouns, I think it would sound better and whose else's is the battery if not yours? Haha yeah. Granted, even these pronouns are wy better than the prompt saying "I am going to sleep." Outright creepy :D REPOSITORY R122 Po

D19454: Fix errors in kirigami example files

2019-03-17 Thread Carl Schwan
ognarb updated this revision to Diff 54124. ognarb added a comment. Remove goBack funtion, and I repported the bug https://bugs.kde.org/show_bug.cgi?id=405571 :) REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19454?vs=52927&id=54124 BRANCH arcpatch-D19

D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Filip Fila
filipf added a comment. Looks good. I'd avoid using pronouns, I think it would sound better and whose else's is the battery if not yours? Don't have a better idea for planned sleep, maybe just planned sleep actions? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.

D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Krešimir Čohar
rooty updated this revision to Diff 54123. rooty added a comment. Make sleep prompt more natural-sounding REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19838?vs=54121&id=54123 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19838 AFFEC

D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Krešimir Čohar
rooty updated this revision to Diff 54121. rooty added a comment. Fix "be go" REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19838?vs=54118&id=54121 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19838 AFFECTED FILES daemon/powerdevi

D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Krešimir Čohar
rooty added a comment. I'm not sold on the use of pronouns here, we could actually do without them If we agree to keep the pronouns, I'm not going to object but... we can sound both non-technical and professional at the same time :D P.S. I could use input on "All planned sleep", it's le

D19502: Add a SearchField and PasswordField component

2019-03-17 Thread Carl Schwan
ognarb updated this revision to Diff 54119. ognarb added a comment. Rebase REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19502?vs=54117&id=54119 BRANCH dev REVISION DETAIL https://phabricator.kde.org/D19502 AFFECTED FILES examples/simpleexamples/

D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Krešimir Čohar
rooty updated this revision to Diff 54118. rooty added a comment. Remove "as soon as possible" (less anxiety-inducing) REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19838?vs=54116&id=54118 BRANCH master REVISION DETAIL https://phabricator.kde.org/

D19502: Add a SearchField and PasswordField component

2019-03-17 Thread Carl Schwan
ognarb updated this revision to Diff 54117. ognarb added a comment. - Use qsTr instead of i18n - Kirigami version 2.7 -> 2.8 REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19502?vs=53106&id=54117 BRANCH dev REVISION DETAIL https://phabricator.kde.o

D19838: [powerdevil] Touch up messages/prompts

2019-03-17 Thread Krešimir Čohar
rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R122 Powerdevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D19838 AFFECTED FILES daemon/powerdevilcore.cpp To: rooty

D19825: Improve update states' UI

2019-03-17 Thread Krešimir Čohar
rooty added a comment. Hey I know this has landed already but how do you feel about the word Retrieving instead of Fetching? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19825 To: ngraham, apol, #vdg, #discover_software_store Cc: rooty, abetts, pl

D19825: Improve update states' UI

2019-03-17 Thread Andres Betts
abetts added a comment. +1 Maybe the icon can be smaller, but in principle, yes! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19825 To: ngraham, apol, #vdg, #discover_software_store Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zre

D19044: [InlineMessage] Do not draw shadows around the message

2019-03-17 Thread Filip Fila
filipf added a comment. In D19044#432878 , @mart wrote: > In D19044#432875 , @filipf wrote: > > > In D19044#432853 , @mart wrote: > > > > > uuh, no, this

D19044: [InlineMessage] Do not draw shadows around the message

2019-03-17 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R169:56ca5702d8a6: [InlineMessage] Do not draw shadows around the message (authored by filipf). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19044?vs=52923&id=54113

D19837: Add support for applications in KNSBackend

2019-03-17 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added reviewers: apol, ngraham, Discover Software Store. leinir added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Prior to this patch,

D19825: Improve update states' UI

2019-03-17 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R134:95c39a6f7f2b: Improve update states' UI (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19825?vs=54107&id=54111 REVISION DETA

D19825: Improve update states' UI

2019-03-17 Thread Nathaniel Graham
ngraham updated this revision to Diff 54107. ngraham marked 2 inline comments as done. ngraham added a comment. Improve a string and find the property properly REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19825?vs=54087&id=54107 BRANCH

D19821: Fix breeze dialog background with Qt 5.12.2

2019-03-17 Thread Krešimir Čohar
rooty added a comment. In D19821#432780 , @Zren wrote: > Another option I believe is to keep the `

D19825: Improve update states' UI

2019-03-17 Thread Aleix Pol Gonzalez
apol added a comment. conceptual +1 INLINE COMMENTS > UpdatesPage.qml:152 > +Layout.maximumHeight: Layout.minimumHeight > +visible: isBusy > +} use `page.isBusy` so it doesn't have to start looking for the symbol all over the place > UpdatesPage.

D19834: Fix monochrome icons in tooltips

2019-03-17 Thread Nathaniel Graham
ngraham closed this revision. ngraham added a comment. This landed, not sure why Phab didn't notice. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D19834 To: ngraham, #plasma, mart Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-m

D19044: [InlineMessage] Do not draw shadows around the message

2019-03-17 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. In D19044#432875 , @filipf wrote: > In D19044#432853 , @mart wrote: > > > uuh, no, this duplicates m

D19044: [InlineMessage] Do not draw shadows around the message

2019-03-17 Thread Filip Fila
filipf added a comment. In D19044#432853 , @mart wrote: > uuh, no, this duplicates more, i meant moving things from the control to the template But I moved most of things from `src/controls/InlineMessage.qml` to `src/controls/templates/I

D19834: Fix monochrome icons in tooltips

2019-03-17 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch is shamelessly stolen from Marco Martin's work in KInfoCenter (23fa369831709f43a310047

D19044: [InlineMessage] Do not draw shadows around the message

2019-03-17 Thread Marco Martin
mart added a comment. uuh, no, this duplicates more, i meant moving things from the control to the template REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19044 To: filipf, #vdg, #kirigami, ngraham, mart Cc: Codezela, rooty, ndavis, mart, abetts, plasma-devel, dom

D19829: kicker: add option to make root level icons visible

2019-03-17 Thread Aleksei Nikiforov
i.Dark_Templar added a comment. Favorite icons are much larger, it's hard to confuse them with root level menu icons. If it's deemed as informational noise, it's disabled by default. But in case it's not, it may be enabled if this change is applied. And in my opinion it looks more consistent

D19790: Improve the look of the GTK Application Style KCM UI

2019-03-17 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R99:36dd29f8b65a: Improve the look of the GTK Application Style KCM UI (authored by GB_2). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=5403

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 39 - Still unstable!

2019-03-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/39/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 Mar 2019 16:33:46 + Build duration: 4 min 16 sec and counting JUnit Tests Name: (root) Failed:

D19454: Fix errors in kirigami example files

2019-03-17 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > ognarb wrote in AbstractApplicationWindow.qml:105 > Without I get the errror: TypeError: Property 'goBack' of object > QQuickStackView_QML_91(0x55ea59443ee0) is not a function yeah, i think it's actually a kirigmai bug, let's not do it in the exampl

D19502: Add a SearchField and PasswordField component

2019-03-17 Thread Marco Martin
mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ognarb wrote in SearchField.qml:44 > Are you sure? It would mean that Kirigami should then depends on ki18n. And > them Kirigami wouldn't be a Tier 1 KDE framewor

D18438: [Task Manager] When closing apps, resize only when mouse is out.

2019-03-17 Thread Eike Hein
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Looks good now! Do you need help landing this or do you have a dev account? REPOSITORY R119 Plasma Desktop BRANCH arc_taskmanagerclose (branched from master) REVISION DETAIL https:/

D19744: [taskmanager] Fix desktop file mapping for some apps

2019-03-17 Thread Nicolas Fella
nicolasfella added a comment. The desktop files are called org.gnome.Nautilus.desktop and org.gnome.gedit.desktop The problem seems gone with Nautilus and Gedit from master though REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19744 To: nicolasfella,

D19829: kicker: add option to make root level icons visible

2019-03-17 Thread Eike Hein
hein added a comment. Kicker intentionally doesn't have icons on the root level to not conflict with the favorites column and reduce visual noise. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg Cc: ngraham, plasm

D19829: kicker: add option to make root level icons visible

2019-03-17 Thread Aleksei Nikiforov
i.Dark_Templar added a comment. Attaching screenshot with current look of menu (or with disabled option) and new look with enabled option and also a configuration widget. F6698363: kde-menu-changes.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19744: [taskmanager] Fix desktop file mapping for some apps

2019-03-17 Thread Eike Hein
hein added a comment. What's the name of the .desktop file though? That's the most relevant part. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19744 To: nicolasfella, #plasma, hein, broulik Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, leslie

D19829: kicker: add option to make root level icons visible

2019-03-17 Thread Nathaniel Graham
ngraham added reviewers: Plasma, VDG. ngraham added a comment. Screenshots are always appreciated for changes to the UI. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg Cc: ngraham, plasma-devel, jraleigh, GB_2,

D19821: Fix breeze dialog background with Qt 5.12.2

2019-03-17 Thread Chris Holland
Zren added a comment. Another option I believe is to keep the `

D19829: kicker: add option to make root level icons visible

2019-03-17 Thread Aleksei Nikiforov
i.Dark_Templar created this revision. i.Dark_Templar added a reviewer: hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. i.Dark_Templar requested review of this revision. REVISION SUMMARY In file applets/kicker/package/contents/config/main.xml an option 'showIconsRo

D19821: Fix breeze dialog background with Qt 5.12.2

2019-03-17 Thread Antonio Rojas
arojas added a comment. Apparently tooltips need a fix too https://bbs.archlinux.org/viewtopic.php?pid=1837417#p1837417 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt, #plasma Cc: arojas, rikmills, asturmlechner, kde-frameworks-de

[Powerdevil] [Bug 348529] Turn off screen after lock screen

2019-03-17 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=348529 --- Comment #24 from Nate Graham --- *** Bug 405344 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

D19825: Improve update states' UI

2019-03-17 Thread Nathaniel Graham
ngraham updated this revision to Diff 54087. ngraham added a comment. Don't show the icon when there are any updates REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19825?vs=54084&id=54087 BRANCH improve-update-states (branched from master

D19826: kns: Show subcategories for things that have one

2019-03-17 Thread Dan Leinir Turthra Jensen
leinir requested changes to this revision. leinir added a comment. The rest looks nice and solid :) INLINE COMMENTS > KNSBackend.cpp:161 > +if (cats.count() > 1) { > +m_categories += cats; > +for(const auto &cat: cats) { Don't think we need this, already creating the cate

D19826: kns: Show subcategories for things that have one

2019-03-17 Thread Aleix Pol Gonzalez
apol planned changes to this revision. apol added a comment. Should look into whether it works for installed packages. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19826 To: apol, #discover_software_store Cc: plasma-devel, jraleigh, GB_2, ragreen,

D19826: kns: Show subcategories for things that have one

2019-03-17 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Show subcategories for KNS resources that have more than 1 Category inside. At the moment

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 38 - Still Failing!

2019-03-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/38/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 Mar 2019 13:34:20 + Build duration: 53 sec and counting CONSOLE OUTPUT [...truncated 323 lines..

D19825: Improve update states' UI

2019-03-17 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: apol, VDG, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Add a busy indicator when something is refreshing or checking - Upd

D19823: Port to the new install directory for knsrc files

2019-03-17 Thread Aleix Pol Gonzalez
apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY See https://phabricator.kde.org/D19338 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

2019-03-17 Thread Nathaniel Graham
ngraham added a comment. On the other hand, the radio is infinite when the indicator isn't visible on an IOTM due to https://bugs.kde.org/show_bug.cgi?id=381656 :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb Cc: ngraham, broulik, pla

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 37 - Still Failing!

2019-03-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/37/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 Mar 2019 12:50:26 + Build duration: 1 min 12 sec and counting CONSOLE OUTPUT [...truncated 323 l

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.12 - Build # 65 - Still unstable!

2019-03-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.12/65/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Mar 2019 09:51:19 + Build duration: 1 hr 54 min and counting JUnit Tests Name: projectroo

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

2019-03-17 Thread Kai Uwe Broulik
broulik added a comment. Not sure, it might be accidentally triggered which is why I didn't implement this. Especially in icon tasks where the audio icon to task item ratio is quite large. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb Cc:

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

2019-03-17 Thread Farid Boudedja
faridb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. faridb requested review of this revision. REVISION SUMMARY The task manager shows an indicator on tasks playing audio (when enabled in the settings). This patch adds the ability to mute/unmu

D19821: Fix breeze dialog background with Qt 5.12.2

2019-03-17 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY style elements without type="text/css" were ignored before, but now they act as if type w

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 36 - Still Failing!

2019-03-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/36/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 Mar 2019 11:07:42 + Build duration: 8 min 39 sec and counting CONSOLE OUTPUT [...truncated 457 l

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 35 - Still Failing!

2019-03-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/35/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 Mar 2019 09:51:19 + Build duration: 36 min and counting CONSOLE OUTPUT [...truncated 497 lines..

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 15 - Fixed!

2019-03-17 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/15/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 Mar 2019 09:32:19 + Build duration: 6 min 43 sec and counting JUnit Tests Na

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 34 - Failure!

2019-03-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/34/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 Mar 2019 09:33:44 + Build duration: 1 min 27 sec and counting CONSOLE OUTPUT [...truncated 511 l

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.12 - Build # 64 - Failure!

2019-03-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.12/64/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Mar 2019 09:33:44 + Build duration: 1 min 9 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 12 - Fixed!

2019-03-17 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/12/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 Mar 2019 09:32:17 + Build duration: 2 min 59 sec and counting JUnit Tests Name:

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 12 - Still unstable!

2019-03-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/12/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Sun, 17 Mar 2019 09:32:10 + Build duration: 2 min 37 sec and counting JUnit Tests Na

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 15 - Still unstable!

2019-03-17 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/15/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 17 Mar 2019 09:32:12 + Build duration: 1 min 21 sec and counting JUnit Tests

D19340: Search new knsrc locations

2019-03-17 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R134:d617dd8e6a1e: Search new knsrc locations (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19340?vs=53876&id=54070 REVISION DETA

D19500: [KDirModel] Fix job urls change signal connection

2019-03-17 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. If there was a unittest for this code, it wouldn't remain broken for so long... Feel free to add one :-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D195

D19469: [sddm-theme] Update login screen preview image

2019-03-17 Thread Krešimir Čohar
rooty added a comment. I'll post one REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19469 To: rooty, #vdg, ngraham, filipf Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19469: [sddm-theme] Update login screen preview image

2019-03-17 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Seems like a nice-to-have, not a must-have. :) Is there a patch for it? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19469 To: rooty, #vdg, ngraham, filipf Cc: plasma-devel, jraleigh, GB_2, ragreen,

Re: welcome plasma-active-window-control

2019-03-17 Thread Jonathan Riddell
On Sat, Mar 16, 2019 at 07:55:16PM +0100, Roman Gilg wrote: > On Sat, Mar 16, 2019 at 6:53 PM Jonathan Riddell wrote: > > > > Just passed kdereview and moved into extra/base is Plasma Active Window > > Control. > > > > Plasma Active Window Control is a plasma widget that you can embed in > > your

D19469: [sddm-theme] Update login screen preview image

2019-03-17 Thread Krešimir Čohar
rooty added a comment. In D19469#432282 , @ngraham wrote: > I do believe that this is the very last patch for T10325: 5.16 Login screen improvements . :) There is one last thing we might want to do for