D18597: Fix combobox initial sizing

This revision was automatically updated to reflect the committed changes. Closed by commit R858:152bb7363a80: Fix combobox initial sizing (authored by davidedmundson). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18597?vs=50488&id=

D18607: Add a popup search bar to the plasma-nm applet

ngraham added a comment. In D18607#402168 , @vpilo wrote: > Better just place it at the top above the the connections list, then? I think that would make sense. In such a limited space, I think it's fine for the search field to only

D18607: Add a popup search bar to the plasma-nm applet

vpilo added a comment. Better just place it at the top above the the connections list, then? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18607 To: vpilo, #vdg, #plasma Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zren

D18607: Add a popup search bar to the plasma-nm applet

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in appletproxymodel.cpp:60 > what happens if you have a filter and the the entry is a slave? Edit: ignore this. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18607

D18607: Add a popup search bar to the plasma-nm applet

davidedmundson added a comment. Seems niche, but this solution is also unobtrusive, so I like that. I have a lot of VPNs searching through them would be quite useful. Having the search bar on the bottom is a bit weird as when you filter the results will be at the top, meaning the user's

D18607: Add a popup search bar to the plasma-nm applet

vpilo created this revision. vpilo added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vpilo requested review of this revision. REVISION SUMMARY If there are not enough connections to fill the scrollview, the search bar is not displayed by defa

D18598: Defer initial positions apply until listing is complete

hein added a comment. Sorry for the noise. Please review again (I'm off till tomorrow). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18598 To: hein, #plasma, davidedmundson, chinmoyr Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, al

D18598: Defer initial positions apply until listing is complete

hein updated this revision to Diff 50509. hein added a comment. Revert an unintended change, fixes positionertest REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18598?vs=50506&id=50509 BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D18598: Defer initial positions apply until listing is complete

hein updated this revision to Diff 50506. hein added a comment. Add missing include REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18598?vs=50502&id=50506 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18598 AFFECTED FILES contai

D18598: Defer initial positions apply until listing is complete

hein updated this revision to Diff 50502. hein added a comment. Signal-slot hygiene REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18598?vs=50498&id=50502 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18598 AFFECTED FILES contai

D18598: Defer initial positions apply until listing is complete

hein updated this revision to Diff 50498. hein added a comment. Reorder abort checks and unset m_deferApplyPositions if going for a reset REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18598?vs=50490&id=50498 BRANCH master REVISION DETAIL https

D18598: Defer initial positions apply until listing is complete

hein added a comment. In D18598#401848 , @davidedmundson wrote: > If the QML code calls setPositions({}) and when we apply m_positions.size() < 5 > m_deferApplyPositions gets left on true forever. Is that ok? It's not, good catch. U

D18598: Defer initial positions apply until listing is complete

davidedmundson added a comment. If the QML code calls setPositions({}) and when we apply m_positions.size() < 5 m_deferApplyPositions gets left on true forever. Is that ok? Other than that, looks good. INLINE COMMENTS > positioner.cpp:82 > if (m_folderModel) { >

D18578: Reduce string objects

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks okay from a theoretical point of view, I can expect the practical impact of this be about 0~ :P REPOSITORY R106 KSysguard BRANCH reduceStrings REVISION DETAIL https://phabricator.

D18576: Simpe C updates to ksysguardd code

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM +1 REPOSITORY R106 KSysguard BRANCH simplify_c_code REVISION DETAIL https://phabricator.kde.org/D18576 To: tcanabrava, apol Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D18598: Defer initial positions apply until listing is complete

hein created this revision. hein added reviewers: Plasma, davidedmundson, chinmoyr. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY This fixes the infamous "desktop positions partially scramble on reboot" bug that occurs when KDirLister completes listin

D18596: Set combobox popups to be modal

This revision was automatically updated to reflect the committed changes. Closed by commit R858:0ac99af6e691: Set combobox popups to be modal (authored by davidedmundson). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18596?vs=50483

D18597: Fix combobox initial sizing

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY We have a listview in a popup. The popup is resized to the listview content

D18596: Set combobox popups to be modal

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This closer matches what we see on QWidgets where losing focus closes the c

D18588: Configuration to never show the passwors dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R116:1d7841399924: Configuration to never show the passwors dialog (authored by mart). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18588?vs=5

D18588: Configuration to never show the passwors dialog

mart updated this revision to Diff 50468. mart added a comment. - return true REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18588?vs=50466&id=50468 BRANCH arcpatch-D18588 REVISION DETAIL https://phabricator.kde.org/D18588 AF

D18588: Configuration to never show the passwors dialog

mart created this revision. mart added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY on Plasma mobile, not qwidget dialogs should be ever shown at any time. the networkmanager KCM i

D18580: Accept commas to separate processes on the Search Edit

This revision was automatically updated to reflect the committed changes. Closed by commit R111:f5dcd02c52fd: Accept commas to separate processes on the Search Edit (authored by tcanabrava). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18580?vs=504

D18580: Accept commas to separate processes on the Search Edit

tcanabrava updated this revision to Diff 50463. tcanabrava added a comment. - Accept commas for PID REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18580?vs=50426&id=50463 BRANCH acceptCommasSearch REVISION DETAIL https://phabricator.kde.org/

KDE CI: Plasma » breeze » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze/job/kf5-qt5%20FreeBSDQt5.12/11/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 29 Jan 2019 07:39:23 + Build duration: 35 min and counting