D18485: [KRDB] Also try wildcard tooltip

broulik closed this revision. broulik added a comment. https://cgit.kde.org/plasma-desktop.git/commit/?h=Plasma/5.12&id=c6bab929ac252c053f46d1ddd07d9cc421db22bd REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18485 To: broulik, #plasma, davidedmundson, ngraha

D18482: [KRDB] Write correct tooltip colors into gtkrc in kcminit

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c394dc46fb73: [KRDB] Write correct tooltip colors into gtkrc in kcminit (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18482?vs=50136&id=50165#toc REPOSITORY R119 Plas

D12278: [Colors KCM] Port to new design

broulik updated this revision to Diff 50164. broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Update wording - Add "disabled text" to preview and make delegate slightly larger because of this - Use "Apply" button in col

D18491: [KCM] Use a better icon

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Icon was already there, so we can do this in 5.15. TEST PLAN F6565234: Looks fantastic

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

davidedmundson added a comment. Ok, so two important tasks. 1. We need to get this extra license into KCoreAddons::KAboutLicense I think otherwise it won't render properly in the plasma UI. I can take care of that. (Though I can't find it here https://spdx.org/licenses/ does it hav

D18489: warnings--

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY KAboutData::setProgramIconName isn't used in the AboutData dialog box, inst

D17784: Don't ignore default virtual devices

sharhalakis added a comment. Stefanos Harhalakis REVISION DETAIL https://phabricator.kde.org/D17784 To: sharhalakis, broulik, drosca Cc: filipf, ngraham, cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

filipf added a comment. In D18078#398858 , @ngraham wrote: > My vote goes to the grassland. We already have two nice city images, and the desert one looks too much like the default wallpaper in macOS 10.14 Mojave. We might be accused of copying

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

filipf added a comment. In D18078#39 , @davidedmundson wrote: > Can you please confirm the source of these images. > We need to be sure they all fall under: https://community.kde.org/Policies/Licensing_Policy > > If not, we need to t

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in metadata.desktop:7 > License=Unsplash > > What's unsplash? https://unsplash.com/license > License > > All photos published on Unsplash can be used for free. You can use them for > commercial and noncommercial purposes.

D18318: Prettify and search enable the error page

ngraham added a comment. Awesome, almost there! I tried with the icon size `huge` instead of `enormous`and I think it might look a bit better. What do you think? F6564901: Huge instead of enormous.png REPOSITORY R134 Discover Software Store REVI

D17920: Remove duplicated file

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0aee25b30f44: Remove duplicated file (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17920?vs=48539&id=50155#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE

D18481: [applets/appmenu] Show placeholder when configuring and empty

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2fd853aea2ce: [applets/appmenu] Show placeholder when configuring and empty (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18

D18480: [applets/appmenu] Set iconSource properly

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ea67f7103044: [applets/appmenu] Set iconSource properly (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18480?vs=50134&id=5015

D18481: [applets/appmenu] Show placeholder when configuring and empty

davidedmundson updated this revision to Diff 50151. davidedmundson added a comment. use plasmoid.title REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18481?vs=50138&id=50151 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18481 AF

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

davidedmundson added a comment. Can you please confirm the source of these images. We need to be sure they all fall under: https://community.kde.org/Policies/Licensing_Policy If not, we need to take it up with people who care about this legal stuff. INLINE COMMENTS > metadata.desktop

D18418: Adjust some KCMs to implement new Appearance section layout [1/3]

ngraham abandoned this revision. ngraham added a comment. Where did this thing come from? We already have D18419 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18418 To: ngraham, #vdg, #plasma, davidedmundson Cc: plasma-

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

ngraham added a comment. My vote goes to the grassland. We already have two nice city images, and the desert one looks too much like the default wallpaper in macOS 10.14 Mojave. We might be accused of copying them. > As for implementation, I take it we should wait until 5.17 since there

D18480: [applets/appmenu] Set iconSource properly

ngraham accepted this revision. ngraham added a comment. Whoops! REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D18480 To: davidedmundson, #plasma, broulik, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezh

D18482: [KRDB] Write correct tooltip colors into gtkrc in kcminit

davidedmundson accepted this revision. davidedmundson added a comment. > Because of a bug preventing proper propagation of environment variables to apps launched through Kickoff/KRunner (KRun?) via klauncher(??) this is hardly noticeable but when you e.g. open Gimp or Inkscape through "Open W

D12278: [Colors KCM] Port to new design

GB_2 added inline comments. INLINE COMMENTS > colors.cpp:58 > + > +KAboutData *about = new KAboutData(QStringLiteral("kcm_colors"), > i18n("Configure color schemes"), > + QStringLiteral("2.0"), QString(), > KAboutLicense::GPL); Better: "Choose the colo

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

filipf added a comment. In D18078#398570 , @ngraham wrote: > Where are we with replacing one of those flower images with another one? We could add one more cityscape instead: F6563983: image.png

D18482: [KRDB] Write correct tooltip colors into gtkrc in kcminit

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Confirmed; it's fixed!!! You did it! *high-fives* REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18482 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, p

D18481: [applets/appmenu] Show placeholder when configuring and empty

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in main.qml:106 > I think you could just use `plasmoid.title` here That's clever! I'll put this in 5.15 then. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D18481 To: dav

D18481: [applets/appmenu] Show placeholder when configuring and empty

broulik added a comment. oh and perhaps `enabled: false` otherwise it's a defunct button? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D18481 To: davidedmundson, #plasma, broulik Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Z

D18481: [applets/appmenu] Show placeholder when configuring and empty

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main.qml:104 > +PlasmaComponents.ToolButton { > +id: noMenuPlaceholder > +visible: buttonRepeater.count == 0 Unused id > main.qml:106

D18485: [KRDB] Also try wildcard tooltip

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In Gimp's toolbox the tooltip colors were only applied to its background, not the text, leading t

D18481: [applets/appmenu] Show placeholder when configuring and empty

davidedmundson added a comment. With this patch as-is the placeholder is also shown if the applet is on the desktop and the active window doesn't have a menu. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18481 To: davidedmundson, #plasma Cc: plasma-devel

D18482: [KRDB] Write correct tooltip colors into gtkrc in kcminit

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY kcminit for performance reasons is not desktop settings aware which means it won't load the p

D18481: [applets/appmenu] Show placeholder when configuring and empty

davidedmundson added a comment. F6564166: Screenshot_20190123_190537.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18481 To: davidedmundson, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesl

D18481: [applets/appmenu] Show placeholder when configuring and empty

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Before this patch if you had no active menu and configured your plasmoid it

D18480: [applets/appmenu] Set iconSource properly

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY setting an icon via i18n makes no sense TEST PLAN Put in vertical panel, h

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

ngraham added a comment. Where are we with replacing one of those flower images with another one? REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18078 To: filipf, #plasma, #vdg, ngraham Cc: abetts, mart, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D12278: [Colors KCM] Port to new design

broulik updated this revision to Diff 50123. broulik retitled this revision from "WIP: [Colors KCM] Port to new design" to "[Colors KCM] Port to new design". broulik edited the summary of this revision. broulik edited the test plan for this revision. REPOSITORY R119 Plasma Desktop CHANGES SINC

D18470: [kcms/cursortheme] Set theme before loading size

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5c18d665b7e8: [kcms/cursortheme] Set theme before loading size (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18470?vs=50105&id

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

ngraham added a comment. Fantastic news! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14796 To: gpark, hein Cc: kucharczyk, lavender, ngraham, apol, plasma-devel, hein, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abett

D18471: [kcms/cursortheme] Fix size combo

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9096bdefc66e: [kcms/cursortheme] Fix size combo (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18471?vs=50106&id=50118#toc REPOSITORY R119 Plasma Desktop CHANG

D18471: [kcms/cursortheme] Fix size combo

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Can we get this into the 5.15 branch? REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D18471 To: davidedmundson, #plasma, ngraham Cc: ngra

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

hein added a comment. @gpark just came back from an exchange semester. We met the other day and will schedule a work session in Feb to resume on this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14796 To: gpark, hein Cc: kucharczyk, lavender, ngraham, apo

D18318: Prettify and search enable the error page

leinir updated this revision to Diff 50110. leinir added a comment. In fact, don't need that outer item, so removing that REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18318?vs=50107&id=50110 REVISION DETAIL https://phabricator.kde.org/D

D18471: [kcms/cursortheme] Fix size combo

ngraham added a comment. Thanks, this fixes it, and the code change looks sane! While testing, I noticed that this combobox suffers from the same problem suffered by that the sub-pixel rendering combobox in the Fonts KCM: you can only close but pop-up by clicking on the button again: ht

D18318: Prettify and search enable the error page

leinir updated this revision to Diff 50107. leinir added a comment. Try and pop the the icon above the text, and just use iconsize enormous rather than a hardcoded one, and also raise the whole thing just a bit. And since the plan is to not use a similar layout on the updates page in short o

D18470: [kcms/cursortheme] Set theme before loading size

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. 👍🏼 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18470 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Z

D18182: Fix new file creation leading to dupe items on a fresh view

McPain requested changes to this revision. McPain added a comment. This revision now requires changes to proceed. That's what I got with this patch. F6563817: изображение.png Please remove Qt::QueuedConnection from both connections. Additionally,

D18471: [kcms/cursortheme] Fix size combo

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY The biggest problem fixed was that m_preferredSize was sometimes treated as

D18470: [kcms/cursortheme] Set theme before loading size

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Available sizes changes when the theme changes. Therefore we need it to

KDE CI: Plasma » kwin » stable-kf5-qt5 SUSEQt5.11 - Build # 55 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20SUSEQt5.11/55/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Fri, 18 Jan 2019 00:22:53 + Build duration: 22 min and counting BUILD ARTIFACTS abi-compatibil

D18418: Adjust some KCMs to implement new Appearance section layout [1/3]

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop BRANCH appearance-section-layout-changes (branched from master) REVISION DETAIL https://phabricator.kde.org/D18418 A