[sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

Git commit f6c79ff4787148459aa91c17d683e4fd6a57c323 by Ben Cooksley. Committed on 21/01/2019 at 05:46. Pushed by bcooksley into branch 'master'. Disable execution of tests for plasma-integration. This is necessary to ensure CI nodes do not become blocked due to hanging tests withing plasma-integr

D15684: DateTime Runner timezone and 24 hour clock time conversion.

smithjd updated this revision to Diff 49976. smithjd added a comment. - [DateTime Runner] Add from-zone, to-zone and 24-hour time conversion. Improve timezone lookups (i.e. identical zone names now return all matches). The zone name is now used instead of the abbreviation in matches. - Reba

D18419: Adjust some KCMs to implement new Appearance section layout

abetts added a comment. I am not opposed to a reorg as long as it doesn't touch the KCMs, but be aware that you "might" have to reorg again as we port KCMs. So, do you prefer to do it, potentially twice, or just once? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kd

D18413: Don't put some KCMs in a single-item top-level category

This revision was automatically updated to reflect the committed changes. Closed by commit R119:827a39eb070d: Don't put some KCMs in a single-item top-level category (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18413?vs=49963&id

D18419: Adjust some KCMs to implement new Appearance section layout

ngraham added a comment. That's true, and we discussed this a lot in the VDG channel. The problem is that such a condition will in practice result in delaying this re-ogranization practically indefinitely. https://phabricator.kde.org/tag/plasma_kcm_redesign/ lists 42 KCMs that require p

D18419: Adjust some KCMs to implement new Appearance section layout

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. We have all agreed before that we will not do any top-down shuffling until all the work updating KCMs bottom-up has been completed. It's documented in that linked

D18419: Adjust some KCMs to implement new Appearance section layout [1/3]

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This is patch one out of three in support of the new Appearance section layout decided upon o

D18418: Adjust some KCMs to implement new Appearance section layout [1/3]

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This is patch one out of three in support of the new Appearance section layout decided upon o

D18417: Adjust and remove some top-level categories to implement new Appearance section layout [2/3]

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This is patch two out of three in support of the new Appearance section layout decided upon o

D18413: [Colors KCM] Don't put the KCM in a single-item top-level category

ngraham updated this revision to Diff 49963. ngraham added a comment. Also do the same for the Notifications and Accessibility KCMs REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18413?vs=49958&id=49963 BRANCH remove-fake-single-item-color-categor

D18413: [Colors KCM] Don't put the KCM in a single-item top-level category

rapiteanu added a comment. I like this change, but isn't Accessibility and Notifications in the same boat as Colors? Also, as a related patch, shouldn't Display and Monitors be uniform with the rest of this menu and display 'Contains 3 elements' instead of actually describing the category?

D18392: [mobile/broadband] Port to SimpleKCM and FormLayout

ngraham added a comment. Needs a bit more padding. I'd put some whitespace between the checkboxes and the text field, and between the text field and the buttons. Also the bottoms kind of feel funny integrated into the form layout. I might put them on a row at the bottom of the page instead.

D18413: [Colors KCM] Don't put the KCM in a single-item top-level category

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch lets the Colors KCM display a proper tooltip that contains its caption, rather than a

D18411: [Analog Clock] Port config window to QQC2 and use Kirigami FormLayout

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c02d60d349af: [Analog Clock] Port config window to QQC2 and use Kirigami FormLayout (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D18411: [Analog Clock] Port config window to QQC2 and use Kirigami FormLayout

ngraham marked an inline comment as done. ngraham added a comment. Yep, works great in Oxygen, and no crash. F6558536: Screenshot_20190120_111048.png REPOSITORY R120 Plasma Workspace BRANCH analog-clock-modernize-config-window-layout (branched

D18401: [Look And Feel KCM] Use new icon

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d6669db9aec0: [Look And Feel KCM] Use new icon (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18401?vs=49915&id=49955 REVISION DETAIL

D18411: [Analog Clock] Port config window to QQC2 and use Kirigami FormLayout

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > configGeneral.qml:22 > > -//FIXME this causes a crash in Oxygen style > -//QtControls.GroupBox { Have you tested this in Oxygen? REPOSITORY R120 Pl

D18411: [Analog Clock] Port config window to QQC2 and use Kirigami FormLayout

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. TEST PLAN F6558524: New FormLayout REPOSITORY R120 Plasma Workspace BRAN

D18401: [Look And Feel KCM] Use new icon

ngraham added a comment. In D18401#396992 , @davidedmundson wrote: > > which we can depend on for the 5.16 release. > > Can I confirm you do mean 5.16 as in 4 months? Confirmed. This is targeting master only. REPOSITORY R119 Plasma

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 49949. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=49946&id=49949 REVISION DETAIL https://phabricator.kde.org/D18394 AFFECTED FILES vpn/openconnect/CMakeLists.txt vpn/openconnect/nm-openconnect-service.h vpn/openconnect/opencon

D18401: [Look And Feel KCM] Use new icon

ngraham added a comment. We wanted to communicate that this affects more than just Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18401 To: ngraham, #vdg Cc: Codezela, davidedmundson, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, les

D18401: [Look And Feel KCM] Use new icon

Codezela added a comment. why the background color on this icon not like the other i think it look forign REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18401 To: ngraham, #vdg Cc: Codezela, davidedmundson, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pi

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 49946. enriquem added a comment. Changed the buildup of the "tokens" ComoBox REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=49921&id=49946 REVISION DETAIL https://phabricator.kde.or

D18370: Set libkworkspace minimum version

This revision was automatically updated to reflect the committed changes. Closed by commit R119:270c67514052: Set libkworkspace minimum version (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18370?vs=49838&id=49945 REVISIO

D18401: [Look And Feel KCM] Use new icon

davidedmundson added a comment. > which we can depend on for the 5.16 release. Can I confirm you do mean 5.16 as in 4 months? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18401 To: ngraham, #vdg Cc: davidedmundson, abetts, plasma-devel, jraleigh, GB_2,

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 49921. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=49920&id=49921 REVISION DETAIL https://phabricator.kde.org/D18394 AFFECTED FILES vpn/openconnect/CMakeLists.txt vpn/openconnect/nm-openconnect-service.h vpn/openconnect/opencon

D18394: Add OTP support for openconnect VPN

enriquem updated this revision to Diff 49920. enriquem added a comment. Amended to remove global tokenModeList REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18394?vs=49911&id=49920 REVISION DETAIL https://phabricator.kde.org/D18

D18381: Add tooltip to configure panel button

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7a08f3d135c5: Add tooltip to configure panel button (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18381?vs=49870&id=49918 REVISION DETA